Re: [PATCH v2] bpf: BPF based latency tracing

2015-06-22 Thread Daniel Wagner
On 06/20/2015 10:14 AM, Daniel Borkmann wrote: I think it would be useful to perhaps have two options: 1) User specifies a specific CPU and gets one such an output above. Good point. Will do. 2) Summary view, i.e. to have the samples of each CPU for comparison next to each other in

[PATCH v1] bpf: BPF based latency tracing

2015-06-19 Thread Daniel Wagner
|| 524288 - 1048575 : 298 || All this is based on the trace3 examples written by Alexei Starovoitov a...@plumgrid.com. Signed-off-by: Daniel Wagner daniel.wag...@bmw-carit.de Cc: Alexei Starovoitov a...@plumgrid.com

[PATCH v2] bpf: BPF based latency tracing

2015-06-19 Thread Daniel Wagner
|| 524288 - 1048575 : 298 || All this is based on the trace3 examples written by Alexei Starovoitov a...@plumgrid.com. Signed-off-by: Daniel Wagner daniel.wag...@bmw-carit.de Cc: Alexei Starovoitov a...@plumgrid.com

Re: [PATCH 6/7] sock, cgroup: add sock->sk_cgroup

2015-11-20 Thread Daniel Wagner
Hi Tejun, On 11/19/2015 07:52 PM, Tejun Heo wrote: > +/* > + * There's a theoretical window where the following accessors race with > + * updaters and return part of the previous pointer as the prioidx or > + * classid. Such races are short-lived and the result isn't critical. > + */ > static

Re: [PATCH 4/7] netprio_cgroup: limit the maximum css->id to USHRT_MAX

2015-11-20 Thread Daniel Wagner
so that the > two cgroup related fields are adjacent. > > Signed-off-by: Tejun Heo <t...@kernel.org> > Cc: Daniel Borkmann <dan...@iogearbox.net> > Cc: Daniel Wagner <daniel.wag...@bmw-carit.de> Acked-by: Daniel Wagner <daniel.wag...@bmw-carit.de> -- To unsubscri

Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

2015-11-22 Thread Daniel Wagner
Hi Tejun, On 11/21/2015 05:13 PM, Tejun Heo wrote: > This is v3 of the xt_cgroup2 patchset. Changes from the last take are > > * Folded cgroup2 path matching into xt_cgroup as a new revision rather > than a separate xt_cgroup2 match as suggested by Pablo. > > * Refreshed on top of Nina's

Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

2015-11-23 Thread Daniel Wagner
On 11/23/2015 08:11 AM, Daniel Wagner wrote: > [3.217648] systemd[1]: tmp.mount: Directory /tmp to mount over is not > empty, mounting anyway. > [3.224665] BUG: spinlock bad magic on CPU#1, systemd/1 > [3.225653] lock: cgroup_sk_update_lock+0x0/0x60, .magic: 000

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

2015-11-23 Thread Daniel Wagner
ast Acked-by should do the trick: Tested-by: Daniel Wagner <daniel.wag...@bmw-carit.de> Acked-by: Daniel Wagner <daniel.wag...@bmw-carit.de> cheers, daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kern

Re: [PATCH 8/9] netfilter: prepare xt_cgroup for multi revisions

2015-11-23 Thread Daniel Wagner
Hi Tejun, On 11/21/2015 05:14 PM, Tejun Heo wrote: > xt_cgroup will grow cgroup2 path based match. Postfix existing > symbols with _v0 and prepare for multi revision registration. > > Signed-off-by: Tejun Heo <t...@kernel.org> > Cc: Daniel Borkmann <dan...@iogearbox.

Re: [PATCH 7/9] sock, cgroup: add sock->sk_cgroup

2015-11-23 Thread Daniel Wagner
Hi Tejun, On 11/21/2015 05:13 PM, Tejun Heo wrote: > Signed-off-by: Tejun Heo <t...@kernel.org> > Cc: Daniel Borkmann <dan...@iogearbox.net> > Cc: Daniel Wagner <daniel.wag...@bmw-carit.de> I did a quick test and for new connection the cgroup2 match worked as expected.

Re: [PATCH 7/9] sock, cgroup: add sock->sk_cgroup

2015-11-23 Thread Daniel Wagner
On 11/23/2015 04:48 PM, Tejun Heo wrote: > On Mon, Nov 23, 2015 at 02:02:03PM +0100, Daniel Wagner wrote: >> On 11/21/2015 05:13 PM, Tejun Heo wrote: >>> Signed-off-by: Tejun Heo <t...@kernel.org> >>> Cc: Daniel Borkmann <dan...@iogearbox.net> >>&g

Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

2015-11-23 Thread Daniel Wagner
On 11/23/2015 04:53 PM, Tejun Heo wrote: > On Mon, Nov 23, 2015 at 09:54:32AM +0100, Daniel Wagner wrote: > ... >>> [3.224665] BUG: spinlock bad magic on CPU#1, systemd/1 >>> [3.225653] lock: cgroup_sk_update_lock+0x0/0x60, .magic: , >>>

Re: [PATCH net-next] nfnetlink_queue: enable PID info retrieval

2016-06-10 Thread Daniel Wagner
Hi Daniel, > [ Cc'ing John, Daniel, et al ] > > Btw, while I just looked at scm_detach_fds(), I think commits ... > > * 48a87cc26c13 ("net: netprio: fd passed in SCM_RIGHTS datagram not set > correctly") > * d84295067fc7 ("net: net_cls: fd passed in SCM_RIGHTS datagram not set > correctly") >

Re: [PATCH v2 net-next 0/12] bpf: map pre-alloc

2016-03-08 Thread Daniel Wagner
> > this path set switches bpf hash map to use pre-allocation by default > and introduces BPF_F_NO_PREALLOC flag to keep old behavior for cases > where full map pre-allocation is too memory expensive. > > Some time back Daniel Wagner reported crashes when bpf hash map is >

[PATCH 1/2] carl9170: Fix wrong completion usage

2016-08-18 Thread Daniel Wagner
From: Daniel Wagner <daniel.wag...@bmw-carit.de> carl9170_usb_stop() is used from several places to flush and cleanup any pending work. The normal pattern is to send a request and wait for the irq handler to call complete(). The completion is not reinitialized during normal ope

[PATCH 2/2] ath10k: use complete() instead complete_all()

2016-08-18 Thread Daniel Wagner
From: Daniel Wagner <daniel.wag...@bmw-carit.de> There is only one waiter for the completion, therefore there is no need to use complete_all(). Let's make that clear by using complete() instead of complete_all(). The usage pattern of the completion is: waiter c

[PATCH 0/2] wireless: Use complete() instead complete_all()

2016-08-18 Thread Daniel Wagner
From: Daniel Wagner <daniel.wag...@bmw-carit.de> Hi, Using complete_all() is not wrong per se but it suggest that there might be more than one reader. For -rt I am reviewing all complete_all() users and would like to leave only the real ones in the tree. The main problem for -rt

Re: wl1251 & mac address & calibration data

2016-12-15 Thread Daniel Wagner
chanism" though -- but for that I can only refer you at this point to some of Daniel Wagner and Tom Gunderson's firmwared deamon prospect. It should help pave the way for a clean solution and help address other stupid issues. The firmwared project is hosted here https://github.com/teg/firmwared