Re: XDP redirect measurements, gotchas and tracepoints

2017-08-22 Thread Duyck, Alexander H
On Tue, 2017-08-22 at 11:17 -0700, John Fastabend wrote: > On 08/22/2017 11:02 AM, Michael Chan wrote: > > On Mon, Aug 21, 2017 at 12:25 PM, Jesper Dangaard Brouer > > wrote: > > > > > > I'be been playing with the latest XDP_REDIRECT feature, that was > > > accepted in net-next (for ixgbe), see m

Re: [PATCH] ipv6: gso: fix payload length when gso_size is zero

2017-10-05 Thread Duyck, Alexander H
On Thu, 2017-10-05 at 20:06 +0300, Alexey Kodanev wrote: > When gso_size reset to zero for the tail segment in skb_segment(), later > in ipv6_gso_segment(), we will get incorrect payload_len for that segment. > inet_gso_segment() already has a check for gso_size before calculating > payload so fixi

Re: [PATCH v2] gso: fix payload length when gso_size is zero

2017-10-06 Thread Duyck, Alexander H
On Fri, 2017-10-06 at 19:02 +0300, Alexey Kodanev wrote: > When gso_size reset to zero for the tail segment in skb_segment(), later > in ipv6_gso_segment(), __skb_udp_tunnel_segment() and gre_gso_segment() > we will get incorrect results (payload length, pcsum) for that segment. > inet_gso_segment(

RE: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

2017-10-17 Thread Duyck, Alexander H
> -Original Message- > From: Eric Dumazet [mailto:eduma...@google.com] > Sent: Tuesday, October 17, 2017 4:21 AM > To: Henrik Austad > Cc: netdev ; David S . Miller > ; Daniel Borkmann ; David > Ahern ; Duyck, Alexander H > ; Willem de Bruijn ; > John F

Re: [patch net-next 01/20] net: sched: add block bind/unbind notif. and extended block_get/put

2017-10-17 Thread Duyck, Alexander H
On Tue, 2017-10-17 at 22:05 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Introduce new type of ndo_setup_tc message to propage binding/unbinding > of a block to driver. Call this ndo whenever qdisc gets/puts a block. > Alongside with this, there's need to propagate binder type from qdisc > cod

Re: [PATCH RFC net-next] net: vlan/macvlan: count packets properly with gso

2018-11-29 Thread Duyck, Alexander H
On Thu, 2018-11-29 at 15:58 -0500, Debabrata Banerjee wrote: > Fix packet count when using vlan/macvlan drivers with gso. Without this it > is not possible to reconcile packet counts between underlying devices and > these virtual devices. Additionally, the output looks wrong in a standalone > way i

Re: [PATCH net v2 2/2] udp: only do GSO if # of segs > 1

2019-10-02 Thread Duyck, Alexander H
On Wed, 2019-10-02 at 13:29 -0400, Josh Hunt wrote: > Prior to this change an application sending <= 1MSS worth of data and > enabling UDP GSO would fail if the system had SW GSO enabled, but the > same send would succeed if HW GSO offload is enabled. In addition to this > inconsistency the error i

Re: [PATCH net v2] i40e/i40evf: proper update of the page_offset field

2017-05-15 Thread Duyck, Alexander H
On Mon, 2017-05-15 at 06:52 +0200, Björn Töpel wrote: > From: Björn Töpel > > In f8b45b74cc62 ("i40e/i40evf: Use build_skb to build frames") > i40e_build_skb updates the page_offset field with an incorrect offset, > which can lead to data corruption. This patch updates page_offset > correctly, by

Re: [Intel-wired-lan] [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

2017-05-22 Thread Duyck, Alexander H
On Mon, 2017-05-22 at 06:25 +0300, Or Gerlitz wrote: > On Mon, May 22, 2017 at 1:35 AM, Alexander Duyck > wrote: > > > > On Sat, May 20, 2017 at 2:15 PM, Or Gerlitz wrote: > > > > > > On Sat, May 20, 2017 at 3:58 AM, Amritha Nambiar > > > wrote: > > > > > > > > The following series introduces

Re: [Intel-wired-lan] [i40e] regression on TCP stream and TCP maerts, kernel-4.12.0-0.rc2

2017-06-01 Thread Duyck, Alexander H
On Thu, 2017-06-01 at 12:14 +0200, Adrian Tomasov wrote: > On Wed, 2017-05-31 at 14:42 -0700, Alexander Duyck wrote: > > > > On Wed, May 31, 2017 at 6:48 AM, Adrian Tomasov > > wrote: > > > > > > > > > On Tue, 2017-05-30 at 18:27 -0700, Alexander Duyck wrote: > > > > > > > > > > > > On Tue, M

RE: [Intel-wired-lan] [PATCH] igb: Allow to remove administratively set MAC on VFs

2017-04-04 Thread Duyck, Alexander H
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Corinna Vinschen > Sent: Tuesday, April 4, 2017 8:11 AM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] igb: Allow to remove

RE: [net 2/2] ixgbe: Limit use of 2K buffers on architectures with 256B or larger cache lines

2017-03-03 Thread Duyck, Alexander H
> -Original Message- > From: David Laight [mailto:david.lai...@aculab.com] > Sent: Friday, March 3, 2017 4:25 AM > To: Kirsher, Jeffrey T ; da...@davemloft.net > Cc: Duyck, Alexander H ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > jogre...@red

Re: [patch net-next 1/7] ipv4: fib: Only flush FIB aliases belonging to currently flushed table

2017-02-09 Thread Duyck, Alexander H
On Thu, 2017-02-09 at 10:28 +0100, Jiri Pirko wrote: > From: Ido Schimmel > > In case the MAIN table is flushed and its trie is shared with the LOCAL > table, then we might be flushing FIB aliases belonging to the latter. > This can lead to FIB_ENTRY_DEL notifications sent with the wrong table >

RE: [PATCH net-next 8/9] ipvlan: improve compiler hints

2017-04-27 Thread Duyck, Alexander H
> -Original Message- > From: Chiappero, Marco > Sent: Thursday, April 27, 2017 7:52 AM > To: netdev@vger.kernel.org > Cc: David S . Miller ; Kirsher, Jeffrey T > ; Duyck, Alexander H > ; Grandhi, Sainath > ; Mahesh Bandewar ; > Chiappero, Marco > Subjec

Re: [Intel-wired-lan] [PATCH 249/249] net:ethernet:intel:igb_main.c: Add Throttling disable option in order to decrease latency usually required by RT applications.

2016-09-07 Thread Duyck, Alexander H
On Tue, 2016-09-06 at 14:46 +, Amir Yihie wrote: > From e433f5bedd49a65b7337d025f3f204f0f21ad5e5 Mon Sep 17 00:00:00 > 2001 > From: amiry > Date: Tue, 6 Sep 2016 14:58:38 +0300 > Subject: [PATCH 249/249] net:ethernet:intel:igb_main.c: Add > Throttling disable >  option in order to decrease lat

Re: [PATCH RFC] ixgbe: ixgbe_atr() must check if network header is available in headlen

2016-10-17 Thread Duyck, Alexander H
On Sat, 2016-10-15 at 17:31 -0400, Sowmini Varadhan wrote: > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be > passed down an sk_buff that has the network and transport > header in the paged data, so it needs to make sure these > headers are available in the headlen bytes to calculate the

RE: [mm PATCH v2 01/26] swiotlb: Drop unused functions swiotlb_map_sg and swiotlb_unmap_sg

2016-11-03 Thread Duyck, Alexander H
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, November 3, 2016 7:46 AM > To: Konrad Rzeszutek Wilk > Cc: Christoph Hellwig ; Duyck, Alexander H > ; linux...@kvack.org; akpm@linux- > foundation.org; netdev@vger.

RE: bug in ixgbe_atr

2016-10-13 Thread Duyck, Alexander H
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Thursday, October 13, 2016 6:44 PM > To: Duyck, Alexander H ; > netdev@vger.kernel.org > Subject: bug in ixgbe_atr > > When I was playing around with TPACKET_V2, I t

RE: bug in ixgbe_atr

2016-10-14 Thread Duyck, Alexander H
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Thursday, October 13, 2016 8:49 PM > To: Duyck, Alexander H > Cc: netdev@vger.kernel.org > Subject: Re: bug in ixgbe_atr > > On (10/14/16 02:06), Duyck, Alexander H wrot

Re: [net PATCH 2/2] ipv4: Drop suffix update from resize code

2016-12-05 Thread Duyck, Alexander H
On Mon, 2016-12-05 at 12:28 -0500, David Miller wrote: > From: Robert Shearman > Date: Mon, 5 Dec 2016 15:05:18 + > > > > > On 01/12/16 12:27, Alexander Duyck wrote: > > > > > > It has been reported that update_suffix can be expensive when it is > > > called > > > on a large node in which m

RE: [net-next v2 02/19] i40e: simplify txd use count calculation

2016-12-07 Thread Duyck, Alexander H
; jogre...@redhat.com; guru.anbalag...@oracle.com; Duyck, Alexander H > > Subject: Re: [net-next v2 02/19] i40e: simplify txd use count calculation > > On Wed, 2016-12-07 at 14:19 -0800, Jeff Kirsher wrote: > > From: Mitch Williams > > > > The i40e_txd_use_count function w

RE: [net-next v2 02/19] i40e: simplify txd use count calculation

2016-12-07 Thread Duyck, Alexander H
> -Original Message- > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Wednesday, December 7, 2016 5:04 PM > To: Duyck, Alexander H > Cc: Kirsher, Jeffrey T ; da...@davemloft.net; > Williams, Mitch A ; netdev@vger.kernel.org; > nhor...@redhat.com; sassm

RE: [PATCH net] fib_trie: Avoid expensive update of suffix length when not required

2016-12-02 Thread Duyck, Alexander H
> -Original Message- > From: Robert Shearman [mailto:rshea...@brocade.com] > Sent: Friday, December 2, 2016 5:54 AM > To: Alexander Duyck > Cc: David Miller ; Netdev ; > Duyck, Alexander H > Subject: Re: [PATCH net] fib_trie: Avoid expensive update of suffix length

Re: [net] 2ab9fb18c4: kernel BUG at include/linux/skbuff.h:1935!

2016-11-14 Thread Duyck, Alexander H
On Mon, 2016-11-14 at 07:49 +0800, kernel test robot wrote: > FYI, we noticed the following commit: > > https://github.com/0day-ci/linux > Eric-Dumazet/net-__skb_flow_dissect-must-cap-its-return-value/20161110-080839 > commit 2ab9fb18c46b91b16a0f0f329336d3be9fc32deb ("net: __skb_flow_dissect() >

Re: [net PATCH 1/2] ipv4: Restore fib_trie_flush_external function and fix call ordering

2016-11-15 Thread Duyck, Alexander H
On Tue, 2016-11-15 at 20:51 +0100, Jiri Pirko wrote: > Tue, Nov 15, 2016 at 11:46:06AM CET, alexander.h.du...@intel.com wrote: > > > > The patch that removed the FIB offload infrastructure was a bit too > > aggressive and also removed code needed to clean up us splitting the table > > if additiona

Re: [net PATCH 1/2] ipv4: Restore fib_trie_flush_external function and fix call ordering

2016-11-15 Thread Duyck, Alexander H
On Tue, 2016-11-15 at 21:31 +0100, Jiri Pirko wrote: > Tue, Nov 15, 2016 at 09:29:09PM CET, alexander.h.du...@intel.com wrote: > > > > On Tue, 2016-11-15 at 20:51 +0100, Jiri Pirko wrote: > > > > > > Tue, Nov 15, 2016 at 11:46:06AM CET, alexander.h.du...@intel.com wrote: > > > > > > > > > > > >

Re: [net PATCH 1/2] ipv4: Restore fib_trie_flush_external function and fix call ordering

2016-11-15 Thread Duyck, Alexander H
On Tue, 2016-11-15 at 21:52 +0100, Jiri Pirko wrote: > Tue, Nov 15, 2016 at 09:49:02PM CET, alexander.h.du...@intel.com wrote: > > > > On Tue, 2016-11-15 at 21:31 +0100, Jiri Pirko wrote: > > > > > > Tue, Nov 15, 2016 at 09:29:09PM CET, alexander.h.du...@intel.com wrote: > > > > > > > > > > > >

Re: [net PATCH 1/2] ipv4: Restore fib_trie_flush_external function and fix call ordering

2016-11-15 Thread Duyck, Alexander H
On Tue, 2016-11-15 at 22:07 +0100, Jiri Pirko wrote: > Tue, Nov 15, 2016 at 10:01:03PM CET, alexander.h.du...@intel.com wrote: > > > > On Tue, 2016-11-15 at 21:52 +0100, Jiri Pirko wrote: > > > > > > Tue, Nov 15, 2016 at 09:49:02PM CET, alexander.h.du...@intel.com wrote: > > > > > > > > > > > >