Re: [PATCH][FIX 4.1] bgmac: fix requests for extra polling calls from NAPI

2015-04-23 Thread Felix Fietkau
On 2015-04-23 20:56, Rafał Miłecki wrote: After d75b1ade567f (net: less interrupt masking in NAPI) polling function has to return whole budget when it wants NAPI to call it again. Signed-off-by: Rafał Miłecki zaj...@gmail.com Cc: Felix Fietkau n...@openwrt.org Fixes: eb64e2923a886 (bgmac

[PATCH] pppoe: drop pppoe device in pppoe_unbind_sock_work

2015-05-09 Thread Felix Fietkau
when a PADT is received) Signed-off-by: Felix Fietkau n...@openwrt.org --- drivers/net/ppp/pppoe.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c index ff059e1..6a544f2 100644 --- a/drivers/net/ppp/pppoe.c +++ b/drivers/net/ppp/pppoe.c

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-11-09 Thread Felix Fietkau
On 2015-11-09 18:53, Willem de Bruijn wrote: > On Sat, Nov 7, 2015 at 8:11 AM, Felix Fietkau <n...@openwrt.org> wrote: >> On 2015-07-31 00:15, Martin Blumenstingl wrote: >>> On Wed, Jul 29, 2015 at 8:05 AM, Willem de Bruijn <will...@google.com> >>> wrote:

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-11-07 Thread Felix Fietkau
On 2015-07-31 00:15, Martin Blumenstingl wrote: > On Wed, Jul 29, 2015 at 8:05 AM, Willem de Bruijn wrote: >> Martin, to return to your initial statement that PPPoE PADI packets can >> have a zero payload: the PPPoE RFC states that PADI packets "MUST >> contain exactly one TAG

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-03 Thread Felix Fietkau
On 2015-10-02 15:30, Neil Armstrong wrote: > On 10/02/2015 03:29 PM, Sergei Shtylyov wrote: >> On 10/2/2015 1:48 PM, Neil Armstrong wrote: >> >>> To simplify and prevent memory leakage when unbinding, use >>> the devm_ memory allocation calls. >>> >>> Tested-by: Andrew Lunn >>>

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-02 Thread Felix Fietkau
On 2015-10-02 12:48, Neil Armstrong wrote: > To simplify and prevent memory leakage when unbinding, use > the devm_ memory allocation calls. > > Tested-by: Andrew Lunn > Tested-by: Florian Fainelli > Signed-off-by: Neil Armstrong I

[PATCH] net: remove unnecessary semicolon in netdev_alloc_pcpu_stats()

2015-12-05 Thread Felix Fietkau
This semicolon causes a build error if the function call is wrapped in parentheses. Fixes: aabc92bbe3cf ("net: add __netdev_alloc_pcpu_stats() to indicate gfp flags") Reported-by: Imre Kaloz <ka...@openwrt.org> Signed-off-by: Felix Fietkau <n...@openwrt.org> --- include

Re: [PATCH] net: emac: emac gigabit ethernet controller driver

2015-12-07 Thread Felix Fietkau
On 2015-12-07 23:58, Gilad Avidov wrote: > +/* RRD (Receive Return Descriptor) */ > +union emac_rrd { > + struct { > + /* 32bit word 0 */ > + u32 xsum:16; > + u32 nor:4; /* number of RFD */ > + u32 si:12; /* start index of rfd-ring

Re: [PATCH 1/2] add basic register-field manipulation macros

2016-06-13 Thread Felix Fietkau
itfield.h > > diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h > new file mode 100644 > index ..ae2224464523 > --- /dev/null > +++ b/include/linux/bitfield.h > @@ -0,0 +1,58 @@ > +/* > + * Copyright (C) 2014 Felix Fietkau <n...@openwrt.org> Please change my email address to n...@nbd.name here - Felix

Re: [PATCH] mac80211: minstrel_ht: fix out-of-bound in minstrel_ht_set_best_prob_rate

2016-01-29 Thread Felix Fietkau
...@gmail.com> > Link: > http://lkml.kernel.org/r/calygninyjhsavne35qs6ucgasb2dx1_i5hcravuox14otz2...@mail.gmail.com Acked-by: Felix Fietkau <n...@openwrt.org>

Re: KASAN splal in minstrel_ht_update_stats()

2016-01-28 Thread Felix Fietkau
On 2016-01-15 06:23, Konstantin Khlebnikov wrote: > Jan 10 17:56:25 hamm kernel: [184374.378842] > == > Jan 10 17:56:25 hamm kernel: [184374.379001] BUG: KASAN: > slab-out-of-bounds in minstrel_ht_update_stats.isra.7+0x6e1/0x9e0 [...]

Re: [PATCH V2 03/12] net-next: mediatek: add embedded switch driver (ESW)

2016-02-26 Thread Felix Fietkau
On 2016-02-26 16:18, Andrew Lunn wrote: > On Fri, Feb 26, 2016 at 03:21:35PM +0100, John Crispin wrote: >> The ESW is found in many of the old 100mbit MIPS based SoCs. it has 5 >> external ports, 1 cpu port and 1 further port that the internal HW >> offloading engine connects to. >> >> This

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

2016-02-26 Thread Felix Fietkau
On 2016-02-26 14:09, Michal Kazior wrote: > Since 11n aggregation become important to get the > best out of txops. However aggregation inherently > requires buffering and queuing. Once variable > medium conditions to different associated stations > is considered it became apparent that bufferbloat

Re: [RFC/RFT] mac80211: implement fq_codel for software queuing

2016-03-07 Thread Felix Fietkau
On 2016-03-07 15:05, Avery Pennarun wrote: > On Fri, Mar 4, 2016 at 1:32 AM, Michal Kazior wrote: >> On 4 March 2016 at 03:48, Tim Shepard wrote: >> [...] >>> (I am interested in knowing what other mac80211 drivers have been >>> modified to use the

Re: [PATCH 1/3] net: bgmac: allocate struct bgmac just once & don't copy it

2017-01-27 Thread Felix Fietkau
On 2017-01-27 10:20, Rafał Miłecki wrote: > From: Rafał Miłecki > > To share as much code as possible in bgmac we call alloc_etherdev from > bgmac.c which is used by both: platform and bcma code. The easiest > solution was to use it for allocating whole struct bgmac but it

Re: [net, 6/6] net: korina: version bump

2017-01-22 Thread Felix Fietkau
On 2017-01-22 13:10, Roman Yeryomin wrote: > On 17 January 2017 at 21:19, Roman Yeryomin <leroi.li...@gmail.com> wrote: >> On 17 January 2017 at 20:55, Felix Fietkau <n...@nbd.name> wrote: >>> On 2017-01-17 18:33, Roman Yeryomin wrote: >>>> Sig

Re: [net, 6/6] net: korina: version bump

2017-01-17 Thread Felix Fietkau
On 2017-01-17 18:33, Roman Yeryomin wrote: > Signed-off-by: Roman Yeryomin > --- > drivers/net/ethernet/korina.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c > index 83c994f..c8fed01

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Felix Fietkau
On 2016-12-07 19:54, Jason A. Donenfeld wrote: > On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: >> It's so much better to analyze properly where the misalignment comes from >> and address it at the source, as we have for various cases that trip up >> Sparc too. > >

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Felix Fietkau
On 2016-12-10 21:32, Måns Rullgård wrote: > Felix Fietkau <n...@nbd.name> writes: > >> On 2016-12-10 14:25, Måns Rullgård wrote: >>> Felix Fietkau <n...@nbd.name> writes: >>> >>>> On 2016-12-07 19:54, Jason A. Donenfeld wrote:

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-10 Thread Felix Fietkau
On 2016-12-10 14:25, Måns Rullgård wrote: > Felix Fietkau <n...@nbd.name> writes: > >> On 2016-12-07 19:54, Jason A. Donenfeld wrote: >>> On Wed, Dec 7, 2016 at 7:51 PM, David Miller <da...@davemloft.net> wrote: >>>> It's so much better to analy

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-10 Thread Felix Fietkau
On 2017-01-10 11:56, Johannes Berg wrote: > On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wrote: >> > I wonder if MAC80211 should be doing IGMP snooping and not bridge >> > in this environment. >> >> In the long term, yes.

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-10 Thread Felix Fietkau
On 2017-01-10 18:17, Dave Taht wrote: > In the case of wifi I have 3 issues with this line of thought. > > multicast in wifi has generally supposed to be unreliable. This makes > it reliable. reliability comes at a cost - > > multicast is typically set at a fixed low rate today. unicast is >

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-11 Thread Felix Fietkau
On 2017-01-11 13:15, IgorMitsyanko wrote: > On 01/11/2017 02:30 PM, Felix Fietkau wrote: >> On 2017-01-11 12:26, IgorMitsyanko wrote: >>> On 01/11/2017 12:27 AM, Felix Fietkau wrote: >>>> On 2017-01-10 11:56, Johannes Berg wrote: >>>>> On Tue, 2

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-11 Thread Felix Fietkau
On 2017-01-11 12:26, IgorMitsyanko wrote: > On 01/11/2017 12:27 AM, Felix Fietkau wrote: >> On 2017-01-10 11:56, Johannes Berg wrote: >>> On Tue, 2017-01-10 at 05:18 +0100, Linus Lüssing wrote: >>>> On Mon, Jan 09, 2017 at 01:30:32PM -0800, Stephen Hemminger wro

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-03 Thread Felix Fietkau
t. > > The initial patch and idea is from Felix Fietkau. > > Cc: Felix Fietkau <n...@nbd.name> > Signed-off-by: Linus Lüssing <linus.luess...@c0d3.blue> Please add Signed-off-by: Felix Fietkau <n...@nbd.name> in the next version, and maybe also From: Thanks, - Felix

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-06 Thread Felix Fietkau
On 2017-01-06 14:54, Johannes Berg wrote: > >> The bridge layer can use IGMP snooping to ensure that the multicast >> stream is only transmitted to clients that are actually a member of >> the group. Can the mac80211 feature do the same? > > No, it'll convert the packet for all clients that are

Re: [PATCH net-next] bridge: multicast to unicast

2017-01-06 Thread Felix Fietkau
On 2017-01-06 13:47, Johannes Berg wrote: > On Mon, 2017-01-02 at 20:32 +0100, Linus Lüssing wrote: >> Implements an optional, per bridge port flag and feature to deliver >> multicast packets to any host on the according port via unicast >> individually. This is done by copying the packet per host

Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy

2017-03-27 Thread Felix Fietkau
ad); >> frag_ptr = skb->data; >> frag_size = head_size; >> +frag--; > > Isn't it just a question of time until the compiler will see through > this trick and warn about it? Frag is incremented again before being accessed, so there is nothing for the compiler to see through here. Acked-by: Felix Fietkau <n...@nbd.name> - Felix

Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-23 Thread Felix Fietkau
On 2017-03-23 15:25, John Crispin wrote: > > > On 23/03/17 15:09, Felix Fietkau wrote: >> On 2017-03-23 09:06, Sean Wang wrote: >>> Hi Andrew, >>> >>> The purpose for the regmap table registered is to >>> >>> provide a way which h

Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-23 Thread Felix Fietkau
On 2017-03-23 09:06, Sean Wang wrote: > Hi Andrew, > > The purpose for the regmap table registered is to > > provide a way which helps us to look up a specific > > register on the switch through regmap-debugfs. > > > And not all ranges of register is defined > > so I only include the

Re: [PATCH v2 net-next] tcp: allow drivers to tweak TSQ logic

2017-11-28 Thread Felix Fietkau
On 2017-11-12 00:54, Eric Dumazet wrote: > From: Eric Dumazet > > I had many reports that TSQ logic breaks wifi aggregation. > > Current logic is to allow up to 1 ms of bytes to be queued into qdisc > and drivers queues. > > But Wifi aggregation needs a bigger budget to

Re: [PATCH 1/3] kallsyms: don't leak address when symbol not found

2017-12-18 Thread Felix Fietkau
On 2017-12-18 00:53, Tobin C. Harding wrote: > Currently if kallsyms_lookup() fails to find the symbol then the address > is printed. This potentially leaks sensitive information. Instead of > printing the address we can return an error, giving the calling code the > option to print the address or

Re: [PATCH] mt76: fix memcpy to potential null pointer on failed allocation

2017-12-14 Thread Felix Fietkau
ue") > > Fixes: 7bc04215a66b ("mt76: add driver code for MT76x2e") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Felix Fietkau <n...@nbd.name>

Re: [PATCH RFC,WIP 5/5] netfilter: nft_flow_offload: add ndo hooks for hardware offload

2017-11-11 Thread Felix Fietkau
On 2017-11-03 16:26, Pablo Neira Ayuso wrote: > This patch adds the infrastructure to offload flows to hardware, in case > the nic/switch comes with built-in flow tables capabilities. > > If the hardware comes with not hardware flow tables or they have > limitations in terms of features, this

Re: [PATCH net-next 1/3] net: dsa: mediatek: add VLAN support for MT7530

2017-12-12 Thread Felix Fietkau
On 2017-12-07 07:06, sean.w...@mediatek.com wrote: > From: Sean Wang > > MT7530 can treat each port as either VLAN-unware port or VLAN-ware port Shouldn't that be VLAN-unaware/VLAN-aware (in the code as well)? - Felix

Re: [PATCH] [wireless-next] mt76: fix building without CONFIG_LEDS_CLASS

2018-01-18 Thread Felix Fietkau
On 2018-01-18 14:14, Arnd Bergmann wrote: > When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while > mt76 is built-in, we run into a link error: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function > `mt76_register_device': > mac80211.c:(.text+0xb78): relocation truncated

[PATCH] net: igmp: fix source address check for IGMPv3 reports

2018-01-19 Thread Felix Fietkau
eported-by: Sebastian Gottschall <s.gottsch...@dd-wrt.com> Signed-off-by: Felix Fietkau <n...@nbd.name> --- net/ipv4/igmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index 726f6b608274..2d49717a7421 100644 --- a/net/ipv4/i

Re: [PATCH] net: igmp: fix source address check for IGMPv3 reports

2018-01-23 Thread Felix Fietkau
On 2018-01-22 22:17, David Miller wrote: > From: Felix Fietkau <n...@nbd.name> > Date: Fri, 19 Jan 2018 11:50:46 +0100 > >> Commit "net: igmp: Use correct source address on IGMPv3 reports" >> introduced a check to validate the source address of locally ge

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-10 Thread Felix Fietkau
On 2018-02-10 14:56, Kai Heng Feng wrote: > >> On 9 Feb 2018, at 3:16 PM, Kalle Valo wrote: >> Sure, but we have to make sure that we don't create regressions on >> existing systems. For example, did you test this with any system which >> don't support btcoex? (just asking,

[PATCH 1/2] netfilter: nf_tables: fix flowtable free

2018-02-05 Thread Felix Fietkau
Every flow_offload entry is added into the table twice. Because of this, rhashtable_free_and_destroy can't be used, since it would call kfree for each flow_offload object twice. Signed-off-by: Felix Fietkau <n...@nbd.name> --- include/net/netfilter/nf_flow_table.h | 2 ++ net/ipv4/net

[PATCH 2/2] netfilter: nf_tables: fix flowtable resource leak

2018-02-05 Thread Felix Fietkau
When cleaning up flowtable entries, associated dst and ct entries need to be released as well Signed-off-by: Felix Fietkau <n...@nbd.name> --- net/netfilter/nf_flow_table.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/net/netfilter/nf_flow_tab

Re: [PATCH] ath9k: turn on btcoex_enable as default

2018-02-08 Thread Felix Fietkau
On 2018-02-08 06:28, Kai-Heng Feng wrote: > Without btcoex_enable, WiFi activies make both WiFi and Bluetooth > unstable if there's a bluetooth connection. > > Enable this option when bt_ant_diversity is disabled. > > BugLink: https://bugs.launchpad.net/bugs/1746164 > Signed-off-by: Kai-Heng

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

2018-03-12 Thread Felix Fietkau
On 2018-03-12 19:58, David Miller wrote: > From: Pablo Neira Ayuso > Date: Mon, 12 Mar 2018 18:58:50 +0100 > >> The following patchset contains Netfilter/IPVS updates for your net-next >> tree. This batch comes with more input sanitization for xtables to >> address bug

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

2018-03-12 Thread Felix Fietkau
On 2018-03-12 21:01, David Miller wrote: > From: Felix Fietkau <n...@nbd.name> > Date: Mon, 12 Mar 2018 20:30:01 +0100 > >> It's not dead and useless. In its current state, it has a software fast >> path that significantly improves nftables routing/NAT throughput

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-13 Thread Felix Fietkau
On 2018-02-27 11:08, Rafał Miłecki wrote: > I've problem when using OpenWrt/LEDE on a home router with Broadcom's > FullMAC WiFi chipset. > > > First of all OpenWrt/LEDE uses bridge interface for LAN network with: > 1) IFLA_BRPORT_MCAST_TO_UCAST > 2) Clients isolation in hostapd > 3) Hairpin

Re: Problem with bridge (mcast-to-ucast + hairpin) and Broadcom's 802.11f in their FullMAC fw

2018-03-13 Thread Felix Fietkau
[resent with fixed typo in linux-wireless address] On 2018-02-27 11:08, Rafał Miłecki wrote: > I've problem when using OpenWrt/LEDE on a home router with Broadcom's > FullMAC WiFi chipset. > > > First of all OpenWrt/LEDE uses bridge interface for LAN network with: > 1)

Re: [PATCH RFC] net_sched/codel: do not defer queue length update

2018-03-10 Thread Felix Fietkau
On 2017-08-21 10:14, Konstantin Khlebnikov wrote: > When codel wants to drop last packet in ->dequeue() it cannot call > qdisc_tree_reduce_backlog() right away - it will notify parent qdisc > about zero qlen and HTB/HFSC will deactivate class. The same class will > be deactivated second time by

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

2018-04-05 Thread Felix Fietkau
On 2018-04-05 15:51, Joe Perches wrote: >> You have to factor in >> not just the .text size, but the fact that referencing an exported >> symbol needs a .reloc entry as well, which also eats up some space (at >> least when the code is being built as module). > > Thanks, the modules I built got

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

2018-04-05 Thread Felix Fietkau
On 2018-03-31 09:05, Joe Perches wrote: > There are many local static and non-static arrays that are used for > Ethernet broadcast address output or comparison. > > Centralize the array into a single separate file and remove the local > arrays. I suspect that for many targets and configurations,