Network activity LED trigger

2007-05-23 Thread Florian Fainelli
not adequate. Also the ledtrig_network_activity can be network device specific for instance. Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 80acd08..25d2b58 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -127,5 +127,12

[PATCH] Fix kernel unaligned access with r8169 on sparc64

2007-07-06 Thread Florian Fainelli
The following patch against 2.6.22-rc6 will fix this problem. Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 5ec7752..5095dbe 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -69,6 +69,7 @@ VERSION 2.2LK 2005/01/25 #include asm

Re: [PATCH] Fix kernel unaligned access with r8169 on sparc64

2007-07-09 Thread Florian Fainelli
Few things about this patch. It's pretty quick and dirty, more experienced people with a better knowledge of the ip stack would certainly do better. Though the problem was reported with Debian's 2.6.18 kernel, it is also present in the 2.6.22-rc6 version. Without the patch, I can hardly achieve

Re: Network activity LED trigger

2007-05-10 Thread Florian Fainelli
is probably not adequate. Also the ledtrig_network_activity can be network device specific for instance. Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 80acd08..25d2b58 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -127,5

Network activity LED trigger

2007-03-01 Thread Florian Fainelli
Hi All, I have been talking a bit with Richard, who is the LED API maintainer, and a LED trigger based on network activity would be something great. There are somethings that concern the network stack : - should we specify if the network driver is allowed to contribute to the LED activity,

Re: Network activity LED trigger

2007-03-02 Thread Florian Fainelli
already have LEDs, so it is not necessary for those models to overload the user with lights everywhere. Regars, Florian Le jeudi 1 mars 2007, Florian Fainelli a écrit : Hi All, I have been talking a bit with Richard, who is the LED API maintainer, and a LED trigger based on network activity

Re: Network activity LED trigger

2007-03-02 Thread Florian Fainelli
to embedded devices for which you do not necessarily want to assign a LED to a given network interface cheers, jamal On Fri, 2007-02-03 at 13:58 +0100, Florian Fainelli wrote: Hi All, Some more thoughts. The IDE activity LED trigger is currently triggered when a function is called

[PATCH] Au1000 link beat detection

2007-03-03 Thread Florian Fainelli
Hi all This patch fixes the link beat detection when the cable is not plugged at startup with au1000_eth driver. Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff -urN linux-2.6.16.7/drivers/net/au1000_eth.c linux-2.6.16.7.new/drivers/net/au1000_eth.c --- linux-2.6.16.7/drivers/net

[PATCH] Add a network activity LED trigger

2007-07-18 Thread Florian Fainelli
trigger as defined by the LED subsystem. Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 87d2046..fdc5a8a 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -128,5 +128,12 @@ config LEDS_TRIGGER_HEARTBEAT load

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread Florian Fainelli
Hello Patrick, Le mercredi 18 juillet 2007, Patrick McHardy a écrit : Module isn't possible, you call the led trigger from net/core/dev.c. You are right, it just occured to me. Besides missing a declaration and not linking without the network LED config option, its pretty ridiculous to call

[PATCH] Au1000 eth : fix ioctl handling

2007-07-24 Thread Florian Fainelli
Hi all, This patch fixes the handling of unsupported ioctls with the au1000_eth driver. Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c index c27cfce..99a1c61 100644 --- a/drivers/net/au1000_eth.c +++ b/drivers/net

[PATCH][RFC] Add support for the RDC R6040 Fast Ethernet controller

2007-10-29 Thread Florian Fainelli
are the following ones : RDC_PCI_VENDOR_ID = 0x17f3 RDC_PCI_DEVICE_ID_RDC_R6040 = 0x6040 Thank you very much in advance for your comments. Signed-off-by: Sten Wang [EMAIL PROTECTED] Signed-off-by: Daniel Gimpelevich [EMAIL PROTECTED] Signed-off-by: Florian Fainelli [EMAIL PROTECTED] --- diff --git

[PATCH][RFC take 2] Add support for the RDC R6040 Fast Ethernet controller

2007-11-10 Thread Florian Fainelli
saying in your mails, but I have fixed them as well). Thanks to Jeff and Stephen for their detailed comments. Signed-off-by: Sten Wang [EMAIL PROTECTED] Signed-off-by: Daniel Gimpelevich [EMAIL PROTECTED] Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff --git a/drivers/net/Kconfig b

[PATCH] Add support for the RDC R6040 Fast Ethernet controller

2007-11-12 Thread Florian Fainelli
This patch adds support for the RDC R6040 MAC we can find in the RDC R-321x System-on-chips. Signed-off-by: Sten Wang [EMAIL PROTECTED] Signed-off-by: Daniel Gimpelevich [EMAIL PROTECTED] Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig

Re: [PATCH] Add support for the RDC R6040 Fast Ethernet controller

2007-11-13 Thread Florian Fainelli
Le Tuesday 13 November 2007 06:31:32 David Miller, vous avez écrit : I've added this to my netdev-2.6 tree, thanks! Thanks David ! - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] r6040 various bugfixes

2007-11-15 Thread Florian Fainelli
Hello Stephen, Le jeudi 15 novembre 2007, Stephen Hemminger a écrit : Looks good, thanks: There is a function to make this easier: @@ -756,10 +803,8 @@ r6040_open(struct net_device *dev) if (lp-switch_sig != ICPLUS_PHY_ID) { /* set and active a timer process */

[PATCH] r6040 various bugfixes

2007-11-15 Thread Florian Fainelli
each TX/RX error to a separate line for better reading - suppress volatiles and make checkpatch happy - better control of the timer - fix spin_unlock_irq typo in netdev_get_settings - fix various typos and spelling in the driver Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff --git

Re: [PATCH] r6040 various cleanups

2007-12-13 Thread Florian Fainelli
Hi Francois, Francois Romieu a écrit : Thanks, I have split it in parts. The serie should be available shortly at: git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git r6040 You are welcome, thank you for taking care of this driver ! Please note that: 1. TIMER_WUT has

[PATCH] Add me as maintainer of the RDC r6040 driver

2007-12-19 Thread Florian Fainelli
This patch adds me as maintainer of the RDC R6040 Fast Ethernet driver. Signed-off-by: Florian Fainelli [EMAIL PROTECTED] -- diff --git a/MAINTAINERS b/MAINTAINERS index 9507b42..6038bfb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3162,6 +3162,12 @@ M: [EMAIL PROTECTED] L: [EMAIL

Re: [PATCH] Add me as maintainer of the RDC r6040 driver

2008-01-13 Thread Florian Fainelli
Hi Jeff, Le samedi 12 janvier 2008, Jeff Garzik a écrit : applied Thank you. I think you will get this change twice when you pull Francoi's netdev-2.6 repository which has the r6040 patches I sent already. -- Cordialement, Florian Fainelli -- -- To unsubscribe

Re: Pull request for 'r6040' branch

2008-02-10 Thread Florian Fainelli
latest head and given each patch a compile test. The content is identical to Florian's initial work (minus the removal of the unused TIMER_WUT and a duplicate update of an error counter). Thank you very much Francois. Jeff, any news on this ? -- Cordialement, Florian Fainelli

Re: [RFC PATCH 0/3] Enable connecting DSA-based switch to the USB RMII interface.

2015-04-21 Thread Florian Fainelli
On 21/04/15 10:39, Andrew Lunn wrote: I would however say that sysfs is the wrong API. The linux network stack uses netlink for most configuration activities. So i would suggest adding a netlink binding to DSA, and place the code in net/dsa/, not within an MDIO driver. I suppose we could do

Re: [RFC PATCH 0/3] Enable connecting DSA-based switch to the USB RMII interface.

2015-04-21 Thread Florian Fainelli
On 21/04/15 05:47, Andrew Lunn wrote: Hi Jan Interesting work, but i think the architecture is wrong. DSA needs an Ethernet device, an MDIO bus, and information about ports on the switch. That requirement is completely artificial as it is today, and just comes from arbitrary limitations

Re: [RFC PATCH 0/3] Enable connecting DSA-based switch to the USB RMII interface.

2015-04-21 Thread Florian Fainelli
On 21/04/15 10:30, Andrew Lunn wrote: My goal in reworking this weird DSA device/driver model is that you could just register your switch devices as an enhanced phy_driver/spi_driver/pci_driver etc..., such that libphy-ready drivers could just take advantage of that when they scan/detect their

Re: Resource usages in Linux drivers

2015-04-23 Thread Florian Fainelli
On 23/04/15 16:19, Francois Romieu wrote: Sergei Shtylyov sergei.shtyl...@cogentembedded.com : On 4/23/2015 1:08 PM, Jia-Ju Bai wrote: [...] I also find many drivers do not use these managed APIs, especially in ethernet card drivers (like e100, r8169). Is it possible to change them?

Re: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread Florian Fainelli
On 22/04/15 03:22, Shengzhou Liu wrote: RTL8211F needs to enalbe TXDLY for RGMII during phy initialization, so move it to rtl8211f_config for early initialization. Signed-off-by: Shengzhou Liu shengzhou@freescale.com cc: Joe Hershberger joe.hershber...@gmail.com ---

Re: [PATCH] net: mdio-gpio: support access that may sleep

2015-04-24 Thread Florian Fainelli
On 24/04/15 08:04, David Miller wrote: From: Vivien Didelot vivien.dide...@savoirfairelinux.com Date: Wed, 22 Apr 2015 13:06:54 -0400 Some systems using mdio-gpio may use gpio on message based busses, which require sleeping (e.g. gpio from an I2C I/O expander). Since this driver does not

Re: [PATCH] net: mdio-gpio: support access that may sleep

2015-04-24 Thread Florian Fainelli
On 24/04/15 09:01, David Miller wrote: From: Florian Fainelli f.faine...@gmail.com Date: Fri, 24 Apr 2015 08:56:34 -0700 On 24/04/15 08:04, David Miller wrote: From: Vivien Didelot vivien.dide...@savoirfairelinux.com Date: Wed, 22 Apr 2015 13:06:54 -0400 Some systems using mdio-gpio may

Re: [PATCH] net: mdio-gpio: support access that may sleep

2015-04-24 Thread Florian Fainelli
On 24/04/15 10:25, Sergei Shtylyov wrote: On 04/24/2015 06:56 PM, Florian Fainelli wrote: Some systems using mdio-gpio may use gpio on message based busses, which require sleeping (e.g. gpio from an I2C I/O expander). Since this driver does not use IRQ handler, it is safe to use

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Florian Fainelli
On 14/04/15 14:37, Sergei Shtylyov wrote: +/* Wait for stopping the hardware TX process */ +ravb_wait(ndev, TCCR, TCCR_TSRQ0 | TCCR_TSRQ1 | TCCR_TSRQ2 | TCCR_TSRQ3, + 0); + +ravb_wait(ndev, CSR, CSR_TPO0 | CSR_TPO1 | CSR_TPO2 | CSR_TPO3, 0); + +/* Stop the

Re: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread Florian Fainelli
Le 22/04/2015 20:53, shengzhou@freescale.com a écrit : -Original Message- From: Florian Fainelli [mailto:f.faine...@gmail.com] Sent: Thursday, April 23, 2015 12:57 AM To: Liu Shengzhou-B36685; netdev@vger.kernel.org; joe.hershber...@gmail.com Subject: Re: [PATCH] net/phy: refactor

Re: [RFC PATCH 1/3] net/dsa: Refactor dsa_probe()

2015-04-21 Thread Florian Fainelli
On 21/04/15 06:26, Jan Kaisrlik wrote: From: Jan Kaisrlik ja.kaisr...@gmail.com This patch refactors dsa_probe in order to simplify code in the patch 2/3. It does not look like you are working on the latest net-next tree, that part of the code has already been refactored to have separate

Re: [PATCH iproute2] Use PATH_MAX instead of MAXPATHLEN

2015-04-28 Thread Florian Fainelli
On 27/04/15 09:13, Stephen Hemminger wrote: On Sat, 25 Apr 2015 22:33:28 +0200 Felix Janda felix.ja...@posteo.de wrote: They are equivalent but the former is more common. PATH_MAX is specified by POSIX and needs limits.h while MAXPATHLEN has BSD origin and needs sys/param.h. PATH_MAX has

[RFC PATCH net-next 0/8] net: dsa: New registration API

2015-04-29 Thread Florian Fainelli
/ffainelli/linux/tree/dsa-model-proposal Happy testing! Florian Fainelli (8): net: dsa: Move dsa_switch_tree final setup in separate function net: phy: Check fixup lists in get_phy_device() net: phy: Allow PHY devices to identify themselves as Ethernet switches net: mv643xx_eth: Handle

[PATCH net-next 0/2] net: systemport: interrupt coalescing support

2015-05-11 Thread Florian Fainelli
Hi David, This patch series adds support for RX TX interrupt coalescing in the systemport driver. Florian Fainelli (2): net: systemport: Implement TX coalescing control knobs net: systemport: Implement RX coalescing control knobs drivers/net/ethernet/broadcom/bcmsysport.c | 63

[PATCH net-next 3/3] net: phy: mdio-gpio: Handle phy_ignore_ta_mask

2015-05-12 Thread Florian Fainelli
Update mdiobb_read() to read whether the PHY has a broken turn-around, and if it does, ignore it to make the read succeeed. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/phy/mdio-bitbang.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers

Re: linux-next: manual merge of the net-next tree with the net tree

2015-05-20 Thread Florian Fainelli
2015-05-20 19:59 GMT-07:00 Stephen Rothwell s...@canb.auug.org.au: Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/phy/phy.c between commit c15e10e71ce3 (net: phy: Make sure phy_start() always re-enables the phy interrupts) from the net tree and commit

[PATCH net-next] net: bcmgenet: improve TX timeout

2015-06-04 Thread Florian Fainelli
control to help with the recovery. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 67 ++ 1 file changed, 67 insertions(+) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom

[PATCH net-next] net: phy: bcm7xxx: update workaround to fix 100BaseT corner cases

2015-06-08 Thread Florian Fainelli
Update the AFE_TX_CONFIG value to solve marginal rise/fall issues observed when the link is operating in 100BaseT. This workaround applies to GPHY revisions D0, E0 and newer. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/phy/bcm7xxx.c | 7 +-- 1 file changed, 5

Re: [PATCH v2] net: phy: dp83867: Add TI dp83867 phy

2015-06-08 Thread Florian Fainelli
On 08/06/15 07:04, Dan Murphy wrote: Florian Thanks for the re-review On 06/03/2015 09:47 PM, Florian Fainelli wrote: Le 06/02/15 07:34, Dan Murphy a écrit : Add support for the TI dp83867 Gigabit ethernet phy device. The DP83867 is a robust, low power, fully featured Physical Layer

[PATCH net] net: bcmgenet: power on MII block for all MII modes

2015-06-08 Thread Florian Fainelli
: aa09677cba423 (net: bcmgenet: add MDIO routines) Signed-off-by: Florian Fainelli f.faine...@gmail.com --- David, I am targetting net here since this is a bug fix, however, we have few people using MII or Reverse MII with GENET, such that there is no need to queue this for -stable unless you want

Re: [PATCH] net: phy: dp83867: Fix device tree entries

2015-06-08 Thread Florian Fainelli
On 08/06/15 12:30, Dan Murphy wrote: Fix the device tree entries to modify the '_' to '-'. Also changes the names of the internal delay properties from -int- to -internal- as the -int- appeared as a keyword. Signed-off-by: Dan Murphy dmur...@ti.com Reviewed-by: Florian Fainelli f.faine

Re: [PATCH v3 3/3] net/phy: micrel: Center FLP timing at 16ms

2015-06-05 Thread Florian Fainelli
On 05/06/15 15:40, Jaeden Amero wrote: Link failures have been observed when using the KSZ9031 with HP 1810-8G and HP 1910-8G network switches. Center the FLP timing at 16ms to help avoid intermittent link failures. From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2, section

Re: [PATCH v3 0/3] net/phy: micrel: Center FLP timing at 16ms

2015-06-05 Thread Florian Fainelli
the unnecessary result variable from ksz9031_config_init() introduced by a previous version of net/phy: micrel: Center FLP timing at 16ms. Reviewed-by: Florian Fainelli f.faine...@gmail.com Jaeden Amero (3): net/phy: micrel: Be more const correct net/phy: micrel: Comment MMD address of extended

Weird DHCP related problems with net-next

2015-06-09 Thread Florian Fainelli
Hi, I am observing a strange problem on net-next (not observed with net, bisection in progress) where the initial DHCP configuration using busybox's udhcpc is able to configure the local interface address and DNS serer, but not the default gateway. Restarting udhcpc a second time does not exhibit

Re: [PATCH v2] net: phy: dp83867: Add TI dp83867 phy

2015-06-03 Thread Florian Fainelli
Le 06/02/15 07:34, Dan Murphy a écrit : Add support for the TI dp83867 Gigabit ethernet phy device. The DP83867 is a robust, low power, fully featured Physical Layer transceiver with integrated PMD sublayers to support 10BASE-T, 100BASE-TX and 1000BASE-T Ethernet protocols. Sorry for the

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-03 Thread Florian Fainelli
On 02/06/15 23:53, Scott Feldman wrote: On Tue, Jun 2, 2015 at 3:31 PM, nolan no...@cumulusnetworks.com wrote: On 06/02/2015 12:44 AM, Scott Feldman wrote: That brings up an interesting point about having multiple bridges with the same vlan configured. I struggled with that problem with

Re: Weird DHCP related problems with net-next

2015-06-09 Thread Florian Fainelli
Hi Andrew, On 09/06/15 12:22, Andrew Lunn wrote: On Tue, Jun 09, 2015 at 11:54:50AM -0700, Florian Fainelli wrote: Hi, I am observing a strange problem on net-next (not observed with net, bisection in progress) where the initial DHCP configuration using busybox's udhcpc is able to configure

Re: Weird DHCP related problems with net-next

2015-06-09 Thread Florian Fainelli
On 09/06/15 13:31, Florian Fainelli wrote: Hi Andrew, On 09/06/15 12:22, Andrew Lunn wrote: On Tue, Jun 09, 2015 at 11:54:50AM -0700, Florian Fainelli wrote: Hi, I am observing a strange problem on net-next (not observed with net, bisection in progress) where the initial DHCP

Re: [PATCH RFC] net: phy: Introduced the PHY_AN_PENDING state

2015-06-09 Thread Florian Fainelli
Le 06/09/15 21:36, Keng Soon Cheah a écrit : The PHY_AN_PENDING state is put as a gate to enter the PHY_AN state where it will wait for any uncomplete auto-negotiation session to finish before starting a new one. This extra state could be used to workaround some auto-negotation issues from

Re: [net PATCH 1/1] net: phy: fix phy link up when limiting speed via device tree

2015-06-25 Thread Florian Fainelli
2015-06-25 9:51 GMT-07:00 Mugunthan V N mugunthan...@ti.com: When limiting phy link speed using max-speed to 100mbps or less on a giga bit phy, phy never completes auto negotiation and phy state machine is held in PHY_AN. Fixing this issue by comparing the giga bit advertise though

Re: [net PATCH 1/1] net: phy: fix phy link up when limiting speed via device tree

2015-06-25 Thread Florian Fainelli
it but phy has BMSR_ESTATEN set. So that auto negotiation is restarted as old and new advertise are different and link comes up fine. Signed-off-by: Mugunthan V N mugunthan...@ti.com Reviewed-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/phy/phy_device.c | 5 +++-- 1 file

Re: [PATCHv3 net-next] net: fec: Ensure clocks are enabled while using mdio bus

2015-06-22 Thread Florian Fainelli
2015-06-22 19:52 GMT-07:00 Andrew Lunn and...@lunn.ch: int mii_id, int regnum) { struct fec_enet_private *fep = bus-priv; unsigned long time_left; + int ret; + + ret = clk_prepare_enable(fep-clk_ipg); + if (ret) + return ret; fep-mii_timeout = 0;

[PATCH net 3/3] net: phy: mdio-bcm-unimac: workaround initial read failures for integrated PHYs

2015-06-26 Thread Florian Fainelli
PHY driver/device registered, all workarounds are located there (e.g: power management suspend/resume calls). Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/phy/mdio-bcm-unimac.c | 43 +++ 1 file changed, 43 insertions(+) diff --git

[PATCH net 2/3] net: bcmgenet: workaround initial read failures for integrated PHYs

2015-06-26 Thread Florian Fainelli
PHY driver/device registered, all workarounds are located there (e.g: power management suspend/resume calls). Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/ethernet/broadcom/genet/bcmgenet.h | 1 + drivers/net/ethernet/broadcom/genet/bcmmii.c | 54

[PATCH net 0/3] net: phy: bcm7xxx initial read/write workaround

2015-06-26 Thread Florian Fainelli
and UniMAC MDIO. Thanks! Florian Fainelli (3): net: phy: bcm7xxx: workaround MDIO management controller initial read net: bcmgenet: workaround initial read failures for integrated PHYs net: phy: mdio-bcm-unimac: workaround initial read failures for integrated PHYs drivers/net/ethernet

[PATCH net 1/3] net: phy: bcm7xxx: workaround MDIO management controller initial read

2015-06-26 Thread Florian Fainelli
The initial MDIO read or write towards the BCM7xxx integrated PHY may fail, workaround this by inserting a dummy MII_BMSR read to force the MDIO management controller to see at least one valid transaction and get out of stuck state out of reset. Signed-off-by: Florian Fainelli f.faine

[PATCH net 2/3] net: bcmgenet: workaround initial read failures for integrated PHYs

2015-06-26 Thread Florian Fainelli
PHY driver/device registered, all workarounds are located there (e.g: power management suspend/resume calls). Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/ethernet/broadcom/genet/bcmgenet.h | 1 + drivers/net/ethernet/broadcom/genet/bcmmii.c | 54

Re: [PATCH net 0/3] net: phy: bcm7xxx initial read/write workaround

2015-06-26 Thread Florian Fainelli
On 26/06/15 10:38, Florian Fainelli wrote: Hi David, This patch series fixes occasional BCM7xxx PHY driver binding failure due to a harware bug where the first read or write does not come out of the PHY MDIO management controller. Since we have two different MDIO controllers using

Re: [PATCH v3] net/phy: tune get_phy_c45_ids to support more c45 phy

2015-06-26 Thread Florian Fainelli
. This looks better to me now: Reviewed-by: Florian Fainelli f.faine...@gmail.com Signed-off-by: Shengzhou Liu shengzhou@freescale.com --- v3: restructure the loop to probe naturally. v2: use MDIO_DEVS1 and MDIO_DEVS2 instead of constant '6', '5' drivers/net/phy/phy_device.c | 20

[PATCH net] net: bcmgenet: power on MII block for all MII modes

2015-06-26 Thread Florian Fainelli
: aa09677cba423 (net: bcmgenet: add MDIO routines) Signed-off-by: Florian Fainelli f.faine...@gmail.com --- David, I am targetting net here since this is a bug fix, however, we have few people using MII or Reverse MII with GENET, such that there is no need to queue this for -stable unless you want

[PATCH net 0/3] net: phy: bcm7xxx initial read/write workaround

2015-06-26 Thread Florian Fainelli
and UniMAC MDIO. Thanks! Florian Fainelli (3): net: phy: bcm7xxx: workaround MDIO management controller initial read net: bcmgenet: workaround initial read failures for integrated PHYs net: phy: mdio-bcm-unimac: workaround initial read failures for integrated PHYs drivers/net/ethernet

[PATCH net 1/3] net: phy: bcm7xxx: workaround MDIO management controller initial read

2015-06-26 Thread Florian Fainelli
The initial MDIO read or write towards the BCM7xxx integrated PHY may fail, workaround this by inserting a dummy MII_BMSR read to force the MDIO management controller to see at least one valid transaction and get out of stuck state out of reset. Signed-off-by: Florian Fainelli f.faine

Re: [PATCH net] dsa: fix promiscuity leak on slave dev open error

2015-06-26 Thread Florian Fainelli
: David S. Miller da...@davemloft.net CC: Florian Fainelli f.faine...@gmail.com CC: Guenter Roeck li...@roeck-us.net CC: Andrew Lunn and...@lunn.ch CC: Scott Feldman sfel...@gmail.com Acked-by: Florian Fainelli f.faine...@gmail.com --- net/dsa/slave.c |2 +- 1 files changed, 1 insertions

Re: [PATCHv2 net-next] net: fec: Ensure clocks are enabled while using mdio bus

2015-06-20 Thread Florian Fainelli
Le 06/20/15 09:15, Andrew Lunn a écrit : When a switch is attached to the mdio bus, the mdio bus can be used while the interface is not open. If the IPG clock are not enabled, MDIO reads/writes will simply time out. So enable the clock before starting a transaction, and disable it afterwards.

Re: [PATCH net-next 2/2] net: phy: mdio-bcm-unimac: handle broken turn-around for specific PHYs

2015-06-10 Thread Florian Fainelli
On 10/06/15 12:14, Florian Fainelli wrote: Some Ethernet PHYs/switches such as Broadcom's BCM53125 have a hardware bug which makes them not release the MDIO line during turn-around time. This gets flagged by the UniMAC MDIO controller as a read failure, and we fail the read transaction

[PATCH net-next v2 2/2] net: phy: mdio-bcm-unimac: handle broken turn-around for specific PHYs

2015-06-10 Thread Florian Fainelli
for the PHY we are reading from and if it is listed in this bitmask, ignore the read failure and proceed with returning the data we read out of the controller. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/phy/mdio-bcm-unimac.c | 8 +++- 1 file changed, 7 insertions(+), 1

[PATCH net-next v2 0/2] net: broadcom MDIO support for broken turn-around

2015-06-10 Thread Florian Fainelli
and I will try to address the MDIO code duplication between GENET and UniMAC in a future patch series. Thanks! Changes in v2: - remove brcmphy.h include in mdio-bcm-unimac.c - use the same comment as with GENET's MDIO read function Florian Fainelli (2): net: bcmgenet: handle broken turn-around

[PATCH net-next 1/2] net: bcmgenet: handle broken turn-around for specific PHYs

2015-06-10 Thread Florian Fainelli
for the PHY we are reading from and if it is listed in this bitmask, ignore the read failure and proceed with returning the data we read out of the controller. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 ++- 1 file changed, 6 insertions

[PATCH net-next 0/2] net: broadcom MDIO support for broken turn-around

2015-06-10 Thread Florian Fainelli
and I will try to address the MDIO code duplication between GENET and UniMAC in a future patch series. Thanks! Florian Fainelli (2): net: bcmgenet: handle broken turn-around for specific PHYs net: phy: mdio-bcm-unimac: handle broken turn-around for specific PHYs drivers/net/ethernet/broadcom

[PATCH net-next v2 1/2] net: bcmgenet: handle broken turn-around for specific PHYs

2015-06-10 Thread Florian Fainelli
for the PHY we are reading from and if it is listed in this bitmask, ignore the read failure and proceed with returning the data we read out of the controller. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 ++- 1 file changed, 6 insertions

[PATCH net-next 2/2] net: phy: mdio-bcm-unimac: handle broken turn-around for specific PHYs

2015-06-10 Thread Florian Fainelli
for the PHY we are reading from and if it is listed in this bitmask, ignore the read failure and proceed with returning the data we read out of the controller. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/phy/mdio-bcm-unimac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: Weird DHCP related problems with net-next

2015-06-10 Thread Florian Fainelli
On 10/06/15 14:44, Scott Feldman wrote: On Tue, Jun 9, 2015 at 5:12 PM, Florian Fainelli f.faine...@gmail.com wrote: I see the problem now, DSA does not implement a port_obj_add callback, so when net/ipv4/fib_trie.c::switchdev_fib_ipv4_add() gets to call switchdev_port_obj_add, we return

Re: [PATCH] net: fec: Ensure clocks are enabled while using mdio bus

2015-06-14 Thread Florian Fainelli
Le 06/14/15 07:41, Andrew Lunn a écrit : On Sun, Jun 14, 2015 at 08:07:12AM +, Duan Andy wrote: From: Andrew Lunn and...@lunn.ch Sent: Friday, June 12, 2015 11:39 PM To: David Miller Cc: Duan Fugang-B38611; Cory Tusar; netdev; Andrew Lunn Subject: [PATCH] net: fec: Ensure clocks are

DSA: Exposing CPU port [Was: Re: [PATCH 3/3] net: dsa: Allow configuration of CPU DSA port speeds/duplex]

2015-06-17 Thread Florian Fainelli
2015-06-17 11:09 GMT-07:00 Vivien Didelot vivien.dide...@savoirfairelinux.com: Hi Andrew, All, On 12/06/15 10:18, Andrew Lunn wrote: By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower.

Re: macb napi strange behavior

2015-06-17 Thread Florian Fainelli
2015-06-17 12:00 GMT-07:00 Nicolae Rosia nicolae.ro...@gmail.com: Hi, On Wed, Jun 17, 2015 at 9:54 PM, Jaeden Amero jaeden.am...@ni.com wrote: On 06/17/2015 11:09 AM, Nicolae Rosia wrote: The times we've seen tons of interrupts on Ethernet with interrupts routed through the PL was when the

Re: [PATCH net-next] switchdev: fix handling for drivers not supporting IPv4 fib add/del ops

2015-06-10 Thread Florian Fainelli
between no support and failed support. Reported-by: Florian Fainelli f.faine...@gmail.com Signed-off-by: Scott Feldman sfel...@gmail.com Signed-off-by: Florian Fainelli f.faine...@gmail.com --- net/switchdev/switchdev.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH net-next 0/5] net: phy: broadcom: define pseudo-PHY address

2015-06-10 Thread Florian Fainelli
Hi David, This patch series converts existing in-tree users of the Broadcom pseudo-PHY address (30) used to configure MDIO-connected switches to share a constant in a shared header files. Thanks! Florian Fainelli (5): net: phy: broadcom: include phy.h for brcmphy.h net: phy: broadcom

[PATCH net-next 2/5] net: phy: broadcom: define Broadcom pseudo-PHY address in brcmphy.h

2015-06-10 Thread Florian Fainelli
Define the pseudo-PHY address (30) which is used by all Broadcom Ethernet switches in a shared header file. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- include/linux/brcmphy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h

[PATCH net-next 1/5] net: phy: broadcom: include phy.h for brcmphy.h

2015-06-10 Thread Florian Fainelli
-by: Florian Fainelli f.faine...@gmail.com --- include/linux/brcmphy.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h index 656da2a12ffe..abb6106f839d 100644 --- a/include/linux/brcmphy.h +++ b/include/linux/brcmphy.h @@ -1,6 +1,8 @@ #ifndef

[PATCH net-next 4/5] bgmac: Utilize BRCM_PSEUDO_PHY_ADDR

2015-06-10 Thread Florian Fainelli
What BGMAC defines as BGMAC_PHY_NOREGS is in fact the Broadcom Ethernet switches' pseudo-PHY address (30), utilize the newly introduced constant from brcmphy.h Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/ethernet/broadcom/bgmac.h | 3 ++- 1 file changed, 2 insertions

[PATCH net-next 3/5] b44: Utilize BRCM_PSEUDO_PHY_ADDR

2015-06-10 Thread Florian Fainelli
What B44 has been locally using as B44_PHY_ADDR_NO_LOCAL_PHY is in fact the Broadcom Ethernet switches pseudo-PHY address (30). Update the header to use the newly introduced constant and update comments so they are within 80 columns and consistent. Signed-off-by: Florian Fainelli f.faine

[PATCH net-next 5/5] net: dsa: bcm_sf2: Utilize BRCM_PSEUDO_PHY_ADDR

2015-06-10 Thread Florian Fainelli
Utilize the newly introduced BRCM_PSEUDO_PHY_ADDR constant from brcmphy.h instead of open-coding the Broadcom Ethernet switches pseudo-PHY address (30). Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/dsa/bcm_sf2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU DSA port speeds/duplex

2015-06-15 Thread Florian Fainelli
On 12/06/15 11:29, Guenter Roeck wrote: [snip] static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent) { struct dsa_switch_driver *drv = ds-drv; @@ -204,6 +234,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent) }

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU DSA port speeds/duplex

2015-06-15 Thread Florian Fainelli
On 12/06/15 10:18, Andrew Lunn wrote: By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA and CPU port in the device tree, and use this

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU DSA port speeds/duplex

2015-06-12 Thread Florian Fainelli
On 12/06/15 10:18, Andrew Lunn wrote: By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA and CPU port in the device tree, and use this

Re: [PATCH v4] NET: Add ezchip ethernet driver

2015-06-14 Thread Florian Fainelli
Le 06/13/15 23:26, Noam Camus a écrit : From: Noam Camus no...@ezchip.com Simple LAN device for debug or management purposes. Device supports interrupts for RX and TX(completion). Device does not have DMA ability. Signed-off-by: Noam Camus no...@ezchip.com Signed-off-by: Tal Zilcer

[PATCH net-next 0/3] net: systemport: misc improvements

2015-05-28 Thread Florian Fainelli
Hi David, These patches are highly inspired by changes from Petri on bcmgenet, last patch is a misc fix that I had pending for a while, but is not a candidate for 'net' at this point. Thanks! Florian Fainelli (3): net: systemport: Pre-calculate and utilize cb-bd_addr net: systemport

[PATCH net-next 1/3] net: systemport: Pre-calculate and utilize cb-bd_addr

2015-05-28 Thread Florian Fainelli
There is a 1:1 mapping between the software maintained control block in priv-rx_cbs and the buffer address in priv-rx_bds, such that there is no need to keep computing the buffer address when refiling a control block. Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/ethernet

[PATCH net-next 2/3] net: systemport: rewrite bcm_sysport_rx_refill

2015-05-28 Thread Florian Fainelli
() to call bcm_sysport_rx_refill() at the top of Rx packet processing loop, so that the new replacement Rx skb is already in place before the current Rx skb is processed. This is loosely inspired from d6707bec5986 (net: bcmgenet: rewrite bcmgenet_rx_refill()) Signed-off-by: Florian Fainelli f.faine

[PATCH net-next 3/3] net: systemport: Add a check for oversized packets

2015-05-28 Thread Florian Fainelli
Occasionnaly we may get oversized packets from the hardware which exceed the nomimal 2KiB buffer size we allocate SKBs with. Add an early check which drops the packet to avoid invoking skb_over_panic() and move on to processing the next packet. Signed-off-by: Florian Fainelli f.faine...@gmail.com

Re: [PATCH 3/7] net: dsa: ar8xxx: add regmap support

2015-05-28 Thread Florian Fainelli
Le 05/28/15 18:42, Mathieu Olivari a écrit : All switch registers can now be dumped using regmap/debugfs. \# cat /sys/kernel/debug/regmap/mdiobus/registers : 1302 0004: ... ... ethtool has a register dump command, which should already be supported by the current code in

Re: [PATCH 7/7] Documentation: devicetree: add ar8xxx binding

2015-05-28 Thread Florian Fainelli
Le 05/28/15 18:42, Mathieu Olivari a écrit : Add device-tree binding for ar8xxx switch families. Signed-off-by: Mathieu Olivari math...@codeaurora.org --- .../devicetree/bindings/net/dsa/qca-ar8xxx.txt | 70 ++ 1 file changed, 70 insertions(+) create mode 100644

Re: [PATCH net-next 2/3] net: systemport: rewrite bcm_sysport_rx_refill

2015-05-28 Thread Florian Fainelli
Le 05/28/15 20:58, Petri Gynther a écrit : [snip] /* We do not have a backing SKB, so we do not a corresponding Is this comment still valid? I removed it from bcmgenet. Not really, thanks, I will fix that in v2. [snip] + + if (priv-rx_read_ptr ==

[PATCH net-next v2 2/3] net: systemport: rewrite bcm_sysport_rx_refill

2015-05-29 Thread Florian Fainelli
() to call bcm_sysport_rx_refill() at the top of Rx packet processing loop, so that the new replacement Rx skb is already in place before the current Rx skb is processed. This is loosely inspired from d6707bec5986 (net: bcmgenet: rewrite bcmgenet_rx_refill()) Signed-off-by: Florian Fainelli f.faine

[PATCH net-next v2 0/3] net: systemport: misc. improvements

2015-05-29 Thread Florian Fainelli
comment and use an unlikely optimization Thanks! Florian Fainelli (3): net: systemport: Pre-calculate and utilize cb-bd_addr net: systemport: rewrite bcm_sysport_rx_refill net: systemport: Add a check for oversized packets drivers/net/ethernet/broadcom/bcmsysport.c | 113

[PATCH net-next v2 1/3] net: systemport: Pre-calculate and utilize cb-bd_addr

2015-05-29 Thread Florian Fainelli
There is a 1:1 mapping between the software maintained control block in priv-rx_cbs and the buffer address in priv-rx_bds, such that there is no need to keep computing the buffer address when refiling a control block. Reviewed-by: Petri Gynther pgynt...@google.com Signed-off-by: Florian Fainelli

[PATCH net-next v2 3/3] net: systemport: Add a check for oversized packets

2015-05-29 Thread Florian Fainelli
Signed-off-by: Florian Fainelli f.faine...@gmail.com --- drivers/net/ethernet/broadcom/bcmsysport.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index 62ea403e15b8..bbd8676a9675 100644 --- a/drivers

Re: [RFC 0/3] DSA and Marvell 88E6352 802.1q support

2015-06-01 Thread Florian Fainelli
On 31/05/15 14:21, Scott Feldman wrote: Hi Scott, If I understand you correctly, that means we would expect users to use bridge commands even on non-bridged dsa ports. I don't think we can make this kind of assumption. Users will expect configure VLANs on non-bridge ports as they would

[PATCH net] net: dsa: Properly propagate errors from dsa_switch_setup_one

2015-05-29 Thread Florian Fainelli
() consistently which is both more informative and avoids for the caller to use IS_ERR_OR_NULL(). Fixes: df197195a5248 (net: dsa: split dsa_switch_setup into two functions) Reported-by: Andrew Lunn and...@lunn.ch Signed-off-by: Florian Fainelli f.faine...@gmail.com --- net/dsa/dsa.c | 4 ++-- 1 file

  1   2   3   4   5   6   7   8   9   10   >