Re: randconfig build error with next-20150421, in net/ceph

On Tue, Apr 21, 2015 at 08:10:44AM -0700, Jim Davis wrote: Building with the attached random configuration file, ERROR: __divdi3 [net/ceph/libceph.ko] undefined! Commit 7321f19d (crush: straw2 bucket type with an efficient 64-bit crush_ln()). + draw = ln / w; where

[PATCH] net: dsa: Fix scope of eeprom-length property

eeprom-length is a switch property, not a dsa property, and thus needs to be attached to the switch node, not to the dsa node. Reported-by: Andrew Lunn and...@lunn.ch Fixes: 6793abb4e849 (net: dsa: Add support for switch EEPROM access) Signed-off-by: Guenter Roeck li...@roeck-us.net --- net/dsa

Re: v3.12-stable-queue build errors

On Mon, Apr 27, 2015 at 10:35:51AM -0500, Eric W. Biederman wrote: Jiri Slaby jsl...@suse.cz writes: On 04/25/2015, 04:16 PM, Guenter Roeck wrote: Several powerpc build fail with: drivers/net/ethernet/freescale/gianfar.c: In function 'gfar_start_xmit': drivers/net/ethernet/freescale

Re: [RFC PATCH net-next 7/8] net: dsa: mv88e6060: make it a proper PHY driver

On 04/29/2015 06:57 PM, Florian Fainelli wrote: Convert the Marvell 88E6060 switch driver into a proper PHY library driver that can be registered. To make sure we do not introduce functional changes, the PHY driver provides autoneg and status callbacks to make sure the attached Ethernet MAC

Re: [RFC PATCH] bgmac: Fix build error seen if BCM47XX is not configured

On Wed, Apr 15, 2015 at 10:21:49PM +0200, Rafał Miłecki wrote: On 15 April 2015 at 22:05, Guenter Roeck li...@roeck-us.net wrote: arm:allmodconfig fails to build as follows since ARCH_BCM_5301X is configured but not BCM47XX. drivers/net/ethernet/broadcom/bgmac.c: In function 'bgmac_probe

[RFC PATCH] bgmac: Fix build error seen if BCM47XX is not configured

: fc300dc3733f (bgmac: allow enabling on ARCH_BCM_5301X) Cc: Rafał Miłecki zaj...@gmail.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- Seen in today's upstream kernel. I don't like this fix too much (I think it is quite kludgy), so I marked it RFC (and please don't beat the messenger

[PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

Return correct error code if _mv88e6xxx_reg_read returns an error. Fixes: facd95b2e0ec0 (net: dsa: mv88e6xxx: Add Hardware bridging support) Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/net/dsa/mv88e6xxx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

On 04/16/2015 05:37 AM, Andrew Lunn wrote: On Wed, Apr 15, 2015 at 10:12:42PM -0700, Guenter Roeck wrote: Return correct error code if _mv88e6xxx_reg_read returns an error. Fixes: facd95b2e0ec0 (net: dsa: mv88e6xxx: Add Hardware bridging support) Signed-off-by: Guenter Roeck li...@roeck-us.net

Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

On 04/15/2015 10:12 PM, Guenter Roeck wrote: Return correct error code if _mv88e6xxx_reg_read returns an error. Fixes: facd95b2e0ec0 (net: dsa: mv88e6xxx: Add Hardware bridging support) Signed-off-by: Guenter Roeck li...@roeck-us.net I should have given proper credit. Reported-by: kbuild

[PATCH] dsa: mv88e6xxx: Drop duplicate declaration of 'ret' variable

A duplicate declaration of 'ret' can result in hiding an error code. Drop it. Fixes: 17ee3e04ddbf (net: dsa: Provide additional RMON statistics) Signed-off-by: Guenter Roeck li...@roeck-us.net --- Found by compiling the file with W=2. drivers/net/dsa/mv88e6xxx.c | 2 -- 1 file changed, 2

Re: [PATCH 2/2] net: dsa: register hwmon for any provided function

On Thu, Apr 16, 2015 at 02:38:19PM -0400, Vivien Didelot wrote: A switch driver may only provide one of the temperature limit accessors, or the temperature alarm getter. So register the hwmon subsystem if any of the related functions is provided. Thus, check get_temp to set the visibility of

Re: [PATCH 1/2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max

On Thu, Apr 16, 2015 at 02:38:18PM -0400, Vivien Didelot wrote: Since commit da4759c, sysfs will only use the permissions returned by is_visible, instead of OR'ing them with the default file mode. This allows us to declare temp1_max with the DEVICE_ATTR_RW macro and just return the desired

Re: [PATCH] dsa: mv88e6xxx: Fix error handling in mv88e6xxx_set_port_state

On 04/16/2015 11:51 AM, Geert Uytterhoeven wrote: On Thu, Apr 16, 2015 at 3:46 PM, Guenter Roeck li...@roeck-us.net wrote: On 04/15/2015 10:12 PM, Guenter Roeck wrote: Return correct error code if _mv88e6xxx_reg_read returns an error. Fixes: facd95b2e0ec0 (net: dsa: mv88e6xxx: Add Hardware

Re: [PATCH 2/2] net: dsa: register hwmon for any provided function

hi Vivien, On 04/16/2015 03:05 PM, Vivien Didelot wrote: Hi Guenter, switch (index) { +case 0: /* temp1_input */ +if (drv-get_temp) +mode |= S_IRUGO; This should be mandatory. Sorry, I don't really understand what you are trying to

Re: [PATCH v2] net: dsa: use DEVICE_ATTR_RW to declare temp1_max

in dsa_hwmon_attrs_visible if set_temp_limit isn't provided. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com Looks good. Reviewed-by: Guenter Roeck li...@roeck-us.net --- net/dsa/dsa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/dsa/dsa.c b

Re: netlink: Disable insertions/removals during rehash

On 06/04/2015 08:52 PM, Herbert Xu wrote: On Thu, Jun 04, 2015 at 09:27:27AM -0700, Guenter Roeck wrote: sorry for bothering you - I don't see this patch in any of your trees, and it is marked as changes requested in patchwork. Did I look at the wrong places, do you still plan to apply

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

Vivien, On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit implements the port_vlan_add and port_vlan_del functions in the dsa_switch_driver structure for Marvell 88E6xxx compatible switches. This allows to access a switch VLAN Table Unit, and thus define VLANs from standard userspace

Re: [RFC 2/9] net: dsa: add basic support for VLAN operations

On 06/01/2015 06:27 PM, Vivien Didelot wrote: This patch adds the glue between DSA and switchdev to add and delete SWITCHDEV_OBJ_PORT_VLAN objects. This will allow the DSA switch drivers implementing the port_vlan_add and port_vlan_del functions to access the switch VLAN database through

Re: netlink: Disable insertions/removals during rehash

On 06/04/2015 11:59 AM, David Miller wrote: From: Guenter Roeck li...@roeck-us.net Date: Thu, 4 Jun 2015 09:27:27 -0700 sorry for bothering you - I don't see this patch in any of your trees, and it is marked as changes requested in patchwork. Did I look at the wrong places, do you still plan

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

On 06/02/2015 11:53 PM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 3:31 PM, nolan no...@cumulusnetworks.com wrote: On 06/02/2015 12:44 AM, Scott Feldman wrote: That brings up an interesting point about having multiple bridges with the same vlan configured. I struggled with that problem with

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

On 06/03/2015 07:56 AM, Vivien Didelot wrote: Hi Guenter, On Jun 2, 2015, at 10:17 PM, Guenter Roeck li...@roeck-us.net wrote: On Tue, Jun 02, 2015 at 09:39:50PM -0400, Vivien Didelot wrote: Guenter, On Jun 2, 2015, at 2:50 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM

Re: [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure

On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit changes the 802.1Q mode of each port from Disabled to Secure. This enables the VLAN support, by checking the VTU entries on ingress. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- drivers/net/dsa/mv88e6xxx.c | 14

Re: netlink: Disable insertions/removals during rehash

On Sat, May 16, 2015 at 05:10:19PM -0400, David Miller wrote: From: Herbert Xu herb...@gondor.apana.org.au Date: Sat, 16 May 2015 21:16:28 +0800 On Fri, May 15, 2015 at 01:02:57PM -0400, David Miller wrote: From: Herbert Xu herb...@gondor.apana.org.au Date: Thu, 14 May 2015 13:58:24

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU DSA port speeds/duplex

Hi Florian, On 06/12/2015 10:18 AM, Andrew Lunn wrote: By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA and CPU port in the device tree,

Re: [PATCH 3/3] net: dsa: Allow configuration of CPU DSA port speeds/duplex

On 06/12/2015 11:14 AM, Florian Fainelli wrote: On 12/06/15 10:18, Andrew Lunn wrote: By default, DSA and CPU ports are configured to the maximum speed the switch supports. However there can be use cases where the peer device port is slower. Allow a fixed-link property to be used with the DSA

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

. (The ARM does not need to consume the multicast, it just manages the switch.) Possibly, but Vivien didn't answer my question (how the local SA address finds its way into the switch fdb). I'll check it myself. Thanks, Guenter On Jun 3, 2015 3:24 AM, Guenter Roeck li...@roeck-us.net mailto:li

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

On Tue, Jun 02, 2015 at 09:06:15PM -0400, Vivien Didelot wrote: Hi Guenter, On Jun 2, 2015, at 10:24 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit disables SA learning and refreshing for the CPU port. Hi Vivien, This patch

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

On Tue, Jun 02, 2015 at 09:12:30PM -0400, Vivien Didelot wrote: Hi Guenter, Andrew, On Jun 2, 2015, at 10:53 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: Disable the mirroring policy

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

On Tue, Jun 02, 2015 at 09:39:50PM -0400, Vivien Didelot wrote: Guenter, On Jun 2, 2015, at 2:50 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: +/* Bringing an interface up adds it to the VLAN 0. Ignore this. */ +if (!vid

Re: [RFC 0/3] DSA and Marvell 88E6352 802.1q support

On 05/31/2015 09:48 AM, Scott Feldman wrote: On Fri, May 29, 2015 at 3:42 PM, Guenter Roeck li...@roeck-us.net wrote: Scott, On 05/28/2015 10:02 PM, Scott Feldman wrote: On Thu, May 28, 2015 at 2:37 PM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: This RFC is based on v4.1

Re: DSA and underlying 802.1Q encapsulation

On 05/27/2015 01:48 PM, Vivien Didelot wrote: Hi Guenter, Interesting question. Does the underlying network device support VLAN HW acceleration (NETIF_F_HW_VLAN_CTAG_RX, NETIF_F_HW_VLAN_CTAG_TX) ? Yes, in our case, it's an IGB device. I also set the DSA slave_dev-features and

Re: [RFC 1/3] net: dsa: add basic support for VLAN ndo

On 05/29/2015 08:51 AM, Or Gerlitz wrote: On Fri, May 29, 2015 at 6:38 PM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: Hi, - On May 29, 2015, at 11:24 AM, Or Gerlitz gerlitz...@gmail.com wrote: On Fri, May 29, 2015 at 12:37 AM, Vivien Didelot

Re: [RFC 2/3] net: dsa: mv88e6xxx: add support for VTU operations

Hi Vivien, On 05/28/2015 02:37 PM, Vivien Didelot wrote: This commit implements the port_vlan_add, port_vlan_kill, and port_bridge_setlink dsa_switch_driver functions to access the VTU, and thus add support for adding, removing VLANs, and joining ports to them. Signed-off-by: Vivien Didelot

Re: [RFC 0/3] DSA and Marvell 88E6352 802.1q support

Scott, On 05/28/2015 10:02 PM, Scott Feldman wrote: On Thu, May 28, 2015 at 2:37 PM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: This RFC is based on v4.1-rc3. It is meant to get a glance to the commits responsible to implement the necessary NDOs between DSA and the Marvell

Re: DSA and underlying 802.1Q encapsulation

On 05/27/2015 06:46 PM, Andrew Lunn wrote: On Wed, May 27, 2015 at 03:51:59PM -0700, Guenter Roeck wrote: On 05/27/2015 02:05 PM, Andrew Lunn wrote: Do you have lock debugging enabled in your code ? I am getting a recursive lock warning due to a recursive call to dev_mc_sync(). I think we may

Re: DSA and underlying 802.1Q encapsulation

On 05/28/2015 06:44 AM, Vivien Didelot wrote: Hi Guenter, If yes, the dsa code may need to move the tag into the header. If we are lucky, a call to vlan_hwaccel_push_inside() might do it. Thanks, I'm currently looking into it and doing some tests, I'm coming back to you asap. Issue fixed,

Re: DSA and underlying 802.1Q encapsulation

On 05/27/2015 02:05 PM, Andrew Lunn wrote: Do you have lock debugging enabled in your code ? I am getting a recursive lock warning due to a recursive call to dev_mc_sync(). I think we may have to implement lock nesting for dsa, similar to how it id done for vlan support, but I have not been able

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

On 06/01/2015 06:27 PM, Vivien Didelot wrote: Disable the mirroring policy in the monitor control register, since this feature is not needed. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com Should this be a separate patch, unrelated to the patch set ? If I understand

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit disables SA learning and refreshing for the CPU port. Hi Vivien, This patch also seems to be unrelated to the rest of the series. Can you add an explanation why it is needed ? With this in place, how does the CPU port SA find its

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

On 06/02/2015 06:42 AM, Andrew Lunn wrote: Also, we already have cases where the switch is connected to the CPU with more than one Ethernet port. It is easy to imagine that the user of such a system might want to configure two bridge groups. Hi Guenter I think that is orthogonal. Having

Re: [RFC 6/9] net: dsa: mv88e6352: allow egress of unknown multicast

On 06/01/2015 06:27 PM, Vivien Didelot wrote: This patch disables egress of unknown unicast destination addresses. Hi Vivien, seems to me this patch is unrelated to the rest of the series. Not sure if we really want this. If an address is in the arp cache but has timed out from the bridge

Re: [RFC 2/9] net: dsa: add basic support for VLAN operations

On 06/01/2015 06:27 PM, Vivien Didelot wrote: This patch adds the glue between DSA and switchdev to add and delete SWITCHDEV_OBJ_PORT_VLAN objects. This will allow the DSA switch drivers implementing the port_vlan_add and port_vlan_del functions to access the switch VLAN database through

Re: [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure

On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit changes the 802.1Q mode of each port from Disabled to Secure. This enables the VLAN support, by checking the VTU entries on ingress. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- drivers/net/dsa/mv88e6xxx.c | 14

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

On 06/02/2015 12:44 AM, Scott Feldman wrote: On Mon, Jun 1, 2015 at 11:50 PM, Guenter Roeck li...@roeck-us.net wrote: [cut] I brought this up before. No idea if my e-mail got lost or what happened. We use a fid per port, and a fid per bridge group. With VLANs, this is completely ignored, ahd

Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c

On Sat, Jul 04, 2015 at 12:44:36AM -0700, Vinson Lee wrote: Hi. With the latest Linux 4.2-rc1, I am hitting this build error with GCC 4.4.7 on CentOS 6. CC net/netfilter/ipset/ip_set_hash_netnet.o net/netfilter/ipset/ip_set_hash_netnet.c: In function ‘hash_netnet4_uadt’:

Re: DSA and underlying 802.1Q encapsulation

On Tue, May 26, 2015 at 06:29:57PM -0400, Vivien Didelot wrote: Hi, I'm doing tests with VLAN support in DSA and I noticed that the EDSA frame is prepended with a 802.1q header once queued to the underlying network device, in net/dsa/tag_edsa.c: skb-dev = p-parent-dst-master_netdev;

Re: [PATCH net-next] net: dsa: mv88e6352: Use mnemonics for EEPROM registers and bits

On 08/08/2015 08:04 AM, Andrew Lunn wrote: Add register definitions #defines for accessing the EEPROM. Signed-off-by: Andrew Lunn and...@lunn.ch Acked-by: Guenter Roeck li...@roeck-us.net -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord

Re: [PATCH net] net: dsa: Do not override PHY interface if already configured

On Wed, Aug 12, 2015 at 02:30:35PM -0700, David Miller wrote: From: Florian Fainelli f.faine...@gmail.com Date: Sat, 8 Aug 2015 12:58:57 -0700 In case we need to divert reads/writes using the slave MII bus, we may have already fetched a valid PHY interface property from Device Tree, and

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

On 08/17/2015 02:19 PM, Jeremy Linton wrote: On 08/17/2015 03:45 PM, Guenter Roeck wrote: Commit 0b50dc4fc971 (Convert smsc911x to use ACPI as well as DT) makes the call to smsc911x_probe_config() unconditional, and no longer fails if there is no device node. device_get_phy_mode() is called

[PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

: Jeremy Linton jeremy.lin...@arm.com Cc Graeme Gregory graeme.greg...@linaro.org Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/net/ethernet/smsc/smsc911x.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net

Re: [PATCH] net: dsa: mv88e6xxx: call _mv88e6xxx_stats_wait with SMI lock held

...@savoirfairelinux.com Not strictly needed because the mutex is initialized in the same call sequence, but it doesn't hurt and is technically ok (and may prevent others from submitting the same patch again ;-) Reviewed-by: Guenter Roeck li...@roeck-us.net --- drivers/net/dsa/mv88e6xxx.c | 7 +-- 1

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Move temperature sensor code to mv88e6xxx.c

On 07/25/2015 11:58 AM, Vivien Didelot wrote: On Jul 25, 2015, at 12:42 PM, Guenter Roeck li...@roeck-us.net wrote: Move the temperature sensing code for mv88e6352 and mv88e6320 families into mv88e6xxx.c to simplify adding support for additional chips. With this change, mv88e6xxx_6320_family

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Move temperature sensor code to mv88e6xxx.c

On 07/25/2015 11:46 AM, Andrew Lunn wrote: On Sat, Jul 25, 2015 at 09:42:28AM -0700, Guenter Roeck wrote: Move the temperature sensing code for mv88e6352 and mv88e6320 families into mv88e6xxx.c to simplify adding support for additional chips. With this change, mv88e6xxx_6320_family() no longer

Re: [PATCH] net: dsa: mv88e6xxx: fix fid_mask when leaving bridge

the wrong fid_mask: 0b10 (0x2). With this patch we correctly get 0b10010100 (0xf94), meaning port 0 uses FID 1, br0 uses FID 0, and br1 uses FID 3. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com Reviewed-by: Guenter Roeck li...@roeck-us.net -- To unsubscribe from

[PATCH -next] net: hisilicon: Never build on SPARC

: implicit declaration of function 'of_translate_address' Fixes: 876133d3161d ("net: hisilicon: add OF dependency") Cc: Arnd Bergmann <a...@arndb.de> Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- drivers/net/ethernet/hisilicon/Kconfig | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH -next] net: hisilicon: Never build on SPARC

Hi Arnd, On 10/21/2015 07:39 AM, Arnd Bergmann wrote: On Wednesday 21 October 2015 07:29:33 Guenter Roeck wrote: The Hisilicon network driver does not build for Sparc. Enabling COMPILE_TEST for it causes Sparc allmodconfig/allyesconfig builds to fail with drivers/net/ethernet/hisilicon

Re: [PATCH -next] net: hisilicon: Never build on SPARC

On 10/21/2015 08:57 AM, Arnd Bergmann wrote: On Wednesday 21 October 2015 08:33:11 David Miller wrote: From: Guenter Roeck <li...@roeck-us.net> Date: Wed, 21 Oct 2015 07:56:18 -0700 @@ -57,6 +57,11 @@ extern int of_dma_get_range(struct device_node *np, u64 *dm

Re: [PATCH -next] net: hisilicon: Never build on SPARC

On Wed, Oct 21, 2015 at 09:11:53PM +0200, Arnd Bergmann wrote: > On Wednesday 21 October 2015 10:03:05 Guenter Roeck wrote: > > > > > > Something like this? > > > > > > static inline u64 of_translate_address(struct device_node *np, const > > > __be

Re: [PATCH -next] net: hisilicon: Never build on SPARC

On 11/06/2015 12:30 PM, Arnd Bergmann wrote: On Friday 06 November 2015 11:16:52 Guenter Roeck wrote: On Wed, Oct 21, 2015 at 02:53:20PM -0700, Guenter Roeck wrote: On Wed, Oct 21, 2015 at 09:11:53PM +0200, Arnd Bergmann wrote: On Wednesday 21 October 2015 10:03:05 Guenter Roeck wrote

Re: [PATCH -next] net: hisilicon: Never build on SPARC

Arnd, On Wed, Oct 21, 2015 at 02:53:20PM -0700, Guenter Roeck wrote: > On Wed, Oct 21, 2015 at 09:11:53PM +0200, Arnd Bergmann wrote: > > On Wednesday 21 October 2015 10:03:05 Guenter Roeck wrote: > > > > > > > > Something like this? > > > > > >

Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

On 10/14/2015 07:52 PM, Andrew Lunn wrote: On Wed, Oct 14, 2015 at 09:28:55PM -0400, Vivien Didelot wrote: On Oct. Thursday 15 (42) 12:46 AM, Andrew Lunn wrote: On Sun, Oct 11, 2015 at 06:08:34PM -0400, Vivien Didelot wrote: DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

On 07/08/2015 07:52 AM, Andrew Lunn wrote: On Tue, Jul 07, 2015 at 08:38:15PM -0700, Guenter Roeck wrote: From: Aleksey S. Kazantsev io...@yandex.ru MV88E6320 and MV88E6321 are largely compatible to MV886352, but are members of a different chip family. Signed-off-by: Aleksey S. Kazantsev io

Re: [PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

On Thu, Jul 09, 2015 at 10:53:23AM +0200, Paul Bolle wrote: On di, 2015-07-07 at 20:38 -0700, Guenter Roeck wrote: --- a/drivers/net/dsa/mv88e6352.c +++ b/drivers/net/dsa/mv88e6352.c -MODULE_ALIAS(platform:mv88e6352); MODULE_ALIAS(platform:mv88e6172); +MODULE_ALIAS

[PATCH] dsa: mv88e6352/mv88e6xxx: Add support for Marvell 88E6320 and 88E6321

From: Aleksey S. Kazantsev io...@yandex.ru MV88E6320 and MV88E6321 are largely compatible to MV886352, but are members of a different chip family. Signed-off-by: Aleksey S. Kazantsev io...@yandex.ru Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/net/dsa/Kconfig | 6

Re: [PATCH 1/2] net: dsa: mv88e6xxx: sleep in _mv88e6xxx_stats_wait

Hi Vivien, On Fri, Jul 10, 2015 at 02:20:47PM -0400, Vivien Didelot wrote: is this really beneficial and/or needed ? Except using existing generic code, no. It adds at least 1ms delay to a loop which did not have any delay at all unless the register read itself was sleeping. I

Re: [RFC PATCH] smsc911x: Ignore error return from device_get_phy_mode()

On 08/26/2015 12:44 PM, Jeremy Linton wrote: On 08/26/2015 01:49 PM, Guenter Roeck wrote: Check the return value from device_property_read_u32() to see if there is a suitable firmware interface to read the data, and abort if not. The function should return -ENXIO in that case; however

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

On 08/26/2015 10:04 AM, Tony Lindgren wrote: Hi, * Guenter Roeck li...@roeck-us.net [150817 13:48]: Commit 0b50dc4fc971 (Convert smsc911x to use ACPI as well as DT) makes the call to smsc911x_probe_config() unconditional, and no longer fails if there is no device node. device_get_phy_mode

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

Hi Tony, On 08/26/2015 10:04 AM, Tony Lindgren wrote: Hi, * Guenter Roeck li...@roeck-us.net [150817 13:48]: Commit 0b50dc4fc971 (Convert smsc911x to use ACPI as well as DT) makes the call to smsc911x_probe_config() unconditional, and no longer fails if there is no device node

[PATCH -next v2 2/2] smsc911x: Ignore error return from device_get_phy_mode()

or used) Signed-off-by: Guenter Roeck li...@roeck-us.net --- v2: Dropped RFC Removed check for -ENODATA Depends on patch 1/2 Tested with non-devicetree configuration. Should be tested with ACPI and FDT configurations. drivers/net/ethernet/smsc/smsc911x.c | 14 -- 1 file changed

[PATCH -next v2 1/2] device property: Return -ENXIO if there is no suitable FW interface

Return -ENXIO if device property array access functions don't find a suitable firmware interface. This lets drivers decide if they should use available platform data instead. Cc: Rafael J. Wysocki rafael.j.wyso...@intel.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- v2: Added patch

Re: [PATCH -next] smsc911x: Fix crash seen if neither ACPI nor OF is configured or used

Hi Tony, On 08/26/2015 01:16 PM, Tony Lindgren wrote: [ ... ] We may need two separate patches, one to fix up device_property_read_u32() to return -ENXIO, and one to fix smsc911x_probe_config() to ignore the error from device_get_phy_mode(), and to bail out if device_property_read_u32()

Re: [PATCH -next v2 1/2] device property: Return -ENXIO if there is no suitable FW interface

On 08/26/2015 04:37 PM, Rafael J. Wysocki wrote: On Wednesday, August 26, 2015 01:20:44 PM Guenter Roeck wrote: Return -ENXIO if device property array access functions don't find a suitable firmware interface. This lets drivers decide if they should use available platform data instead. Cc

[PATCH -next v3 1/2] device property: Return -ENXIO if there is no suitable FW interface

Return -ENXIO if device property array access functions don't find a suitable firmware interface. This lets drivers decide if they should use available platform data instead. Cc: Rafael J. Wysocki rafael.j.wyso...@intel.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- v2: Added patch v3

[PATCH -next v3 2/2] smsc911x: Ignore error return from device_get_phy_mode()

or used) Tested-by: Tony Lindgren t...@atomide.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- v2: Dropped RFC Removed check for -ENODATA Depends on patch 1/2 v3: Added Tony's Tested-by: Tested with non-devicetree and devicetree configurations. Should be tested with ACPI configuration

Re: [PATCH net-next] lib: move strncpy_from_unsafe() into mm/maccess.c

t-in.o: In function `fetch_memory_string': trace_kprobe.c:(.text+0x11acf8): undefined reference to `strncpy_from_unsafe' move strncpy_from_unsafe() next to probe_kernel_read/write() which use the same memory access style. Reported-by: Fengguang Wu <fengguang...@intel.com> Reported-by: Guent

Re: [PATCH net] net: dsa: fix EDSA frame from hwaccel frame

On Tue, Aug 25, 2015 at 06:28:34PM -0700, Florian Fainelli wrote: Le 08/03/15 23:35, Vivien Didelot a écrit : If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, an EDSA frame is prepended with a 802.1q header once queued. To fix this, push the VLAN tag to the payload if

Re: Glibc recvmsg from kernel netlink socket hangs forever

On 10/05/2015 04:26 PM, Steven Schlansker wrote: On Sep 25, 2015, at 7:58 PM, Guenter Roeck <li...@roeck-us.net> wrote: On 09/25/2015 02:37 PM, Steven Schlansker wrote: Thank you for the patches to try, I'll build a kernel with them early next week and report back. It sounds like

Re: Glibc recvmsg from kernel netlink socket hangs forever

On 09/25/2015 08:55 AM, Herbert Xu wrote: On Thu, Sep 24, 2015 at 10:34:10PM -0700, Guenter Roeck wrote: Any idea what may be needed for 4.1 ? I am currently trying https://patchwork.ozlabs.org/patch/473041/, This patch should not make any difference on 4.1 and later because 4.1 is where I

Re: Glibc recvmsg from kernel netlink socket hangs forever

Herbert, On 09/25/2015 08:55 AM, Herbert Xu wrote: On Thu, Sep 24, 2015 at 10:34:10PM -0700, Guenter Roeck wrote: Any idea what may be needed for 4.1 ? I am currently trying https://patchwork.ozlabs.org/patch/473041/, This patch should not make any difference on 4.1 and later because 4.1

Re: [PATCH] net: dsa: Fix Marvell Egress Trailer check

the fourth byte twice. Signed-off-by: Neil Armstrong <narmstr...@baylibre.com> Nice catch. Acked-by: Guenter Roeck <li...@roeck-us.net> --- net/dsa/tag_trailer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/tag_trailer.c b/net/dsa/tag_trailer.c i

Re: Glibc recvmsg from kernel netlink socket hangs forever

Herbert, On 09/24/2015 09:58 PM, Herbert Xu wrote: On Thu, Sep 24, 2015 at 09:36:53PM -0700, Guenter Roeck wrote: http://comments.gmane.org/gmane.linux.network/363085 might explain your problem. I thought this was resolved in 4.1, but it looks like the problem still persists there. At least

[PATCH] libertas_tf: Drop unused variable and define

gcc-6 reports: drivers/net/wireless/marvell/libertas_tf/main.c:30:19: error: 'lbtf_driver_version' defined but not used with -Werror=unused-const-variable=. Reported-by: Fengguang Wu <fengguang...@intel.com> [0-day test robot] Signed-off-by: Guenter Roeck <li...@roe

[PATCH] iwlwifi: Remove unused array 'iwlagn_loose_lookup'

gcc-6 reports the following error if -Werror=unused-const-variable is enabled. drivers/net/wireless/intel/iwlwifi/dvm/lib.c:210:21: error: 'iwlagn_loose_lookup' defined but not used Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- drivers/net/wireless/intel/iwlwifi/dvm/lib.

[PATCH] b43: Remove unused phy_a code

gt; [0-day test robot] Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- drivers/net/wireless/broadcom/b43/phy_a.c | 298 -- 1 file changed, 298 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/phy_a.c b/drivers/net/wireless/broadcom/b43/p

Re: [PATCH] b43: Remove unused phy_a code

On 06/03/2016 02:35 PM, Michael Büsch wrote: On Fri, 3 Jun 2016 14:32:46 -0700 Guenter Roeck <li...@roeck-us.net> wrote: gcc-6 reports the following error with -Werror=unused-const-variable. drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: 'b43_phyops_a' defined but no

[PATCH v2 2/2] b43: Completely remove support for phy_a

Per Michael Büsch: "All a-phy code is usused", so remove it all. Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- v2: Added patch drivers/net/wireless/broadcom/b43/main.c | 31 +--- drivers/net/wireless/broadcom/b43/wa.c | 283 +++ driv

[PATCH v2 1/2] b43: Remove unused phy_a code

ation code into phy_g.c. Reported-by: Fengguang Wu <fengguang...@intel.com> [0-day test robot] Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- v2: Remove phy_a.c; move left-over code into phy_g.c Remove now unused data structure drivers/net/wireless/broadcom/b43/Makefile

[PATCH v3 1/2] b43: Remove unused phy_a code

ation code into phy_g.c. Reported-by: Fengguang Wu <fengguang...@intel.com> [0-day test robot] Cc: Michael Büsch <m...@bues.ch> Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- v3: Do not rename b43_phy_inita() v2: Remove phy_a.c; move left-over code into phy_g.c Remove now unused

[PATCH v3 2/2] b43: Completely remove support for phy_a

Per Michael Büsch: "All a-phy code is usused", so remove it all. Cc: Michael Büsch <m...@bues.ch> Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- v3: no change v2: added patch drivers/net/wireless/broadcom/b43/main.c | 31 +--- drivers/net/wireless/bro

[PATCH 1/2] timer: Export destroy_hrtimer_on_stack()

hrtimer_init_on_stack() needs a matching call to destroy_hrtimer_on_stack(), so both need to be exported. Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- kernel/time/hrtimer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c

[PATCH 2/2] net: pktgen: Call destroy_hrtimer_on_stack()

If CONFIG_DEBUG_OBJECTS_TIMERS=y, hrtimer_init_on_stack() requires a matching call to destroy_hrtimer_on_stack() to clean up timer debug objects. Signed-off-by: Guenter Roeck <li...@roeck-us.net> --- net/core/pktgen.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Build failure in mainline kernel due to 'lan78xx: add ndo_get_stats64'

Hi, your commit a59f8c5b048 ("lan78xx: add ndo_get_stats64") is causing the following build failure if CONFIG_PM is not enabled. drivers/net/usb/lan78xx.c: In function 'lan78xx_get_stats64': drivers/net/usb/lan78xx.c:3274:27: error: 'struct dev_pm_info' has no member named 'runtime_auto'

Re: [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

On 03/25/2016 05:10 PM, Patrick Uiterwijk wrote: Add versions of the phy_page_read and _write functions to be used in a context where the SMI mutex is held. Signed-off-by: Patrick Uiterwijk --- drivers/net/dsa/mv88e6xxx.c | 42

Re: [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

On 03/25/2016 06:58 PM, Patrick Uiterwijk wrote: On Sat, Mar 26, 2016 at 2:45 AM, Guenter Roeck <li...@roeck-us.net> wrote: On 03/25/2016 05:10 PM, Patrick Uiterwijk wrote: Add versions of the phy_page_read and _write functions to be used in a context where the SMI mutex is held. Sign

Re: [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}

On 03/26/2016 11:32 AM, Vivien Didelot wrote: Hi Guenter, Guenter Roeck <li...@roeck-us.net> writes: Is there some good reason for changing the name of those labels ? Vivien suggested to rename this since it makes more clear that this write is meant to return to page 0 to mak

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

, but auto suspend is not enabled anyway. Hence protect the check for runtime_auto by #ifdef CONFIG_PM to fix this. Fixes: a59f8c5b048dc938 ("lan78xx: add ndo_get_stats64") Reported-by: Guenter Roeck <li...@roeck-us.net> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>

Re: [1/1] net: pegasus: remove dead coding

On Wed, May 18, 2016 at 02:13:30AM +0200, Heinrich Schuchardt wrote: > (!count || count < 4) is always true. Even if count >= 4 ? Guenter > So let's remove the coding which is dead at least since 2005. > > Signed-off-by: Heinrich Schuchardt > > --- >

Re: Crashes in -next due to 'phy: add support for a reset-gpio specification'

On 05/17/2016 10:01 PM, Florian Fainelli wrote: Le 17/05/2016 21:37, Guenter Roeck a écrit : Hi, my xtensa qemu tests crash in -next as follows. [ ... ] [9.366256] libphy: ethoc-mdio: probed [9.367389] (null): could not attach to PHY [9.368555] (null): failed to probe MDIO bus

Crashes in -next due to 'phy: add support for a reset-gpio specification'

Hi, my xtensa qemu tests crash in -next as follows. [ ... ] [9.366256] libphy: ethoc-mdio: probed [9.367389] (null): could not attach to PHY [9.368555] (null): failed to probe MDIO bus [9.371540] Unable to handle kernel paging request at virtual address 001c [

Re: [PATCH] Revert "phy: add support for a reset-gpio specification"

On Wed, May 18, 2016 at 09:52:22AM -0700, Florian Fainelli wrote: > On 05/18/2016 09:05 AM, Fabio Estevam wrote: > > Commit da47b4572056 ("phy: add support for a reset-gpio specification") > > causes the following xtensa qemu crash according to Guenter Roeck: > > &

  1   2   >