[PATCH 0/2] drivers: net: xgene: Misc bug fixes

2017-08-25 Thread Iyappan Subramanian
This patch set, 1. Adds call to PHY disconnect in the case of error 2. Cleans up all outstanding TX descriptors when the driver is being rmmod'd Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (1): drivers: net: xgene: Clean up all outstanding tx descri

[PATCH 2/2] drivers: net: xgene: Clean up all outstanding tx descriptors

2017-08-25 Thread Iyappan Subramanian
any() from xgene_enet_setup_tx_desc(). The only caller of xgene_enet_setup_tx_desc() will call dev_kfree_skb_any() upon return of an error. Nothing is gained by calling it twice in a row. Signed-off-by: Iyappan Subramanian Signed-off-by: Dean Nelson Tested-by: Quan Nguyen --- drivers/net/ethernet

[PATCH 1/2] drivers: net: xgene: Correct probe sequence handling

2017-08-25 Thread Iyappan Subramanian
: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 27 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 1d307f2..6e253d9 100644

Re: [PATCH 2/2] drivers: net: xgene: Clean up all outstanding tx descriptors

2017-08-28 Thread Iyappan Subramanian
Hi Andrew, On Fri, Aug 25, 2017 at 4:10 PM, Andrew Lunn wrote: > On Fri, Aug 25, 2017 at 03:23:30PM -0700, Iyappan Subramanian wrote: >> When xgene_enet is rmmod'd and there are still outstanding tx descriptors >> that have been setup but have not completed, it is

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Iyappan Subramanian
etrived. Always abort if the clock is missing on > * DT system as the driver can't cope with this case. > > -- Thanks for the patch. Acked-by: Iyappan Subramanian > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea.[ RFC1925, 2.3 ]

[PATCH] drivers: net: xgene: Correct probe sequence handling

2017-08-29 Thread Iyappan Subramanian
: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 27 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 1d307f2..6e253d9 100644

[PATCH 2/3] drivers: net: xgene: Configure tx/rx delay for ACPI

2017-09-05 Thread Iyappan Subramanian
From: Quan Nguyen This patch fixes configuring tx/rx delay values for ACPI. Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/apm

[PATCH 0/3] drivers: net: xgene: Misc bug fixes

2017-09-05 Thread Iyappan Subramanian
This patch set fixes bugs related to handling the case for ACPI for, reading and programming tx/rx delay values. Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (2): drivers: net: xgene: Read tx/rx delay for ACPI drivers: net: xgene: Remove return statement from void function

[PATCH 1/3] drivers: net: xgene: Read tx/rx delay for ACPI

2017-09-05 Thread Iyappan Subramanian
This patch fixes reading tx/rx delay values for ACPI. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b

[PATCH 3/3] drivers: net: xgene: Remove return statement from void function

2017-09-05 Thread Iyappan Subramanian
commit 183db4 ("drivers: net: xgene: Correct probe sequence handling") changed the return type of xgene_enet_check_phy_handle() to void. This patch, removes the return statement from the last line. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_

[PATCH v2 net-next 04/12] drivers: net: xgene: Remove redundant local stats

2017-05-10 Thread Iyappan Subramanian
From: Quan Nguyen Commit 5944701df90d ("net: remove useless memset's in drivers get_stats64") makes the pdata->stats redundant. This patch removes pdata->stats and updates get_stats64() callback accordingly. Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subraman

[PATCH v2 net-next 10/12] drivers: net: xgene: Add frame recovered statistics counter for errata 10GE_8/ENET_11

2017-05-10 Thread Iyappan Subramanian
From: Quan Nguyen This patch adds statistic counter for frames recovered from HW errata 10GE_8 and ENET_11: "HW reports Length error for valid 64 byte frames with len <46 bytes". Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/ether

[PATCH v2 net-next 05/12] drivers: net: xgene: Refactor statistics error parsing code

2017-05-10 Thread Iyappan Subramanian
From: Quan Nguyen This patch fixes the tx error counters and adds more rx error counters. Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 6 -- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 2 -- drivers/net

[PATCH v2 net-next 09/12] drivers: net: xgene: Workaround for HW errata 10GE_4

2017-05-10 Thread Iyappan Subramanian
From: Quan Nguyen This patch adds workaround for HW errata 10GE_4: "XGENET_ICM_ECM_DROP_COUNT_REG_0 reg not clear on read". Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 2 ++ drivers/net/ethernet

[PATCH v2 net-next 08/12] drivers: net: xgene: Add rx_overrun/tx_underrun statistics

2017-05-10 Thread Iyappan Subramanian
This patch adds rx_overrun and tx_underrun ethtool statistic counters. Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_ethtool.c | 16 +--- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 11 +++ drivers/net

[PATCH v2 net-next 03/12] drivers: net: xgene: Use rgmii mdio mac access

2017-05-10 Thread Iyappan Subramanian
From: Quan Nguyen This patch switches to use rgmii mdio mac access routines if available, as they share the same HW. Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 14 ++ 1 file changed, 14 insertions(+) diff

[PATCH v2 net-next 11/12] drivers: net: xgene: Workaround for HW errata 10GE_10/ENET_15

2017-05-10 Thread Iyappan Subramanian
uan Nguyen Signed-off-by: Iyappan Subramanian --- .../net/ethernet/apm/xgene/xgene_enet_ethtool.c| 33 ++ drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 20 +++-- drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 ++ 3 files changed, 46 insertions(+), 9

[PATCH v2 net-next 00/12] drivers: net: xgene: Add ethtool stats and bug fixes

2017-05-10 Thread Iyappan Subramanian
This patch set, - adds ethtool extended statistics support - addresses errata workarounds - fixes bugs related to statistics Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- v2: Address review comments from v1 - Adds lock to protect mdio-xgene indirect MAC access

[PATCH v2 net-next 12/12] drivers: net: xgene: Fix redundant prefetch buffer cleanup

2017-05-10 Thread Iyappan Subramanian
ing port_ops->shutdown() after delete_rings() Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 21 - drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 +- drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.

[PATCH v2 net-next 02/12] drivers: net: phy: xgene: Add lock to protect mac access

2017-05-10 Thread Iyappan Subramanian
From: Quan Nguyen This patch, - refactors mac access routine - adds lock to protect mac indirect access Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/phy/mdio-xgene.c | 74 ++-- drivers/net/phy/mdio-xgene.h | 3 ++ 2

[PATCH v2 net-next 01/12] drivers: net: xgene: Protect indirect MAC access

2017-05-10 Thread Iyappan Subramanian
This patch, - refactors mac read/write functions - adds lock to protect indirect mac access Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 119 +- drivers/net/ethernet/apm/xgene

[PATCH v2 net-next 07/12] drivers: net: xgene: Extend ethtool statistics

2017-05-10 Thread Iyappan Subramanian
From: Quan Nguyen This patch adds extended ethtool statistics support. Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- .../net/ethernet/apm/xgene/xgene_enet_ethtool.c| 89 +- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 29 +++ drivers

[PATCH v2 net-next 06/12] drivers: net: xgene: Remove unused macros

2017-05-10 Thread Iyappan Subramanian
From: Quan Nguyen This patch cleans up unused macros to improve readability. Signed-off-by: Quan Nguyen Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene

[PATCH net-next] drivers: net: xgene: Check all RGMII phy mode variants

2017-05-17 Thread Iyappan Subramanian
This patch addresses the review comment from the previous patch set, by adding a helper function to address all RGMII phy mode variants. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- Review comment reference: http://www.spinics.net/lists/netdev/msg434649.html --- .../net

Re: [PATCH net-next] drivers: net: xgene: Check all RGMII phy mode variants

2017-05-17 Thread Iyappan Subramanian
On Wed, May 17, 2017 at 1:26 PM, Andrew Lunn wrote: >> +bool is_xgene_enet_phy_mode_rgmii(struct net_device *ndev) >> +{ >> + struct xgene_enet_pdata *pdata = netdev_priv(ndev); >> + int phy_mode = pdata->phy_mode; >> + bool ret; >> + >> + ret = phy_mode == PHY_INTERFACE_MODE_RGMII

[PATCH v2 net-next 1/2] include: linux: Add helper function to check phy interface mode

2017-05-18 Thread Iyappan Subramanian
Added helper function that checks phy_mode is RGMII (all variants) 'bool phy_interface_mode_is_rgmii(phy_interface_t mode)' Changed the following function, to use the above. 'bool phy_interface_is_rgmii(struct phy_device *phydev)' Signed-off-by: Iyappan Subramanian S

[PATCH v2 net-next 0/2] Check all RGMII phy mode variants

2017-05-18 Thread Iyappan Subramanian
This patch set, - adds phy_interface_mode_is_rgmii() helper function - addresses review comment from previous patch set, by calling phy_interface_mode_is_rgmii() to address all RGMII variants Signed-off-by: Iyappan Subramanian --- v2: Address review comments from v1 - adds

[PATCH v2 net-next 2/2] drivers: net: xgene: Check all RGMII phy mode variants

2017-05-18 Thread Iyappan Subramanian
This patch addresses the review comment from the previous patch set, by using phy_interface_mode_is_rgmii() helper function to address all RGMII phy mode variants. Signed-off-by: Iyappan Subramanian Signed-off-by: Quan Nguyen --- Review comment reference: http://www.spinics.net/lists/netdev

Re: [PATCH v2 net-next 1/2] include: linux: Add helper function to check phy interface mode

2017-05-18 Thread Iyappan Subramanian
On Thu, May 18, 2017 at 3:19 PM, Florian Fainelli wrote: > On 05/18/2017 03:13 PM, Iyappan Subramanian wrote: >> Added helper function that checks phy_mode is RGMII (all variants) >> 'bool phy_interface_mode_is_rgmii(phy_interface_t mode)' >> >> Changed the

[PATCH net-next v1 3/4] drivers: net: xgene: Add 10GbE support with ring manager v2

2015-04-28 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 1 + drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 141 ++ drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 17 +++ drivers/net/ethernet/apm/xgene/xgene_enet_xgmac.c | 1

[PATCH net-next v1 0/4] drivers: net: xgene: Add ethernet with ring manager v2 support

2015-04-28 Thread Iyappan Subramanian
Adding XFI based 10GbE and SGMII based 1GbE with ring manager v2 support for APM X-Gene ethernet driver. The ring manager v2 is used by 2nd generation SoC. v1: * Initial version --- Iyappan Subramanian (4): drivers: net: xgene: Change ring manager to use function pointers drivers: net

[PATCH net-next v1 2/4] drivers: net: xgene: Add ring manager v2 functions

2015-04-28 Thread Iyappan Subramanian
Adding ring manager v2 support for APM X-Gene ethernet driver. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/Makefile | 2 +- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 1 + drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 + drivers/net

[PATCH net-next v1 1/4] drivers: net: xgene: Change ring manager to use function pointers

2015-04-28 Thread Iyappan Subramanian
This is a preparatory patch for adding ethernet support for APM X-Gene ethernet driver to work with ring manager v2. Added xgene_ring_ops structure for storing chip specific ring manager properties and functions. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene

[PATCH net-next v1 4/4] drivers: net: xgene: Add SGMII based 1GbE support with ring manager v2

2015-04-28 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 1 - drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 26 +++--- drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 1 - drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c | 62

[PATCH net-next 1/1] drivers: net: xgene: fix kbuild warnings

2015-04-30 Thread Iyappan Subramanian
Fixed the following kbuild warnings: 1. unused variable 'of_id' 2. buffer overflow 'ring_cfg' 5 <= 5 Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 ++ drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 +- 2 files chan

[PATCH net-next 0/2] drivers: xgene: Add support RGMII TX/RX delay configuration

2015-10-16 Thread Iyappan Subramanian
This patch adds support RGMII TX/RX delay configuration. Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (2): drivers: net: xgene: Add support RGMII TX/RX delay configuration Documentation: dts: xgene: Add TX/RX delay field .../devicetree/bindings/net/apm-xgene-enet.txt

[PATCH net-next 1/2] drivers: net: xgene: Add support RGMII TX/RX delay configuration

2015-10-16 Thread Iyappan Subramanian
: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 8 +++- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 1 + drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 49 drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 + 4 files changed, 59

[PATCH net-next 2/2] Documentation: dts: xgene: Add TX/RX delay field

2015-10-16 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian --- Documentation/devicetree/bindings/net/apm-xgene-enet.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt index f55aa28

Re: [PATCH net-next 1/2] drivers: net: xgene: Add support RGMII TX/RX delay configuration

2015-10-23 Thread Iyappan Subramanian
On Fri, Oct 16, 2015 at 2:36 PM, Florian Fainelli wrote: > On 16/10/15 13:35, Iyappan Subramanian wrote: >> Add RGMII TX/RX delay configuration support. RGMII standard requires 2ns >> delay to help the RGMII bridge receiver to sample data correctly. If the >> default value do

[PATCH net-next v2 2/2] Documentation: dts: xgene: Add TX/RX delay field

2015-10-26 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian --- Documentation/devicetree/bindings/net/apm-xgene-enet.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt index f55aa28

[PATCH net-next v2 0/2] drivers: xgene: Add support RGMII TX/RX delay configuration

2015-10-26 Thread Iyappan Subramanian
using configuration registers. This will help in maintain the CLK-CTL delay relationship in various operating conditions. This patch adds support RGMII TX/RX delay configuration. Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (2): drivers: net: xgene: Add support RGMII TX/RX delay

[PATCH net-next v2 1/2] drivers: net: xgene: Add support RGMII TX/RX delay configuration

2015-10-26 Thread Iyappan Subramanian
: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 8 +++- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 1 + drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 49 drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 + 4 files changed, 59

[PATCH net-next] drivers: net: xgene: fix RGMII 10/100Mb mode

2015-11-05 Thread Iyappan Subramanian
This patch fixes the RGMII 10/100M mode by reprogramming the clock. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 49 +++- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h | 1 + drivers/net/ethernet/apm

[PATCH 3/6] drivers: net: xgene: fix ununiform latency across queues

2016-05-09 Thread Iyappan Subramanian
This patch addresses ununiform latency across queues by adding more queues to match with, upto number of CPU cores. Also, number of interrupts are increased and the channel numbers are reordered. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene

[PATCH 0/6] drivers: net: xgene: Bug fixes

2016-05-09 Thread Iyappan Subramanian
: fix register offset Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (6): drivers: net: xgene: fix IPv4 forward crash drivers: net: xgene: fix sharing of irqs drivers: net: xgene: fix ununiform latency across queues drivers: net: xgene: fix statistics counters race condition

[PATCH 5/6] drivers: net: xgene: Using static MSS values

2016-05-09 Thread Iyappan Subramanian
Due to the nature of hardware design for TSO, if the MSS values that are stored in the register, changes during TSO operation, data corruption may occur. This patch fixes the issue by using one of the predefined MSS values. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net

[PATCH 2/6] drivers: net: xgene: fix sharing of irqs

2016-05-09 Thread Iyappan Subramanian
Since hardware doesn't allow sharing of interrupts, this patch fixes the same by removing IRQF_SHARED flag. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH 1/6] drivers: net: xgene: fix IPv4 forward crash

2016-05-09 Thread Iyappan Subramanian
This patch fixes the crash observed during IPv4 forward test by setting the drop field in the dbptr. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 11 ++- drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 2 ++ 2 files

[PATCH 4/6] drivers: net: xgene: fix statistics counters race condition

2016-05-09 Thread Iyappan Subramanian
This patch fixes the race condition on updating the statistics counters by moving the counters to the ring structure. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 17 +++ drivers/net/ethernet/apm/xgene/xgene_enet_hw.h

[PATCH 6/6] drivers: net: xgene: fix register offset

2016-05-09 Thread Iyappan Subramanian
This patch fixes SG_RX_DV_GATE_REG_0_ADDR register offset and ring state field lengths. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 6 +++--- drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.h | 2 +- 2 files changed, 4

[PATCH v2 2/5] drivers: net: xgene: fix sharing of irqs

2016-05-13 Thread Iyappan Subramanian
Since hardware doesn't allow sharing of interrupts, this patch fixes the same by removing IRQF_SHARED flag. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v2 3/5] drivers: net: xgene: fix ununiform latency across queues

2016-05-13 Thread Iyappan Subramanian
This patch addresses ununiform latency across queues by adding more queues to match with, upto number of CPU cores. Also, number of interrupts are increased and the channel numbers are reordered. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene

[PATCH v2 1/5] drivers: net: xgene: fix IPv4 forward crash

2016-05-13 Thread Iyappan Subramanian
This patch fixes the crash observed during IPv4 forward test by setting the drop field in the dbptr. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 11 ++- drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 2 ++ 2 files

[PATCH v2 5/5] drivers: net: xgene: fix register offset

2016-05-13 Thread Iyappan Subramanian
This patch fixes SG_RX_DV_GATE_REG_0_ADDR register offset and ring state field lengths. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 6 +++--- drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.h | 2 +- 2 files changed, 4

[PATCH v2 4/5] drivers: net: xgene: fix statistics counters race condition

2016-05-13 Thread Iyappan Subramanian
This patch fixes the race condition on updating the statistics counters by moving the counters to the ring structure. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 19 ++- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h

[PATCH v2 0/5] drivers: net: xgene: Bug fixes

2016-05-13 Thread Iyappan Subramanian
reposting all other patches from v1 v1: - Initial version Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (5): drivers: net: xgene: fix IPv4 forward crash drivers: net: xgene: fix sharing of irqs drivers: net: xgene: fix ununiform latency across queues drivers: net: xgene: fix

[PATCH v1 2/6] drivers: net: xgene: Backward compatibility with older firmware

2016-05-27 Thread Iyappan Subramanian
: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 59 +++- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 166 +++--- drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2 + drivers/net/ethernet/apm/xgene

[PATCH v1 0/6] drivers: net: xgene: Fix 1G hot-plug and module support

2016-05-27 Thread Iyappan Subramanian
: Iyappan Subramanian --- Iyappan Subramanian (6): drivers: net: xgene: MAC and PHY configuration changes drivers: net: xgene: Backward compatibility with older firmware drivers: net: phy: Add MDIO driver dtb: xgene: Add MDIO node dtb: xgene: Remove clock nodes drivers: net: xgene: Fix

[PATCH v1 6/6] drivers: net: xgene: Fix module load/unload crash

2016-05-27 Thread Iyappan Subramanian
tting irq_name before calling request_irq. - Calling dev_close() within remove - Added shutdown callback - Changed to use dmam_ APIs Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 71 +++- drivers/net/etherne

[PATCH v1 3/6] drivers: net: phy: Add MDIO driver

2016-05-27 Thread Iyappan Subramanian
er to manage MDIO bus. This driver registers the mdio bus and registers the PHYs connected to it. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/Kconfig | 1 + drivers/net/phy/Kconfig| 7 + drivers/net/phy/Mak

[PATCH v1 1/6] drivers: net: xgene: MAC and PHY configuration changes

2016-05-27 Thread Iyappan Subramanian
dev object existence - Calling phy_connect based on pdata->mdio_driver flag Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 189 +- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h

[PATCH v1 4/6] dtb: xgene: Add MDIO node

2016-05-27 Thread Iyappan Subramanian
Added mdio node for mdio driver. Also added phy-handle reference to the ethernet nodes. Removed unused mdio subnode within ethernet node. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le --- arch/arm64/boot/dts/apm/apm-merlin.dts | 10 ++ arch/arm64

[PATCH v1 5/6] dtb: xgene: Remove clock nodes

2016-05-27 Thread Iyappan Subramanian
Since the MDIO will be responsible for clock reset, removing the clock nodes from shadowcat xge0 and storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 12 arch/arm64/boot/dts/apm/apm

Re: [PATCH v1 5/6] dtb: xgene: Remove clock nodes

2016-05-31 Thread Iyappan Subramanian
On Mon, May 30, 2016 at 12:34 AM, Matthias Brugger wrote: > > > On 27/05/16 09:22, Iyappan Subramanian wrote: >> >> Since the MDIO will be responsible for clock reset, removing the clock >> nodes from shadowcat xge0 and storm sgenet1. >> >> Signed-off-by: Iy

[PATCH v2 5/5] drivers: net: xgene: Fix module load/unload crash

2016-05-31 Thread Iyappan Subramanian
tting irq_name before calling request_irq. - Calling dev_close() within remove - Added shutdown callback - Changed to use dmam_ APIs Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c

[PATCH v2 2/5] drivers: net: xgene: Backward compatibility with older firmware

2016-05-31 Thread Iyappan Subramanian
: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 60 +++- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 165 +++--- drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2

[PATCH v2 0/5] drivers: net: xgene: Fix 1G hot-plug and module support

2016-05-31 Thread Iyappan Subramanian
: Iyappan Subramanian Tested-by: Matthias Brugger --- v2: Address review comments from v1 - Fixed patch 1 compilation error - Fixed mdio@1f61 xge0clk reference - Squashed dtb patches - Added PORT_OFFSET macro v1: - Initial version --- Iyappan Subramanian (5

[PATCH v2 4/5] dtb: xgene: Add MDIO node

2016-05-31 Thread Iyappan Subramanian
Added mdio node for mdio driver. Also added phy-handle reference to the ethernet nodes. Removed unused mdio subnode within storm menet ethernet node. Removed unused clock node from storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias

[PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-05-31 Thread Iyappan Subramanian
er to manage MDIO bus. This driver registers the mdio bus and registers the PHYs connected to it. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/Kconfig | 1 + drivers/net/phy/Kc

[PATCH v2 1/5] drivers: net: xgene: MAC and PHY configuration changes

2016-05-31 Thread Iyappan Subramanian
dev object existence - Calling phy_connect based on pdata->mdio_driver flag Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 190 +- drivers/net/ethernet/apm

[PATCH v2 1/3] drivers: net: xgene: Get channel number from device binding

2016-04-29 Thread Iyappan Subramanian
This patch gets ethernet to CPU channel (prefetch buffer number) from the newly added 'channel' property, thus decoupling Linux driver from resource management. Signed-off-by: Iyappan Subramanian --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 15 ++- 1 file c

[PATCH v2 2/3] Documentation: dtb: xgene: Add channel property

2016-04-29 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian --- Documentation/devicetree/bindings/net/apm-xgene-enet.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt index 078060a..05f705e3

[PATCH v2 3/3] dtb: xgene: Add channel property

2016-04-29 Thread Iyappan Subramanian
Added 'channel' property, describing ethernet to CPU channel number. Signed-off-by: Iyappan Subramanian --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 1 + arch/arm64/boot/dts/apm/apm-storm.dtsi | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm64/boot/d

[PATCH v2 0/3] drivers: net: xgene: fix: Get channel number from device binding

2016-04-29 Thread Iyappan Subramanian
U channel number v1: - Initial version Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (3): drivers: net: xgene: Get channel number from device binding Documentation: dtb: xgene: Add channel property dtb: xgene: Add channel property Documentation/devicetree/bindings/net/apm-xgene-en

Re: [PATCH] drivers: net: xgene: constify xgene_cle_ops structure

2016-05-01 Thread Iyappan Subramanian
struct xgene_cle_ops *cle_ops; > + const struct xgene_cle_ops *cle_ops; > struct delayed_work link_work; > u32 port_id; > u8 cpu_bufnum; > Thanks Julia. Acked-by: Iyappan Subramanian

[PATCH net-next 2/4] drivers: net: xgene: Add support for RSS

2016-02-02 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 386 +++- drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 52 2 files changed, 433 insertions(+), 5

[PATCH net-next 0/4] Add support for Classifier and RSS

2016-02-02 Thread Iyappan Subramanian
messages enqueued per CPU though the help of Toeplitz Hash function of 4-tuple of source TCP/UDP port, destination TCP/UDP port, source IPV4 address and destination IPV4 address. (iii) Multi queue, to make advantage of RSS --- Iyappan Subramanian (4): drivers: net: xgene: Add support for

[PATCH net-next 3/4] drivers: net: xgene: Add support for multiple queues

2016-02-02 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 11 +- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 452 ++- drivers/net/ethernet/apm/xgene

[PATCH net-next 4/4] dtb: xgene: Add irqs to support multi queue

2016-02-02 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 8 +++- arch/arm64/boot/dts/apm/apm-storm.dtsi | 8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a

[PATCH net-next 1/4] drivers: net: xgene: Add support for Classifier engine

2016-02-02 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/Makefile | 3 +- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 357 +++ drivers/net/ethernet/apm/xgene

[PATCH net-next v2 0/4] Add support for Classifier and RSS

2016-02-12 Thread Iyappan Subramanian
coalescing v1: - Initial version Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (4): drivers: net: xgene: Add support for Classifier engine drivers: net: xgene: Add support for RSS drivers: net: xgene: Add support for multiple queues dtb: xgene: Add irqs to support multi

[PATCH net-next v2 2/4] drivers: net: xgene: Add support for RSS

2016-02-12 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 386 +++- drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 41 +++ 2 files changed, 422 insertions(+), 5

[PATCH net-next v2 1/4] drivers: net: xgene: Add support for Classifier engine

2016-02-12 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/Makefile | 3 +- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 357 +++ drivers/net/ethernet/apm/xgene

[PATCH net-next v2 3/4] drivers: net: xgene: Add support for multiple queues

2016-02-12 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 11 +- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 12 + drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 5

[PATCH net-next v2 4/4] dtb: xgene: Add irqs to support multi queue

2016-02-12 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 8 +++- arch/arm64/boot/dts/apm/apm-storm.dtsi | 8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a

[PATCH net-next v3 2/4] drivers: net: xgene: Add support for RSS

2016-02-17 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 386 +++- drivers/net/ethernet/apm/xgene/xgene_enet_cle.h | 41 +++ 2 files changed, 422 insertions(+), 5

[PATCH net-next v3 0/4] Add support for Classifier and RSS

2016-02-17 Thread Iyappan Subramanian
longest to shortlest line v2: Address review comments from v1 - fix kbuild warning - add default coalescing v1: - Initial version Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (4): drivers: net: xgene: Add support for Classifier engine drivers: net: xgene: Add support for

[PATCH net-next v3 3/4] drivers: net: xgene: Add support for multiple queues

2016-02-17 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 11 +- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 12 + drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 5

[PATCH net-next v3 1/4] drivers: net: xgene: Add support for Classifier engine

2016-02-17 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/Makefile | 3 +- drivers/net/ethernet/apm/xgene/xgene_enet_cle.c | 357 +++ drivers/net/ethernet/apm/xgene

[PATCH net-next v3 4/4] dtb: xgene: Add irqs to support multi queue

2016-02-17 Thread Iyappan Subramanian
Signed-off-by: Iyappan Subramanian Signed-off-by: Khuong Dinh Signed-off-by: Tanmay Inamdar Tested-by: Toan Le --- arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 8 +++- arch/arm64/boot/dts/apm/apm-storm.dtsi | 8 +++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a

[PATCH 1/2] drivers: net: xgene: fix: Derive prefetch number from irq

2016-03-08 Thread Iyappan Subramanian
firmware and the driver by deriving the prefetch buffer number from the Linux irq. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 19 +++ drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 6 ++ drivers/net

[PATCH 2/2] drivers: net: xgene: fix: Remove IRQF_SHARED flag

2016-03-08 Thread Iyappan Subramanian
Not allowing sharing of IRQs. Signed-off-by: Iyappan Subramanian Tested-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene

[PATCH 0/2] drivers: net: xgene: fix irq related issues

2016-03-08 Thread Iyappan Subramanian
This patch set addresses, 1. Remove static association of prefetch buffers and derive that from Linux irq 2. Remove irq sharing Signed-off-by: Iyappan Subramanian --- Iyappan Subramanian (2): drivers: net: xgene: fix: Derive prefetch number from irq drivers: net: xgene

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-06-06 Thread Iyappan Subramanian
Hi Andrew, Thanks for the review. On Tue, May 31, 2016 at 6:11 PM, Andrew Lunn wrote: > On Tue, May 31, 2016 at 05:10:38PM -0700, Iyappan Subramanian wrote: >> +static int xgene_mdio_reset(struct xgene_mdio_pdata *pdata) >> +{ >> + int ret; >> +

[PATCH v3 1/5] drivers: net: xgene: MAC and PHY configuration changes

2016-06-06 Thread Iyappan Subramanian
dev object existence - Calling phy_connect based on pdata->mdio_driver flag Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 190 +- drivers/net/ethernet/apm

[PATCH v3 0/5] drivers: net: xgene: Fix 1G hot-plug and module support

2016-06-06 Thread Iyappan Subramanian
: Iyappan Subramanian Tested-by: Matthias Brugger --- v3: Address review comments from v2 - Add comment about hardware clock reset sequence on xgene_mdio_reset v2: Address review comments from v1 - Fixed patch 1 compilation error - Fixed mdio@1f61 xge0clk reference

[PATCH v3 4/5] dtb: xgene: Add MDIO node

2016-06-06 Thread Iyappan Subramanian
Added mdio node for mdio driver. Also added phy-handle reference to the ethernet nodes. Removed unused mdio subnode within storm menet ethernet node. Removed unused clock node from storm sgenet1. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias

[PATCH v3 5/5] drivers: net: xgene: Fix module load/unload crash

2016-06-06 Thread Iyappan Subramanian
tting irq_name before calling request_irq. - Calling dev_close() within remove - Added shutdown callback - Changed to use dmam_ APIs Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c

[PATCH v3 3/5] drivers: net: phy: Add MDIO driver

2016-06-06 Thread Iyappan Subramanian
er to manage MDIO bus. This driver registers the mdio bus and registers the PHYs connected to it. Signed-off-by: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/Kconfig | 1 + drivers/net/phy/Kc

[PATCH v3 2/5] drivers: net: xgene: Backward compatibility with older firmware

2016-06-06 Thread Iyappan Subramanian
: Iyappan Subramanian Tested-by: Fushen Chen Tested-by: Toan Le Tested-by: Matthias Brugger --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 60 +++- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 165 +++--- drivers/net/ethernet/apm/xgene/xgene_enet_main.h | 2

  1   2   3   >