resend [PATCH 2/5 2.6.21] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-05-26 Thread James Chapman
sockaddr_pppox for binary compatibility. Also add a PPPIOCGL2TPSTATS ioctl to allow userspace to obtain L2TP counters and state from the kernel. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21/include/linux/if_ppp.h

resend [PATCH 5/5 2.6.21] L2TP: Add PPPoL2TP in-kernel documentation

2007-05-26 Thread James Chapman
Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21/Documentation/networking/l2tp.txt === --- /dev/null +++ linux-2.6.21/Documentation/networking/l2tp.txt @@ -0,0 +1,167 @@ +This brief document describes how to use

resend [PATCH 4/5 2.6.21] L2TP: Add PPPoL2TP maintainer

2007-05-26 Thread James Chapman
Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21/MAINTAINERS === --- linux-2.6.21.orig/MAINTAINERS +++ linux-2.6.21/MAINTAINERS @@ -2700,6 +2700,11 @@ P: Michal Ostrowski M: [EMAIL PROTECTED] S

resend [PATCH 1/5 2.6.21] UDP: Introduce UDP encapsulation type for L2TP

2007-05-26 Thread James Chapman
more work when CONFIG_XFRM is not defined. Signed-off-by: James Chapman [EMAIL PROTECTED] --- There are some magic numbers returned by udp_encap_rcv() that should perhaps now be made #defines. I chose not to do so in this patch. Index: linux-2.6.21/include/linux/udp.h

L2TP driver review

2007-06-03 Thread James Chapman
, this L2TP driver needs to be accepted... Thanks -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development Original Message Subject: resend [PATCH 0/5 2.6.21] L2TP: Introduce PPP-over-L2TP driver Date: Sat, 26 May 2007 18:46:24

[PATCH 0/5 2.6.22-rc6] L2TP: Introduce PPP-over-L2TP driver

2007-06-27 Thread James Chapman
in-kernel documentation. The driver is being used on x86, ia64, ppc, arm, mips32 and possibly other architectures. It is also known to work on multi-core SMP boxes. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe

[PATCH 1/5 2.6.22-rc6] UDP: Introduce UDP encapsulation type for L2TP

2007-06-27 Thread James Chapman
when CONFIG_XFRM is not defined. Signed-off-by: James Chapman [EMAIL PROTECTED] --- This mechanism could now be used by any protocol encapsulated in UDP since the encap_rcv funcptr could be set to point to a protocol-specific encap_rcv function. Should UDP_ENCAP_L2TPINUDP be something like

[PATCH 2/5 2.6.22-rc6] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-06-27 Thread James Chapman
sockaddr_pppox for binary compatibility. Also add a PPPIOCGL2TPSTATS ioctl to allow userspace to obtain L2TP counters and state from the kernel. Add new if_pppol2tp.h header. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.22-rc6/include/linux/if_ppp.h

[PATCH 4/5 2.6.22-rc6] L2TP: Add PPPoL2TP maintainer

2007-06-27 Thread James Chapman
Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.22-rc6/MAINTAINERS === --- linux-2.6.22-rc6.orig/MAINTAINERS +++ linux-2.6.22-rc6/MAINTAINERS @@ -2903,6 +2903,11 @@ P: Michal Ostrowski M: [EMAIL PROTECTED

[PATCH 5/5 2.6.22-rc6] L2TP: Add PPPoL2TP in-kernel documentation

2007-06-27 Thread James Chapman
Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.22-rc6/Documentation/networking/l2tp.txt === --- /dev/null +++ linux-2.6.22-rc6/Documentation/networking/l2tp.txt @@ -0,0 +1,169 @@ +This brief document describes how

Re: [PATCH 1/5 2.6.22-rc6] UDP: Introduce UDP encapsulation type for L2TP

2007-06-28 Thread James Chapman
bounced. Hint taken though. :) I'll implement it if I can find some time. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

Re: [PATCH 2/5 2.6.22-rc6] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-06-28 Thread James Chapman
platforms and thus you won't need to provide s compat ioctl() handler for your statistics ioctl(). Thanks for the info. I wasn't aware of aligned_u64. I'll make this change for you so we don't have to go back and forth again just for this. Thanks! -- James Chapman Katalix Systems Ltd http

Re: e1000: backport ich9 support from 7.5.5 ?

2007-06-30 Thread James Chapman
it needed to support the specific device(s) present. BTW, since you're doing a major update, would it be a good time to switch to phylib to manage your PHYs? -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from

Re: e1000: backport ich9 support from 7.5.5 ?

2007-07-01 Thread James Chapman
Kok, Auke wrote: James Chapman wrote: I briefly looked over your new driver. I think it might benefit by moving common parts into one or more libraries (or modules) and have separate chip-specific drivers for 82540, 82541, 82542, 82543, 82571 etc. Put all the chip-specific bits in a chip

[PATCH net-2.6.23] UDP: Cleanup UDP encapsulation code

2007-07-05 Thread James Chapman
in udp_mib_indatagrams. Previously they weren't counted. Make xfrm4_rcv_encap() static since it is no longer called externally. Signed-off-by: James Chapman [EMAIL PROTECTED] --- Tested with L2TP and L2TP/IPsec. The registered UDP encap handler returns 0 when the skb is to be discarded. Original code from

[PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code

2007-07-05 Thread James Chapman
. Signed-off-by: James Chapman [EMAIL PROTECTED] --- Tested with L2TP and L2TP/IPsec. Update after comments from Patrick. Fix encapsulated transport mode case and remove stupid file history comment change. include/net/xfrm.h |5 +- net/ipv4/udp.c | 156

Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code

2007-07-05 Thread James Chapman
have to derive the encap_type from encap_rcv funcptr values, which would be messy. I think it might complicate the logic in ESP too. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line

Re: Multiqueue and virtualization WAS(Re: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

2007-07-06 Thread James Chapman
for virtualization. I've seen some boxes with thousands of net devices (mostly ppp, but also some ATM). It would be nice to be able to assign a tag to an arbitrary set of devices. Does the network namespace stuff help with any of this? -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts

Re: RFR: New e1000 driver (e1000new), was: Re: e1000: backport ich9 support from 7.5.5 ?

2007-07-07 Thread James Chapman
IDs in each driver. For the initial version, support just one device - more can be added later. The important thing is to get the structure right in the initial version. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-07 Thread James Chapman
time to restructure the new driver to make sure it is right for the future. I agree with Jeff that the initial version of the new driver should have only essential features - bells and whistles can be added incrementally. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts

Re: Splitting e1000 (Was: Re: e1000: backport ich9 support from 7.5.5 ?)

2007-07-08 Thread James Chapman
to get the same scrutiny, and if they did would be tarred and feathered. Auke has already posted an early snapshot, archived here: http://marc.info/?l=linux-netdevm=118315951209350w=3 Jeff and I have already commented on the code. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts

Re: RFR: New e1000 driver (e1000new), was: Re: e1000: backport ich9 support from 7.5.5 ?

2007-07-08 Thread James Chapman
James Chapman wrote: I envisage something like this:- e1000_core.c- common code used by all drivers of the e1000 family. Exports functions used by actual drivers. Loadable as a separate module when built as a module. e1000_82541.c- driver for 82541 e1000_82542.c

Re: mv643xx(2/20): use MII library for PHY management

2005-08-24 Thread James Chapman
the MII library code rather than writing local driver support code. It is also useful to make the actual MII registers available to the user with maskable kernel printk messages so the MII registers are being read anyway Signed-off-by: James Chapman [EMAIL PROTECTED] Acked-by: Dale Farnsworth [EMAIL

[PATCH 3/5 2.6.21-rc4] l2tp: pppox protocol module load

2007-03-23 Thread James Chapman
[PPPOL2TP]: Add the ability to autoload a pppox protocol module. This patch allows a name pppox-proto-nnn to be used in modprobe.conf to autoload a driver for PPPoX protocol nnn. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc4/drivers/net/pppox.c

[PATCH 4/5 2.6.21-rc4] l2tp: pppol2tp kbuild changes

2007-03-23 Thread James Chapman
[PPPOL2TP]: Modify kbuild for the new pppol2tp driver. This patch adds a new config option, CONFIG_PPPOL2TP and adds if_pppol2tp.h to the list of exported headers. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc4/drivers/net/Kconfig

[PATCH 5/5 2.6.21-rc4] l2tp: add pppol2tp maintainer

2007-03-23 Thread James Chapman
[PPPOL2TP]: Update maintainers file for PPP over L2TP. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc4/MAINTAINERS === --- linux-2.6.21-rc4.orig/MAINTAINERS +++ linux-2.6.21-rc4/MAINTAINERS @@ -2700,6 +2700,11

Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

2007-03-24 Thread James Chapman
you think needs to be updated? Thanks -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

2007-03-25 Thread James Chapman
Hi Patrick, Thanks for your comments so far. More questions below. Patrick McHardy wrote: James Chapman wrote: Patrick McHardy wrote: The interaction with UDP sockets looks pretty horrible IMO. On the send side I don't see why you can't simply build the UDP header yourself instead of doing

Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

2007-03-25 Thread James Chapman
Patrick McHardy wrote: James Chapman wrote: [PPPOL2TP]: Add PPP-over-L2TP driver core. A couple more comments: - seq_file handling doesn't check seq_printf return values ack and tries to dump the entire hash table at once, which might exceed the available room. I thought

[PATCH 0/5 2.6.21-rc7] l2tp: introduce PPP over L2TP driver

2007-04-23 Thread James Chapman
an entry to MAINTAINERS file. The driver is being used on x86, ia64, ppc, arm, mips32 and possibly other architectures. It is also known to work on multi-core SMP boxes. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development

[PATCH 2/5 2.6.21-rc7] l2tp: pppol2tp changes to existing ppp kernel headers

2007-04-23 Thread James Chapman
[L2TP]: Modify kernel headers for L2TP. This patch adds L2TP definitions to existing PPP and socket headers. Signed-off-by: James Chapman [EMAIL PROTECTED] --- Add struct sockaddr_pppol2tp to carry L2TP-specific address information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't use

[PATCH 3/5 2.6.21-rc7] skb: introduce skb_queue_walk_safe()

2007-04-23 Thread James Chapman
[SKB]: Introduce skb_queue_walk_safe() This patch provides a method for walking skb lists while inserting or removing skbs from the list. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc7/include/linux/skbuff.h

[PATCH 0/5 2.6.21-rc7] l2tp: introduce PPP over L2TP driver

2007-04-23 Thread James Chapman
an entry to MAINTAINERS file. The driver is being used on x86, ia64, ppc, arm, mips32 and possibly other architectures. It is also known to work on multi-core SMP boxes. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development

[PATCH 1/5 2.6.21-rc7] skb: introduce skb_queue_walk_safe()

2007-04-23 Thread James Chapman
[SKB]: Introduce skb_queue_walk_safe() This patch provides a method for walking skb lists while inserting or removing skbs from the list. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc7/include/linux/skbuff.h

[PATCH 2/5 2.6.21-rc7] l2tp: pppol2tp changes to existing ppp kernel headers

2007-04-23 Thread James Chapman
[L2TP]: Modify kernel headers for L2TP. This patch adds L2TP definitions to existing PPP and socket headers. Signed-off-by: James Chapman [EMAIL PROTECTED] --- Add struct sockaddr_pppol2tp to carry L2TP-specific address information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't use

[PATCH 4/5 2.6.21-rc7] l2tp: pppox protocol module load

2007-04-23 Thread James Chapman
[L2TP]: Add the ability to autoload a pppox protocol module. This patch allows a name pppox-proto-nnn to be used in modprobe.conf to autoload a PPPoX protocol nnn. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc7/drivers/net/pppox.c

[PATCH 5/5 2.6.21-rc7] l2tp: add pppol2tp maintainer

2007-04-23 Thread James Chapman
[L2TP]: Update maintainers file for PPP over L2TP. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21-rc7/MAINTAINERS === --- linux-2.6.21-rc7.orig/MAINTAINERS +++ linux-2.6.21-rc7/MAINTAINERS @@ -2709,6 +2709,11

Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

2007-04-24 Thread James Chapman
Patrick McHardy wrote: James Chapman wrote: +static void pppol2tp_recv_dequeue(struct pppol2tp_session *session) +{ + struct sk_buff *skb; + struct sk_buff *tmp; + + /* If the pkt at the head of the queue has the nr that we +* expect to send up next, dequeue it and any

Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

2007-04-26 Thread James Chapman
Patrick McHardy wrote: James Chapman wrote: Patrick McHardy wrote: Still the ugly old_data_ready/old_sk_destruct and pppol2tp_fget hacks. I added comments in the code about why I think pppol2tp_fget is needed. This driver handles PPP-over-L2TP sockets. These are attached to a plain UDP

[PATCH 0/5 2.6.21] L2TP: Introduce PPP-over-L2TP driver

2007-04-30 Thread James Chapman
applied skb_queue_walk_safe patch. 4 - Add an entry to MAINTAINERS file for this driver. 5 - Add in-kernel documentation. The driver is being used on x86, ia64, ppc, arm, mips32 and possibly other architectures. It is also known to work on multi-core SMP boxes. -- James Chapman Katalix Systems

[PATCH 1/5 2.6.21] UDP: Introduce UDP encapsulation type for L2TP

2007-04-30 Thread James Chapman
more work when CONFIG_XFRM is not defined. Signed-off-by: James Chapman [EMAIL PROTECTED] --- There are some magic numbers returned by udp_encap_rcv() that should perhaps now be made #defines. I chose not to do so in this patch. Index: linux-2.6.21/include/linux/udp.h

[PATCH 4/5 2.6.21] L2TP: Add PPPoL2TP maintainer

2007-04-30 Thread James Chapman
Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21/MAINTAINERS === --- linux-2.6.21.orig/MAINTAINERS +++ linux-2.6.21/MAINTAINERS @@ -2700,6 +2700,11 @@ P: Michal Ostrowski M: [EMAIL PROTECTED] S

[PATCH 2/5 2.6.21] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-04-30 Thread James Chapman
sockaddr_pppox for binary compatibility. Also add a PPPIOCGL2TPSTATS ioctl to allow userspace to obtain L2TP counters and state from the kernel. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21/include/linux/if_ppp.h

[PATCH 5/5 2.6.21] L2TP: Add PPPoL2TP in-kernel documentation

2007-04-30 Thread James Chapman
Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21/Documentation/networking/l2tp.txt === --- /dev/null +++ linux-2.6.21/Documentation/networking/l2tp.txt @@ -0,0 +1,167 @@ +This brief document describes how to use

L2TP support?

2007-03-22 Thread James Chapman
been kept up to date with the current kernel so could be submitted again if people want it. I didn't want to repost it without revisiting the above thread first though... :) Shall I post the patch? -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux

Re: L2TP support?

2007-03-22 Thread James Chapman
Hi Ingo, Ingo Oeser wrote: Hi James, James Chapman schrieb: Is there interest in adding L2TP support? Yes, if there is also a user space part somewhere. Yes there is. There's a pppd plugin which comes with the openl2tp project, http://sf.net/projects/openl2tp. OpenL2TP supports both LAC

[PATCH 2.6.23-rc1] PPPOL2TP: Add CONFIG_INET Kconfig dependency

2007-07-30 Thread James Chapman
[PPPOL2TP]: Add CONFIG_INET Kconfig dependency. PPPOL2TP uses UDP so it obviously depends on CONFIG_INET. Signed-off-by: James Chapman [EMAIL PROTECTED] --- Toralf Foerster reported that make rndconfig failed in 2.6.23-rc1 when selecting CONFIG_PPPOL2TP without CONFIG_INET. Index: linux

Re: RFC: issues concerning the next NAPI interface

2007-08-24 Thread James Chapman
and network device phy internal loopback could be developed? -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: RFC: issues concerning the next NAPI interface

2007-08-26 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Fri, 24 Aug 2007 18:16:45 +0100 Does hardware interrupt mitigation really interact well with NAPI? It interacts quite excellently. If NAPI disables interrupts and keeps them disabled while there are more packets arriving

Re: RFC: issues concerning the next NAPI interface

2007-08-27 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Sun, 26 Aug 2007 20:36:20 +0100 David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Fri, 24 Aug 2007 18:16:45 +0100 Does hardware interrupt mitigation really interact well with NAPI? It interacts quite excellently

Re: RFC: issues concerning the next NAPI interface

2007-08-27 Thread James Chapman
Jan-Bernd Themann wrote: On Monday 27 August 2007 17:51, James Chapman wrote: In the second half of my previous reply (which seems to have been deleted), I suggest a way to avoid this problem without using hardware interrupt mitigation / coalescing. Original text is quoted below. I've

[PATCH net-2.6.24] e100: fix driver init lockup on e100_up()

2007-08-27 Thread James Chapman
is being used. Signed-off-by: James Chapman [EMAIL PROTECTED] diff --git a/drivers/net/e100.c b/drivers/net/e100.c index e25f5ec..48996a4 100644 --- a/drivers/net/e100.c +++ b/drivers/net/e100.c @@ -2575,11 +2575,12 @@ static int __devinit e100_probe(struct pci_dev *pdev, strncpy(netdev

Re: [E1000-devel] [PATCH net-2.6.24] e100: fix driver init lockup on e100_up()

2007-08-27 Thread James Chapman
Kok, Auke wrote: James Chapman wrote: Recent NAPI changes require that napi_enable() is always matched with a napi_disable(). This patch makes sure that this invariant holds for e100. It also moves the netif_napi_add() call until after private pointers have been intialized, though this might

Re: RFC: issues concerning the next NAPI interface

2007-08-27 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 16:51:29 +0100 To implement this, there's no need for timers, hrtimers or generic NAPI support that others have suggested. A driver's poll() would set an internal flag and record the current jiffies value when

Re: [E1000-devel] [PATCH net-2.6.24] e100: fix driver init lockup on e100_up()

2007-08-28 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 22:03:15 +0100 Kok, Auke wrote: James Chapman wrote: nic = netdev_priv(netdev); -netif_napi_add(netdev, nic-napi, e100_poll, E100_NAPI_WEIGHT); nic-netdev = netdev; nic-pdev = pdev; nic

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Mon, 27 Aug 2007 22:41:43 +0100 I don't recall saying anything in previous posts about this. Are you confusing my posts with Jan-Bernd's? Yes, my bad. Jan-Bernd has been talking about using hrtimers to _reschedule_ NAPI. My

Re: RFC: issues concerning the next NAPI interface

2007-08-28 Thread James Chapman
Jan-Bernd Themann wrote: On Tuesday 28 August 2007 11:22, James Chapman wrote: So in this scheme what runs -poll() to process incoming packets? The hrtimer? No, the regular NAPI networking core calls -poll() as usual; no timers are involved. This scheme simply delays the napi_complete() from

Re: [E1000-devel] [PATCH net-2.6.24] e100: fix driver init lockup on e100_up()

2007-08-28 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Tue, 28 Aug 2007 09:22:36 +0100 I like this idea. A quick survey of other NAPI drivers doesn't show any that do an explicit napi_disable() at init, though they might do so from internal functions. Each driver would need

Re: malformed captured packets

2007-08-29 Thread James Chapman
with previous kernels? What is the network topology related to the DSL interface? -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: RFC: issues concerning the next NAPI interface

2007-08-29 Thread James Chapman
think? -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: malformed captured packets

2007-08-30 Thread James Chapman
Toralf Förster wrote: Am Mittwoch, 29. August 2007 schrieb James Chapman: Can you provide more information about the problem, please? Are you using a simple DSL modem with PPPoE, such that the ppp0 interface is that of the pppd started by a local PPPoE server? Is this a problem only

Re: 82557/8/9 Ethernet Pro 100 interrupt mitigation support

2007-09-03 Thread James Chapman
to use NAPI? Or is this an orthogonal feature? Use NAPI. The e100 driver has been NAPI-only for a while. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread James Chapman
it for comment. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

2007-09-05 Thread James Chapman
jamal wrote: On Wed, 2007-05-09 at 13:03 +0100, James Chapman wrote: I have a patch that solves the high interrupt rate problem by keeping the driver in polled mode longer. It's written for the latest NAPI version that DaveM posted recently. I'll try to get some time to write it up and post

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-06 Thread James Chapman
like CONFIG_PREEMPT, CONFIG_HIGH_RES_TIMER, CONFIG_HZ and maybe even bogomips / nr_cpus. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-06 Thread James Chapman
Stephen Hemminger wrote: On Thu, 06 Sep 2007 16:30:30 +0100 James Chapman [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: What about the latency that NAPI imposes? Right now there are certain applications that don't like NAPI because it add several more microseconds, and this may make

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-07 Thread James Chapman
not. I agree. I'm leaning towards a new ethtool parameter to control this to be consistent with other per-device tunables. imho, the work should definately be pursued further:) Thanks Mandeep. I'll try. :) -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-07 Thread James Chapman
jamal wrote: On Thu, 2007-06-09 at 15:16 +0100, James Chapman wrote: First, do we need to encourage consistency in NAPI poll drivers? not to stiffle the discussion, but Stephen Hemminger is planning to write a new howto; that would be a good time to bring up the topic. The challenge

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-10 Thread James Chapman
feedback. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-10 Thread James Chapman
processing. Is it better to give other runnable tasks a fair chunk of the cpu pie? I think so. I'll try to incorporate application cpu load into my tests. Thanks for your feedback. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-10 Thread James Chapman
Andi Kleen wrote: James Chapman [EMAIL PROTECTED] writes: On some platforms the precise timers (like ktime_get()) can be slow, but often they are fast. It might make sense to use a shorter constant time wait on those with fast timers at least. Right now this cannot be known by portable code

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-10 Thread James Chapman
. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ipconfig.c: De-clutter IP configuration report

2007-09-11 Thread James Chapman
the parameters available to userspace for use by boot scripts etc. A proc file listing variables and values in /bin/sh syntax would be easy to use. I've been meaning to do this for ages so I'll roll a patch. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded

Re: [PATCH] Fix e100 on systems that have cache incoherent DMA

2007-09-12 Thread James Chapman
on a test system to fire packets at the embedded system at max rate? Also test what happens when you fire packets in both directions simultaneously. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread James Chapman
whether it will be useful to offer NAPI idle polling as an _option_. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread James Chapman
Stephen Hemminger wrote: On Wed, 12 Sep 2007 14:50:01 +0100 James Chapman [EMAIL PROTECTED] wrote: By low traffic, I assume you mean a rate at which the NAPI driver doesn't stay in polled mode. The problem is that that rate is getting higher all the time, as interface and CPU speeds increase

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Thu, 6 Sep 2007 15:16:00 +0100 First, do we need to encourage consistency in NAPI poll drivers? A survey of current NAPI drivers shows different strategies being used in their poll(). Some such as r8169 do the napi_complete

Re: e1000 driver and samba

2007-09-15 Thread James Chapman
: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send

Re: [PATCH 1/3] [PPP] L2TP: Disallow non-UDP datagram sockets

2007-09-18 Thread James Chapman
Herbert Xu wrote: [PPP] L2TP: Disallow non-UDP datagram sockets With the addition of UDP-Lite we need to refine the socket check so that only genuine UDP sockets are allowed through. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Acked-by: James Chapman [EMAIL PROTECTED] - To unsubscribe from

Re: [PATCH 2/3] [PPP] L2TP: Fix skb handling in pppol2tp_recv_core

2007-09-18 Thread James Chapman
already been performed by the UDP layer. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Acked-by: James Chapman [EMAIL PROTECTED] -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-18 Thread James Chapman
don't apply this patch for now. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[PATCH net-2.6.24] [L2TP] Fix lockup introduced by recent changes

2007-09-18 Thread James Chapman
the skb. Signed-off-by: James Chapman [EMAIL PROTECTED] Index: net-2.6.24/drivers/net/pppol2tp.c === --- net-2.6.24.orig/drivers/net/pppol2tp.c +++ net-2.6.24/drivers/net/pppol2tp.c @@ -1066,11 +1066,10 @@ static int pppol2tp_xmit(struct

Re: [PATCH 3/3] [PPP] L2TP: Fix skb handling in pppol2tp_xmit

2007-09-19 Thread James Chapman
Herbert Xu wrote: On Tue, Sep 18, 2007 at 09:19:33PM +0100, James Chapman wrote: This one causes my test system to lock up. I'll investigate. Please don't apply this patch for now. Sorry, I added a double-free on the skb after ip_queue_xmit. Please try this one instead. - /* Free

[PATCH 2.6.23] [PPP]: L2TP: Fix oops in transmit and receive paths

2007-11-05 Thread James Chapman
ip_queue_xmit() needs it. Signed-off-by: James Chapman [EMAIL PROTECTED] --- This patch is for stable 2.6.23 fixes and the mainline. Index: linux-2.6.23-l2tp/drivers/net/pppol2tp.c === --- linux-2.6.23-l2tp.orig/drivers/net/pppol2tp.c

Re: NAPI poll behavior in various Intel drivers

2008-01-04 Thread James Chapman
more than receiving, it will exit polled mode on every poll. I noticed this while trying to work on a generic fix for the -poll() does not exit when device is brought down while being bombed with packets bug. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your

Re: NAPI poll behavior in various Intel drivers

2008-01-04 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Fri, 04 Jan 2008 20:10:30 + With the latest NAPI, this code has to change. But rather than remove the tx_cleaned logic completely, shouldn't transmit processing be included in the work_done accounting when a driver does

Re: questions on NAPI processing latency and dropped network packets

2008-01-10 Thread James Chapman
/net/core/netdev_max_backlog is set to the default of 300 So...anyone have any ideas/suggestions? Thanks, Chris -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

2008-02-05 Thread James Chapman
Acked-by: James Chapman [EMAIL PROTECTED] Rami Rosen wrote: Hi, When CONFIG_PROC_FS is not set and CONFIG_PPPOL2TP is set, we have the following warning in build: drivers/net/pppol2tp.c: In function 'pppol2tp_init': drivers/net/pppol2tp.c:2472: warning: label 'out_unregister_pppox_proto

Re: [patch 7/7] pppol2tp: fix printk warnings

2008-02-08 Thread James Chapman
: warning: long long unsigned int format, __u64 arg (arg 10) Not all platforms implement u64 with unsigned long long. eg: powerpc. Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Acked-by: James Chapman [EMAIL PROTECTED] -- James Chapman Katalix Systems Ltd http

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread James Chapman
Jarek Poplawski wrote: James Chapman wrote, On 02/11/2008 10:22 AM: Fix locking issues in the pppol2tp driver which can cause a kernel crash on SMP boxes when hundreds of L2TP sessions are created/deleted simultaneously (ISP environment). The driver was violating read_lock() and write_lock

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread James Chapman
Jarek Poplawski wrote: On Mon, Feb 11, 2008 at 11:49:24PM +0100, Jarek Poplawski wrote: On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: ... Below is example output from lockdep. The oops is reproducible when creating/deleting lots of sessions while passing data. The lock

[PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread James Chapman
functions. Signed-off-by: James Chapman [EMAIL PROTECTED] -- This patch has been verified by the ISP that discovered the problem. If the patch is accepted, it should be pushed to the stable 2.6.23 and 2.6.24 trees. Index: linux-2.6.24/drivers/net/pppol2tp.c

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-11 Thread James Chapman
Jarek Poplawski wrote: On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: ... Below is example output from lockdep. The oops is reproducible when creating/deleting lots of sessions while passing data. The lock is being acquired for read and write in softirq contexts

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-12 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 23:41:18 + Jarek Poplawski wrote: On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: ... Below is example output from lockdep. The oops is reproducible when creating/deleting lots of sessions

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-19 Thread James Chapman
David Miller wrote: From: James Chapman [EMAIL PROTECTED] Date: Mon, 18 Feb 2008 22:09:24 + Here's a new version of the patch. The patch avoids disabling irqs and fixes the sk_dst_get() usage that DaveM mentioned. But even with this patch, lockdep still complains if hundreds of ppp

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-19 Thread James Chapman
Jarek Poplawski wrote: On Mon, Feb 18, 2008 at 10:09:24PM +, James Chapman wrote: Jarek Poplawski wrote: Hi, It seems, this nice report is still uncomplete: could you check if there could have been something more yet? Unfortunately the ISP's syslog stops. But I've been able to borrow two

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-20 Thread James Chapman
Jarek Poplawski wrote: On Mon, Feb 18, 2008 at 10:09:24PM +, James Chapman wrote: ... Unfortunately the ISP's syslog stops. But I've been able to borrow two Quad Xeon boxes and have reproduced the problem. Here's a new version of the patch. The patch avoids disabling irqs and fixes

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-20 Thread James Chapman
). I'll look over it. I think I need to take a step back and look at what's happening in more detail though. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development Feb 20 22:11:41 localhost kernel: = Feb

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-21 Thread James Chapman
Jarek Poplawski wrote: On Wed, Feb 20, 2008 at 10:37:57PM +, James Chapman wrote: Jarek Poplawski wrote: (testing patch #1) But I hope you tested with the fixed (take 2) version of this patch... Yes I did. :) But I just got another lockdep error (attached). Since it's quite

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-25 Thread James Chapman
except these other changes in pppol2tp_xmit). I did this and all lockdep errors have now gone. Tests ran all weekend. See attached patch. Is this an acceptable solution? If so, I'll prepare and send official patches. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts

  1   2   3   >