Re: TSN Scorecard, was Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

Hi, On 09/19/2017 10:49 PM, Richard Cochran wrote: (...) > > No, that is not what I meant. We need some minimal additional kernel > support in order to fully implement the TSN family of standards. Of > course, the bulk will have to be done in user space. It would be a > mistake to cram the

Re: [next-queue PATCH v3 2/4] net/sched: Fix accessing invalid dev_queue

Hi, On 10/03/2017 08:47 PM, Eric Dumazet wrote: > On Tue, 2017-10-03 at 16:44 -0700, Vinicius Costa Gomes wrote: >> From: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> >> >> In qdisc_alloc() the dev_queue pointer was used without any checks being >>

Re: [next-queue PATCH v2 2/5] net/sched: Fix accessing invalid dev_queue

Hi, On 09/30/2017 05:22 PM, Cong Wang wrote: > On Fri, Sep 29, 2017 at 5:26 PM, Vinicius Costa Gomes > <vinicius.go...@intel.com> wrote: >> From: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> >> >> In qdisc_alloc() the dev_queue pointer was used w

Re: [next-queue PATCH 2/3] net/sched: Introduce Credit Based Shaper (CBS) qdisc

Hi, On 09/27/2017 02:14 PM, Vinicius Costa Gomes wrote: > Hi, > > Cong Wang writes: > >> On Tue, Sep 26, 2017 at 4:39 PM, Vinicius Costa Gomes >> wrote: >>> +static int cbs_init(struct Qdisc *sch, struct nlattr *opt) >>> +{ >>> +

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

Hi Richard, On 09/01/2017 06:03 AM, Richard Cochran wrote: > > I happy to see this posted. At first glance, it seems like a step in > the right direction. > > On Thu, Aug 31, 2017 at 06:26:20PM -0700, Vinicius Costa Gomes wrote: >> * Time-aware shaper (802.1Qbv): > ... >>S 0x01 300 >>

Re: [next-queue PATCH v6 3/5] net/sched: Introduce Credit Based Shaper (CBS) qdisc

s primary usage is to apply some bandwidth reservation to user >> defined traffic classes, which are mapped to different queues via the >> mqprio qdisc. >> >> Only a simple software implementation is added for now. >> >> Signed-off-by: Vinicius Costa Gomes <

Re: [Intel-wired-lan] [next-queue PATCH v6 2/5] mqprio: Implement select_queue class_ops

Hi Alex, On 10/12/2017 08:21 AM, Alexander Duyck wrote: > On Wed, Oct 11, 2017 at 5:54 PM, Vinicius Costa Gomes > <vinicius.go...@intel.com> wrote: >> From: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> >> >> When replacing a child qdisc from

Re: [Intel-wired-lan] [next-queue PATCH v6 2/5] mqprio: Implement select_queue class_ops

On 10/12/2017 09:09 AM, Alexander Duyck wrote: > On Thu, Oct 12, 2017 at 8:59 AM, Jesus Sanchez-Palencia > <jesus.sanchez-palen...@intel.com> wrote: >> Hi Alex, >> >> >> On 10/12/2017 08:21 AM, Alexander Duyck wrote: >>> On Wed, Oct 11, 2017 at 5

Re: [net-next PATCH] mqprio: Reserve last 32 classid values for HW traffic classes and misc IDs

for (ntx = arg->skip; ntx < netdev_get_num_tc(dev); ntx++) { > + if (arg->fn(sch, ntx + TC_H_MIN_PRIORITY, arg) < 0) { > + arg->stop = 1; > + return; > + } > + arg->count++; > + } > + > + /* Pad the values and skip over unused traffic classes */ > + if (ntx < TC_MAX_QUEUE) { > + arg->count = TC_MAX_QUEUE; > + ntx = TC_MAX_QUEUE; > + } > + > + /* Reset offset, sort out remaining per-queue qdiscs */ > + for (ntx -= TC_MAX_QUEUE; ntx < dev->num_tx_queues; ntx++) { > if (arg->fn(sch, ntx + 1, arg) < 0) { > arg->stop = 1; > - break; > + return; > } > arg->count++; > } > Tested-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> Looks good. thanks, Jesus

Re: [PATCH RFC V1 net-next 0/6] Time based packet transmission

Hi Richard, On 09/18/2017 12:41 AM, Richard Cochran wrote: > This series is an early RFC that introduces a new socket option > allowing time based transmission of packets. This option will be > useful in implementing various real time protocols over Ethernet, > including but not limited to

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

Hi Richard, On 09/19/2017 10:25 PM, Richard Cochran wrote: (...) > >> I have a question, what about a controller that doesn't provide a way to >> set a per-packet transmission time, but it supports Qbv/Qbu. What would >> be your proposal to configure it? > > SO_TXTIME will have a generic SW

[PATCH iproute2] man: Clarify idleslope calculation for tc-cbs

for further clarifications if needed. Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> --- man/man8/tc-cbs.8 | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/man/man8/tc-cbs.8 b/man/man8/tc-cbs.8 index 97e00c84..32e1e0d4 100644 --- a/man/man8/

Re: [PATCH v1 net-next 14/14] net/sched: Make etf report drops on error_queue

Hi Willem, On 06/28/2018 07:27 AM, Willem de Bruijn wrote: (...) > >> struct sock_txtime { >> clockid_t clockid;/* reference clockid */ >> - u16 flags; /* bit 0: txtime in deadline_mode */ >> + u16 flags; /* bit 0:

Re: [PATCH v1 net-next 14/14] net/sched: Make etf report drops on error_queue

On 06/29/2018 11:49 AM, Willem de Bruijn wrote: diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c +static void report_sock_error(struct sk_buff *skb, u32 err, u8 code) +{ + struct sock_exterr_skb *serr; + ktime_t txtime = skb->tstamp; + +

[PATCH iproute2] man: Fix typos on tc-cbs

Signed-off-by: Jesus Sanchez-Palencia --- man/man8/tc-cbs.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/man8/tc-cbs.8 b/man/man8/tc-cbs.8 index 32e1e0d4..ad1d8821 100644 --- a/man/man8/tc-cbs.8 +++ b/man/man8/tc-cbs.8 @@ -28,7 +28,7 @@ defined rate limiting method

[PATCH v1 net-next 13/14] net/sched: Enforce usage of CLOCK_TAI for sch_etf

be necessary. For now, the qdisc will return EINVAL if any clocks other than CLOCK_TAI are used. Signed-off-by: Jesus Sanchez-Palencia --- net/sched/sch_etf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c index cd6cb5b69228..5514a8aa3bd5

[PATCH v1 net-next 09/14] igb: Only change Tx arbitration when CBS is on

can be enabled separately. That is achieved by moving the DataTranARB setup to igb_config_tx_modes() instead. Similarly, when disabling CBS we must check if it has been disabled for all queues, and clear the DataTranARB accordingly. Signed-off-by: Jesus Sanchez-Palencia --- drivers/net/ethernet

[PATCH v1 net-next 08/14] igb: Refactor igb_configure_cbs()

802.1Qav specifies, but the i210 datasheet refers to this set of functionality as "Qav Transmission Mode". Here we also perform a tiny refactor at is_any_cbs_enabled(), and add further documentation to igb_setup_tx_mode(). Signed-off-by: Jesus Sanchez-Palencia --- drivers/net/ethernet

[PATCH v1 net-next 03/14] net: ipv4: Hook into time based transmission

-by: Jesus Sanchez-Palencia --- include/net/inet_sock.h | 1 + net/ipv4/ip_output.c| 3 +++ net/ipv4/raw.c | 2 ++ net/ipv4/udp.c | 1 + 4 files changed, 7 insertions(+) diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index 83d5b3c2ac42..314be484c696 100644

[PATCH v1 net-next 14/14] net/sched: Make etf report drops on error_queue

.: ((__u64) serr->ee_data << 32) + serr->ee_info This feature is disabled by default and must be explicitly enabled by applications. Enabling it can bring some overhead for the Tx cycles of the application. Signed-off-by: Jesus Sanchez-Palencia --- include/linux/socket.h

[PATCH v1 net-next 07/14] net/sched: Add HW offloading capability to ETF

nchronized for this mode to behave as expected. Signed-off-by: Jesus Sanchez-Palencia --- include/net/pkt_sched.h| 5 +++ include/uapi/linux/pkt_sched.h | 1 + net/sched/sch_etf.c| 71 +- 3 files changed, 76 insertions(+), 1 deletion(-)

[PATCH v1 net-next 06/14] net/sched: Introduce the ETF Qdisc

the SO_TXTIME deadline mode. For this mode, it will dequeue a packet as soon as possible and change the skb timestamp to 'now' during etf_dequeue(). Signed-off-by: Jesus Sanchez-Palencia Signed-off-by: Vinicius Costa Gomes --- include/linux/netdevice.h | 1 + include/uapi/linux/pkt_sched.h

[PATCH v1 net-next 04/14] net: packet: Hook into time based transmission.

From: Richard Cochran For raw layer-2 packets, copy the desired future transmit time from the CMSG cookie into the skb. Signed-off-by: Richard Cochran Signed-off-by: Jesus Sanchez-Palencia --- net/packet/af_packet.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/packet

[PATCH v1 net-next 12/14] igb: Only call skb_tx_timestamp after descriptors are ready

amp() after the information has been copied into the DMA tx_ring. Signed-off-by: Jesus Sanchez-Palencia --- drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/

[PATCH v1 net-next 11/14] igb: Add support for ETF offload

this has been handled by the ETF qdisc already. Signed-off-by: Jesus Sanchez-Palencia --- .../net/ethernet/intel/igb/e1000_defines.h| 16 ++ drivers/net/ethernet/intel/igb/igb.h | 1 + drivers/net/ethernet/intel/igb/igb_main.c | 139 +++--- 3 files changed, 139

[PATCH v1 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

ure when tunnels are used. Signed-off-by: Jesus Sanchez-Palencia --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index b1f274f22d85..236802b35203 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -4898,7 +489

[PATCH v1 net-next 02/14] net: Add a new socket option for a future transmit time.

; u16 flags; }; Note that two new fields were added to struct sock by filling a 4-bytes hole found in the struct. For that reason, neither the struct size or number of cachelines were altered. Signed-off-by: Richard Cochran Signed-off-by: Jesus Sanchez-Palencia --- arch/alpha

[PATCH v1 net-next 00/14] Scheduled packet Transmission: ETF

chwork.ozlabs.org/cover/882342/ [2] github doesn't make it clear, but the gist can be cloned like this: $ git clone https://gist.github.com/jeez/bd3afeff081ba64a695008dd8215866f scheduled-tx-tests [3] https://github.com/jeez/linux/tree/etf-v1 [4] https://github.com/jeez/iproute2/tree/etf-v1 Je

[PATCH v1 net-next 05/14] net/sched: Allow creating a Qdisc watchdog with other clocks

From: Vinicius Costa Gomes This adds 'qdisc_watchdog_init_clockid()' that allows a clockid to be passed, this allows other time references to be used when scheduling the Qdisc to run. Signed-off-by: Vinicius Costa Gomes --- include/net/pkt_sched.h | 2 ++ net/sched/sch_api.c | 11

[PATCH v1 net-next 10/14] igb: Refactor igb_offload_cbs()

Split code into a separate function (igb_offload_apply()) that will be used by ETF offload implementation. Signed-off-by: Jesus Sanchez-Palencia --- drivers/net/ethernet/intel/igb/igb_main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/net

Re: [PATCH v1 net-next 02/14] net: Add a new socket option for a future transmit time.

Hi Eric, On 06/27/2018 03:16 PM, Eric Dumazet wrote: > > > On 06/27/2018 02:59 PM, Jesus Sanchez-Palencia wrote: >> From: Richard Cochran >> >> This patch introduces SO_TXTIME. User space enables this option in >> order to pass a desired future transmit time

[PATCH v1 iproute2 1/2] uapi pkt_sched: Add etf info - DO NOT COMMIT

This should come from the next uapi headers update. Sending it now just as a convenience so anyone can build tc with etf and taprio support. Signed-off-by: Jesus Sanchez-Palencia --- include/uapi/linux/pkt_sched.h | 66 ++ 1 file changed, 66 insertions(+) diff

[PATCH v1 iproute2 2/2] tc: Add support for the ETF Qdisc

[offload] [deadline_mode] Signed-off-by: Vinicius Costa Gomes Signed-off-by: Jesus Sanchez-Palencia --- tc/Makefile | 1 + tc/q_etf.c | 168 2 files changed, 169 insertions(+) create mode 100644 tc/q_etf.c diff --git a/tc/Makefile b/t

Re: [PATCH net-next 0/2] net: stmmac: Support DWMAC5 and TSN

Hi Jose, On 10/25/2017 07:02 AM, Jose Abreu wrote: > Hi, > > This adds support for a new IP version (5) of dwmac and for > TSN features as defined by IEEE802.1Qbv-2015 and IEEE802.1Qbu. Just out of curiosity, are you aware of any NICs that are publicly available which use this IP version?

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

Hi Jose, On 10/26/2017 03:08 AM, Jose Abreu wrote: > Hi Andrew, > > On 26-10-2017 10:03, Andrew Lunn wrote: >>> These parameters may also need to change in runtime depending on >>> the scheduled traffic. Unfortunately, net subsystem does not yet >>> support TSN so this will have to wait and for

Re: [RFC net-next 0/5] TSN: Add qdisc-based config interfaces for traffic shapers

Hi, On 10/19/2017 01:39 PM, Richard Cochran wrote: > On Wed, Oct 18, 2017 at 03:37:35PM -0700, Jesus Sanchez-Palencia wrote: >> I also did some tests with when you don't set valid launch times, but here >> using >> your idea from above, so with the driver calculating a valid

Re: [net-next 1/7] net/sched: Check for null dev_queue on create flow

Hi Davide, On 10/27/2017 03:23 AM, Davide Caratti wrote: > On Thu, 2017-10-26 at 10:17 -0700, Jeff Kirsher wrote: >> From: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> >> >> In qdisc_alloc() the dev_queue pointer was used without any checks >> being

[PATCH v2 net-next 09/14] igb: Refactor igb_configure_cbs()

802.1Qav specifies, but the i210 datasheet refers to this set of functionality as "Qav Transmission Mode". Here we also perform a tiny refactor at is_any_cbs_enabled(), and add further documentation to igb_setup_tx_mode(). Signed-off-by: Jesus Sanchez-Palencia --- drivers/net/ethernet

[PATCH v2 net-next 11/14] igb: Refactor igb_offload_cbs()

Split code into a separate function (igb_offload_apply()) that will be used by ETF offload implementation. Signed-off-by: Jesus Sanchez-Palencia --- drivers/net/ethernet/intel/igb/igb_main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/net

[PATCH v2 net-next 13/14] igb: Add support for ETF offload

this has been handled by the ETF qdisc already. Signed-off-by: Jesus Sanchez-Palencia --- .../net/ethernet/intel/igb/e1000_defines.h| 16 ++ drivers/net/ethernet/intel/igb/igb.h | 1 + drivers/net/ethernet/intel/igb/igb_main.c | 138 +++--- 3 files changed, 138

[PATCH v2 net-next 10/14] igb: Only change Tx arbitration when CBS is on

can be enabled separately. That is achieved by moving the DataTranARB setup to igb_config_tx_modes() instead. Similarly, when disabling CBS we must check if it has been disabled for all queues, and clear the DataTranARB accordingly. Signed-off-by: Jesus Sanchez-Palencia --- drivers/net/ethernet

[PATCH v2 net-next 08/14] net/sched: Add HW offloading capability to ETF

nchronized for this mode to behave as expected. Signed-off-by: Jesus Sanchez-Palencia --- include/net/pkt_sched.h| 5 +++ include/uapi/linux/pkt_sched.h | 1 + net/sched/sch_etf.c| 71 +- 3 files changed, 76 insertions(+), 1 deletion(-)

[PATCH v2 net-next 07/14] net/sched: Introduce the ETF Qdisc

til we decide to allow for other clockids to be used. The rationale here is that PTP times are usually in the TAI scale, thus no other clocks should be necessary. For now, the qdisc will return EINVAL if any clocks other than CLOCK_TAI are used. Signed-off-by: Jesus Sanchez-Palencia Signed-off-by: V

[PATCH v2 net-next 05/14] net: packet: Hook into time based transmission.

From: Richard Cochran For raw layer-2 packets, copy the desired future transmit time from the CMSG cookie into the skb. Signed-off-by: Richard Cochran Signed-off-by: Jesus Sanchez-Palencia --- net/packet/af_packet.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/packet

[PATCH v2 net-next 14/14] net/sched: Make etf report drops on error_queue

.: ((__u64) serr->ee_data << 32) + serr->ee_info This feature is disabled by default and must be explicitly enabled by applications. Enabling it can bring some overhead for the Tx cycles of the application. Signed-off-by: Jesus Sanchez-Palencia --- include/net/sock.h

[PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

ure when tunnels are used. Signed-off-by: Jesus Sanchez-Palencia --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 1357f36c8a5e..c4e24ac27464 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -4898,7 +489

[PATCH v2 net-next 04/14] net: ipv6: Hook into time based transmission

the sockcm_cookie as a parameter so we can just perform the copy at rawv6_send_hdrinc() directly. Signed-off-by: Jesus Sanchez-Palencia --- net/ipv6/ip6_output.c | 11 --- net/ipv6/raw.c| 7 +-- net/ipv6/udp.c| 1 + 3 files changed, 14 insertions(+), 5 deletions(-) diff --git

[PATCH v2 net-next 12/14] igb: Only call skb_tx_timestamp after descriptors are ready

amp() after the information has been copied into the Tx descriptors. Signed-off-by: Jesus Sanchez-Palencia --- drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/

[PATCH v2 net-next 06/14] net/sched: Allow creating a Qdisc watchdog with other clocks

From: Vinicius Costa Gomes This adds 'qdisc_watchdog_init_clockid()' that allows a clockid to be passed, this allows other time references to be used when scheduling the Qdisc to run. Signed-off-by: Vinicius Costa Gomes --- include/net/pkt_sched.h | 2 ++ net/sched/sch_api.c | 11

[PATCH v2 iproute2 2/2] tc: Add support for the ETF Qdisc

[offload] [deadline_mode] Signed-off-by: Vinicius Costa Gomes Signed-off-by: Jesus Sanchez-Palencia --- tc/Makefile | 1 + tc/q_etf.c | 168 2 files changed, 169 insertions(+) create mode 100644 tc/q_etf.c diff --git a/tc/Makefile b/t

[PATCH v2 iproute2 1/2] uapi pkt_sched: Add etf info - DO NOT COMMIT

This should come from the next uapi headers update. Sending it now just as a convenience so anyone can build tc with etf and taprio support. Signed-off-by: Jesus Sanchez-Palencia --- include/uapi/linux/pkt_sched.h | 21 + 1 file changed, 21 insertions(+) diff --git

[PATCH v2 net-next 02/14] net: Add a new socket option for a future transmit time.

-by: Jesus Sanchez-Palencia --- arch/alpha/include/uapi/asm/socket.h | 3 +++ arch/ia64/include/uapi/asm/socket.h | 3 +++ arch/mips/include/uapi/asm/socket.h | 3 +++ arch/parisc/include/uapi/asm/socket.h | 3 +++ arch/s390/include/uapi/asm/socket.h | 3 +++ arch/sparc/include/uapi/asm

[PATCH v2 net-next 00/14] Scheduled packet Transmission: ETF

82342/ [2] github doesn't make it clear, but the gist can be cloned like this: $ git clone https://gist.github.com/jeez/bd3afeff081ba64a695008dd8215866f scheduled-tx-tests [3] https://github.com/jeez/linux/tree/etf-v2 [4] https://github.com/jeez/iproute2/tree/etf-v2 Jesus Sanchez-Palencia (10): net:

[PATCH v2 net-next 03/14] net: ipv4: Hook into time based transmission

-by: Jesus Sanchez-Palencia --- include/net/inet_sock.h | 1 + net/ipv4/icmp.c | 2 ++ net/ipv4/ip_output.c| 3 +++ net/ipv4/ping.c | 1 + net/ipv4/raw.c | 2 ++ net/ipv4/udp.c | 1 + 6 files changed, 10 insertions(+) diff --git a/include/net/inet_sock.h b/include

[RFC iproute2] tc: Add support for the TBS Qdisc

From: Vinicius Costa Gomes The Time Based Scheduler (TBS) queueing discipline allows precise control of the transmission time of packets. The syntax is: tc qdisc add dev DEV parent NODE tbs delta clockid offload <1|0> Signed-off-by: Vinicius

[RFC v2 net-next 00/10] Time based packet transmission

deferring that to the next dequeue call? For last, most of the To Dos we still have before a final patchset are related to further testing the igb support: - testing with L2 only talkers + AF_PACKET sockets; - testing tbs in conjunction with cbs; Thanks, Jesus Jesus Sanchez-Palencia (4): igb

[RFC v2 net-next 03/10] net: ipv4: udp: Hook into time based transmission.

From: Richard Cochran <rcoch...@linutronix.de> For udp packets, copy the desired future transmit time from the CMSG cookie into the skb. Signed-off-by: Richard Cochran <rcoch...@linutronix.de> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> ---

[RFC v2 net-next 05/10] net/sched: Allow creating a Qdisc watchdog with other clocks

From: Vinicius Costa Gomes This adds 'qdisc_watchdog_init_clockid()' that allows a clockid to be passed, this allows other time references to be used when scheduling the Qdisc to run. Signed-off-by: Vinicius Costa Gomes ---

[RFC v2 net-next 02/10] net: ipv4: raw: Hook into time based transmission.

From: Richard Cochran <rcoch...@linutronix.de> For raw packets, copy the desired future transmit time from the CMSG cookie into the skb. Signed-off-by: Richard Cochran <rcoch...@linutronix.de> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> --- net/ip

[RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

re its transmission time. When offloading is disabled, the network adapter will ignore the sk_buff time stamp, and so, the transmission time will be only "best effort" from the Qdisc. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> Signed-off-by: Jesus Sanchez-Palenci

[RFC v2 net-next 04/10] net: packet: Hook into time based transmission.

From: Richard Cochran <rcoch...@linutronix.de> For raw layer-2 packets, copy the desired future transmit time from the CMSG cookie into the skb. Signed-off-by: Richard Cochran <rcoch...@linutronix.de> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com&g

[RFC v2 net-next 10/10] igb: Add support for TBS offload

this has been handled by the TBS qdisc already. Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> --- drivers/net/ethernet/intel/igb/e1000_defines.h | 16 +++ drivers/net/ethernet/intel/igb/igb.h | 1 + drivers/net/ethernet/intel/igb/igb_main.c

[RFC v2 net-next 08/10] igb: Only change Tx arbitration when CBS is on

can be enabled separately. That is achieved by moving the DataTranARB setup to igb_config_tx_modes() instead. Similarly, when disabling CBS we must check if it has been disabled for all queues, and clear the DataTranARB accordingly. Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-pa

[RFC v2 net-next 09/10] igb: Refactor igb_offload_cbs()

Split code into a separate function (igb_offload_apply()) that will be used by TBS offload implementation. Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 23 ++- 1 file changed, 14 insertions

[RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

later on. Signed-off-by: Richard Cochran <rcoch...@linutronix.de> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> --- arch/alpha/include/uapi/asm/socket.h | 3 +++ arch/frv/include/uapi/asm/socket.h | 3 +++ arch/ia64/include/uapi/asm/socket.h| 3 +++ arch

[RFC v2 net-next 07/10] igb: Refactor igb_configure_cbs()

802.1Qav specifies, but the i210 datasheet refers to this set of functionality as "Qav Transmission Mode". Here we also perform a tiny refactor at is_any_cbs_enabled(), and add further documentation to igb_setup_tx_mode(). Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen

Re: [RFC v2 net-next 00/10] Time based packet transmission

Hi Levi, On 01/23/2018 05:43 PM, Levi Pearson wrote: > On Wed, Jan 17, 2018 at 4:06 PM, Jesus Sanchez-Palencia > <jesus.sanchez-palen...@intel.com> wrote: >> This series is the v2 of the Time based packet transmission RFC, which was >> originally proposed by Richard

Re: [Intel-wired-lan] [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

Hi, On 02/01/2018 01:27 AM, Miroslav Lichvar wrote: > On Wed, Jan 31, 2018 at 04:49:36PM -0800, Jesus Sanchez-Palencia wrote: >> On 01/18/2018 09:13 AM, Richard Cochran wrote: >>> Right, the clockid_t should be passed in through the CMSG along with >>> the tim

Re: [Intel-wired-lan] [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

Hi, On 01/18/2018 09:13 AM, Richard Cochran wrote: > On Thu, Jan 18, 2018 at 09:42:27AM +0100, Miroslav Lichvar wrote: >> In the discussion about the v1 patchset, there was a question if the >> cmsg should include a clockid_t. Without that, how can an application >> prevent the packet from being

Re: [Intel-wired-lan] [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

Hi, On 01/18/2018 12:42 AM, Miroslav Lichvar wrote: > On Wed, Jan 17, 2018 at 03:06:12PM -0800, Jesus Sanchez-Palencia wrote: >> From: Richard Cochran <rcoch...@linutronix.de> >> >> This patch introduces SO_TXTIME. User space enables this option in >> order

[PATCH v1 net-next] igb: Use an advanced ctx descriptor for launchtime

nt tx_ring before performing the early return. Signed-off-by: Jesus Sanchez-Palencia --- drivers/net/ethernet/intel/igb/igb_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index e3

Re: [PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

Hi Eric, On 07/16/2018 04:15 PM, Eric Dumazet wrote: > > > On 07/16/2018 02:52 PM, Jesus Sanchez-Palencia wrote: >> Hi Eric, >> >> >> >> On 07/13/2018 10:35 AM, Eric Dumazet wrote: >>> >>> >>> On 07/03/2018 03:42

[PATCH v1 iproute2] tc: Do not use addattr_nest_compat on mqprio and netem

requeues 0 (...) [1] https://patchwork.ozlabs.org/patch/867860/#1893405 Fixes: c14f9d92eee107 ("treewide: Use addattr_nest()/addattr_nest_end() to handle nested attributes") Reported-by: Vinicius Costa Gomes Signed-off-by: Jesus Sanchez-Palencia --- tc/q_mqprio.c | 5 +++-- tc/q_net

Re: tc mqprio offload command error

Hi, On 07/16/2018 10:20 AM, Alexander Duyck wrote: > On Sun, Jul 15, 2018 at 6:30 PM, Chopra, Manish > wrote: >> Hello Folks, >> >> I am trying to set below command to try mqprio offload on 4.18 kernel. It is >> throwing the flowing error. >> >> # tc qdisc add dev eth0 root mqprio num_tc 2 map

Re: [PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

Hi Eric, On 07/13/2018 10:35 AM, Eric Dumazet wrote: > > > On 07/03/2018 03:42 PM, Jesus Sanchez-Palencia wrote: >> This is done in preparation for the upcoming time based transmission >> patchset. Now that skb->tstamp will be used to hold packet's txtime, >> w

[PATCH v2 iproute2] man: Fix typos on tc-cbs

Fix 2 typos on the man page of the CBS qdisc. Signed-off-by: Jesus Sanchez-Palencia Reviewed-by: Simon Horman --- man/man8/tc-cbs.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/man8/tc-cbs.8 b/man/man8/tc-cbs.8 index 32e1e0d4..ad1d8821 100644 --- a/man/man8/tc

[PATCH v3 iproute2 3/3] man: Add initial manpage for tc-etf(8)

Add an initial manpage for tc-etf covering all config options, basic concepts and operation modes. Signed-off-by: Jesus Sanchez-Palencia --- man/man8/tc-etf.8 | 141 ++ 1 file changed, 141 insertions(+) create mode 100644 man/man8/tc-etf.8 diff

[PATCH v3 iproute2 2/3] tc: Add support for the ETF Qdisc

[offload] [deadline_mode] Signed-off-by: Vinicius Costa Gomes Signed-off-by: Jesus Sanchez-Palencia --- tc/Makefile | 1 + tc/q_etf.c | 168 2 files changed, 169 insertions(+) create mode 100644 tc/q_etf.c diff --git a/tc/Makefile b/t

[PATCH v3 iproute2 0/3] Add support for ETF qdisc

of include/uapi/linux/pkt_sched.h and is not meant to be merged. It's provided here just as a convenience for those who want to easily build this patchset. [1] https://patchwork.ozlabs.org/cover/938991/ Jesus Sanchez-Palencia (2): uapi pkt_sched: Add etf info - DO NOT COMMIT man: Add initial

[PATCH v3 iproute2 1/3] uapi pkt_sched: Add etf info - DO NOT COMMIT

This should come from the next uapi headers update. Sending it now just as a convenience so anyone can build tc with etf and taprio support. Signed-off-by: Jesus Sanchez-Palencia --- include/uapi/linux/pkt_sched.h | 21 + 1 file changed, 21 insertions(+) diff --git

[PATCH net-next] net: Use __u32 in uapi net_stamp.h

We are not supposed to use u32 in uapi, so change the flags member of struct sock_txtime from u32 to __u32 instead. Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time") Signed-off-by: Jesus Sanchez-Palencia --- include/uapi/linux/net_tstamp.h | 2 +- 1 file

Re: [PATCH v3 iproute2 2/3] tc: Add support for the ETF Qdisc

On 07/09/2018 10:32 AM, David Ahern wrote: > On 7/9/18 9:48 AM, Jesus Sanchez-Palencia wrote: >> Hi David, >> >> >> On 07/06/2018 08:58 AM, David Ahern wrote: >>> On 7/5/18 4:42 PM, Jesus Sanchez-Palencia wrote: >>> >>>> +static int get_c

[PATCH v2 net-next] net: Use __u32 in uapi net_stamp.h

We are not supposed to use u32 in uapi, so change the flags member of struct sock_txtime from u32 to __u32 instead. Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time") Reported-by: Eric Dumazet Signed-off-by: Jesus Sanchez-Palencia --- include/

Re: [PATCH net-next] net: Use __u32 in uapi net_stamp.h

On 07/09/2018 04:18 PM, Eric Dumazet wrote: > > > On 07/09/2018 04:08 PM, Jesus Sanchez-Palencia wrote: >> We are not supposed to use u32 in uapi, so change the flags member of >> struct sock_txtime from u32 to __u32 instead. >> >> Fixes: 80b14dee2b

Re: [PATCH v2 net-next 02/14] net: Add a new socket option for a future transmit time.

On 07/07/2018 05:44 PM, Eric Dumazet wrote: > > > On 07/03/2018 03:42 PM, Jesus Sanchez-Palencia wrote: >> From: Richard Cochran >> >> This patch introduces SO_TXTIME. User space enables this option in >> order to pass a desired future transmit time in

[PATCH v4 iproute2-next 2/3] tc: Add support for the ETF Qdisc

[offload] [deadline_mode] Signed-off-by: Vinicius Costa Gomes Signed-off-by: Jesus Sanchez-Palencia --- tc/Makefile | 1 + tc/q_etf.c | 181 2 files changed, 182 insertions(+) create mode 100644 tc/q_etf.c diff --git a/tc/Makefile b/t

[PATCH v4 iproute2-next 0/3] Add support for ETF qdisc

ozlabs.org/cover/938991/ Jesus Sanchez-Palencia (2): uapi pkt_sched: Add etf info - DO NOT COMMIT man: Add initial manpage for tc-etf(8) Vinicius Costa Gomes (1): tc: Add support for the ETF Qdisc include/uapi/linux/pkt_sched.h | 21 man/man8/tc-etf.8

[PATCH v4 iproute2-next 3/3] man: Add initial manpage for tc-etf(8)

Add an initial manpage for tc-etf covering all config options, basic concepts and operation modes. Signed-off-by: Jesus Sanchez-Palencia --- man/man8/tc-etf.8 | 141 ++ 1 file changed, 141 insertions(+) create mode 100644 man/man8/tc-etf.8 diff

[PATCH v4 iproute2-next 1/3] uapi pkt_sched: Add etf info - DO NOT COMMIT

This should come from the next uapi headers update. Sending it now just as a convenience so anyone can build tc with etf and taprio support. Signed-off-by: Jesus Sanchez-Palencia --- include/uapi/linux/pkt_sched.h | 21 + 1 file changed, 21 insertions(+) diff --git

Re: [PATCH net-next 0/6] sock cookie initializers

e and sockc_cookie. > > patch 1..3 do exactly this. > patch 4..5 make ipv4 and ipv6 handle cookies the same way and >remove some boilerplate in doing so. > patch 6removes the udp gso branch that needed the above fix Acked-by: Jesus Sanchez-Palencia I've applied th

Re: [PATCH v3 iproute2 2/3] tc: Add support for the ETF Qdisc

ion >> + * 2 of the License, or (at your option) any later version. >> + * >> + * Authors: Vinicius Costa Gomes >> + * Jesus Sanchez-Palencia >> + * >> + */ > > > Please use SPDX tag rather than GPL boilerplate when adding new code. Sur

Re: [PATCH v2 net-next 00/14] Scheduled packet Transmission: ETF

Hi Stephen, On 07/06/2018 02:38 PM, Stephen Hemminger wrote: > On Tue, 3 Jul 2018 15:42:46 -0700 > Jesus Sanchez-Palencia wrote: > >> Changes since v1: >> - moved struct sock_txtime from socket.h to uapi net_tstamp.h; >> - sk_clockid was changed from u16 to

Re: [PATCH v3 iproute2 2/3] tc: Add support for the ETF Qdisc

Hi David, On 07/06/2018 08:58 AM, David Ahern wrote: > On 7/5/18 4:42 PM, Jesus Sanchez-Palencia wrote: > >> +static int get_clockid(__s32 *val, const char *arg) >> +{ >> +const struct static_clockid { >> +const char *name; >

Re: [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

On 01/18/2018 09:11 AM, Richard Cochran wrote: > On Wed, Jan 17, 2018 at 03:06:12PM -0800, Jesus Sanchez-Palencia wrote: >> @@ -2130,6 +2137,15 @@ int __sock_cmsg_send(struct sock *sk, struct msghdr >> *msg, struct cmsghdr *cmsg, >>

Re: [RFC v2 net-next 00/10] Time based packet transmission

Hi, On 01/22/2018 09:26 PM, Richard Cochran wrote: > On Mon, Jan 22, 2018 at 09:23:27PM -0800, Richard Cochran wrote: >> On Wed, Jan 17, 2018 at 03:06:11PM -0800, Jesus Sanchez-Palencia wrote: >>> First, a baseline test was ran for 10 minutes with the

Re: [RFC v2 net-next 01/10] net: Add a new socket option for a future transmit time.

Hi, On 01/19/2018 01:15 PM, Willem de Bruijn wrote: > On Wed, Jan 17, 2018 at 6:06 PM, Jesus Sanchez-Palencia > <jesus.sanchez-palen...@intel.com> wrote: >> From: Richard Cochran <rcoch...@linutronix.de> >> >> This patch introduces SO_TXTIME. User space ena

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

rticular is off. You were right, thanks. It'll be fixed on our next version. Regards, Jesus > > cheers, > jamal > > On 18-01-18 08:35 AM, Jamal Hadi Salim wrote: >> On 18-01-17 06:06 PM, Jesus Sanchez-Palencia wrote: >>> From: Vinicius Costa Gomes <vinicius.go

Re: [RFC v2 net-next 06/10] net/sched: Introduce the TBS Qdisc

Hi, On 01/18/2018 05:35 AM, Jamal Hadi Salim wrote: > On 18-01-17 06:06 PM, Jesus Sanchez-Palencia wrote: >> From: Vinicius Costa Gomes <vinicius.go...@intel.com> >> >> TBS (Time Based Scheduler) uses the information added earlier in this >> series (the socket

[RFC v3 net-next 08/18] net: SO_TXTIME: Add clockid and drop_if_late params

clock source; * SCM_TXTIME for the txtime timestamp; * SCM_DROP_IF_LATE for the drop flag. This flag will be used by the traffic control to decide if a delayed packet should be dropped. Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palen...@intel.com> --- arch/alpha/include/ua

[RFC v3 net-next 16/18] igb: Only change Tx arbitration when CBS is on

can be enabled separately. That is achieved by moving the DataTranARB setup to igb_config_tx_modes() instead. Similarly, when disabling CBS we must check if it has been disabled for all queues, and clear the DataTranARB accordingly. Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-pa

  1   2   >