for (I have limited knowledge on the network driver).
Signed-off-by: Julien Grall julien.gr...@citrix.com
Cc: Ian Campbell ian.campb...@citrix.com
Cc: Wei Liu wei.l...@citrix.com
Cc: netdev@vger.kernel.org
---
Improvement such as support of 64KB grant is not taken into
consideration
Hi David,
On 19/05/15 14:57, David Vrabel wrote:
On 14/05/15 18:00, Julien Grall wrote:
With 64KB page granularity support in Linux, a page will be split accross
multiple MFN (Xen is using 4KB page granularity). Thoses MFNs may not be
contiguous.
With the offset in the page, the helper
On 04/06/15 17:25, Joe Perches wrote:
On Thu, 2015-06-04 at 13:52 +0100, Julien Grall wrote:
On 04/06/15 13:46, David Vrabel wrote:
On 04/06/15 13:45, Julien Grall wrote:
On 03/06/15 18:06, Joe Perches wrote:
On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
rx-status is an int16_t
The variables old_req_cons and ring_slots_used are assigned but never
used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b xen-netback:
always fully coalesce guest Rx packets.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Acked-by: Wei Liu wei.l...@citrix.com
Cc: Ian Campbell
david.vra...@citrix.com
Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com
Cc: Boris Ostrovsky boris.ostrov...@oracle.com
Cc: netdev@vger.kernel.org
[1] http://lkml.org/lkml/2015/5/14/533
Julien Grall (2):
net/xen-netfront: Correct printf format in xennet_get_responses
net/xen-netback: Remove unused
david.vra...@citrix.com
Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com
Cc: Boris Ostrovsky boris.ostrov...@oracle.com
Cc: netdev@vger.kernel.org
[1] http://lkml.org/lkml/2015/5/14/533
Julien Grall (2):
net/xen-netfront: Correct printf format in xennet_get_responses
net/xen-netback: Remove unused
rx-status is an int16_t, print it using %d rather than %u in order to
have a meaningful value when the field is negative.
Also use %d rather than %x for rx-offset.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Reviewed-by: David Vrabel david.vra...@citrix.com
Cc: Konrad Rzeszutek Wilk
The variables old_req_cons and ring_slots_used are assigned but never
used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b xen-netback:
always fully coalesce guest Rx packets.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Acked-by: Wei Liu wei.l...@citrix.com
Cc: Ian Campbell
rx-status is an int16_t, print it using %d rather than %u in order to
have a meaningful value when the field is negative.
Also use %u rather than %x for rx-offset.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Reviewed-by: David Vrabel david.vra...@citrix.com
Cc: Konrad Rzeszutek Wilk
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Cc: Wei Liu wei.l...@citrix.com
Cc: Ian Campbell
The variables old_req_cons and ring_slots_used are assigned but never
used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b xen-netback:
always fully coalesce guest Rx packets.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Acked-by: Wei Liu wei.l...@citrix.com
Cc: Ian Campbell
The variables old_req_cons and ring_slots_used are assigned but never
used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b xen-netback:
always fully coalesce guest Rx packets.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Acked-by: Wei Liu wei.l...@citrix.com
Cc: Ian Campbell
Prepend 0x to all %x in order to avoid confusion while reading when there is
other decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Acked-by: Ian Campbell ian.campb
rx-status is an int16_t, print it using %d rather than %u in order to
have a meaningful value when the field is negative.
Also use %u rather than %x for rx-offset.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Reviewed-by: David Vrabel david.vra...@citrix.com
Cc: Konrad Rzeszutek Wilk
david.vra...@citrix.com
Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com
Cc: Boris Ostrovsky boris.ostrov...@oracle.com
Cc: netdev@vger.kernel.org
[1] http://lkml.org/lkml/2015/5/14/533
Julien Grall (3):
net/xen-netfront: Correct printf format in xennet_get_responses
net/xen-netback: Remove unused
Hi Ian,
On 17/06/2015 10:25, Ian Campbell wrote:
On Tue, 2015-06-16 at 20:10 +0100, Julien Grall wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format
Using xen/page.h will be necessary later for using common xen page
helpers.
As xen/page.h already include asm/xen/page.h, always use the later.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Reviewed-by: David Vrabel david.vra...@citrix.com
Cc: Stefano Stabellini stefano.stabell
stefano.stabell...@eu.citrix.com
Cc: Wei Liu wei.l...@citrix.com
Julien Grall (7):
xen: Include xen/page.h rather than asm/xen/page.h
xen/xenbus: client: Fix call of virt_to_mfn in xenbus_grant_ring
xen/grant-table: Remove unused macro SPP
arm/xen: Drop duplicate define mfn_to_virt
block
On 04/06/15 13:46, David Vrabel wrote:
On 04/06/15 13:45, Julien Grall wrote:
On 03/06/15 18:06, Joe Perches wrote:
On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
rx-status is an int16_t, print it using %d rather than %u in order to
have a meaningful value when the field is negative
On 03/06/15 18:06, Joe Perches wrote:
On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
rx-status is an int16_t, print it using %d rather than %u in order to
have a meaningful value when the field is negative.
[]
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
netdevice using
ipv6 and bridge.
Spotted while trying to destroy a Xen guest on the upstream Linux:
unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1
Signed-off-by: Julien Grall julien.gr...@citrix.com
Cc: Bernhard Thaler bernhard.tha...@wvnet.at
Cc: Pablo Neira Ayuso pa
Regards,
--
Julien Grall
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On 03/07/15 21:42, Florian Westphal wrote:
Julien Grall julien.gr...@citrix.com wrote:
The commit efb6de9b4ba0092b2c55f6a52d16294a8a698edd netfilter: bridge:
forward IPv6 fragmented packets introduced a new function
br_validate_ipv6 which take a reference on the inet6 device. Although
On 06/07/15 12:19, Florian Westphal wrote:
Julien Grall julien.gr...@citrix.com wrote:
On 03/07/15 21:42, Florian Westphal wrote:
I think it makes more sense to use __in6_dev_get() instead which doesn't
take a reference.
__in6_dev_get requires to hold rcu_read_lock or RTNL. My knowledge
Hi Florian,
On 29/06/15 19:55, Florian Westphal wrote:
Julien Grall julien.gr...@citrix.com wrote:
I tried to run the latest Linux tree
(4a10a91756ef381bced7b88cfb9232f660b92d93) as DOM0 Xen.
After destroying a guest using network, I got the following
lines in the DOM0 kernel log
roger@citrix.com
Cc: Russell King li...@arm.linux.org.uk
Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Tomi Valkeinen tomi.valkei...@ti.com
Cc: Wei Liu wei.l...@citrix.com
Cc: x...@kernel.org
Julien Grall (8):
arm/xen: Remove helpers which
On 28/07/15 16:02, Julien Grall wrote:
Hi all,
This patch series aims to use the memory terminologies described in
include/linux/mm.h [1] for Linux xen code.
I mistakenly wrote the wrong include here. It should be include/xen/mm.h
from the Xen tree:
http://xenbits.xen.org/gitweb/?p=xen.git
On 28/07/15 18:16, David Vrabel wrote:
On 28/07/15 16:02, Julien Grall wrote:
Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN
is meant, I suspect this is because the first support for Xen was for
PV. This brough some misimplementation of helpers on ARM and make
Hi Boris,
On 05/08/15 00:16, Boris Ostrovsky wrote:
On 08/04/2015 02:12 PM, Julien Grall wrote:
/*
* We detect special mappings in one of two ways:
@@ -217,9 +232,13 @@ static inline unsigned long
bfn_to_local_pfn(unsigned long mfn)
/* VIRT - MACHINE conversion */
#define
On 05/08/15 13:19, Boris Ostrovsky wrote:
On 08/05/2015 06:51 AM, Julien Grall wrote:
diff --git a/drivers/video/fbdev/xen-fbfront.c
b/drivers/video/fbdev/xen-fbfront.c
index 09dc447..25e3cce 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -539,7
mfn == gfn */ for every use of mfn =
pfn_to_gfn(...).
Regards,
--
Julien Grall
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
On 04/08/15 19:12, Julien Grall wrote:
diff --git a/include/xen/page.h b/include/xen/page.h
index c5ed20b..e7e1425 100644
--- a/include/xen/page.h
+++ b/include/xen/page.h
@@ -3,9 +3,9 @@
#include asm/xen/page.h
-static inline unsigned long page_to_mfn(struct page *page
On 06/08/15 12:06, Stefano Stabellini wrote:
On Thu, 6 Aug 2015, Julien Grall wrote:
Hi,
On 04/08/15 19:12, Julien Grall wrote:
diff --git a/include/xen/page.h b/include/xen/page.h
index c5ed20b..e7e1425 100644
--- a/include/xen/page.h
+++ b/include/xen/page.h
@@ -3,9 +3,9
complex clean up
will come in follow-up patches.
[1]
http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb
Signed-off-by: Julien Grall julien.gr...@citrix.com
Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com
Cc: Russell King li...@arm.linux.org.uk
Cc
...@citrix.com
Cc: x...@kernel.org
Julien Grall (8):
arm/xen: Remove helpers which are PV specific
xen: Make clear that swiotlb and biomerge are dealing with DMA address
arm/xen: implement correctly pfn_to_mfn
xen: Use the correctly the Xen memory terminologies
xen/tmem: Use page_to_gfn rather
@vger.kernel.org
Cc: Roger Pau Monné roger@citrix.com
Cc: Russell King li...@arm.linux.org.uk
Cc: Stefano Stabellini stefano.stabell...@eu.citrix.com
Cc: Thomas Gleixner t...@linutronix.de
Cc: Tomi Valkeinen tomi.valkei...@ti.com
Cc: Wei Liu wei.l...@citrix.com
Cc: x...@kernel.org
Julien Grall (9
also the opportunity to simplify simple construction such
as pfn_to_mfn(page_to_pfn(page)) into xen_page_to_gfn. More complex clean up
will come in follow-up patches.
[1]
http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=e758ed14f390342513405dd766e874934573e6cb
Signed-off-by: Julien Grall
The skb doesn't change within the function. Therefore it's only
necessary to check if we need GSO once at the beginning.
Signed-off-by: Julien Grall julien.gr...@citrix.com
---
Cc: Ian Campbell ian.campb...@citrix.com
Cc: Wei Liu wei.l...@citrix.com
Cc: netdev@vger.kernel.org
Changes in v2
on the grant table code.
Signed-off-by: Julien Grall julien.gr...@citrix.com
---
Cc: Ian Campbell ian.campb...@citrix.com
Cc: Wei Liu wei.l...@citrix.com
Cc: netdev@vger.kernel.org
Improvement such as support of 64KB grant is not taken into
consideration in this patch because we have
;
/* Next page */
if (size) {
BUG_ON(!PageCompound(page));
page++;
}
}
Regards,
--
Julien Grall
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
Hi,
On 09/07/15 21:42, Julien Grall wrote:
+static void xennet_make_one_txreq(unsigned long mfn, unsigned int offset,
+ unsigned int *len, void *data)
+{
+ struct xennet_gnttab_make_txreq *info = data;
+
+ info-tx-flags |= XEN_NETTXF_more_data
to become free. Usage count = 1
Signed-off-by: Julien Grall julien.gr...@citrix.com
Cc: Bernhard Thaler bernhard.tha...@wvnet.at
Cc: Pablo Neira Ayuso pa...@netfilter.org
Cc: f...@strlen.de
Cc: ian.campb...@citrix.com
Cc: wei.l...@citrix.com
Cc: Bob Liu bob@oracle.com
---
Note that it's impossible
on the grant table code.
Note that we allocate a Linux page for each rx skb but only the first
4KB is used. We may improve the memory usage by extending the size of
the rx skb.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com
Cc: Boris Ostrovsky
The skb doesn't change within the function. Therefore it's only
necessary to check if we need GSO once at the beginning.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Cc: Ian Campbell ian.campb...@citrix.com
Cc: Wei Liu wei.l...@citrix.com
Cc: netdev@vger.kernel.org
---
Changes in v2
on the grant table code.
Signed-off-by: Julien Grall julien.gr...@citrix.com
Cc: Ian Campbell ian.campb...@citrix.com
Cc: Wei Liu wei.l...@citrix.com
Cc: netdev@vger.kernel.org
---
Improvement such as support of 64KB grant is not taken into
consideration in this patch because we have the requirement
The skb doesn't change within the function. Therefore it's only
necessary to check if we need GSO once at the beginning.
Signed-off-by: Julien Grall <julien.gr...@citrix.com>
Acked-by: Wei Liu <wei.l...@citrix.com>
---
Cc: Ian Campbell <ian.campb...@citrix.com>
Cc: netd
on the grant table code.
Note that we allocate a Linux page for each rx skb but only the first
4KB is used. We may improve the memory usage by extending the size of
the rx skb.
Signed-off-by: Julien Grall <julien.gr...@citrix.com>
Reviewed-by: David Vrabel <david.vra...@citrix.com>
---
Cc: Konr
on the grant table code.
Signed-off-by: Julien Grall <julien.gr...@citrix.com>
---
Cc: Ian Campbell <ian.campb...@citrix.com>
Cc: Wei Liu <wei.l...@citrix.com>
Cc: netdev@vger.kernel.org
Improvement such as support of 64KB grant is not taken into
consideration in this pat
latest
linus' master.
> On Mon, Sep 07, 2015 at 04:33:56PM +0100, Julien Grall wrote:
>> The PV network protocol is using 4KB page granularity. The goal of this
>> patch is to allow a Linux using 64KB page granularity working as a
>> network backend on a non-modified Xen.
vice_ functions for determining mac/phy"
Signed-off-by: Julien Grall <julien.gr...@citrix.com>
Cc: Jeremy Linton <jeremy.lin...@arm.com>
Cc: David S. Miller <da...@davemloft.net>
---
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: netdev@vger.kernel.org
---
drivers
The skb doesn't change within the function. Therefore it's only
necessary to check if we need GSO once at the beginning.
Signed-off-by: Julien Grall <julien.gr...@citrix.com>
Acked-by: Wei Liu <wei.l...@citrix.com>
---
Cc: Ian Campbell <ian.campb...@citrix.com>
Cc: netd
on the grant table code.
Note that we allocate a Linux page for each rx skb but only the first
4KB is used. We may improve the memory usage by extending the size of
the rx skb.
Signed-off-by: Julien Grall <julien.gr...@citrix.com>
Reviewed-by: David Vrabel <david.vra...@citrix.com>
---
Cc: Konr
52 matches
Mail list logo
