RE: [RFC 07/11] Add support for memory registeration verbs

> > +struct qedr_mr *__qedr_alloc_mr(struct ib_pd *ibpd, int > > +max_page_list_len) { > > + struct qedr_pd *pd = get_qedr_pd(ibpd); > > + struct qedr_dev *dev = get_qedr_dev(ibpd->device); > > + struct qedr_mr *mr; > > + int rc = -ENOMEM; > > + > > + DP_VERBOSE(dev, QEDR_MSG_MR, > > +

RE: [RFC 07/11] Add support for memory registeration verbs

> >>> +struct qedr_mr *__qedr_alloc_mr(struct ib_pd *ibpd, int > >>> +max_page_list_len) { > >>> + struct qedr_pd *pd = get_qedr_pd(ibpd); > >>> + struct qedr_dev *dev = get_qedr_dev(ibpd->device); > >>> + struct qedr_mr *mr; > >>> + int rc = -ENOMEM; > >>> + > >>> + DP_VERBOSE(dev, QEDR_MSG_MR, >

RE: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

> From: Pan Bian > > Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate > memory, and jumps to label "lbl" if the allocation fails. Label "lbl" > first cleans memory and then returns variable rc. Before calling the macro, > the > value of variable rc is

Re: [PATCH net-next 00/12] qed: Add iWARP support for QL4xxxx

From: David Miller Sent: Monday, July 3, 2017 11:59 AM > You really have to compile test your work and do something with > the warnings: > drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1721:5: warning: ‘ll2_syn_handle’ > may be used uninitialized in this funct > This one is

RE: [RFC 15/19] RDMA/qedr: Add iWARP support in existing verbs.

From: Leon Romanovsky [mailto:l...@kernel.org] Sent: Tuesday, June 27, 2017 8:27 AM > On Mon, Jun 26, 2017 at 09:07:05PM +0300, Michal Kalderon wrote: > > Make slight modifications to common RoCE/iWARP code. > > Add additional doorbell for iWARP post_send. > > iWARP QP pbl is allocated in qed

RE: [RFC 01/19] qed: Introduce iWARP personality

From: Leon Romanovsky [mailto:l...@kernel.org] Sent: Tuesday, June 27, 2017 8:37 AM > > On Mon, Jun 26, 2017 at 09:06:51PM +0300, Michal Kalderon wrote: > > iWARP personality introduced the need for differentiating in several > > places in the code whether we are RoCE, iWARP or either. This leads

RE: [RFC 02/19] qed: Implement iWARP initialization, teardown and qp operations

From: Leon Romanovsky [mailto:l...@kernel.org] Sent: Tuesday, June 27, 2017 8:46 AM > > On Mon, Jun 26, 2017 at 09:06:52PM +0300, Michal Kalderon wrote: > > This patch adds iWARP support for flows that have common code between > > RoCE and iWARP, such as initialization, teardown and qp setup

RE: [PATCH v2 net-next 0/7] qed*: RDMA and infrastructure for iWARP

From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Sunday, June 18, 2017 4:15 PM > On Sun, Jun 18, 2017 at 02:50:28PM +0300, Yuval Mintz wrote: > > This series focuses on RDMA in general with emphasis on required > > changes toward adding iWARP support. The vast majority of the changes >

RE: [PATCH v2 net-next 4/7] qed*: Rename qede_roce.[ch]

> From: Michal Kalderon > > Once we have iWARP support, the qede portion of the qedr<->qede would > serve all the RDMA protocols - so rename the file to be appropriate to its > function. > > CC: Michal Kalderon > Signed-off-by: Yuval

Re: [PATCH net-next 3/4] qed: Fix maximum number of CQs for iWARP

From: Leon Romanovsky Sent: Tuesday, September 19, 2017 8:46 PM On Tue, Sep 19, 2017 at 08:26:18PM +0300, Michal Kalderon wrote: >> The maximum number of CQs supported is bound to the number >> of connections supported, which differs between RoCE and iWARP. >> >> This fixes a

Re: [PATCH net-next 2/4] qed: Add iWARP out of order support

From: Leon Romanovsky Sent: Tuesday, September 19, 2017 8:45 PM On Tue, Sep 19, 2017 at 08:26:17PM +0300, Michal Kalderon wrote: >> iWARP requires OOO support which is already provided by the ll2 >> interface (until now was used only for iSCSI offload). >> The changes mostly

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

From: Leon Romanovsky Sent: Tuesday, October 3, 2017 4:26 PM >On Tue, Oct 03, 2017 at 11:54:56AM +0300, Michal Kalderon wrote: >> For iWARP unaligned MPA flow, a slowpath event of flushing an >> MPA connection that entered an unaligned state is required. >> The flush ramrod is

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

From: David Miller Sent: Tuesday, October 3, 2017 8:17 PM >> @@ -423,6 +423,41 @@ static void qed_ll2_rxq_parse_reg(struct qed_hwfn >> *p_hwfn, >> } >> >> static int >> +qed_ll2_handle_slowpath(struct qed_hwfn *p_hwfn, >> + struct qed_ll2_info

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

From: linux-rdma-ow...@vger.kernel.org <linux-rdma-ow...@vger.kernel.org> on behalf of David Miller <da...@davemloft.net> >From: "Kalderon, Michal" <michal.kalde...@cavium.com> >Date: Thu, 5 Oct 2017 20:27:22 + > >> The spinlock is required for

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

From: Kalderon, Michal Sent: Tuesday, October 3, 2017 9:05 PM To: David Miller >From: David Miller <da...@davemloft.net> >Sent: Tuesday, October 3, 2017 8:17 PM >>> @@ -423,6 +423,41 @@ static void qed_ll2_rxq_parse_reg(struct qed_hwfn >>> *p_hw

Re: [PATCH v2 net-next 06/12] qed: Add LL2 slowpath handling

From: David Miller <da...@davemloft.net> Sent: Thursday, October 5, 2017 10:06 PM >> From: Kalderon, Michal >> Sent: Tuesday, October 3, 2017 9:05 PM >> To: David Miller >>>From: David Miller <da...@davemloft.net> >>>Sent: Tuesday, October 3, 201

Re: [PATCH net-next] qed: Set error code for allocation failures

From: Dan Carpenter Sent: Friday, October 27, 2017 2:52 PM >On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> > iwarp_info = _hwfn->p_rdma_info->iwarp; >> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn, >> > if (rc) >> >

Re: [PATCH net-next] qed: Set error code for allocation failures

From: Dan Carpenter Sent: Friday, October 27, 2017 9:40 AM > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan

RE: [PATCH] qed: code indent should use tabs where possible

> From: Rohit Visavalia [mailto:rohit.visava...@softnautics.com] > Sent: Thursday, January 25, 2018 12:26 PM > To: Elior, Ariel ; Dept-Eng Everest Linux L2 engeverestlinu...@cavium.com> > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Rohit Visavalia >

RE: [PATCH net] qed: Use after free in qed_rdma_free()

> From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Tuesday, March 13, 2018 11:10 AM > To: Elior, Ariel <ariel.el...@cavium.com>; Kalderon, Michal > <michal.kalde...@cavium.com> > Cc: Dept-Eng Everest Linux L2 <dept-engeverestlinu...@cavium.com>; >

RE: [PATCH net 2/2] qed: Fix non TCP packets should be dropped on iWARP ll2 connection

> From: Joe Perches [mailto:j...@perches.com] > Sent: Wednesday, March 14, 2018 3:03 PM > To: Kalderon, Michal <michal.kalde...@cavium.com>; > da...@davemloft.net > Cc: netdev@vger.kernel.org; dledf...@redhat.com; j...@mellanox.com; > linux-r...@vger.kernel.org

RE: [PATCH net-next] qed*: Utilize FW 8.33.11.0

> From: Jason Gunthorpe [mailto:j...@ziepe.ca] > Sent: Wednesday, March 28, 2018 1:27 AM > > On Tue, Mar 27, 2018 at 08:50:24PM +0300, Leon Romanovsky wrote: > > On Tue, Mar 27, 2018 at 05:41:51PM +, Kalderon, Michal wrote: > > > > From: Jason Gunthorpe [mail

RE: [PATCH net-next] qed*: Utilize FW 8.33.11.0

> From: Jason Gunthorpe [mailto:j...@ziepe.ca] > Sent: Tuesday, March 27, 2018 12:18 AM > > diff --git a/drivers/infiniband/hw/qedr/main.c > > b/drivers/infiniband/hw/qedr/main.c > > index db4bf97..7dbbe6d 100644 > > +++ b/drivers/infiniband/hw/qedr/main.c > > @@ -51,6 +51,7 @@ > >

RE: [PATCH net] qed: Free RoCE ILT Memory on rmmod qedr

> From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Monday, March 05, 2018 11:41 AM > To: Kalderon, Michal <michal.kalde...@cavium.com> > Cc: da...@davemloft.net; netdev@vger.kernel.org; dledf...@redhat.com; > j...@mellanox.com; linux-r...@vger.kernel.org; Eli

RE: [PATCH V2 net] qed: Free RoCE ILT Memory on rmmod qedr

> From: Yuval Mintz [mailto:yuv...@mellanox.com] > Sent: Monday, March 05, 2018 11:24 PM > To: Kalderon, Michal <michal.kalde...@cavium.com>; > da...@davemloft.net > Cc: netdev@vger.kernel.org; dledf...@redhat.com; Jason Gunthorpe > <j...@mellanox.com>; linux-r...

RE: [PATCH] qlogic/qed: Constify *pkt_type_str[]

> From: Hernán Gonzalez [mailto:her...@vanguardiasur.com.ar] > Sent: Wednesday, February 28, 2018 12:32 AM > > Note: This is compile only tested as I have no access to the hw. > Constifying and declaring as static saves 24 bytes. > > add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-24 (-24) >