[PATCH 04/11] net: packet: change vnet_hdr_len from int to size_t

vnet_hdr_len cannot be negative and is use in operation/function that wait for unsigned value. This patch set vnet_hdr_len as size_t. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- net/packet/af_packet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 06/11] net: ipv6: set the length parameter of rawv6_send_hdrinc() to size_t

length is used in operation/function that wait for unsigned value. Furthermore the only one call of rawv6_send_hdrinc() give a size_t as length arguments. So the parameter need to be set as size_t. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- net/ipv6/raw.c | 2 +-

[PATCH 09/11] net: ipv6: hlen could be set as size_t

The hlen member of raw6_frag_vec is used in operation/function that wait for unsigned value. So it need to be set as size_t. This patch do the same for the hlen variable. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- net/ipv6/raw.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 07/11] net: caif: change chunk from int to size_t

chunk cannot be negative and is use in operation/function that wait for unsigned value. This patch set it as size_t. The patch do the same for the size variable. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- net/caif/caif_socket.c | 5 +++-- 1 file changed, 3 insertions

[PATCH 08/11] net: bluetooth: change the len parameter of sco_send_frame() to size_t

len is used in operation/function that wait for unsigned value. Furthermore the only one call of sco_send_frame give a size_t as argument. So the parameter need to be set as size_t. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- net/bluetooth/sco.c | 2 +- 1 file chan

Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t

On Fri, Oct 23, 2015 at 06:08:52AM -0700, David Miller wrote: > From: LABBE Corentin <clabbe.montj...@gmail.com> > Date: Fri, 23 Oct 2015 14:10:35 +0200 > > > The hlen member of raw_frag_vec is used in operation/function that wait > > for unsigned value. So

[PATCH 03/11] net: llc: change copied to size_t in llc_ui_sendmsg

The variable copied in llc_ui_sendmsg() cannot be negative and is used in functions that wait for unsigned value, so set it as size_t (like it is in llc_ui_recvmsg()) Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- net/llc/af_llc.c | 3 ++- 1 file changed, 2 insertions

[PATCH 02/11] net: llc: fix a setting of error value to size_t

The variable copied is a size_t, so setting a negative value to it is invalid. The patch add an "err" variable for getting the error code. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- net/llc/af_llc.c | 20 1 file changed, 12 insertions

[PATCH 05/11] net: irda: change chunk from int to size_t

chunk cannot be negative and is use in operation/function that wait for unsigned value. This patch set it as size_t. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- net/irda/af_irda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/irda/af_irda.c b/ne

[no subject]

Hello This patch series was begun by my finding that memcpy_[to|from]_msg have a parameter len which is an int but used as size_t in whole functions. Without blindly changing the parameter to size_t, I have tried to see if anywhere in linux source code, someone give a negative argument with the

[PATCH 10/11] net: ipv4: hlen could be set as size_t

The hlen member of raw_frag_vec is used in operation/function that wait for unsigned value. So it need to be set as size_t. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- net/ipv4/raw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/raw.c b/ne

[PATCH v3 3/5] stmmac: remove some __func__ printing

such printing is useless. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 81 ++- 1 file changed, 34 insertions(+), 47 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/et

[PATCH] net: stmmac: fix double-initialization of phy_iface

The variable phy_iface is double-initialized to itself. This patch remove that. Reported-by: coverity (CID 1271141) Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3] stmmac: improve logging

Hello This patch series try to improve logging of the stmmac driver. Changes since v2 - Rollback to dev_ for some early init printing - rebased on 4.4-rc1 Changes since v1 - Use netdev_xxx instead of dev_xxx - Use netif_xxx instead of "if (netif_msg_type) dev_xxx" Regards -- To unsubscribe

[PATCH v3 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

hat dev_xxx displays. And this patch also change some pr_info by netdev_err when the word ERROR is printed. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 210 -- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

[PATCH v3 4/5] stmmac: Fix simple style problem

block comments don't use an empty /* line - Do not include the paragraph about writing to the Free Software Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 71 +++ drivers/net/ethernet/stmicro/

[PATCH v3 5/5] net: stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

As sugested by Joe Perches, we could replace all if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac

[PATCH v3 2/5] stmmac: replace hardcoded function name by __func__

Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/et

[PATCH] net: stmmac: remove unneeded phy_iface variable

The variable phy_iface is double-initialized and finally is not necessary at all. Reported-by: coverity (CID 1271141) Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-)

[PATCH v4 5/5] net: stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

As sugested by Joe Perches, we could replace all if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac

[PATCH v4 1/5] net: stmmac: replace all pr_xxx by their netdev_xxx counterpart

hat dev_xxx displays. And this patch also change some pr_info by netdev_err when the word ERROR is printed. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 210 -- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

[PATCH v4 2/5] net: stmmac: replace hardcoded function name by __func__

Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/et

[PATCH v4 3/5] net: stmmac: remove some __func__ printing

such printing is useless. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 81 ++- 1 file changed, 34 insertions(+), 47 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/et

[PATCH v4] stmmac: improve logging

Hello This patch series try to improve logging of the stmmac driver. Changes since v3 - Fix a missing comma for letting patch to be used atomaticly. Changes since v2 - Rollback to dev_ for some early init printing - rebased on 4.4-rc1 Changes since v1 - Use netdev_xxx instead of dev_xxx - Use

Re: [PATCH v3 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

On Thu, Nov 05, 2015 at 06:58:17PM +0800, kbuild test robot wrote: > Hi LABBE, > > [auto build test ERROR on: net/master] > [also build test ERROR on: v4.3 next-20151105] > > url: > https://github.com/0day-ci/linux/commits/LABBE-Corentin/stmmac-replace-all-pr_xx

[PATCH v4 4/5] net: stmmac: Fix simple style problem

block comments don't use an empty /* line - Do not include the paragraph about writing to the Free Software Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 71 +++ drivers/net/ethernet/stmicro/

[PATCH v2 4/5] stmmac: Fix simple style problem

block comments don't use an empty /* line - Do not include the paragraph about writing to the Free Software Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 74 +++ 1 file changed, 35 insertions(+), 39 del

[PATCH v2 2/5] stmmac: replace hardcoded function name by __func__

Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/et

stmmac: improve logging

Hello This patch series try to improve logging of the stmmac driver. Changes since v1 - Use netdev_xxx instead of dev_xxx - Use netif_xxx instead of "if (netif_msg_type) dev_xxx" Regards -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH v2 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

. In the same time I remove some "stmmac:" print since this will be a duplicate with that dev_xxx displays. And this patch also change some pr_info by netdev_err when the word ERROR is printed. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmm

Re: [PATCH 1/4] stmmac: replace all pr_xxx by their dev_xxx counterpart

On Wed, Sep 09, 2015 at 09:14:42AM -0700, Joe Perches wrote: > On Wed, 2015-09-09 at 15:14 +0200, LABBE Corentin wrote: > > The stmmac driver use lots of pr_xxx functions to print information. > > This is bad since we cannot know which device logs the information. > > (m

[PATCH v2 5/5] stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

As sugested by Joe Perches, we could replace all if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac

[PATCH v2 3/5] stmmac: remove some __func__ printing

Now that stmmac use netdev_xxx, some __func__ are not necessary since their use was to clearly identify which driver was logging. This patch remove __func__ where such printing is useless. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/

[PATCH 4/4] stmmac: Fix simple style problem

block comments don't use an empty /* line - Do not include the paragraph about writing to the Free Software Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 74 +++ 1 file changed, 35 insertions(+), 39 del

[PATCH 3/4] stmmac: remove some __func__ printing

Now that stmmac use dev_xxx, some __func__ are not necessary since their use was to clearly identify which driver was logging. This patch remove __func__ where such printing is useless. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/

[PATCH 2/4] stmmac: replace hardcoded function name by __func__

Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/et

[PATCH 1/4] stmmac: replace all pr_xxx by their dev_xxx counterpart

. In the same time I remove some "stmmac:" print since this will be a duplicate with that dev_xxx displays. And this patch also change some pr_info by dev_err when the word ERROR is printed. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/stmicro/stmm

Re: [PATCH 1/4] stmmac: replace all pr_xxx by their dev_xxx counterpart

On Wed, Sep 09, 2015 at 09:14:42AM -0700, Joe Perches wrote: > On Wed, 2015-09-09 at 15:14 +0200, LABBE Corentin wrote: > > The stmmac driver use lots of pr_xxx functions to print information. > > This is bad since we cannot know which device logs the information. > > (m

Re: [PATCH v2 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

On Wed, Dec 02, 2015 at 05:02:19PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/2/2015 3:54 PM, LABBE Corentin wrote: > > > The simple_strtol function is obsolete. > > This patch replace it by kstrtoint. > > This will simplify code, since some error case no

[PATCH v4 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

The simple_strtol function is obsolete. This patch replace it by kstrtoint. This will simplify code, since some error case not handled by simple_strtol are handled by kstrtoint. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/atm/solos-pci.

[PATCH v4 0/1] atm: solos-pci: Replace simple_strtol by kstrtoint

Hello Change since v3 - rework the test logic with ver/err Change since v2 - Invert a test logic Change since v1 - Always return error code from kstrtox. LABBE Corentin (1): atm: solos-pci: Replace simple_strtol by kstrtoint drivers/atm/solos-pci.c | 28 +--- 1 file

Re: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

On Thu, Dec 03, 2015 at 06:26:31AM -0500, Charles (Chas) Williams wrote: > On Thu, 2015-12-03 at 09:06 +0100, LABBE Corentin wrote: > > @@ -357,11 +357,11 @@ static int process_status(struct solos_card *card, > > int port, struct sk_buff *skb > > if (!str) > &

[PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

The simple_strtol function is obsolete. This patch replace it by kstrtoint. This will simplify code, since some error case not handled by simple_strtol are handled by kstrtoint. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/atm/solos-pci.

[PATCH v3 0/1] atm: solos-pci: Replace simple_strtol by kstrtoint

Hello Change since v2 - Invert a test logic Change since v1 - Always return error code from kstrtox. LABBE Corentin (1): atm: solos-pci: Replace simple_strtol by kstrtoint drivers/atm/solos-pci.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions

[PATCH] cxgb3: Convert simple_strtoul to kstrtox

the simple_strtoul function is obsolete. This patch replace it by kstrtox. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 10 - drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 28 ++--- 2 files c

[PATCH v2 0/1] atm: solos-pci: Replace simple_strtol by kstrtoint

Hello Change since v1 - Always return error code from kstrtox. LABBE Corentin (1): atm: solos-pci: Replace simple_strtol by kstrtoint drivers/atm/solos-pci.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) -- 2.4.10 -- To unsubscribe from this list

[PATCH v2 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint

The simple_strtol function is obsolete. This patch replace it by kstrtoint. This will simplify code, since some error case not handled by simple_strtol are handled by kstrtoint. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/atm/solos-pci.

[PATCH v2 1/1] cxgb3: Convert simple_strtoul to kstrtox

the simple_strtoul function is obsolete. This patch replace it by kstrtox. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 14 +++-- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 28 ++--- 2

[PATCH v2 0/1] cxgb3: Convert simple_strtoul to kstrtox

Hello Change since v1 - Always return kstrtox error code LABBE Corentin (1): cxgb3: Convert simple_strtoul to kstrtox drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 14 +++-- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 28 ++--- 2 files changed, 29

[PATCH] atm: solos-pci: Replace simple_strtol by kstrtoint

The simple_strtol function is obsolete. This patch replace it by kstrtoint. This will simplify code, since some error case not handled by simple_strtol are handled by kstrtoint. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/atm/solos-pci.c | 22 ---

Re: [PATCH 1/5] ethernet: add sun8i-emac driver

Hello I agree to all your comments, but for some I have additionnal questions On Mon, Jun 06, 2016 at 11:25:15AM -0700, Florian Fainelli wrote: > On 06/03/2016 02:56 AM, LABBE Corentin wrote: > > [snip] > > > + > > +/* The datasheet said that each descriptor can t

Re: [linux-sunxi] [PATCH 1/5] ethernet: add sun8i-emac driver

On Sun, Jun 05, 2016 at 11:32:11PM +0100, André Przywara wrote: > On 03/06/16 10:56, LABBE Corentin wrote: > > Hi, > > first: thanks for posting this and the time and work that you spent on > it. With the respective DT nodes this works for me on the Pine64 and > turns

[PATCH 4/5] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver

The sun8i-emac is an ethernet MAC hardware that support 10/100/1000 speed. This patch enable the sun8i-emac on the Allwinner H3 SoC Device-tree. The SoC H3 have an internal PHY, so optionals syscon and ephy are set. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- arch/arm/bo

[PATCH 5/5] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC

The sun8i-emac hardware is present on the Orange PI PC. It uses the internal PHY. This patch create the needed emac and phy nodes. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 11 +++ 1 file changed, 11 insertions(+)

[PATCH 2/5] MAINTAINERS: Add myself as maintainers of sun8i-emac

Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index ed42cb6..d8f5c14 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -581,6 +581,12 @@ S: Maintained F: Documentation/i2c/buss

[PATCH 0/5] net-next: ethernet: add sun8i-emac driver

on the following boards: - H3 Orange PI PC, Orange PI Plus, BananaPI-M2+ - A64 Pine64 - A83T BananaPI-M3 I would like to thanks Chen-Yu Tsai for his help on developing this driver. Regards LABBE Corentin (5): ethernet: add sun8i-emac driver MAINTAINERS: Add myself as maintainers of sun8i-emac ARM

[PATCH 1/5] ethernet: add sun8i-emac driver

This patch add support for sun8i-emac ethernet MAC hardware. It could be found in Allwinner H3/A83T/A64 SoCs. It supports 10/100/1000 Mbit/s speed with half/full duplex. It can use an internal PHY (MII 10/100) or an external PHY via RGMII/RMII. Signed-off-by: LABBE Corentin <clabbe.mo

[PATCH 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

This patch adds documentation for Device-Tree bindings for the Allwinner sun8i-emac driver. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- .../bindings/net/allwinner,sun8i-emac.txt | 64 ++ 1 file changed, 64 insertions(+) create mode

[PATCH v2] phy: remove documentation of removed members of phy_device structure

Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed addr, bus and dev member of the phy_device structure. This patch remove the documentation about those members. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- include/linux/phy.h | 3 --- 1 file chan

Re: [PATCH] phy: remove documentation of removed member addr of phy_device structure

On Thu, Mar 03, 2016 at 04:14:19PM +0100, Andrew Lunn wrote: > On Thu, Mar 03, 2016 at 02:12:28PM +0100, LABBE Corentin wrote: > > Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed > > the addr member of the phy_device structure. > > This patch

[PATCH] phy: remove documentation of removed member addr of phy_device structure

Commit e5a03bfd873c ("phy: Add an mdio_device structure") removed the addr member of the phy_device structure. This patch remove the documentation about that member. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- include/linux/phy.h | 1 - 1 file changed, 1 deletio

Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver

On Wed, Jul 20, 2016 at 11:56:12AM +0200, Arnd Bergmann wrote: > On Wednesday, July 20, 2016 10:03:16 AM CEST LABBE Corentin wrote: > > + > > + /* Benched on OPIPC with 100M, setting more than 256 does not give > > any > > +* perf boost > > +

Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

On Thu, Jul 21, 2016 at 09:55:19AM +0200, Maxime Ripard wrote: > Hi, > > On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off

Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

On Wed, Jul 20, 2016 at 02:15:33PM -0500, Rob Herring wrote: > On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off-by: LABBE Corentin

Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver

On Mon, Jul 25, 2016 at 09:54:55PM +0200, Maxime Ripard wrote: > On Wed, Jul 20, 2016 at 10:03:16AM +0200, LABBE Corentin wrote: > > This patch add support for sun8i-emac ethernet MAC hardware. > > It could be found in Allwinner H3/A83T/A64 SoCs. > > > > It suppor

Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

On Thu, Jul 28, 2016 at 08:49:16PM +0200, Maxime Ripard wrote: > On Thu, Jul 28, 2016 at 03:40:31PM +0200, LABBE Corentin wrote: > > On Thu, Jul 21, 2016 at 09:55:19AM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > On Wed, Jul 20, 2016 at 10

[PATCH] net: bfin_mac: Fix a few spelling fixes

This patch respell some word badly spelled. - Invidate instead of Invalidate - proble instead of probe Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/net/ethernet/adi/bfin_mac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

This patch adds documentation for Device-Tree bindings for the Allwinner sun8i-emac driver. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- .../bindings/net/allwinner,sun8i-emac.txt | 65 ++ 1 file changed, 65 insertions(+) create mode

[PATCH v2 1/5] ethernet: add sun8i-emac driver

This patch add support for sun8i-emac ethernet MAC hardware. It could be found in Allwinner H3/A83T/A64 SoCs. It supports 10/100/1000 Mbit/s speed with half/full duplex. It can use an internal PHY (MII 10/100) or an external PHY via RGMII/RMII. Signed-off-by: LABBE Corentin <clabbe.mo

[PATCH v2 2/5] MAINTAINERS: Add myself as maintainers of sun8i-emac

Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1d74837..daefb19 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -581,6 +581,12 @@ S: Maintained F: Documentation/i2c/buss

[PATCH v2 0/5] net-next: ethernet: add sun8i-emac driver

unneeded __packked and __aligned - Added tuning of RX/TX ring size via ethtool - Corrected use of sk/skb naming - Added some wmb when needed - Moved irq claim/free to emac_open/close - Lots of code refactoring LABBE Corentin (5): ethernet: add sun8i-emac driver MAINTAINERS: Add myself

[PATCH v2 5/5] ARM: dts: sun8i: Enable sun8i-emac on the Orange PI PC

The sun8i-emac hardware is present on the Orange PI PC. It uses the internal PHY. This patch create the needed emac and phy nodes. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 11 +++ 1 file changed, 11 insertions(+)

[PATCH v2 4/5] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver

The sun8i-emac is an ethernet MAC hardware that support 10/100/1000 speed. This patch enable the sun8i-emac on the Allwinner H3 SoC Device-tree. The SoC H3 have an internal PHY, so optionals syscon and ephy are set. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- arch/arm/bo

[PATCH] atm: fore200e: Do not drop const qualifier

The data member of structure firmware is const and this constness is dropped by some cast. This patch add some const for keeping the const information. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> --- drivers/atm/fore200e.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support

On Mon, Sep 12, 2016 at 10:44:51PM +0200, Maxime Ripard wrote: > Hi, > > On Fri, Sep 09, 2016 at 02:45:17PM +0200, Corentin Labbe wrote: > > This patch add pm_runtime support to sun8i-emac. > > For the moment, only basic support is added, (the device is marked as > > used when net/open) > > > >

Re: [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver

On Mon, Sep 12, 2016 at 09:29:33AM +0200, Maxime Ripard wrote: > On Fri, Sep 09, 2016 at 02:45:13PM +0200, Corentin Labbe wrote: > > The sun8i-emac is an ethernet MAC hardware that support 10/100/1000 > > speed. > > > > This patch enable the sun8i-emac on the Allwinner H3 SoC Device-tree. > > The

Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver

On Fri, Sep 09, 2016 at 04:15:27PM +0200, Andrew Lunn wrote: > Hi Corentin > > > +static int sun8i_emac_mdio_register(struct net_device *ndev) > > +{ > > + struct sun8i_emac_priv *priv = netdev_priv(ndev); > > + struct mii_bus *bus; > > + int ret; > > + > > + bus = mdiobus_alloc(); > >

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

On Fri, Sep 09, 2016 at 04:17:10PM +0200, Andrew Lunn wrote: > > +Optional properties: > > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. > > Default is 0) > > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. > > Default is 0) > > What are the

Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module

On Mon, Sep 12, 2016 at 09:28:12AM +0200, Maxime Ripard wrote: > On Fri, Sep 09, 2016 at 02:45:12PM +0200, Corentin Labbe wrote: > > This patch add the dt node for the syscon register present on the > > Allwinner H3. > > > > Only two register are present in this syscon and the only one useful is

Re: [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig

On Mon, Sep 12, 2016 at 09:30:08AM +0200, Maxime Ripard wrote: > Hi, > > On Fri, Sep 09, 2016 at 02:45:16PM +0200, Corentin Labbe wrote: > > Enable the sun8i-emac driver in the sunxi default configuration > > > > Signed-off-by: Corentin Labbe > > Could you make the

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

On Fri, Sep 09, 2016 at 04:04:13PM +0200, Andrew Lunn wrote: > > +The device node referenced by "phy" or "phy-handle" should be a child node > > +of this node. See phy.txt for the generic PHY bindings. > > I've not looked at the code yet, but is this really true? Generally > there is not this

Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig

On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > Signed-off-by: Corentin Labbe > > --- > >

Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver

> > +/* Set Management Data Clock, must be call after device reset */ > > +static void sun8i_emac_set_mdc(struct net_device *ndev) > > +{ > > + struct sun8i_emac_priv *priv = netdev_priv(ndev); > > + unsigned long rate; > > + u32 reg; > > + > > + rate = clk_get_rate(priv->ahb_clk); > > +

Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver

On Fri, Oct 07, 2016 at 08:02:39AM -0700, Joe Perches wrote: > On Fri, 2016-10-07 at 10:25 +0200, Corentin Labbe wrote: > > This patch add support for sun8i-emac ethernet MAC hardware. > > It could be found in Allwinner H3/A83T/A64 SoCs. > > trivial notes: > > > diff --git

Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig

On Tue, Oct 11, 2016 at 11:40:42AM +0200, Maxime Ripard wrote: > On Mon, Oct 10, 2016 at 03:09:43PM +0200, Jean-Francois Moine wrote: > > On Mon, 10 Oct 2016 14:35:11 +0200 > > LABBE Corentin <clabbe.montj...@gmail.com> wrote: > > > > > On Mon, Oct 10, 201

Re: [PATCH v4 03/10] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

On Mon, Oct 10, 2016 at 10:13:35AM -0500, Rob Herring wrote: > On Fri, Oct 07, 2016 at 10:25:50AM +0200, Corentin Labbe wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off-by: Corentin Labbe > >

Re: [PATCH] net: ethernet: fec: Add missing SPEED_

On Thu, Oct 18, 2018 at 11:55:49AM -0700, Florian Fainelli wrote: > On 10/18/2018 11:47 AM, LABBE Corentin wrote: > > On Thu, Oct 18, 2018 at 11:39:24AM -0700, Florian Fainelli wrote: > >> On 10/18/2018 08:05 AM, Corentin Labbe wrote: > >>> Since commit 580

Re: [PATCH net-next] net: phy: phy_support_sym_pause: Clear Asym Pause

On Sat, Oct 20, 2018 at 10:41:28PM +0200, Andrew Lunn wrote: > When indicating the MAC supports Symmetric Pause, clear the Asymmetric > Pause bit, which could of been already set is the PHY supports it. > > Reported-by: Labbe Corentin > Fixes: c306ad36184f ("net: ethernet: