ng ip exec vrf with libcap")
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
Reported on Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=898015
The reporter tested this patch and verified it solves the issue.
lib/utils.c | 15 ---
man/man8/ip-vrf.8 |
d the
problem:
93fa12418dc6f5943692250244be303bb162175b
utils: Always specify family and ->bytelen in get_prefix_1()
Could you please have a look when you have a moment? It's very easy to
reproduce, and it breaks existing scripts and so on.
Thanks!
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
On Wed, 2018-05-16 at 16:53 +0200, Michal Kubecek wrote:
> On Wed, May 16, 2018 at 02:42:24PM +0100, Luca Boccassi wrote:
> > Hans reported a regression in v4.16.0, ip route now requires -6 to
> > be
> > manually added when using v6 addresses while up to 4.15 it didn't,
> &
Documentation should be distribution-agnostic - any specific quirks
should be handled by downstream maintainers, if necessary.
Remove mentions of Debian paths and package names.
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
man/man8/lnstat.8 | 3 +--
man/man8/ss.8 | 3 +--
2
com>
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
man/man8/ip.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip.8 b/man/man8/ip.8
index ae018fdf..94e64319 100644
--- a/man/man8/ip.8
+++ b/man/man8/ip.8
@@ -1,6 +1,6 @@
.TH IP 8 "20 Dec 2011&q
.hu>
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
man/man8/ip-address.8.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/man/man8/ip-address.8.in b/man/man8/ip-address.8.in
index eaa179c6..e7f14533 100644
--- a/man/man8/ip-address.8.in
+++ b/man/man8/ip-address.8.in
@@ -190,6 +1
-by: Luca Boccassi <bl...@debian.org>
---
man/man8/routel.8 | 5 -
1 file changed, 5 deletions(-)
diff --git a/man/man8/routel.8 b/man/man8/routel.8
index 82d580fb..2270eacb 100644
--- a/man/man8/routel.8
+++ b/man/man8/routel.8
@@ -17,11 +17,6 @@ The routel script will list routes in a
On Fri, 2017-12-29 at 20:04 -0800, Stephen Hemminger wrote:
> On Fri, 29 Dec 2017 23:01:24 +0100
> Luca Boccassi <bl...@debian.org> wrote:
>
> > Trying to set a label longer than 15 characters returns an error:
> > RTNETLINK answers: Numerical result out of range
On Fri, 2017-12-29 at 20:02 -0800, Stephen Hemminger wrote:
> On Fri, 29 Dec 2017 23:01:23 +0100
> Luca Boccassi <bl...@debian.org> wrote:
>
> > A Debian user suggested adding more network-related keywords to the
> > ip manpage, so that manpage-scraping and indexing so
Documentation should be distribution-agnostic - any specific quirks
should be handled by downstream maintainers, if necessary.
Remove mentions of Debian paths and package names.
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
man/man8/lnstat.8 | 3 +--
man/man8/ss.8 | 3 +--
2
.hu>
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
man/man8/ip-address.8.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/man/man8/ip-address.8.in b/man/man8/ip-address.8.in
index eaa179c6..7ebf0bc9 100644
--- a/man/man8/ip-address.8.in
+++ b/man/man8/ip-address.8.in
@@ -190,6 +1
com>
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
man/man8/ip.8 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip.8 b/man/man8/ip.8
index ae018fdf..7f26582d 100644
--- a/man/man8/ip.8
+++ b/man/man8/ip.8
@@ -1,6 +1,6 @@
.TH IP 8 "20 Dec 2011&q
-by: Luca Boccassi <bl...@debian.org>
---
man/man8/routel.8 | 5 -
1 file changed, 5 deletions(-)
diff --git a/man/man8/routel.8 b/man/man8/routel.8
index 82d580fb..2270eacb 100644
--- a/man/man8/routel.8
+++ b/man/man8/routel.8
@@ -17,11 +17,6 @@ The routel script will list routes in a
487814431958=2
Patchwork:
https://patchwork.ozlabs.org/patch/854412/
https://patchwork.ozlabs.org/patch/854410/
Thanks
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
.
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
man/man8/devlink-sb.8 | 2 +-
man/man8/ip-link.8.in | 2 +-
man/man8/tc-u32.8 | 6 ++
3 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/man/man8/devlink-sb.8 b/man/man8/devlink-sb.8
index ffb5553e..1882833a 100644
---
testsuite/lib/generic.sh | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Series acked-by: Luca Boccassi <bl...@debian.org>
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
ot;, NULL);
> print_color_string(PRINT_ANY, ifa_family_color(frh-
> >family),
> - "dst", "%s ", dst);
> + "dst", "%s", dst);
> if (frh->dst_len != host_len)
>
file | 16 +++-
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/testsuite/Makefile b/testsuite/Makefile
> index 8fcbc55..f9f3b19 100644
Acked-by: Luca Boccassi
Looks good to me, thanks.
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
On Thu, 2018-08-23 at 09:07 +0200, Stefan Bader wrote:
> On 22.08.2018 20:09, Luca Boccassi wrote:
> > Some generated test files were not removed, including one
> > executable in
> > the testsuite/tools directory.
> > Ensure make clean from the top level directory
Some distributions like Debian nowadays restrict the dmesg command to
root-only. Run it with sudo in the testsuite.
Signed-off-by: Luca Boccassi
---
testsuite/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuite/Makefile b/testsuite/Makefile
index 5e269877
The generate_nlmsg binary is required but make -C testsuite compile
does not build it. Add the necessary includes and C*FLAGS to the tools
Makefile and have the compile target build it.
Signed-off-by: Luca Boccassi
---
testsuite/Makefile | 1 +
testsuite/tools/Makefile | 4 +++-
2 files
Some generated test files were not removed, including one executable in
the testsuite/tools directory.
Ensure make clean from the top level directory works for the testsuite
subdirs too, and that all the files are removed.
Signed-off-by: Luca Boccassi
---
Makefile | 2
15 - Stephen's revert will be enough for
now. I'm going to push 4.16 as soon as it's out anyway, so you can just
do the changes for master if you wish.
> On 13.03.2018 13:02, Luca Boccassi wrote:
> > On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote:
> > > Hello again,
&g
ions. It no longer flushed all IPv4 routes.
>
> Reported-by: Luca Boccassi <bl...@debian.org>
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
> ip/iproute.c | 65 ++--
>
> lib/utils.c | 13 ++
y" argument
> > behaves? My original concern was about "default" only. I agree too,
> > that "all" or "any" should work for all routes. But not for the
> > default.
> >
> > 12.03.2018, 22:37, "Luca Boccassi" <bl...@debian.o
f "default" prefix parameter was corrected. But
> at
> the same time behaviour of "all"/"any" was altered too, because they
> were the same branch of the code. As those parameters mean different,
> they need to be treated differently in code too. This patch re
On Tue, 2018-03-27 at 10:40 -0600, David Ahern wrote:
> On 3/27/18 10:24 AM, Luca Boccassi wrote:
> > ip vrf exec requires root or CAP_NET_ADMIN, CAP_SYS_ADMIN and
> > CAP_DAC_OVERRIDE. It is not possible to run unprivileged commands
> > like
> > ping as non-
capabilities on start if not
invoked with "vrf exec".
Update the manpage with the requirements.
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
Changes since RFC: moved drop_cap to lib/util.c to call it from
ipvrf.c after vrf_switch, which is the function that requires the
additi
On Tue, 2018-03-27 at 10:15 -0700, Stephen Hemminger wrote:
> On Tue, 27 Mar 2018 17:24:19 +0100
> Luca Boccassi <bl...@debian.org> wrote:
>
> > ip vrf exec requires root or CAP_NET_ADMIN, CAP_SYS_ADMIN and
> > CAP_DAC_OVERRIDE. It is not possible to run unprivileged
capabilities on start if not
invoked with "vrf exec".
Update the manpage with the requirements.
Signed-off-by: Luca Boccassi <bl...@debian.org>
---
I'd like to be able to run ip vrf exec as a normal user, does this approach
sound sensible? Any concerns? Are there any other alternatives
If libc does not provide strlcpy check for libbsd with pkg-config to
avoid relying on inline version.
Signed-off-by: Luca Boccassi
---
This allows distro maintainers to be able to choose to reduce
duplication and let this code be maintained in one place, in the
external library.
configure | 12
If libc does not provide strlcpy check for libbsd with pkg-config to
avoid relying on inline version.
Signed-off-by: Luca Boccassi
---
Changed from -include /usr/include/bsd/string.h hack to HAVE_LIBBSD
and proper includes in each file that uses strlcpy.
The hack causes a compiler warning as ip
On Wed, 2018-10-31 at 08:09 -0700, Stephen Hemminger wrote:
> On Mon, 29 Oct 2018 10:46:50 +
> Luca Boccassi wrote:
>
> > If libc does not provide strlcpy check for libbsd with pkg-config
> > to
> > avoid relying on inline version.
> >
lable")
Signed-off-by: Luca Boccassi
---
genl/ctrl.c | 3 ---
include/utils.h | 4
ip/iplink.c | 3 ---
ip/ipnetns.c | 3 ---
ip/iproute_lwtunnel.c | 3 ---
ip/ipvrf.c| 3 ---
ip/ipxfrm.c | 3 ---
ip/tunnel.c | 3 ---
ip/xf
Follow the standard pattern, and respect user's verbosity setting.
Signed-off-by: Luca Boccassi
---
testsuite/tools/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuite/tools/Makefile b/testsuite/tools/Makefile
index e1d9bfef..85df69ec 100644
--- a/testsuite
When building Debian packages pre-processor flags are passed via
CPPFLAGS, as the convention indicates. Specifically, the hardening
-D_FORTIFY_SOURCE=2 flag is used.
Pass CPPFLAGS to all calls of QUIET_CC together with CFLAGS.
Signed-off-by: Luca Boccassi
---
configure | 2 +-
misc/Makefile
". If" gets interpreted as a macro, so move the period to the previous
line:
33: warning: macro `If' not defined
Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
Signed-off-by: Luca Boccassi
---
man/man8/tc-skbprio.8 | 4 ++--
1 file changed, 2 insert
Fixes groff warning:
ss.8 92: warning [p 2, 2.8i]: can't break line
And makes the line also more readable.
Signed-off-by: Luca Boccassi
---
This line is the example of an output, so you might not want to break it.
Let me know if you prefer a different solution.
man/man8/ss.8 | 8 +++-
1
On Fri, 2018-11-02 at 15:19 +, Edward Cree wrote:
> On 02/11/18 10:57, Luca Boccassi wrote:
> > ". If" gets interpreted as a macro, so move the period to the
> > previous
> > line:
> >
> > 33: warning: macro `If' not defined
> >
> &g
". If" gets interpreted as a macro, so move the period to the previous
line:
33: warning: macro `If' not defined
Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
Signed-off-by: Luca Boccassi
---
v2: remove extra space to avoid making the full-stop bold.
m
On Mon, 2018-10-29 at 09:27 -0600, David Ahern wrote:
> On 10/29/18 4:46 AM, Luca Boccassi wrote:
> > If libc does not provide strlcpy check for libbsd with pkg-config
> > to
> > avoid relying on inline version.
> >
> > Signed-off-by: Luca Boccassi
> >
It's $(QUIET_CC)$(CC) not $(QUIET_CC), copy-paste error. CI does
verbose build so it slipped through.
Fixes: 6e7d347aabbb ("testsuite: build generate_nlmsg with QUIET_CC")
Signed-off-by: Luca Boccassi
---
testsuite/tools/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletio
e_nlmsg when needed
> testsuite: Warn about empty $(IPVERS)
>
> testsuite/Makefile | 21 ++---
> 1 file changed, 14 insertions(+), 7 deletions(-)
Series-tested-by: Luca Boccassi
--
Kind regards,
Luca Boccassi
signature.asc
Description: This is a digitally signed message part
43 matches
Mail list logo
