Re: [PATCH] natsemi: Messages being noisy

2006-09-15 Thread Mark Brown
On Thu, Sep 14, 2006 at 08:46:07AM -0700, [EMAIL PROTECTED] wrote: On Thu, Sep 14, 2006 at 05:39:08PM +0200, Ingo Oeser wrote: Is it possible to have the maximum value right from the start? May I tune it somewhere to be the maximum from the start? This will (if I recall) increase transmit

Re: [patch 3/9] natsemi: Add support for using MII port with no PHY

2006-04-28 Thread Mark Brown
On Thu, Apr 27, 2006 at 05:54:58AM -0400, Jeff Garzik wrote: Provide a module option which configures the natsemi driver to use the external MII port on the chip but ignore any PHYs that may be attached to it. The link state will be left as it was when the driver started and can The proper

[PATCH] natsemi: NAPI support

2005-12-04 Thread Mark Brown
that functionality any more. Signed-off-by: Mark Brown [EMAIL PROTECTED] --- linux-2.6.14/drivers/net/natsemi.c.orig 2005-11-29 19:29:12.0 + +++ linux/drivers/net/natsemi.c 2005-12-04 22:13:33.0 + @@ -3,6 +3,7 @@ Written/copyright 1999-2001 by Donald Becker. Portions

Re: [PATCH] natsemi: NAPI support

2005-12-05 Thread Mark Brown
On Mon, Dec 05, 2005 at 12:12:09AM +0100, Francois Romieu wrote: - netif_poll_disable() may sleep while a spinlock is held. So it can, thanks. Btw, the poll/close routines seem racy with each other. I had been under the impression that the stack was supposed to make sure that no poll() is

Re: [PATCH] natsemi: NAPI support

2005-12-06 Thread Mark Brown
On Tue, Dec 06, 2005 at 01:19:34AM +0100, Francois Romieu wrote: Mark Brown [EMAIL PROTECTED] : I had been under the impression that the stack was supposed to make sure that no poll() is running before the driver close() gets called? Not exactly. dev_close() waits a bit but it can

Re: [PATCH] natsemi: NAPI support

2005-12-09 Thread Mark Brown
On Tue, Dec 06, 2005 at 10:56:19PM +0100, Francois Romieu wrote: netif_rx_schedule_prep return netif_running(dev) dev_close clear_bit(__LINK_STATE_START, dev-state); Oh, of course - thanks for bearing wth me. Will fix that too and resubmit. -- You grabbed my hand and we fell

[PATCH] natsemi: NAPI support

2005-12-12 Thread Mark Brown
that functionality any more. Signed-off-by: Mark Brown [EMAIL PROTECTED] --- This revision of the patch: - Doesn't sleep with the device spinlock held in suspend(). - Improves the synchronisation between poll() and the shutdown paths. --- linux-2.6.14/drivers/net/natsemi.c.orig 2005-11-29 19:29

Re: [PATCH] natsemi: NAPI support

2005-12-13 Thread Mark Brown
On Mon, Dec 12, 2005 at 07:25:20PM -0500, Jeff Garzik wrote: Was it updated per the comments you received on the first posting? I think I addressed everything, yes. -- You grabbed my hand and we fell into it, like a daydream - or a fever. signature.asc Description: Digital signature

Resubmit: [PATCH] natsemi: NAPI support

2005-12-21 Thread Mark Brown
that functionality any more. Signed-off-by: Mark Brown [EMAIL PROTECTED] --- This revision of the patch: - Doesn't sleep with the device spinlock held in suspend(). - Improves the synchronisation between poll() and the shutdown paths. and should address all the issues people previously raised. --- linux

Re: Resubmit: [PATCH] natsemi: NAPI support

2006-01-03 Thread Mark Brown
that functionality any more. Signed-off-by: Mark Brown [EMAIL PROTECTED] --- This revision of the patch: - Doesn't sleep with the device spinlock held in suspend(). - Improves the synchronisation between poll() and the shutdown paths. --- linux-2.6.14/drivers/net/natsemi.c.orig 2005-11-29 19:29

[patch 0/2] natsemi: NAPI and a bugfix

2006-02-02 Thread Mark Brown
These patches provide a series of updates to the natsemi driver: the NAPI patch I've submitted before and a workaround for an issue with the hardware that is easier to provoke at higher data rates. 1/2: Convert the driver to NAPI 2/2: Fix hardware issue with RX state machine lock up -- You

[patch 2/2] natsemi: NAPI and a bugfix

2006-02-02 Thread Mark Brown
implements the fix from the application note: when an oversized packet is reported it resets the RX state machine, dropping any currently pending packets. Signed-off-by: Mark Brown [EMAIL PROTECTED] Index: linux-2.6.15.2/drivers/net/natsemi.c

[patch 1/2] natsemi: NAPI and a bugfix

2006-02-02 Thread Mark Brown
. Signed-off-by: Mark Brown [EMAIL PROTECTED] Index: linux-2.6.15.2/drivers/net/natsemi.c === --- linux-2.6.15.2.orig/drivers/net/natsemi.c 2006-01-31 06:25:07.0 + +++ linux-2.6.15.2/drivers/net/natsemi.c2006-02-01

Re: Natsemi DP83815 driver spaming

2007-05-01 Thread Mark Brown
On Mon, Apr 30, 2007 at 08:55:22PM -0700, Andrew Morton wrote: On Mon, 30 Apr 2007 22:58:47 +0200 Rafał Bilski [EMAIL PROTECTED] wrote: ezri user.info kernel: eth0: DSPCFG accepted after 0 usec. ezri user.notice kernel: eth0: Wake-up event 0x8a ezri user.info kernel: eth0: Setting

Re: Natsemi DP83815 driver spaming

2007-05-01 Thread Mark Brown
On Tue, May 01, 2007 at 12:25:20PM +0200, Rafał Bilski wrote: eth0: Media selection timer tick. eth0: possible phy reset: re-initializing This is why the reset is being triggered - it's a workaround for a hardware bug which checks to make sure the hardware is in the state that the kernel

Re: Natsemi DP83815 driver spaming

2007-05-01 Thread Mark Brown
On Tue, May 01, 2007 at 09:52:30PM +0200, Rafał Bilski wrote: * 2) check for sudden death of the NIC: *It seems that a reference set for this chip went out with incorrect info, *and there exist boards that aren't quite right. An unexpected voltage *drop can cause the

Re: Natsemi DP83815 driver spaming

2007-05-02 Thread Mark Brown
On Tue, May 01, 2007 at 11:51:41PM -0700, Tim Hockin wrote: I'm not sure what the right answer is. The code was designed to do the right thing, and yet in your case it's broken. Does it need to be a build option to work around broken hardware? Yuck. Without a system that really needs the

Re: Natsemi DP83815 driver spaming

2007-05-02 Thread Mark Brown
On Wed, May 02, 2007 at 10:05:31PM +0200, Rafał Bilski wrote: What about module option? That would work, though you crossed in the post with me writing a patch adding a sysfs file; I merged the two for overkill (below). I also have a patch which changes the log message for the workaround so

[PATCH 1/2] natsemi: Improve diagnostics for DspCfg workaround

2007-05-03 Thread Mark Brown
-By: Mark Brown [EMAIL PROTECTED] --- drivers/net/natsemi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c index a8d7ff2..109e802 100644 --- a/drivers/net/natsemi.c +++ b/drivers/net/natsemi.c @@ -1756,7 +1756,7 @@ static void

[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset

2007-05-03 Thread Mark Brown
on any given system provide an option in sysfs allowing users to disable the workaround at runtime and provides a module option to set the default. Signed-Off-By: Mark Brown [EMAIL PROTECTED] --- drivers/net/natsemi.c | 68 - 1 files changed, 66

[PATCH 0/2] natsemi: Improve DspCfg workaround

2007-05-03 Thread Mark Brown
The natsemi driver contains a workaround for broken hardware which can on some boards cause more problems than it solves. The following patch series improves this by making the diagnostic more obvious and allowing users to disable the workaround if it causes them problems. -- You grabbed my

[patch 2/4] natsemi: Support oversized EEPROMs

2006-03-12 Thread Mark Brown
The natsemi chip can have a larger EEPROM attached than it itself uses for configuration. This patch adds support for user space access to such an EEPROM. Signed-off-by: Mark Brown [EMAIL PROTECTED] Index: natsemi-queue/drivers/net/natsemi.c

[patch 4/4] natsemi: Add quirks for Aculab E1/T1 PMXc cPCI carrier cards

2006-03-12 Thread Mark Brown
duplex, having a large EEPROM and using the MII port while ignoring PHYs. Signed-off-by: Mark Brown [EMAIL PROTECTED] Index: natsemi-queue/drivers/net/natsemi.c === --- natsemi-queue.orig/drivers/net/natsemi.c2006-02-25 17:41

[patch 0/4] natsemi: Aculab E1/T1 PMXc Carrier Card support

2006-03-12 Thread Mark Brown
This patch series against the upstream branch of netdev-2.6 adds support for these boards to the natsemi driver. It implements some new functionality required by the boards and enables the appropriate settings when such a board is detected. -- You grabbed my hand and we fell into it, like a

[patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-12 Thread Mark Brown
be accessed via the MII ioctl()s. This is useful for systems where the device is connected without a PHY or where either information or actions outside the scope of the driver are required in order to use the PHYs. Signed-Off-By: Mark Brown [EMAIL PROTECTED] Index: natsemi-queue/drivers/net/natsemi.c

Re: [patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-13 Thread Mark Brown
On Sun, Mar 12, 2006 at 01:41:13PM -0800, [EMAIL PROTECTED] wrote: Not that my opinion should hold much weight, having been absent from the driver for some time, but yuck. Is there no better way to do this thatn sprinkling poo all over it? The changes are mostly isolated into check_link(),

Re: [patch 1/4] natsemi: Add support for using MII port with no PHY

2006-03-16 Thread Mark Brown
On Thu, Mar 16, 2006 at 01:09:02AM -0800, Andrew Morton wrote: Mark Brown [EMAIL PROTECTED] wrote: + if (np-ignore_phy (ecmd-autoneg == AUTONEG_ENABLE || + ecmd-port == PORT_INTERNAL)) { What's PORT_INTERNAL? ethtool doesn't appear to define that. It should

[patch 0/2] natsemi: Support Aculab E1/T1 cPCI carrier cards

2007-02-14 Thread Mark Brown
These patches add support for the Aculab E1/T1 cPCI carrier card to the natsemi driver. The first patch provides support for using the MII port with no PHY and the second adds the quirk required to configure the card. -- You grabbed my hand and we fell into it, like a daydream - or a fever. - To

[patch 2/2] natsemi: Support Aculab E1/T1 PMXc cPCI carrier cards

2007-02-14 Thread Mark Brown
Aculab E1/T1 PMXc cPCI carrier card cards present a natsemi on the cPCI bus with an oversized EEPROM using a direct MII-MII connection with no PHY. This patch adds a new device table entry supporting these cards. Signed-Off-By: Mark Brown [EMAIL PROTECTED] Index: linux/drivers/net/natsemi.c

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-14 Thread Mark Brown
On Wed, Feb 14, 2007 at 03:28:34PM +0200, Ahmed S. Darwish wrote: A trivial comment actually, Is there a point to write multi-line comments in two different formats ? No goal in doing that, no - it wasn't a conscious decision. -- You grabbed my hand and we fell into it, like a daydream - or

[patch 0/2] natsemi: Support Aculab E1/T1 cPCI carrier cards

2007-02-19 Thread Mark Brown
These patches add support for the Aculab E1/T1 cPCI carrier card to the natsemi driver. The first patch provides support for using the MII port with no PHY and the second adds the quirks required to detect and configure the card. This revision should address the issues raised by Jeff over the

[patch 2/2] natsemi: Support Aculab E1/T1 PMXc cPCI carrier cards

2007-02-19 Thread Mark Brown
Aculab E1/T1 PMXc cPCI carrier card cards present a natsemi on the cPCI bus with an oversized EEPROM using a direct MII-MII connection with no PHY. This patch adds a new device table entry supporting these cards. Signed-Off-By: Mark Brown [EMAIL PROTECTED] --- This revision removes extra

[patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-19 Thread Mark Brown
the MII ioctl()s. This is useful for systems where the device is connected without a PHY or where either information or actions outside the scope of the driver are required in order to use the PHYs. Signed-Off-By: Mark Brown [EMAIL PROTECTED] --- This revision of the patch fixes some issues brought

natsemi: Fix detection of vanilla natsemi cards

2007-02-23 Thread Mark Brown
for the vanilla cards. This patch fixes the problem minimally. Signed-Off-By: Mark Brown [EMAIL PROTECTED] --- linux.orig/drivers/net/natsemi.c2007-02-23 11:13:03.0 + +++ linux/drivers/net/natsemi.c 2007-02-23 11:12:00.0 + @@ -260,7 +260,7 @@ static const struct

Re: natsemi: Fix detection of vanilla natsemi cards

2007-02-23 Thread Mark Brown
On Fri, Feb 23, 2007 at 07:47:40AM -0600, Bob Tracy wrote: ACK except for a missing comma at the end of the line being replaced, which prevents the patch from applying cleanly. Otherwise, this fixes the problem I was having. Thanks! Aargh. --- linux.orig/drivers/net/natsemi.c2007-02-23

natsemi: Fix detection of vanilla natsemi cards

2007-02-25 Thread Mark Brown
for the vanilla cards. This patch fixes the problem minimally. Signed-Off-By: Mark Brown [EMAIL PROTECTED] --- linux.orig/drivers/net/natsemi.c2007-02-23 11:13:03.0 + +++ linux/drivers/net/natsemi.c 2007-02-23 11:12:00.0 + @@ -260,7 +260,7 @@ static const struct

Re: [PATCH] natsemi: netpoll fixes

2007-03-05 Thread Mark Brown
On Tue, Mar 06, 2007 at 12:10:08AM +0400, Sergei Shtylyov wrote: #ifdef CONFIG_NET_POLL_CONTROLLER static void natsemi_poll_controller(struct net_device *dev) { + struct netdev_private *np = netdev_priv(dev); + disable_irq(dev-irq); - intr_handler(dev-irq, dev); + +

Re: [PATCH] natsemi: netpoll fixes

2007-03-05 Thread Mark Brown
[Once more with CCs] On Tue, Mar 06, 2007 at 12:10:08AM +0400, Sergei Shtylyov wrote: #ifdef CONFIG_NET_POLL_CONTROLLER static void natsemi_poll_controller(struct net_device *dev) { + struct netdev_private *np = netdev_priv(dev); + disable_irq(dev-irq); -

Re: [PATCH] natsemi: netpoll fixes

2007-03-11 Thread Mark Brown
register is only read when there is no poll scheduled. It also reverts a workaround for this problem from the netpoll hook. Thanks to Sergei Shtylyov [EMAIL PROTECTED] for spotting the issue and Simon Blake [EMAIL PROTECTED] for testing resources. Signed-Off-By: Mark Brown [EMAIL PROTECTED] Index

Re: [PATCH] natsemi: netpoll fixes

2007-03-12 Thread Mark Brown
On Mon, Mar 12, 2007 at 04:05:48PM +0300, Sergei Shtylyov wrote: Mark Brown wrote: hands_off is stronger than that - it's used for sync with some of the other code paths like suspend/resume and means don't touch the chip. I've added a new driver local flag instead. I'm not sure

Re: [PATCH] natsemi: netpoll fixes

2007-03-12 Thread Mark Brown
method and Simon Blake [EMAIL PROTECTED] for testing resources. Signed-Off-By: Mark Brown [EMAIL PROTECTED] Index: linux-2.6/drivers/net/natsemi.c === --- linux-2.6.orig/drivers/net/natsemi.c2007-03-11 02:32:43.0 +

Re: [PATCH] natsemi: netpoll fixes

2007-03-13 Thread Mark Brown
On Tue, Mar 13, 2007 at 04:53:54PM +0300, Sergei Shtylyov wrote: Mark Brown wrote: confused and eventually locks up. Before locking up it will usually report one or more oversided packets so this is a useful hint that we should reset the recieve state machine in order to recover from

[PATCH] natsemi: Use NATSEMI_TIMER_FREQ consistently

2007-10-09 Thread Mark Brown
-by: Mark Brown [EMAIL PROTECTED] --- drivers/net/natsemi.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c index 0b33a58..1f88604 100644 --- a/drivers/net/natsemi.c +++ b/drivers/net/natsemi.c @@ -108,7 +108,7 @@ static int

[PATCH] natsemi: Use round_jiffies() for slow timers

2007-10-09 Thread Mark Brown
Unless we have failed to fill the RX ring the timer used by the natsemi driver is not particularly urgent and can use round_jiffies() to allow grouping with other timers. Signed-off-by: Mark Brown [EMAIL PROTECTED] --- drivers/net/natsemi.c | 10 +++--- 1 files changed, 7 insertions(+), 3

[PATCH] natsemi: Use round_jiffies() for slow timers

2007-10-10 Thread Mark Brown
Unless we have failed to fill the RX ring the timer used by the natsemi driver is not particularly urgent and can use round_jiffies() to allow grouping with other timers. Signed-off-by: Mark Brown [EMAIL PROTECTED] --- Rediffed against current netdev-2.6.git#upstream drivers/net/natsemi.c

[PATCH] natsemi: Check return value for pci_enable_device()

2007-10-10 Thread Mark Brown
pci_enable_device() is __must_check so do that in natsemi_resume(). Signed-off-by: Mark Brown [EMAIL PROTECTED] --- drivers/net/natsemi.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c index b881786..50e1ec6 100644

[PATCH] natsemi: Update locking documentation

2008-01-27 Thread Mark Brown
in a number of laptops and at least one mass market PCI ethernet card. Signed-off-by: Mark Brown [EMAIL PROTECTED] --- drivers/net/natsemi.c | 18 ++ 1 files changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c index c329a4f

Re: [PATCH 1/2] regmap: only call custom reg_update_bits() if reg is marked volatile

2015-10-06 Thread Mark Brown
On Tue, Oct 06, 2015 at 06:25:08AM -0700, David Miller wrote: > > 4) David should then merge the regmap for-next branch into net-next > Nope, this doesn't work at all. > It is my tree which people depend upon, not the other way around. Yes, it does work - this is the way we normally handle

Re: [PATCH net-next v2 1/2] regmap: Allow installing custom reg_update_bits function

2015-10-06 Thread Mark Brown
On Tue, Oct 06, 2015 at 06:22:08AM -0700, David Miller wrote: > Date: Tue, 6 Oct 2015 10:57:15 +0100 > > I obviously can't just merge in net-next. > People do this all the time, when needed. My history never changes, > and the networking tree is one of the first trees pulled into > linux-next,

Re: [PATCH 1/2] regmap: only call custom reg_update_bits() if reg is marked volatile

2015-10-06 Thread Mark Brown
On Mon, Oct 05, 2015 at 11:29:56PM -0700, David Miller wrote: > From: Mark Brown <broo...@kernel.org> > > Dave, to be clear please do *not* apply this patch at least for the time > > being - I've not reviewed it or the one from Thursday that you applied > > this mor

Re: [PATCH net-next v2 1/2] regmap: Allow installing custom reg_update_bits function

2015-10-06 Thread Mark Brown
On Mon, Oct 05, 2015 at 11:21:48PM -0700, David Miller wrote: > > Ugh, this is a mess :( Can you please drop this patch instead? > I can't just "drop" changes. Once a commit hits my tree it is part > of the permanent record. I was expecting a revert if you want to keep the branch fast forward

Re: [PATCH 1/2] regmap: Allow installing custom reg_update_bits function

2015-10-01 Thread Mark Brown
On Thu, Oct 01, 2015 at 02:33:06AM -0400, j...@ringle.org wrote: > @@ -2509,6 +2510,10 @@ static int _regmap_update_bits(struct regmap *map, > unsigned int reg, > int ret; > unsigned int tmp, orig; > > + if (map->reg_update_bits) > + return

Re: [PATCH 1/2] regmap: Allow installing custom reg_update_bits function

2015-10-02 Thread Mark Brown
On Thu, Oct 01, 2015 at 08:29:19AM -0400, Jon Ringle wrote: > On Thu, 1 Oct 2015, Mark Brown wrote: > > This completely bypasses and therefore breaks the cache infrastructure. > Right after sending the v2 patch, I realized that calling the > custom reg_update_bits would onl

Re: [PATCH 1/2] regmap: only call custom reg_update_bits() if reg is marked volatile

2015-10-06 Thread Mark Brown
On Tue, Oct 06, 2015 at 08:50:43AM -0400, Jon Ringle wrote: > 4) David should then merge the regmap for-next branch into net-next What I generally do (and what's best practice in general for cross tree work) is apply patches on topic branches and then create a signed tag for anything that's

Re: [PATCH net-next v2 1/2] regmap: Allow installing custom reg_update_bits function

2015-10-05 Thread Mark Brown
On Mon, Oct 05, 2015 at 06:16:09AM -0700, David Miller wrote: > >> Applied. > > Thanks David. However, I've sent a v3 patch, and also expecting feedback > > from Mark Brown on the regmap portion of it. > Please send me relative changes from v2 to v3, thanks.

Re: [PATCH net-next v3 1/2] regmap: Allow installing custom reg_update_bits function

2015-10-06 Thread Mark Brown
On Thu, Oct 01, 2015 at 12:38:07PM -0400, j...@ringle.org wrote: > From: Jon Ringle > > This commit allows installing a custom reg_update_bits function for cases > where > the hardware provides a mechanism to set or clear register bits without a > read/modify/write cycle.

Re: [PATCH 1/2] regmap: only call custom reg_update_bits() if reg is marked volatile

2015-10-05 Thread Mark Brown
On Mon, Oct 05, 2015 at 09:29:31AM -0400, j...@ringle.org wrote: > From: Jon Ringle > > The only time that it makes sense to call a custom provided reg_update_bits > function, is the register being updated is one that has volatile bits. > Otherwise, the normal

linux-next: manual merge of the ipvs-next tree with the tree

2015-12-01 Thread Mark Brown
Hi Simon, Today's linux-next merge of the ipvs-next tree got a conflict in between commit 264640fc2c5f4f ("ipv6: distinguish frag queues by device for multicast and link-local packets") from the net tree and commit 029f7f3b8701c ("netfilter: ipv6: nf_defrag: avoid/free clone operations") from

Re: next-20160104 build: 3 failures 15 warnings (next-20160104)

2016-01-04 Thread Mark Brown
On Mon, Jan 04, 2016 at 11:07:41PM +0100, Arnd Bergmann wrote: > On Monday 04 January 2016 16:50:25 Mark Brown wrote: > > On Mon, Jan 04, 2016 at 12:12:20PM +, Build bot for Mark Brown wrote: > > and various other linker errors caused by the fact that the new fman > &g

Re: next-20160104 build: 3 failures 15 warnings (next-20160104)

2016-01-04 Thread Mark Brown
On Mon, Jan 04, 2016 at 12:12:20PM +, Build bot for Mark Brown wrote: Today's linux-next fails to build an arm allmodconfig (and probably also at least arm64 though other errors prevent that getting to linking currently) due to: | drivers/built-in.o: In function `dtsec_restart_autoneg

Re: next-20151126 build: 3 failures 15 warnings (next-20151126)

2015-11-26 Thread Mark Brown
On Thu, Nov 26, 2015 at 08:34:20PM +0200, Kalle Valo wrote: > Mark Brown <broo...@kernel.org> writes: > > It still ought to be fixed regardless of why it showed up - the > > intention of the code is that we build the real thermal code regardless > > of if that's modular

[PATCH 1/2] net: fsl: Don't use NO_IRQ to check return value of irq_of_parse_and_map()

2015-11-26 Thread Mark Brown
was previously used the check was broken since on ARM NO_IRQ is -1 but irq_of_parse_and_map() returns 0 on error. Signed-off-by: Mark Brown <broo...@kernel.org> --- drivers/net/ethernet/freescale/gianfar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

Re: next-20151126 build: 3 failures 15 warnings (next-20151126)

2015-11-26 Thread Mark Brown
On Thu, Nov 26, 2015 at 09:06:25AM +, Build bot for Mark Brown wrote: For the past couple of days an arm64 allmodconfig has been failing to build due to: > arm64-allmodconfig > ../drivers/net/ethernet/freescale/gianfar.c:650:33: error: 'NO_IRQ' > undeclared (first use in this

[PATCH 2/2] net: fsl: Fix error checking for platform_get_irq()

2015-11-26 Thread Mark Brown
platform_get_irq() returns a negative error code which may not be exactly the (unsigned int)(-1) that NO_IRQ is defined to be. Signed-off-by: Mark Brown <broo...@kernel.org> --- drivers/net/ethernet/freescale/gianfar_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

Re: next-20151126 build: 3 failures 15 warnings (next-20151126)

2015-11-26 Thread Mark Brown
On Thu, Nov 26, 2015 at 09:06:25AM +, Build bot for Mark Brown wrote: Today's -next fails to build an arm64 allmodconfig due to: > arm64-allmodconfig > ../drivers/net/wireless/ath/ath10k/thermal.c:119:6: error: redefinition of > 'ath10k_thermal_event_temperature' > ..

Re: next-20151126 build: 3 failures 15 warnings (next-20151126)

2015-11-26 Thread Mark Brown
On Thu, Nov 26, 2015 at 02:39:40PM +0200, Kalle Valo wrote: > Mark Brown <broo...@kernel.org> writes: > > It looks like this was somehow triggered as part of the reorganisation > > of the WiFi directory structure. > This is surprising and also worrying, any ide

Re: next-20151126 build: 3 failures 15 warnings (next-20151126)

2015-11-26 Thread Mark Brown
On Thu, Nov 26, 2015 at 06:58:32PM +0200, Kalle Valo wrote: > Mark Brown <broo...@kernel.org> writes: > > No, I didn't make much effort to check though since the use of ifdef was > > clearly a bug waiting to happen anyway, I was more surprised it worked > > at all tha

Re: next-20160222 build: 5 failures 9 warnings (next-20160222)

2016-02-22 Thread Mark Brown
On Mon, Feb 22, 2016 at 08:36:46AM +, Build bot for Mark Brown wrote: Today's -next fails to build an arm allmodconfig due to: > arm-allmodconfig > ../drivers/net/ethernet/ti/netcp_core.c:1846:31: error: invalid type argument > of '->' (have 'struct tc_to_netdev') >

Re: linux-next: build failure after merge of the net-next tree

2016-04-22 Thread Mark Brown
On Wed, Apr 13, 2016 at 11:15:13AM -0400, David Miller wrote: > From: Stephen Rothwell > > After merging the net-next tree, today's linux-next build (arm > > allmodconfig) failed like thisi (this has actually been failing for a > > few days, now): > > ERROR:

Re: linux-next: build failure after merge of the net-next tree

2016-04-24 Thread Mark Brown
On Fri, Apr 22, 2016 at 04:20:43PM -0700, Jeff Kirsher wrote: > On Fri, 2016-04-22 at 10:20 +0100, Mark Brown wrote: > > > Jeff, please have your folks look into this.  Probably just a > > simple > > > conversion to mdelay(). > > This is still present, it's been

Re: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-19 Thread Mark Brown
On Mon, Apr 18, 2016 at 05:55:51AM +, Reizer, Eyal wrote: > > I would suggest fixing this using a new API function from the SPI core, if > > we > > don't already have a generic way to do it. > Originally this is what I have done until I was pointed to the generic > cs-gpio mechanism > in

Re: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-19 Thread Mark Brown
On Tue, Apr 19, 2016 at 09:05:45AM +, Reizer, Eyal wrote: > Understood. As this special CS manipulation is unique to wspi (wilink spi) I > think the > best option is to move this gpio allocation into wlcore_spi as a new device > tree entry > used only by this driver. That sounds like it

Re: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-19 Thread Mark Brown
On Tue, Apr 19, 2016 at 05:38:02PM +, Reizer, Eyal wrote: > Hi Mark, > > Hope you can see the attached picture that illustrates what need to sent for > sucesfull SPI init. I think what the picture shows is that you just need to send at least one byte at the end of the transfer *after*

Re: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-19 Thread Mark Brown
On Tue, Apr 19, 2016 at 06:04:49PM +, Reizer, Eyal wrote: > Thanks! Glad the illustration helped. > I will try it out again as if i recall cotrectly, i did try that l, and it > didnt produce the correct waveform, but perhaps i didnt understand the usage > of .cs_change correctly. > Will

Re: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-19 Thread Mark Brown
On Tue, Apr 19, 2016 at 05:21:01PM +, Reizer, Eyal wrote: > The main quirk here is that i need to send extra clocks after the spi init > command while the CS pin is "high" in order to put the wilink chip into SPI > mode. > So just sending an empty transfer wouldnt do the trick here. A

[PATCH] net: phy: spi_ks8895: Don't leak references to SPI devices

2016-04-20 Thread Mark Brown
to it so fix the leak by just using a straight assignment. Signed-off-by: Mark Brown <broo...@kernel.org> --- drivers/net/phy/spi_ks8995.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c index b5d50d458728..93ffed

Re: [PATCHv2] wlcore: spi: add wl18xx support

2016-04-21 Thread Mark Brown
On Thu, Apr 21, 2016 at 11:07:37AM +, Reizer, Eyal wrote: > * (i) If the transfer isn't the last one in the message, this flag is > * used to make the chipselect briefly go inactive in the middle of the > * message. Toggling chipselect in this way may be needed to terminate > * a chip

Re: next-20160701 build: 2 failures 5 warnings (next-20160701)

2016-07-01 Thread Mark Brown
On Fri, Jul 01, 2016 at 10:00:09AM +0100, Build bot for Mark Brown wrote: Today's -next fails to build am ARM allmodconfig due to: > arm-allmodconfig > ../drivers/net/ethernet/mediatek/mtk_eth_soc.c:1300:2: error: implicit > declaration of function 'mtk_handle_irq' > [-Wer

Re: next-20160816 build: 1 failures 2 warnings (next-20160816)

2016-08-16 Thread Mark Brown
On Tue, Aug 16, 2016 at 10:37:20AM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an ARM allmodconfig due to: > arm-allmodconfig > ../drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:300:61: error: 'outb' > undeclared (first use in this function) whic

Re: next-20160929 build: 2 failures 4 warnings (next-20160929)

2016-09-29 Thread Mark Brown
On Thu, Sep 29, 2016 at 12:40:35PM +0100, Build bot for Mark Brown wrote: For the past couple of days -next has been failing to build an ARM allmodconfig due to: > arm-allmodconfig > ERROR: "__aeabi_uldivmod" [net/netfilter/xt_hashlimit.ko] undefined! which appears

Re: [PATCH v2] net: hns: mark symbols static where possible

2016-09-27 Thread Mark Brown
On Tue, Sep 27, 2016 at 07:50:14AM -0400, David Miller wrote: > This still doesn't apply to the net-next tree. > If you aren't actually building your patch against the net-next > tree, don't bother submitting these patches any more. Baoyou, Dave is referring to his git tree at:

Applied "misc: atmel-ssc: register as sound DAI if #sound-dai-cells is present" to the asoc tree

2016-12-15 Thread Mark Brown
matically, if the #sound-dai-cells property is present in devicetree, which it has to be anyway for simple audio card to work. Signed-off-by: Peter Rosin <p...@axentia.se> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Mar

Re: next-20170110 build: 1 failures 4 warnings (next-20170110)

2017-01-10 Thread Mark Brown
On Tue, Jan 10, 2017 at 07:21:32AM +, Build bot for Mark Brown wrote: Today's -next fails to build an arm allmodconfig due to: > arm-allmodconfig > ../drivers/net/ethernet/ti/netcp_core.c:1951:28: error: initialization from > incompatible pointer type [-Werror=incompatibl

[PATCH] net/faraday: Explicitly include linux/of.h and linux/property.h

2017-03-30 Thread Mark Brown
This driver uses interfaces from linux/of.h and linux/property.h but relies on implict inclusion of those headers which means that changes in other headers could break the build, as happened in -next for arm today. Add a explicit includes. Signed-off-by: Mark Brown <broo...@kernel.

Re: next-20170330 build: 2 failures 8 warnings (next-20170330)

2017-03-30 Thread Mark Brown
On Thu, Mar 30, 2017 at 01:50:39PM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an ARM allmodconfig due to: > arm-allmodconfig > ../drivers/net/ethernet/faraday/ftgmac100.c:153:9: error: implicit > declaration of function 'device_get_mac_address' &

[PATCH] net: ethernet: mediatek: Explicitly include linux/interrupt.h

2017-07-20 Thread Mark Brown
The mediatek ethernet driver uses interrupts but does not explicitly include linux/interrupt.h, relying on implicit includes. Fix this so we don't get build breaks as happened for ARM in next-20170720. Signed-off-by: Mark Brown <broo...@kernel.org> --- drivers/net/ethernet/me

Re: next-20170720 build: 1 failures 4 warnings (next-20170720)

2017-07-20 Thread Mark Brown
On Thu, Jul 20, 2017 at 07:26:32AM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an arm allmodconfig due to: > arm-allmodconfig > ../drivers/net/ethernet/mediatek/mtk_eth_soc.c:1685:8: error: unknown type > name 'irqreturn_t' > ../drivers/net/ether

[PATCH] qed*: Fix build for !QED_RDMA

2017-06-21 Thread Mark Brown
A stray semicolon was introduced by bbfcd1e8e1677b (qed*: Set rdma generic functions prefix), remove it. Signed-off-by: Mark Brown <broo...@kernel.org> --- include/linux/qed/qede_rdma.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/qed/qede_rdma.h b/i

Re: next-20170621 build: 1 failures 7 warnings (next-20170621)

2017-06-21 Thread Mark Brown
On Wed, Jun 21, 2017 at 10:56:07AM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an arm allmodconfig with: > ../include/linux/qed/qede_rdma.h:85:1: error: expected identifier or '(' > before '{' token > ../include/linux/qed/qede_rdma.h:85:1: error: expected i

Re: next-20170608 build: 1 failures 4 warnings (next-20170608)

2017-06-08 Thread Mark Brown
On Thu, Jun 08, 2017 at 10:57:50AM +0100, Build bot for Mark Brown wrote: Today's -next fails to build an ARM allmodconfig due to: > arm-allmodconfig > ../drivers/hsi/clients/ssi_protocol.c:1069:5: error: 'struct net_device' has > no member named 'destructor' due to cf124db5

linux-next: manual merge of the drivers-x86 tree with the net-next tree

2017-10-09 Thread Mark Brown
Hi Darren, [Apologies for multiple copies - for some reason vger seems to eat mails I send from scripts, still trying to figure this out] Today's linux-next merge of the drivers-x86 tree got a conflict in: Documentation/admin-guide/thunderbolt.rst between commit: e69b6c02b4c3b ("net: Add

linux-next: manual merge of the cgroup tree with the net-next tree

2017-10-09 Thread Mark Brown
Hi Tejun, Today's linux-next merge of the cgroup tree got a conflict in: kernel/cgroup/cgroup.c between commit: 324bda9e6c5ad ("bpf: multi program support for cgroup+bpf") from the net-next tree and commit: 041cd640b2f3c ("cgroup: Implement cgroup2 basic CPU usage accounting") from

linux-next: manual merge of the rdma tree with the FIXME tree

2017-10-13 Thread Mark Brown
Hi Doug, Today's linux-next merge of the rdma tree got a conflict in: drivers/net/ethernet/mellanox/mlx4/catas.c between commit: d2a0012e7632a5 ("drivers: net: mlx4: use setup_timer() helper.") from the net-next tree and commit: 55c0fcc3de4605 ("net/mlx4_core: Convert timers to use

linux-next: manual merge of the net-next tree with the net tree

2017-10-16 Thread Mark Brown
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/dsa/mv88e6060.c between commit: 3efc93c2bc243 ("net: dsa: mv88e6060: fix switch MAC address") from the net tree and commit: 56c3ff9bf23e1 ("net: dsa: mv88e6060: setup random mac address") from the

linux-next: net/sched/cls_flower.c

2017-10-17 Thread Mark Brown
Hi all, After merging the net-next tree, today's linux-next build (x86_allmodconfig) failed like this: /home/broonie/tmpfs/next/net/sched/cls_flower.c: In function 'fl_hw_destroy_filter': /home/broonie/tmpfs/next/net/sched/cls_flower.c:208:12: error: 'struct tc_cls_flower_offload' has no

Re: linux-next: net/sched/cls_flower.c

2017-10-17 Thread Mark Brown
On Tue, Oct 17, 2017 at 12:21:07PM +0200, Jiri Pirko wrote: > Tue, Oct 17, 2017 at 12:15:09PM CEST, broo...@kernel.org wrote: > >/home/broonie/tmpfs/next/net/sched/cls_flower.c:270:27: error: 'struct > >cls_fl_filter' has no member named 'hw_dev' > > cls_flower.egress_dev = f->hw_dev !=

linux-next: net/sched/sch_mqprio.c

2017-10-17 Thread Mark Brown
Hi all, After merging the net-next tree, today's linux-next build (KCONFIG_NAME) failed like this: ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined! /home/broonie/tmpfs/next/scripts/Makefile.modpost:91: recipe for target '__modpo st' failed Caused by commit 32302902ff093

Re: linux-next: net/sched/cls_flower.c

2017-10-17 Thread Mark Brown
On Tue, Oct 17, 2017 at 11:15:09AM +0100, Mark Brown wrote: > Caused by commit > > 7578d7b45ed870b13a8ace57e32feaed623c2a94 ("net/sched: cls_flower: Set > egress_dev mark when calling into the HW driver") Cut'n'paste error, this should be c019b5166e11faaf9ed3b6431

Re: linux-next: manual merge of the net-next tree with the net tree

2017-10-17 Thread Mark Brown
On Tue, Oct 17, 2017 at 02:30:29PM +0300, Sergei Shtylyov wrote: > > diff --cc drivers/net/dsa/mv88e6060.c > > index f123ed57630d,6173be889d95.. > > --- a/drivers/net/dsa/mv88e6060.c > > +++ b/drivers/net/dsa/mv88e6060.c >Your mail ends here. Yes, that's the resulting diff.

Re: linux-next: manual merge of the drivers-x86 tree with the net-next tree

2017-10-09 Thread Mark Brown
On Mon, Oct 09, 2017 at 10:43:01PM +0300, Mika Westerberg wrote: > If possible, I would rather move this chapter to be before "Networking > over Thunderbolt cable". Reason is that it then follows NVM flashing > chapter which is typically where you need to force power in the first > place. I

  1   2   >