Re: [PATCH] ssb: fix handling of ssb_pmu_get_alp_clock()

On Sun, 7 Jun 2015 01:52:51 +0200 Hauke Mehrtens ha...@hauke-m.de wrote: Dan Carpenter reported missing brackets which resulted in reading a wrong crystalfreq value. I also noticed that the result of this function is ignored. Reported-By: Dan Carpenter dan.carpen...@oracle.com

Re: [PATCH 1/1] ssb: remove unncessary out label

On Fri, 19 Jun 2015 14:23:45 +0530 Maninder Singh maninder...@samsung.com wrote: This patch removes unnecessary label out and some restructring for using device_create_file directly. Signed-off-by: Maninder Singh maninder...@samsung.com Reviewed-by: Rohit Thapliyal r.thapli...@samsung.com

Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused

On Tue, 03 Nov 2015 16:05:51 +0100 Arnd Bergmann wrote: > The SoC variant of the ssb code is now optional like the other > ones, which means we can build the framwork without any > front-end, but that results in a warning: > > drivers/ssb/main.c:616:12: warning:

Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused

On Tue, 03 Nov 2015 17:42:26 +0100 Arnd Bergmann <a...@arndb.de> wrote: > On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote: > > On Tue, 03 Nov 2015 16:05:51 +0100 > > Arnd Bergmann <a...@arndb.de> wrote: > > > > > The SoC variant of t

Re: [PATCH v2 2/3] net: wireless: b43: Coding Style

On Mon, 19 Oct 2015 17:02:22 +0100 Paul McQuade wrote: > Fixed Pointer Coding Style > > Signed-off-by: Paul McQuade > --- > drivers/net/wireless/b43/main.c | 6 +++--- > drivers/net/wireless/b43/main.h | 2 +- > drivers/net/wireless/b43/xmit.h | 2

Re: [PATCH v2 3/3] net: wireless: b43: Statics are init to 0

On Mon, 19 Oct 2015 17:02:23 +0100 Paul McQuade wrote: > diff --git a/drivers/net/wireless/b43/phy_lp.c > b/drivers/net/wireless/b43/phy_lp.c > index 058a9f2..086f0ba 100644 > --- a/drivers/net/wireless/b43/phy_lp.c > +++ b/drivers/net/wireless/b43/phy_lp.c > @@ -2502,7

Re: [PATCH 2/3] net: wireless: b43: Fixed Pointer issue

On Sun, 18 Oct 2015 00:01:37 +0100 Paul McQuade wrote: > Moved around pointer to avoid ERROR > > Signed-off-by: Paul McQuade > --- > drivers/net/wireless/b43/dma.h | 14 +++--- > drivers/net/wireless/b43/main.c | 6 +++--- >

Re: [PATCH] b43: Remove unused phy_a code

On Fri, 3 Jun 2016 14:32:46 -0700 Guenter Roeck wrote: > gcc-6 reports the following error with -Werror=unused-const-variable. > > drivers/net/wireless/broadcom/b43/phy_a.c:576:40: error: > 'b43_phyops_a' defined but not used > > Turns out a lot of code in this file

Re: [PATCH v2 1/2] b43: Remove unused phy_a code

On Fri, 3 Jun 2016 21:11:51 -0700 Guenter Roeck wrote: > +static void __b43_phy_initg(struct b43_wldev *dev) > +{ > + struct b43_phy *phy = >phy; > + > + might_sleep(); > + > + if (phy->rev >= 6) { > + if (b43_phy_read(dev, B43_PHY_ENCORE) &

Re: [v3,1/2] b43: Remove unused phy_a code

r: > > 'b43_phyops_a' defined but not used > > > > Per Michael Büsch: "All a-phy code is usused", so remove it all, > > and move the remaining Type-G initialization code into phy_g.c. > > > > Reported-by: Fengguang Wu <fengguang...@intel.com&g

Re: [v3,1/2] b43: Remove unused phy_a code

On Thu, 16 Jun 2016 18:56:14 +0300 Kalle Valo <kv...@codeaurora.org> wrote: > Michael Büsch <m...@bues.ch> writes: > > > On Thu, 16 Jun 2016 15:23:37 + (UTC) > > Kalle Valo <kv...@codeaurora.org> wrote: > > > >> Guenter Roeck <li...@roe

Re: [PATCH] b43: fix memory leak

On Thu, 18 Feb 2016 18:04:36 +0530 Sudip Mukherjee wrote: > From: Sudip Mukherjee > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. > > Signed-off-by: Sudip Mukherjee

Re: [PATCH] b43: fix memory leak

On Fri, 19 Feb 2016 20:37:18 +0530 Sudip Mukherjee wrote: > > https://patchwork.kernel.org/patch/8049041/ > > I have an old laptop running on 800Mhz CPU. It has "Broadcom BCM4311 > [14e4:4311] (rev 01)". > I will try to test it on this weekend. Any news on this

Re: [PATCH RFC] b43: stop hardcoding LED behavior

On Mon, 25 Apr 2016 20:21:36 +0200 Lucas Stach wrote: > > Numbers please. Did you measure that is actually causes more > > _wakeups_? > > How many? > > The led work is placed in the mac80211 workqueue and LED updates only > > happen on behalf of mac80211 activities (by default).

Re: [PATCH RFC] b43: stop hardcoding LED behavior

On Mon, 25 Apr 2016 09:40:51 +0200 Lucas Stach wrote: > On my system the SPROM correctly defines the only wired LED (radio) but > skips all others, leading to the hardcode to register LEDs with RX and TX > triggers. Hm ok. It probably is a good idea to change the condition from

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

On Fri, 02 Jun 2017 09:18:14 +0800 Jia-Ju Bai wrote: > On 06/02/2017 12:11 AM, Jonathan Corbet wrote: > > On Thu, 01 Jun 2017 09:05:07 +0800 > > Jia-Ju Bai wrote: > > > >> I admit my patches are not well tested, and they may not well fix the bugs. >

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

On Wed, 31 May 2017 18:29:07 +0800 Jia-Ju Bai wrote: > The driver may sleep under a spin lock, and the function call path is: > b43legacy_attr_interfmode_store (acquire the lock by spin_lock_irqsave) > b43legacy_radio_set_interference_mitigation >

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: > Jia-Ju Bai writes: > > > The driver may sleep under a spin lock, and the function call path is: > > b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) > >

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

On Wed, 31 May 2017 19:07:15 -0500 Larry Finger <larry.fin...@lwfinger.net> wrote: > On 05/31/2017 10:32 AM, Michael Büsch wrote: > > On Wed, 31 May 2017 13:26:43 +0300 > > Kalle Valo <kv...@codeaurora.org> wrote: > > > >> Jia-Ju Bai <baijiaju1...

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

On Thu, 01 Jun 2017 07:27:20 +0300 Kalle Valo <kv...@codeaurora.org> wrote: > Michael Büsch <m...@bues.ch> writes: > > >> > --- a/drivers/net/wireless/broadcom/b43legacy/main.c > >> > +++ b/drivers/net/wireless/broadcom/b43legacy/main.

Re: [PATCH 1/2] b43: fix unitialized reads of ret by initializing the array to zero

On Tue, 5 Sep 2017 19:15:50 +0100 Colin King wrote: > From: Colin Ian King > > The u8 char array ret is not being initialized and elements outside > the range start to end contain just garbage values from the stack. > This results in a later

Re: [PATCH 2/2] b43legacy: fix unitialized reads of ret by initializing the array to zero

On Tue, 5 Sep 2017 19:16:58 +0100 Colin King wrote: > From: Colin Ian King > > The u8 char array ret is not being initialized and elements outside > the range start to end contain just garbage values from the stack. > This results in a later

Re: [PATCH] net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment

On Tue, 10 Apr 2018 21:54:19 +0800 Jia-Ju Bai wrote: > dma_tx_fragment() is never called in atomic context. > > dma_tx_fragment() is only called by b43legacy_dma_tx(), which is > only called by b43legacy_tx_work(). > b43legacy_tx_work() is only set a parameter of