Re: [Cbe-oss-dev] [PATCH 4/10] spidernet: zero out a pointer.

; If you're going to be paranoid, shouldn't you do something here to make sure the value's hit the device? + pci_unmap_single(card-pdev, hw_buf_addr, SPIDER_NET_MAX_FRAME, PCI_DMA_FROMDEVICE); cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http

Re: [Cbe-oss-dev] [PATCH 10/10] spidernet: increase the NAPI weight

-- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description: This is a digitally signed

Re: [PATCH 2.6.22-rc4] ehea: Fixed possible kernel panic on VLAN packet recv

routine. Which would leave only one place to get it right. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T

Re: [Cbe-oss-dev] [PATCH 0/18] spidernet driver bug fixes

in a driver deadlock. 2) misconfigured TX interrupts, causing a sever performance degardation for small packets. I realise it's late, but shouldn't major bugfixes be going into 22 ? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2

Re: [PATCH 0/15] spidernet driver bug fixes

On Mon, 2007-06-11 at 13:14 -0500, Linas Vepstas wrote: On Fri, Jun 08, 2007 at 01:20:20PM -0400, Jeff Garzik wrote: On Fri, Jun 08, 2007 at 12:06:08PM -0500, Linas Vepstas wrote: On Fri, Jun 08, 2007 at 11:12:31AM +1000, Michael Ellerman wrote: On Thu, 2007-06-07 at 14:17 -0500, Linas

Re: [PATCH 0/15] spidernet driver bug fixes

On Tue, 2007-06-12 at 19:00 -0400, Jeff Garzik wrote: Linas Vepstas wrote: On Fri, Jun 08, 2007 at 01:20:20PM -0400, Jeff Garzik wrote: On Fri, Jun 08, 2007 at 12:06:08PM -0500, Linas Vepstas wrote: On Fri, Jun 08, 2007 at 11:12:31AM +1000, Michael Ellerman wrote: On Thu, 2007-06-07 at 14

Re: [PATCH 0/15] spidernet driver bug fixes

On Tue, 2007-06-12 at 21:54 -0400, Jeff Garzik wrote: Michael Ellerman wrote: Linas posted the patches, I responded querying whether the bug fixes should go into 2.6.22, and then you told him you need to order your bug fixes first in the queue. Which seemed pretty clear to me that you'd

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

On Wed, 2007-06-13 at 21:01 +0200, Segher Boessenkool wrote: I wish there was a git option to just make my shit look like the remote, dammit! The above is the easiest way I know how to do that. git-fetch -f remote:local ? There's always git reset --hard sha1 cheers -- Michael Ellerman

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

is less so. ccache! cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description

[PATCH] s2io: Fix a compiler warning in a printk()

Fix a compile warning in the s2io driver. It's caused because u64 is unsigned long on PPC64 not unsigned long long. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- Index: work/drivers/net/s2io.c === --- work.orig/drivers/net

[PATCH 0/18] Updates bug fixes for iseries_veth network driver

Hi, This is a series of patches for the iseries_veth driver. Most of these are pretty much unchanged since I posted them earlier: http://www.uwsg.iu.edu/hypermail/linux/kernel/0506.3/1837.html I've added patches to add sysfs support, and do some further code cleanups. Please merge if they look

[PATCH 1/18] iseries_veth: Cleanup error and debug messages

refer to LPAR not lpar - be consistent about printing return codes as %d not %x - make format strings fit in 80 columns Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 98 +++-- 1 files changed, 51 insertions(+), 47

[PATCH 7/18] iseries_veth: Only call dma_unmap_single() if dma_map_single() succeeded

-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) Index: veth-dev2/drivers/net/iseries_veth.c === --- veth-dev2.orig/drivers/net

[PATCH 18/18] iseries_veth: Be consistent about driver name, increment version

DRV_NAME and use it everywhere. While we're at it, change the version number to 2.0, to reflect the changes made in this patch series. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) Index

[PATCH 8/18] iseries_veth: Make init_connection() destroy_connection() symmetrical

() before we've called driver_register(). I've never seen this actually happen though. So instead we explicitly call veth_destroy_connection() for each connection, any that have been set up will be deallocated. We also fix a potential leak if vio_register_driver() fails. Signed-off-by: Michael Ellerman

[PATCH 17/18] iseries_veth: Remove studly caps from iseries_veth.c

Having merged iseries_veth.h, let's remove some of the studly caps that came with it. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 74 ++--- 1 files changed, 37 insertions(+), 37 deletions(-) Index: veth-dev2

[PATCH 15/18] iseries_veth: Add sysfs support for port structs

Also to aid debugging, add sysfs support for iseries_veth's port structures. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 67 + 1 files changed, 67 insertions(+) Index: veth-dev2/drivers/net/iseries_veth.c

[PATCH 11/18] iseries_veth: Add a per-connection ack timer

-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 75 + 1 files changed, 69 insertions(+), 6 deletions(-) Index: veth-dev2/drivers/net/iseries_veth.c === --- veth

[PATCH 3/18] iseries_veth: Try to avoid pathological reset behaviour

, in the hope that the other end will get itself sorted. Needless to say I'd love it if someone has a better idea. This does work, I've so far been unable to get it to break, whereas without the fix a reset of one end will lead to a dead connection ~8/10 times. Signed-off-by: Michael Ellerman [EMAIL

[PATCH 5/18] iseries_veth: Remove redundant message stack lock

must hold the connection's lock. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) Index: veth-dev2/drivers/net/iseries_veth.c

[PATCH 2/18] iseries_veth: Remove a FIXME WRT deletion of the ack_timer

ok, because the flags the timer consults have been reset. It's cleaner though to call del_timer_sync() once we've dropped the lock, although the timer may still run between us dropping the lock and calling del_timer_sync(), but as above that's ok. Signed-off-by: Michael Ellerman [EMAIL PROTECTED

[PATCH 10/18] iseries_veth: Remove TX timeout code

The iseries_veth driver uses the generic TX timeout watchdog, however a better solution is in the works, so remove this code. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 48 - 1 files changed, 48 deletions

[PATCH 9/18] iseries_veth: Use kobjects to track lifecycle of connection structs

forever due to leftover skbs. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 121 ++--- 1 files changed, 83 insertions(+), 38 deletions(-) Index: veth-dev2/drivers/net/iseries_veth.c

[PATCH 14/18] iseries_veth: Add sysfs support for connection structs

To aid in field debugging, add sysfs support for iseries_veth's connection structures. At the moment this is all read-only, however we could think about adding write support for some attributes in future. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/iseries_veth.c | 94

[PATCH] powerpc: ibmveth: Harden driver initilisation for kexec

, because we don't want to disturb the regular code path for 99% of users. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] Acked-by: Anton Blanchard [EMAIL PROTECTED] Signed-off-by: Santiago Leon [EMAIL PROTECTED] --- ibmveth.c | 31 ++- 1 file changed, 26 insertions

Re: [PATCH 2/14] Spidernet add net_ratelimit to suppress long output

-- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description: This is a digitally signed message part

Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

); + spider_net_enable_rxchtails(card); spider_net_enable_rxdmac(card); return 0; cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children

Re: [PATCH 12/14] Spidernet Avoid possible RX chain corruption

On Thu, 2006-12-14 at 11:15 -0600, Linas Vepstas wrote: On Thu, Dec 14, 2006 at 11:22:43AM +1100, Michael Ellerman wrote: spider_net_refill_rx_chain(card); - spider_net_enable_rxchtails(card); spider_net_enable_rxdmac(card); return 0; Didn't you just add that line

Re: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec

On Mon, 2006-03-27 at 12:11 +1100, Michael Ellerman wrote: On Thu, 2006-03-02 at 13:40 -0600, Santiago Leon wrote: From: Michael Ellerman [EMAIL PROTECTED] After a kexec the veth driver will fail when trying to register with the Hypervisor because the previous kernel has not unregistered

Re: [PATCH] is_valid_ether_addr() returns true for FF:FF:FF:FF:FF:FF

On Mon, 12 Dec 2005 19:26, Jeff Garzik wrote: David S. Miller wrote: From: Michael Ellerman [EMAIL PROTECTED] Date: Mon, 12 Dec 2005 18:56:49 -0600 Since a5fe736eaf9bae1b45317313de04b564441b94f2 (2.6.13-rc1 ish), is_valid_ether_addr() has been broken, because its assumption

[RFC/PATCH 2/2] Fixup callers of is_multicast_ether_addr()

Fixup callers who're checking for is_multicast || is_broadcast, that's no longer necessary. Change !is_multicast callers to use is_unicast. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- drivers/net/wireless/ipw2200.c | 15 +-- net/ieee80211/ieee80211_rx.c |5

[RFC/PATCH 1/2] is_multicast_ether_addr() should include the broadcast address

of the code and there's currently no callers that will be affected by the change to is_multicast_ether_addr(). Some callers are checking for is_multicast || is_broadcast, I'll post another patch to remove the redundant is_broadcast checks. Others really want is_unicast. Signed-off-by: Michael Ellerman [EMAIL

Re: [PATCH] [2/4] pasemi_mac: irq mapping changes

probably check that irq_create_mapping() succeeds, just to be pedantic. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children

[PATCH] Fix sparse errors in drivers/net/ibmveth.c

decide, as it happens gcc 4.~ inlines it anyway. drivers/net/ibmveth.c:957:71: warning: Using plain integer as NULL pointer drivers/net/ibmveth.c:964:85: warning: Using plain integer as NULL pointer Split the long lines as well, ugly, but 80 columns. Signed-off-by: Michael Ellerman [EMAIL

Re: [PATCH 2/2] ehea: NAPI multi queue TX/RX path for SMP

' /scratch/michael/kisskb-build/src/drivers/net/ehea/ehea_main.c:1807: error: 'struct sk_buff' has no member named 'nh' /scratch/michael/kisskb-build/src/drivers/net/ehea/ehea_main.c:1809: error: 'struct sk_buff' has no member named 'nh' cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab

Re: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec

On Fri, 3 Mar 2006 11:34, Randy.Dunlap wrote: On Fri, 3 Mar 2006 11:22:45 +1100 Michael Ellerman wrote: Hi Jeff, I realise it's late, but it'd be really good if you could send this up for 2.6.16, we're hosed without it. I'm wondering if this means that for every virtual/hypervisor

Re: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec

On Thu, 2006-03-02 at 13:40 -0600, Santiago Leon wrote: From: Michael Ellerman [EMAIL PROTECTED] After a kexec the veth driver will fail when trying to register with the Hypervisor because the previous kernel has not unregistered. So if the registration fails, we unregister and then try

Re: [PATCH 4/6] ehea: header files

max_entries_scq; + int max_entries_sq; + int max_entries_rq1; + int max_entries_rq2; + int max_entries_rq3; +}; Enormous structs with no comments. -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do

Re: [PATCH 1/6] ehea: interface to network stack

On Thu, 2006-08-10 at 16:15 +1000, Michael Ellerman wrote: + struct hcp_query_ehea_port_cb_2 *cb2 = NULL; + struct net_device_stats *stats = port-stats; + + EDEB_EN(7, net_device=%p, dev); + + cb2 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL); + if (!cb2) { + EDEB_ERR(4

Re: [PATCH 4/6] ehea: header files

on what we should be doing here? I believe it must match the module name. It also might be nice to call it DRV_NAME like most other network drivers do. cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit

Re: ehea debug output discussion

old printk, rather than implementing something new. cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description

Re: [PATCH 4/4]: powerpc/cell spidernet ethtool -i version number info.

that they're running, rather than trying to guess based on version numbers. But that's just me :) cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children

RE: [PATCH 4/6] ehea: header files

a seperate 4k define. Fair enough. You seem to only use it in drivers/net/ehea/ehea_qmr.c, if so put the definition in there, that way someone is less likely to use the EHEA_PAGESIZE definition where they really need PAGE_SIZE. cheers -- Michael Ellerman IBM OzLabs wwweb: http

Re: [2.6.19 PATCH 7/7] ehea: Makefile Kconfig

with three NICs and none of them are eHEA. cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description

Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

are lying to the compiler, and it can no longer help you. cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc

Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

On Sat, 2006-08-19 at 02:48 -0400, Andy Gay wrote: On Sat, 2006-08-19 at 16:18 +1000, Michael Ellerman wrote: If you try to return an uninitialized value the compiler will warn you, you'll then look at the code and realise you missed a case, you might save yourself a bug. You

Re: [PATCH] powerpc: ibmveth: Harden driver initilisation for kexec

On 4/29/06, Santiago Leon [EMAIL PROTECTED] wrote: Michael Ellerman wrote: Any chance of getting it into to 2.6.17 ... 2.6.19 perhaps? cheers - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

with firmware how that will work WRT restoring MSI state. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

. The other option would be to design some new arch hook to do resume, but just doing a disable/enable seems simpler to me. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote: On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote: On pseries there's a chance it will work for PCI error recovery, but if so it's just lucky that firmware has left everything configured the same way. ? The papr

Re: [PATCH] ehea: add kexec support

kexec starts a new kernel. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] How do you plan to support kdump? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from

Re: [PATCH] ehea: add kexec support

On Tue, 2007-10-30 at 09:39 +0100, Christoph Raisch wrote: Michael Ellerman [EMAIL PROTECTED] wrote on 28.10.2007 23:32:17: How do you plan to support kdump? When kexec is fully supported kdump should work out of the box as for any other ethernet card (if you load the right eth

Re: [PATCH] ehea: add kexec support

On Wed, 2007-10-31 at 20:48 +0100, Christoph Raisch wrote: Michael Ellerman [EMAIL PROTECTED] wrote on 30.10.2007 23:50:36: On Tue, 2007-10-30 at 09:39 +0100, Christoph Raisch wrote: Michael Ellerman [EMAIL PROTECTED] wrote on 28.10.2007 23:32:17: Hope I didn't miss anything here

Re: [PATCH] ehea: Add kdump support

in the crashed kernel. d) something else cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person

Re: [RFC] ehea: kdump support using new shutdown hook

), 0); arguments wrong way around. Remind me why bzero is deprecated again? :) cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our

Re: [RFC] ehea: kdump support using new shutdown hook

); ibmebus_unregister_driver(ehea_driver); unregister_reboot_notifier(ehea_reboot_nb); + ret = crash_shutdown_unregister(ehea_crash_deregister); + if (ret) + ehea_info(failed unregistering crash handler); You don't need ret if that's all you're going to do with it. cheers -- Michael

Re: [PATCH 2/2] ehea: add memory remove hotplug support

wasn't registered properly? Bang? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc

Re: [PATCH 2/2] ehea: add memory remove hotplug support

On Mon, 2008-02-04 at 16:24 +0100, Jan-Bernd Themann wrote: On Monday 04 February 2008 15:46, Michael Ellerman wrote: On Mon, 2008-02-04 at 14:04 +0100, Jan-Bernd Themann wrote: Add memory remove hotplug support @@ -3559,6 +3578,10 @@ int __init ehea_module_init(void) if (ret

Re: [patch 1/6] pasemi_mac: Move RX/TX section enablement to dma_lib

; + pasemi_write_dma_reg(PAS_DMA_COM_TXCMD, 0); + while ((i 0) (pasemi_read_dma_reg(PAS_DMA_COM_TXSTA) 1)) + i--; This kind of caught my eye, is it still going to work when the next core is twice as fast? cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http

Re: [PATCH] ehea: Fix memory hook reference counting crashes

On Sat, 2015-04-25 at 14:43 -0400, David Miller wrote: From: Michael Ellerman m...@ellerman.id.au Date: Fri, 24 Apr 2015 15:52:32 +1000 The recent commit to only register the EHEA memory hotplug hooks on adapter probe has a few problems. Firstly the reference counting is wrong

[PATCH] ehea: Fix memory hook reference counting crashes

: registering mr failed ehea: register MR failed - driver inoperable! ehea: memory is going offline Fixes: aa183323312d (ehea: Register memory hotplug, reboot and crash hooks on adapter probe) Signed-off-by: Michael Ellerman m...@ellerman.id.au --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 6

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: (Evolution 3.16 is basically unbearable for replying to patches. Anyone else running into this?) If you mean the crazy lag when selecting moderate-to-large amounts of text (for

Re: [v2,9/9] fsl/fman: Add FMan MAC driver

On Thu, 2015-06-25 at 21:25 -0500, Scott Wood wrote: On Fri, 2015-06-26 at 12:21 +1000, Michael Ellerman wrote: On Thu, 2015-06-25 at 19:59 -0500, Scott Wood wrote: On Fri, 2015-06-26 at 01:06 +0200, Paul Bolle wrote: (Evolution 3.16 is basically unbearable for replying to patches

Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote: On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: e1000e_disable_aspm_locked() is only used in __e1000_resume() which is inside CONFIG_PM. So when CONFIG_PM=n we get a defined but not used warning for e1000e_disable_aspm_locked

Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

On Thu, 2015-07-23 at 07:07 -0700, Jeff Kirsher wrote: On Wed, 2015-07-22 at 11:41 +1000, Michael Ellerman wrote: On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote: On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: e1000e_disable_aspm_locked() is only used in __e1000_resume

[PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

e1000e_disable_aspm_locked() is only used in __e1000_resume() which is inside CONFIG_PM. So when CONFIG_PM=n we get a defined but not used warning for e1000e_disable_aspm_locked(). Move it inside the existing CONFIG_PM block to avoid the warning. Signed-off-by: Michael Ellerman m

Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

On Tue, 2015-12-08 at 17:44 -0500, Paul Gortmaker wrote: > This file was originally cloned off of the MPC8641D-HPCN reference > platform, which actually had a PHY IRQ line connected. However > this board does not. The bogus entry was largely inert and went > undetected until commit

Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

On Tue, 2015-12-08 at 21:40 -0500, David Miller wrote: > From: Paul Gortmaker > Date: Tue, 8 Dec 2015 17:44:02 -0500 > > This file was originally cloned off of the MPC8641D-HPCN reference > > platform, which actually had a PHY IRQ line connected. However > > this

Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file

On Tue, 2015-12-08 at 21:04 -0500, Paul Gortmaker wrote: > [Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file] On 09/12/2015 > (Wed 12:10) Michael Ellerman wrote: > > On Tue, 2015-12-08 at 17:44 -0500, Paul Gortmaker wrote: > > > This file was originally clone

Re: [P.A. Semi] Does the ethernet interface work on your Electra, Chitra, Nemo, and Athena board?

On Wed, 2015-12-02 at 05:59 +0100, Christian Zigotzky wrote: > Hi all, > > We tested some 4.3 kernels on a P.A. Semi reference board. Ultimately, > ethernet does not work, though on the reference board, the interface is > detected, gets link, but will not pass any packets/traffic. > >

Re: sbc8641: drop bogus PHY IRQ entries from DTS file

On Tue, 2015-08-12 at 22:44:02 UTC, Paul Gortmaker wrote: > This file was originally cloned off of the MPC8641D-HPCN reference > platform, which actually had a PHY IRQ line connected. However > this board does not. The bogus entry was largely inert and went > undetected until commit

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

On Tue, 2016-06-21 at 14:28 +0530, Naveen N. Rao wrote: > On 2016/06/20 03:56PM, Thadeu Lima de Souza Cascardo wrote: > > On Sun, Jun 19, 2016 at 11:19:14PM +0530, Naveen N. Rao wrote: > > > On 2016/06/17 10:00AM, Thadeu Lima de Souza Cascardo wrote: > > > > > > > > Hi, Michael and Naveen. > > >

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

On Tue, 2016-06-21 at 12:28 +0530, Naveen N. Rao wrote: > On 2016/06/21 09:38AM, Michael Ellerman wrote: > > On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote: > > > > > > #include > > > > > > in bpf_jit_comp64.c > > > >

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

On Tue, 2016-06-21 at 14:28 +0530, Naveen N. Rao wrote: > On 2016/06/20 03:56PM, Thadeu Lima de Souza Cascardo wrote: > > On Sun, Jun 19, 2016 at 11:19:14PM +0530, Naveen N. Rao wrote: > > > On 2016/06/17 10:00AM, Thadeu Lima de Souza Cascardo wrote: > > > > > > > > Hi, Michael and Naveen. > > >

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

On Fri, 2016-06-17 at 10:00 -0300, Thadeu Lima de Souza Cascardo wrote: > From a984dc02b6317a1d3a3c2302385adba5227be5bd Mon Sep 17 00:00:00 2001 > From: Thadeu Lima de Souza Cascardo > Date: Wed, 15 Jun 2016 13:22:12 -0300 > Subject: [PATCH] ppc: Fix BPF JIT for ABIv2 > >

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

On Tue, 2016-06-21 at 08:45 -0700, Alexei Starovoitov wrote: > On 6/21/16 7:47 AM, Thadeu Lima de Souza Cascardo wrote: > > > > > > > > The calling convention is different with ABIv2 and so we'll need changes > > > > in bpf_slow_path_common() and sk_negative_common(). > > > > > > How big would

Re: [PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

On Tue, 2016-06-07 at 19:02 +0530, Naveen N. Rao wrote: > PPC64 eBPF JIT compiler. > > Enable with: > echo 1 > /proc/sys/net/core/bpf_jit_enable > or > echo 2 > /proc/sys/net/core/bpf_jit_enable > > ... to see the generated JIT code. This can further be processed with >

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > diff --git a/arch/powerpc/net/bpf_jit_comp64.c > b/arch/powerpc/net/bpf_jit_comp64.c > new file mode 100644 > index 000..954ff53 > --- /dev/null > +++ b/arch/powerpc/net/bpf_jit_comp64.c > @@ -0,0 +1,956 @@ ... > + > +static void

Re: [PATCHv2,1/7] ppc bpf/jit: Disable classic BPF JIT on ppc64le

On Wed, 2016-22-06 at 16:25:01 UTC, "Naveen N. Rao" wrote: > Classic BPF JIT was never ported completely to work on little endian > powerpc. However, it can be enabled and will crash the system when used. > As such, disable use of BPF JIT on ppc64le. > > Reported-by: Thadeu Lima de Souza Cascardo

Re: [PATCH 3/3] param: convert some "on"/"off" users to strtobool

| 10 +++--- > arch/powerpc/platforms/pseries/hotplug-cpu.c | 11 +++ Acked-by: Michael Ellerman <m...@ellerman.id.au> (powerpc) cheers

Re: [PATCHv2, 2/7] ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation

On Wed, 2016-22-06 at 16:25:02 UTC, "Naveen N. Rao" wrote: > The existing LI32() macro can sometimes result in a sign-extended 32-bit > load that does not clear the top 32-bits properly. As an example, > loading 0x7fff results in the register containing > 0x7fff. While this does

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote: > On 2016/06/17 10:53PM, Michael Ellerman wrote: > > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote: > > > diff --git a/arch/powerpc/net/bpf_jit_comp64.c > > > b/arch/powerpc/net/bpf_ji

Re: [2/3] powerpc: bpf: flush the entire JIT buffer

On Fri, 2017-01-13 at 17:10:01 UTC, "Naveen N. Rao" wrote: > With bpf_jit_binary_alloc(), we allocate at a page granularity and fill > the rest of the space with illegal instructions to mitigate BPF spraying > attacks, while having the actual JIT'ed BPF program at a random location > within the

Re: [1/3] powerpc: bpf: remove redundant check for non-null image

On Fri, 2017-01-13 at 17:10:00 UTC, "Naveen N. Rao" wrote: > From: Daniel Borkmann > > We have a check earlier to ensure we don't proceed if image is NULL. As > such, the redundant check can be removed. > > Signed-off-by: Daniel Borkmann > [Added

[PATCH] net: Remove NO_IRQ from powerpc-only network drivers

We'd like to eventually remove NO_IRQ on powerpc, so remove usages of it from powerpc-only drivers. Signed-off-by: Michael Ellerman <m...@ellerman.id.au> --- drivers/net/ethernet/freescale/fman/fman_mac.h | 2 +- drivers/net/ethernet/freescale/fs_enet/mac-fcc.c | 2 +- drivers/net/et

Re: [PATCH] MAINTAINERS: Remove myself from PA Semi entries

Olof Johansson writes: > The platform is old, very few users and I lack bandwidth to keep after > it these days. > > Mark the base platform as well as the drivers as orphans, patches have > been flowing through the fallback maintainers for a while already. Sorry to see you go,

Re: [PATCH 2/9] selftests: update filesystems Makefile to work under selftests

Shuah Khan writes: > Update to work under selftests. dnotify_test will not be run as part of > selftests suite and will not included in install targets. It can be built > separately for now. > > Signed-off-by: Shuah Khan > --- >

Re: [1/3] bpf powerpc: introduce accessors for using the tmp local stack space

On Fri, 2016-23-09 at 20:35:00 UTC, "Naveen N. Rao" wrote: > While at it, ensure that the location of the local save area is > consistent whether or not we setup our own stackframe. This property is > utilised in the next patch that adds support for tail calls. > > Signed-off-by: Naveen N. Rao

Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

Joe Perches writes: > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: >> From: Madalin Bucur >> Date: Wed, 2 Nov 2016 22:17:26 +0200 >> >> > This introduces the Freescale Data Path Acceleration Architecture >> > +static inline size_t

Re: [mm PATCH v2 18/26] arch/powerpc: Add option to skip DMA sync as a part of mapping

amin Herrenschmidt <b...@kernel.crashing.org> > Cc: Paul Mackerras <pau...@samba.org> > Cc: Michael Ellerman <m...@ellerman.id.au> > Cc: linuxppc-...@lists.ozlabs.org > Signed-off-by: Alexander Duyck <alexander.h.du...@intel.com> > --- > arch/powerpc/kernel/dma.c

Re: [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

Elena Reshetova writes: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > >

[PATCH] bpf: Update sysctl documentation to list all supported architectures

The sysctl documentation states that the JIT is only available on x86_64, which is no longer correct. Update the list to include all architectures that enable HAVE_CBPF_JIT or HAVE_EBPF_JIT under some configuration. Signed-off-by: Michael Ellerman <m...@ellerman.id.au> --- Documentation/

Re: [PATCH] bpf: Update sysctl documentation to list all supported architectures

Daniel Borkmann <dan...@iogearbox.net> writes: > Hi Michael, > > On 08/16/2017 07:15 AM, Michael Ellerman wrote: >> The sysctl documentation states that the JIT is only available on >> x86_64, which is no longer correct. >> >> Update the list to include all

Re: [PATCH net RESEND] PCI: fix oops when try to find Root Port for a PCI device

Thierry Reding writes: ... > > In case of Tegra, dev actually points to the root port. Now if I read > the above code correctly, highest_pcie_bridge will still be NULL in that > case, which in turn will return NULL from pci_find_pcie_root_port(). But > shouldn't it

Re: [PATCH] bpf: Update sysctl documentation to list all supported architectures

Daniel Borkmann <dan...@iogearbox.net> writes: > On 08/16/2017 01:10 PM, Michael Ellerman wrote: >> Daniel Borkmann <dan...@iogearbox.net> writes: >>> On 08/16/2017 07:15 AM, Michael Ellerman wrote: >>>> diff --git a/Documentation/sysctl/net.txt

[PATCH v2] bpf: Update sysctl documentation to list all supported architectures

The sysctl documentation states that the JIT is only available on x86_64, which is no longer correct. Update the list, and break it out to indicate which architectures support the cBPF JIT (via HAVE_CBPF_JIT) or the eBPF JIT (HAVE_EBPF_JIT). Signed-off-by: Michael Ellerman <m...@ellerman.id

Re: [PATCH] PCI: Allow PCI express root ports to find themselves

Thierry Reding writes: > From: Thierry Reding > > If the pci_find_pcie_root_port() function is called on a root port > itself, return the root port rather than NULL. > > This effectively reverts commit 0e405232871d6 ("PCI: fix oops when > try to

Re: [PATCH v2] bpf: Update sysctl documentation to list all supported architectures

Daniel Borkmann <dan...@iogearbox.net> writes: > On 08/17/2017 12:30 PM, Michael Ellerman wrote: >> The sysctl documentation states that the JIT is only available on >> x86_64, which is no longer correct. >> >> Update the list, and break it out to indicate which

Re: [PATCH net-next] net: phy: use of_mdio_parse_addr

Liviu Dudau writes: > On Fri, Jun 02, 2017 at 02:22:51PM -0400, David Miller wrote: >> From: Jon Mason >> Date: Wed, 31 May 2017 15:43:30 -0400 >> >> > use of_mdio_parse_addr() in place of an OF read of reg and a bounds >> > check (which is litterally

Re: DNS (?) not working on G5 (64-bit powerpc) (was [net-next,v3,3/3] udp: try to avoid 2 cache miss on dequeue)

Paolo Abeni writes: > Thank you! > > I'll submit formally the patch after some more testing. Thanks. > I noticed this version has entered the ppc patchwork, but I think that > the formal submission should go towards the net-next tree. Yeah it picks up all patches sent to the

  1   2   >