Re: [PATCH] check connect(2) status for IPv6 UDP socket

Hi all, in the same way of this patch, why dst_entry are stored for RAW socket ? In case of specific IPSec rules for ICMPv6, xfrm state can be different for the same destination. Attached, a proposed patch. Regards, Nicolas [IPV6] Don't store dst_entry for RAW socket Signed-off-by: Nicolas

IPv6 and rt6_lookup()

updated, and so will expire, whereas the host will keep the corresponding address. Maybe, when strict is set to 1 in rt6_lookup(), kernel must not return an anycast route. What about this patch ? Regards, Nicolas [IPv6] Don't return anycast route when strict is enable Signed-off-by: Nicolas

Re: IPv6 and rt6_lookup()

Le 02.11.2006 18:02, Vlad Yasevich a écrit : Nicolas DICHTEL wrote: Hello, Suppose that a host has autoconfiguration enabled. It will take RA to autoconfigure an IPv6 address. For example, 2001:0db8:3008:c1ca:2d0:b7ff:febb:4aee/64. This host will create a route entry for this onlink prefix

Re: [PATCH] check connect(2) status for IPv6 UDP socket

Herbert Xu a écrit : David S. Miller [EMAIL PROTECTED] wrote: From: Nicolas DICHTEL [EMAIL PROTECTED] Date: Mon, 06 Feb 2006 12:00:30 +0100 in the same way of this patch, why dst_entry are stored for RAW socket ? In case of specific IPSec rules for ICMPv6, xfrm state can be different

Re: [PATCH 2/3] [VLAN]: Update iif when receiving via VLAN device

Thomas Graf a écrit : * Nicolas Dichtel [EMAIL PROTECTED] 2006-06-30 15:16 That creates a nice loop on ingress. Upon reentering the stack with skb-dev set to eth0 again we'll go through the same ingress filters as the first time and we'll hit ifb0 again over and over. Are you suggesting

Oops in IFB

devices. Signed-off-by: Nicolas Dichtel [EMAIL PROTECTED] --- a/drivers/net/ifb.c 2006-07-20 15:16:31.923529050 +0200 +++ b/drivers/net/ifb.c 2006-07-20 15:17:36.370188249 +0200 @@ -271,6 +271,7 @@ for (i = 0; i numifbs !err; i++) err = ifb_init_one(i); if (err) { + i--; while (--i

Re: Oops in IFB

jamal a écrit : BTW, in the name of the LinuxWay(tm) - can you also submit a similar patch for dummy? It suffers from the same bug. No problem, patch is enclosed. Cheers, Nicolas [DUMMY] Avoid an oops when dummy_init_one() failed Signed-off-by: Nicolas Dichtel [EMAIL PROTECTED

Re: Oops in IFB

Sorry, I forgot the patch ;-) Nicolas Nicolas DICHTEL a écrit : jamal a écrit : BTW, in the name of the LinuxWay(tm) - can you also submit a similar patch for dummy? It suffers from the same bug. No problem, patch is enclosed. Cheers, Nicolas [DUMMY] Avoid an oops when dummy_init_one

[PATCH][NET]: fix dummy initialization

Same problem and same fix that for IFB. Regards, Nicolas [NET][DUMMY] Avoid an oops when dummy_init_one() failed Signed-off-by: Nicolas Dichtel [EMAIL PROTECTED] --- a/drivers/net/dummy.c 2006-07-20 16:19:09.395351558 +0200 +++ b/drivers/net/dummy.c 2006-07-20 16:19:58.802327279 +0200

[PATCH iproute2 1/3] tc: fix compilation warning on 32bits arch

The warning was: m_simple.c: In function ‘parse_simple’: m_simple.c:142:4: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘size_t’ [-Wformat] Useful to be able to compile with -Werror. Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- tc

[PATCH iproute2 2/3] libnamespaces: fix warning about syscall()

The warning was: In file included from namespace.c:14:0: ../include/namespace.h: In function ‘setns’: ../include/namespace.h:37:2: warning: implicit declaration of function ‘syscall’ [-Wimplicit-function-declaration] Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include

[PATCH iproute2 3/3] mroute: remove invalid check against NLM_F_MULTI

This flag is only for the netlink protocol (multi-part messages), no reason to reject messages without it. Note that this flag was removed by the following kernel patches (v3.14) 65886f439ab0 ipmr: fix mfc notification flags f518338b1603 ip6mr: fix mfc notification flags Signed-off-by: Nicolas

[PATCH v2 iproute2 1/3] tc: fix compilation warning on 32bits arch

The warning was: m_simple.c: In function ‘parse_simple’: m_simple.c:142:4: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘size_t’ [-Wformat] Useful to be able to compile with -Werror. Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v2: use %zu

[PATCH v2 iproute2 2/3] libnamespaces: fix warning about syscall()

The warning was: In file included from namespace.c:14:0: ../include/namespace.h: In function ‘setns’: ../include/namespace.h:37:2: warning: implicit declaration of function ‘syscall’ [-Wimplicit-function-declaration] Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include

[PATCH v2 iproute2 3/3] mroute: remove invalid check against NLM_F_MULTI

This flag is only for the netlink protocol (multi-part messages), no reason to reject messages without it. Note that this flag was removed by the following kernel patches (v3.14) 65886f439ab0 ipmr: fix mfc notification flags f518338b1603 ip6mr: fix mfc notification flags Signed-off-by: Nicolas

[RFC PATCH net 4/4] netlink: add a flags field in the cb structure

a dump sends this NLMSG_DONE message. Let's set this flag directly into the dump, hence people won't copy and paste NLM_F_MULTI. Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include/linux/netlink.h | 1 + net/core/rtnetlink.c | 9 - net/netlink/af_netlink.c | 1 + 3 files

[PATCH net 0/3] netlink: fix wrong use of the flag NLM_F_MULTI

The first three patches fix a wrong use of this flag. Because it's not the first time that this kind of bug happens, it could be good to find something to help people. The only idea that I have is in the last patch. It's just an example, if people agrees on it, I will update all users and

[PATCH net 1/3] bridge/mdb: remove wrong use of NLM_F_MULTI

...@networkplumber.org CC: bri...@lists.linux-foundation.org Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/bridge/br_mdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index 409608960899..e29ad70b3000 100644 --- a/net/bridge

[PATCH net 2/3] bridge/nl: remove wrong use of NLM_F_MULTI

: Scott Feldman sfel...@gmail.com CC: Stephen Hemminger step...@networkplumber.org CC: bri...@lists.linux-foundation.org Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- drivers/net/ethernet/emulex/benet/be_main.c | 5 +++-- drivers/net/ethernet/intel/i40e/i40e_main.c | 7

[PATCH net 3/3] tipc: remove wrong use of NLM_F_MULTI

api) Fixes: 46f15c6794fb (tipc: add media get/dump to new netlink api) CC: Richard Alpe richard.a...@ericsson.com CC: Jon Maloy jon.ma...@ericsson.com CC: Ying Xue ying@windriver.com CC: tipc-discuss...@lists.sourceforge.net Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/tipc

Re: [PATCH net] rtnl: don't send rtnl msg for unregistered iface

Le 11/05/2015 18:04, Nicolas Dichtel a écrit : Le 11/05/2015 17:37, Jiri Pirko a écrit : [snip] I don't think this is the correct way to fix this. How ifindex can be 0 here? Ifindex is set in register_netdevice and looking at bond_create, I don't see any call to __bond_opt_set before

Re: [PATCH 2/6] net: Add a struct net parameter to sock_create_kern

Le 12/05/2015 13:48, David Laight a écrit : From: Eric W. Biederman Sent: 12 May 2015 09:55 On May 12, 2015 3:24:11 AM CDT, David Laight david.lai...@aculab.com wrote: ... Wouldn't it involve far less churn to add a new function that uses a non-default namespace? The goal is comprehensible

[PATCH v2 iproute2] netns: allow to dump and monitor nsid

during listing on rth). Example: $ ip netns list-id nsid 0 (iproute2 netns name: foo) $ ip monitor nsid Deleted nsid 0 (iproute2 netns name: foo) nsid 16 (iproute2 netns name: bar) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v2: rebase on master after the 4.0 release include

[PATCH iproute2] ipxfrm: wrong nl msg sent on deleteall cmd

'. Reported-by: Gregory Hoggarth gregory.hogga...@alliedtelesis.co.nz Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- ip/xfrm_policy.c | 24 ++-- ip/xfrm_state.c | 12 +++- 2 files changed, 33 insertions(+), 3 deletions(-) diff --git a/ip/xfrm_policy.c b/ip

Re: ip_tunnel: Remove gratuitous skb scrubbing

Le 15/04/2015 15:57, Herbert Xu a écrit : On Wed, Apr 15, 2015 at 06:22:29PM +0800, Herbert Xu wrote: [snip] Subject: skbuff: Do not scrub skb mark within the same name space The commit ea23192e8e577dfc51e0f4fc5ca113af334edff9 (tunnels: Maybe add a Fixes tag? Fixes: ea23192e8e57 (tunnels:

Re: [v3] skbuff: Do not scrub skb mark within the same name space

Le 16/04/2015 09:02, James Morris a écrit : On Thu, 16 Apr 2015, Herbert Xu wrote: [snip] PS I used the wrong email for James the first time around. So let me repeat the question here. Should secmark be preserved or cleared across tunnels within the same name space? In fact, do our security

Re: [PATCH -next] netns: remove duplicated include from net_namespace.c

Le 16/04/2015 15:17, weiyj...@163.com a écrit : From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove duplicated include. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Acked-by: Nicolas Dichtel nicolas.dich...@6wind.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH V1 net-next] IB/ipoib: Fix ndo_get_iflink

-by: Honggang Li ho...@redhat.com Signed-off-by: Erez Shitrit ere...@mellanox.com Signed-off-by: Honggang Li ho...@redhat.com Acked-by: Nicolas Dichtel nicolas.dich...@6wind.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More

Re: ip_tunnel: Remove gratuitous skb scrubbing

Le 15/04/2015 12:22, Herbert Xu a écrit : On Wed, Apr 15, 2015 at 12:20:42PM +0200, Nicolas Dichtel wrote: Le 15/04/2015 12:01, Herbert Xu a écrit : The commit ea23192e8e577dfc51e0f4fc5ca113af334edff9 (tunnels: harmonize cleanup done on skb on rx path) broke anyone trying to use netfilter

Re: ip_tunnel: Remove gratuitous skb scrubbing

Le 15/04/2015 12:01, Herbert Xu a écrit : The commit ea23192e8e577dfc51e0f4fc5ca113af334edff9 (tunnels: harmonize cleanup done on skb on rx path) broke anyone trying to use netfilter marking across IPv4 tunnels. As the commit message did not give any justification for this (in fact it shouldn't

Re: [RFC net-next 2/3] VRF driver and needed infrastructure

Le 08/06/2015 20:35, Shrijeet Mukherjee a écrit : From: Shrijeet Mukherjee s...@cumulusnetworks.com [snip] --- /dev/null +++ b/drivers/net/vrf.c [snip] + +static struct rtnl_link_ops vrf_link_ops __read_mostly = { + .kind = DRV_NAME, + .priv_size = sizeof(struct

Re: [RFC net-next 0/3] Proposal for VRF-lite

Le 08/06/2015 20:35, Shrijeet Mukherjee a écrit : From: Shrijeet Mukherjee s...@cumulusnetworks.com In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the

Re: [PATCH iproute2 resend] Fix changing tunnel remote and local address to any

the tunnel, the current parameters will be read from ip_tunnel_parm, and local and remote address won't be zeroes anymore, so it needs to be explicitly set to any. Signed-off-by: Thadeu Lima de Souza Cascardo casca...@redhat.com Acked-by: Nicolas Dichtel nicolas.dich...@6wind.com

Re: [RFC net-next 0/3] Proposal for VRF-lite

Le 09/06/2015 16:21, David Ahern a écrit : Hi Nicolas: On 6/9/15 2:58 AM, Nicolas Dichtel wrote: I'm not really in favor of the name 'vrf'. This term is very controversial and having a consensus of what is/contains a 'vrf' is quite impossible. There was already a lot of discussions about

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

Le 03/06/2015 00:58, Eric W. Biederman a écrit : [snip] On the drawing board is getting cross namespace routes so with a little luck I will only need loopback devices in most of my network namespaces when the dust settles. +1 I've start to look at this, but I didn't have enough time right now.

Re: [RFC net-next 0/3] Proposal for VRF-lite

Le 09/06/2015 12:15, Thomas Graf a écrit : On 06/08/15 at 11:35am, Shrijeet Mukherjee wrote: [...] model with some performance paths that need optimization. (Specifically the output route selector that Roopa, Robert, Thomas and EricB are currently discussing on the MPLS thread) Thanks for

Re: displayed name changed in ip link show for bridge- and other interfaces

Le 21/06/2015 00:58, Oliver Hartkopp a écrit : On 06/17/2015 09:26 AM, Nicolas Dichtel wrote: Le 16/06/2015 19:35, Oliver Hartkopp a écrit : On 15.06.2015 17:54, Stephen Hemminger wrote: On Mon, 15 Jun 2015 11:13:12 +0200 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Theoretically

Re: displayed name changed in ip link show for bridge- and other interfaces

Le 15/06/2015 09:23, Nicolas Dichtel a écrit : Le 14/06/2015 21:12, Oliver Hartkopp a écrit : @Nicolas: Just saw that you were not responsible for the @NONE m) Sorry. Btw. do you know why this @NONE stuff just emerged in 4.1-rc ? Yes, it comes from the iflink cleanup in kernel: http

Re: [PATCH net-next 0/3 v4] changes to make ipv4 routing table aware of next-hop link status

Le 17/06/2015 21:10, Andy Gospodarek a écrit : On Wed, Jun 17, 2015 at 06:05:32PM +0200, Nicolas Dichtel wrote: Le 15/06/2015 18:33, Andy Gospodarek a écrit : This series adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status

Re: displayed name changed in ip link show for bridge- and other interfaces

Le 16/06/2015 19:35, Oliver Hartkopp a écrit : On 15.06.2015 17:54, Stephen Hemminger wrote: On Mon, 15 Jun 2015 11:13:12 +0200 Nicolas Dichtel nicolas.dich...@6wind.com wrote: Theoretically, virtual interfaces should advertise an IFLA_LINK to 0. I don't know what is the best fix

Re: [PATCH net-next 0/3 v4] changes to make ipv4 routing table aware of next-hop link status

Le 15/06/2015 18:33, Andy Gospodarek a écrit : This series adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving

Re: displayed name changed in ip link show for bridge- and other interfaces

Le 14/06/2015 21:12, Oliver Hartkopp a écrit : @Nicolas: Just saw that you were not responsible for the @NONE m) Sorry. Btw. do you know why this @NONE stuff just emerged in 4.1-rc ? Yes, it comes from the iflink cleanup in kernel:

iproute2: missing patches in branch net-next

Hi Stephen, some patches that were recently included in iproute2 branch net-next are not visible anymore on kernel.org. It seems that the branch has been overridden (note the forced update when I've fetched it): $ git fetch remote: Counting objects: 65, done. remote: Compressing objects: 100%

Re: [PATCH] add stealth mode

Le 02/07/2015 00:53, Matteo Croce a écrit : Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Dest-Unreach for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface. ---

Re: [PATCH] add stealth mode

Le 02/07/2015 10:38, Matteo Croce a écrit : Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface.

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

Le 06/07/2015 17:03, David Ahern a écrit : This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing to

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

Le 22/05/2015 22:50, Alexander Holler a écrit : Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id. Me too, I've recently written a little tool

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

Le 25/05/2015 12:55, Alexander Holler a écrit : Am 25.05.2015 um 09:45 schrieb Nicolas Dichtel: Le 22/05/2015 22:50, Alexander Holler a écrit : First I think if NETLINK_LISTEN_ALL_NSID is enabled, a dump of the interfaces through RTM_GETLINK together with NLM_F_DUMP and NLM_F_REQUEST should

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

Le 26/05/2015 12:53, Alexander Holler a écrit : Am 25.05.2015 um 15:09 schrieb Nicolas Dichtel: [snip] Hmm, sounds like we're talking in different rooms about the same thing in regard to the dump. ;) I just wanted to explain why I think this series misses the (extended) dump which includes

Re: [RFC net-next 0/6] Proposal for VRF-lite - v2

Le 06/07/2015 17:03, David Ahern a écrit : In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique

[PATCH net] Revert dev: set iflink to 0 for virtual interfaces

This reverts commit e1622baf54df8cc958bf29d71de5ad545ea7d93c. The side effect of this commit is to add a '@NONE' after each virtual interface name with a 'ip link'. It may break existing scripts. Reported-by: Olivier Hartkopp socket...@hartkopp.net Signed-off-by: Nicolas Dichtel nicolas.dich

Re: [PATCH net-next] net: add support for linkdown sysctl to netconf

Le 06/07/2015 20:21, Andy Gospodarek a écrit : This kernel patch exports the value of the new ignore_routes_with_linkdown via netconf. Signed-off-by: Andy Gospodarek go...@cumulusnetworks.com Suggested-by: Nicolas Dichtel nicolas.dich...@6wind.com --- You need also to patch devinet_conf_proc

[PATCH net v2] Revert dev: set iflink to 0 for virtual interfaces

This reverts commit e1622baf54df8cc958bf29d71de5ad545ea7d93c. The side effect of this commit is to add a '@NONE' after each virtual interface name with a 'ip link'. It may break existing scripts. Reported-by: Oliver Hartkopp socket...@hartkopp.net Signed-off-by: Nicolas Dichtel nicolas.dich

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

Le 19/08/2015 14:48, Vincent Bernat a écrit : ❦ 19 août 2015 14:38 +0200, Jiri Benc jb...@redhat.com : That's the main goal of this patch: advertising the peer link as IFLA_LINK attribute triggers an infinite loop in userland software when they follow iflink to discover network devices

Re: [PATCH net-next] vrf: rename the framework to mrf

Le 22/08/2015 19:47, David Miller a écrit : From: Nicolas Dichtel nicolas.dich...@6wind.com Date: Sat, 22 Aug 2015 18:10:20 +0200 This patch renames the recently added vrf driver. 'VRF' term is very generic and there is no clear definition of it. For example, someone may expect more isolation

Re: [PATCH] veth: replace iflink by a dedicated symlink in sysfs

Le 20/08/2015 13:53, Jiri Benc a écrit : On Wed, 19 Aug 2015 18:33:14 +0200, Nicolas Dichtel wrote: Probably better to introduce veth netlink attribute then, something like IFLA_VETH_PEER and keeps IFLA_LINK_NETNSID. I'd prefer IFLA_PEER. More generic attribute will be helpful should we

[PATCH net-next] vrf: rename the framework to mrf

enlightens the fact that this driver is not *the* way to implement VRF in linux, but *a* tool among others. CC: Shrijeet Mukherjee s...@cumulusnetworks.com CC: David Ahern d...@cumulusnetworks.com Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- drivers/net/Kconfig | 8 +- drivers

Re: [PATCH net-next v3] route: allow to route in a peer netns via lwt framework

Le 29/07/2015 17:20, Eric Dumazet a écrit : On Wed, 2015-07-29 at 15:16 +0200, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that point to a peer netns. Packets are injected to the peer netns via the loopback device

[PATCH net-next v3] route: allow to route in a peer netns via lwt framework

lo The goal is to be scalable when the number of netns is high (10k or more). Which this patch, we can save two interfaces (veth) per netns, which helps to to reduce memory consumption and the time needed to create a netns. Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v3: fix skb

Re: [PATCH net-next v2] route: allow to route in a peer netns via lwt framework

Le 24/07/2015 17:39, Eric Dumazet a écrit : On Fri, 2015-07-24 at 16:16 +0200, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that point to a peer netns. Packets are injected to the peer netns via the loopback device

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 24/07/2015 17:19, David Ahern a écrit : In this case you are knowingly dropping packets. Would be nice to have a counter showing that. Ok. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH net-next] lwtunnel: export linux/lwtunnel.h to userspace

Note also that include/linux/lwtunnel.h is not needed. CC: Thomas Graf tg...@suug.ch CC: Roopa Prabhu ro...@cumulusnetworks.com Fixes: 499a24256862 (lwtunnel: infrastructure for handling light weight tunnels like mpls) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include/linux

[PATCH net-next] ipv6: use lwtunnel_output6() only if flag redirect is set

This function make sense only when LWTUNNEL_STATE_OUTPUT_REDIRECT is set. The check is already done in IPv4. CC: Thomas Graf tg...@suug.ch CC: Roopa Prabhu ro...@cumulusnetworks.com Fixes: 74a0f2fe8ed5 (ipv6: rt6_info output redirect to tunnel output) Signed-off-by: Nicolas Dichtel nicolas.dich

[PATCH net-next 1/2] ipv6: copy lwtstate in ip6_rt_copy_init()

We need to copy this field (ip6_rt_cache_alloc() and ip6_rt_pcpu_alloc() use ip6_rt_copy_init() to build a dst). CC: Thomas Graf tg...@suug.ch CC: Roopa Prabhu ro...@cumulusnetworks.com Fixes: 19e42e451506 (ipv6: support for fib route lwtunnel encap attributes) Signed-off-by: Nicolas Dichtel

[PATCH net-next 2/2] lwtunnel: change prototype of lwtunnel_state_get()

: Roopa Prabhu ro...@cumulusnetworks.com Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- include/net/lwtunnel.h | 16 +++- net/ipv4/fib_semantics.c | 9 - net/ipv4/route.c | 9 ++--- net/ipv6/ip6_fib.c | 2 +- net/ipv6/route.c | 8

Re: [PATCH iproute2] tc: fix bpf compilation with old glibc

Le 22/07/2015 15:05, Daniel Borkmann a écrit : On 07/22/2015 02:29 PM, Nicolas Dichtel wrote: Error was: f_bpf.o: In function `bpf_parse_opt': f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv' m_bpf.o: In function `parse_bpf': m_bpf.c:(.text+0x587): undefined reference

[PATCH net-next v2] route: allow to route in a peer netns via lwt framework

lo Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v2: rework loopback handling part (update stats and call skb_dst_force()) fix ipv6 processing check lwtunnel type before converting data to a nsid drivers/net/loopback.c| 33 +-- include/net

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 24/07/2015 16:28, David Ahern a écrit : On 7/23/15 8:22 AM, Nicolas Dichtel wrote: static netdev_tx_t loopback_xmit(struct sk_buff *skb, struct net_device *dev) { +int nsid = skb_lwt_netns_info(skb); struct pcpu_lstats *lb_stats; int len; +if (nsid

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 24/07/2015 15:50, roopa a écrit : On 7/24/15, 5:24 AM, Nicolas Dichtel wrote: Sure, but my goal was to not create a new .h file just for these two helpers. It's related to lwtunnel, thus I was thinking they can go here. ok..., since your lwt namespace functions went into net_namespace.c, I

[PATCH net-next] route: allow to route in a peer netns via lwt framework

lo Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- drivers/net/loopback.c| 16 + include/net/lwtunnel.h| 23 +++ include/uapi/linux/lwtunnel.h | 1 + net/core/net_namespace.c | 52 +++ 4 files

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 23/07/2015 17:01, roopa a écrit : On 7/23/15, 7:22 AM, Nicolas Dichtel wrote: [snip] +static inline u32 *lwt_netns_info(struct lwtunnel_state *lwtstate) +{ +return (u32 *)lwtstate-data; +} + +static inline int skb_lwt_netns_info(struct sk_buff *skb) +{ +if (skb-protocol == htons

[PATCH v2 iproute2] tc: fix bpf compilation with old glibc

version of getenv, thus let's simply use getenv(). CC: Daniel Borkmann dan...@iogearbox.net Fixes: 88eea5395483 (tc: {f,m}_bpf: allow to retrieve uds path from env) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- v2: rework the fix to use getenv() instead of secure_getenv() examples

[PATCH net-next] openvswitch: fix compilation when vxlan is a module

tg...@suug.ch Fixes: 614732eaa12d (openvswitch: Use regular VXLAN net_device device) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/openvswitch/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/net/openvswitch/Kconfig b/net/openvswitch/Kconfig index 1119f46b80b4

[PATCH iproute2] tc: fix bpf compilation with old glibc

: 88eea5395483 (tc: {f,m}_bpf: allow to retrieve uds path from env) Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- configure | 49 +++-- tc/Makefile | 6 ++ tc/tc_bpf.h | 9 + 3 files changed, 62 insertions(+), 2 deletions

Re: [PATCH net-next v2 1/5] net: don't reforward packets already forwarded by offload device

Le 16/07/2015 10:04, sfel...@gmail.com a écrit : From: Scott Feldman sfel...@gmail.com Just before queuing skb for xmit on port, check if skb has been marked by switchdev port driver as already fordwarded by device. If so, drop skb. A non-zero skb-offload_fwd_mark field is set by the

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

Le 23/07/2015 17:50, roopa a écrit : On 7/23/15, 8:25 AM, Nicolas Dichtel wrote: Le 23/07/2015 17:01, roopa a écrit : On 7/23/15, 7:22 AM, Nicolas Dichtel wrote: [snip] +static inline u32 *lwt_netns_info(struct lwtunnel_state *lwtstate) +{ +return (u32 *)lwtstate-data; +} + +static

[PATCH linux-3.18.y] rtnl: restore notifications for deleted interfaces

...@gmail.com Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/core/rtnetlink.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 24d3242f0e01..c522f7a00eab 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2229,9 +2229,6

Re: [PATCH net v4] rtnl/bond: don't send rtnl msg for unregistered iface

Le 13/07/2015 16:11, Kristian Evensen a écrit : Hello, I have a quick question about this patch. On Wed, May 13, 2015 at 2:19 PM, Nicolas Dichtel nicolas.dich...@6wind.com wrote: diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 837d30b5ffed..7b25f1ef3d75 100644 --- a/net/core

Re: [PATCH net-next v3 1/5] net: don't reforward packets already forwarded by offload device

sfel...@gmail.com Acked-by: Jiri Pirko j...@resnulli.us Acked-by: Roopa Prabhu ro...@cumulusnetworks.com Acked-by: Nicolas Dichtel nicolas.dich...@6wind.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH net v4] rtnl/bond: don't send rtnl msg for unregistered iface

Le 13/07/2015 16:11, Kristian Evensen a écrit : Hello, I have a quick question about this patch. On Wed, May 13, 2015 at 2:19 PM, Nicolas Dichtel nicolas.dich...@6wind.com wrote: diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 837d30b5ffed..7b25f1ef3d75 100644 --- a/net/core

[PATCH net] ip6_gre: release cached dst on tunnel removal

...@mail.ru Fixes: c12b395a4664 (gre: Support GRE over IPv6) Signed-off-by: huaibin Wang huaibin.w...@6wind.com Signed-off-by: Nicolas Dichtel nicolas.dich...@6wind.com --- net/ipv6/ip6_gre.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index a38d3ac0f18f

Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

Le 21/10/2015 19:12, Hannes Frederic Sowa a écrit : Hello, On Wed, Oct 21, 2015, at 17:56, David Miller wrote: From: Jiri Benc Date: Wed, 21 Oct 2015 17:25:02 +0200 On Wed, 21 Oct 2015 08:32:14 -0700 (PDT), David Miller wrote: As you say the apps are broken, so file a bug

Re: [PATCH net] net: try harder to not reuse ifindex when moving interfaces

Le 22/10/2015 17:00, Jiri Benc a écrit : On Thu, 22 Oct 2015 16:52:13 +0200, Nicolas Dichtel wrote: With the proposed scenario: 1. create netns 'new_netns' 2. in root netns, move the interface with ifindex 2 to new_netns 3. in new_netns, delete the interface with ifindex 2 4. in new_netns

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

Le 14/10/2015 11:34, Hannes Frederic Sowa a écrit : [sni] This sysctl is on my list to be enabled soon by default by any systemd based distribution. For that reason, could you maybe remove all the I'm not sure to understand why we add a sysctl then. Or at least, why the linux default value is

Re: [PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk

Le 07/10/2015 22:39, Eric W. Biederman a écrit : Nicolas Dichtel <nicolas.dich...@6wind.com> writes: Le 06/10/2015 20:53, Eric W. Biederman a écrit : It is confusing and silly hiding a paramater so modify all of the callers to pass in the appropriate socket or skb->sk if no socket

Re: [PATCH net-next 00/16] net: Pass net through the output path v2

in passing sock_net(sk) from the socket a packet locally originates on to the dst->output function. LGTM. Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel

Re: [PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route

<ro...@cumulusnetworks.com> Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> --- I am not sure if it is too late for this change. But, sending this patch out because it only affects ip monitor output Seems reasonable to me, but I let Stephen speaking at this. -- To unsubscribe from

Re: [PATCH net-next 0/3] net: Pass net into defragmentation

, and nf_ct_frag6_gather. Acked-by: Nicolas Dichtel <nicolas.dich...@6wind.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk

Le 06/10/2015 20:53, Eric W. Biederman a écrit : It is confusing and silly hiding a paramater so modify all of the callers to pass in the appropriate socket or skb->sk if no socket is known. Signed-off-by: "Eric W. Biederman" --- [snip] @@ -456,7 +456,7 @@

Re: [PATCH net-next 01/15] ipv4: Fix ip_local_out_sk by passing the sk into __ip_local_out_sk

Le 06/10/2015 20:53, Eric W. Biederman a écrit : In the rare case where sk != skb->sk ip_local_out_sk arranges to call dst->output differently if the skb is queued or not. This is a bug. Fix this bug by passing the sk parameter of ip_local_out_sk through from ip_local_out_sk to

Re: [RFC net-next 2/6] net: Preparation for vrf device

Le 06/07/2015 17:03, David Ahern a écrit : Add a VRF_MASTER flag for interfaces and helper functions for determining if a device is a VRF_MASTER. Also, add link attribute for passing VRF_TABLE id. Both are used in the following patch that adds a VRF device driver. Signed-off-by: Shrijeet

Re: [PATCH net-next v2] ipv4: add support for linkdown sysctl to netconf

net-next, not net. Signed-off-by: Andy Gospodarek go...@cumulusnetworks.com Suggested-by: Nicolas Dichtel nicolas.dich...@6wind.com Acked-by: Nicolas Dichtel nicolas.dich...@6wind.com --- I realize two of these changes result in lines 80 chars, but this is to keep the coding-style used

Re: [RFC net-next 0/6] Proposal for VRF-lite - v2

Le 06/07/2015 19:53, Shrijeet Mukherjee a écrit : No no problem, Just trying to get the functional aspects worked out. the global search replace will be easy. Was hoping to see some more responses on the naming suggestions here from the community. If there is not disagreement we can spin

Re: [RFC net-next 2/6] net: Preparation for vrf device

Le 08/07/2015 10:37, Nicolas Dichtel a écrit : [snip] Also, why calling this '_MASTER', is there a notion of SLAVE? Ok, just got it in the next patch ;-) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

Le 06/07/2015 17:03, David Ahern a écrit : This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a device and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all local routes pointing to

Re: Issue with /etc/netns/${nsname}/hosts

Le 02/09/2015 01:23, James Loosli a écrit : I seem to have an issue with using namespace-specific hosts files. Here's an example. I have different entries for foo.com in my hosts file for the namespace and the system-wide hosts file; root@server-01 Tue Sep 01 04:15:02pm cat

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

Le 06/09/2015 22:46, Roopa Prabhu a écrit : From: Roopa Prabhu I've sent you some comments about the v2, so please keep me in CC for the next versions. Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

+ Michal Kubecek Le 06/09/2015 22:46, roopa a écrit : On 9/4/15, 1:12 AM, Nicolas Dichtel wrote: Le 03/09/2015 01:44, Roopa Prabhu a écrit : [snip] Fixes: 4a287eba2de3 ("IPv6 routing, NLM_F_* flag support: REPLACE and EXCL flags support, warn about missing CREATE flag") ECMP was

Re: [PATCH net-next v2] ipv6: fix multipath route replace error recovery

Le 08/09/2015 02:01, roopa a écrit : On 9/7/15, 5:03 AM, Nicolas Dichtel wrote: [snip] yes, i had submitted the patch you mention above to fix a slightly different problem that existed then..which was introduced by "51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)&

Re: [PATCH net v3] ipv6: fix multipath route replace error recovery

Le 08/09/2015 02:42, roopa a écrit : On 9/6/15, 1:46 PM, Roopa Prabhu wrote: From: Roopa Prabhu Problem: The ecmp route replace support for ipv6 in the kernel, deletes the existing ecmp route too early, ie when it installs the first nexthop. If there is an error in

  1   2   3   4   5   6   >