[PATCH net-next v1 08/10] tipc: protect tipc_subscrb_get() with subscriber spin lock

2016-02-01 Thread Parthasarathy Bhuvaragan
tion to subscriber's subscription list. Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH net-next v1 09/10] tipc: donot create timers if subscription timeout = TIPC_WAIT_FOREVER

2016-02-01 Thread Parthasarathy Bhuvaragan
-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/net/tipc/s

[PATCH net-next v1 07/10] tipc: hold subscriber->lock for tipc_nametbl_subscribe()

2016-02-01 Thread Parthasarathy Bhuvaragan
of subscriber lock Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/t

[PATCH net-next v1 02/10] tipc: remove filter and timeout elements from struct tipc_subscription

2016-02-01 Thread Parthasarathy Bhuvaragan
tipc_subscription and replace them with elements from struct tipc_subscr. Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 15 ---

[PATCH net-next v1 03/10] tipc: remove struct tipc_name_seq from struct tipc_subscription

2016-02-01 Thread Parthasarathy Bhuvaragan
y: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/name_table.c | 14 ++ net/tipc/subscr.c | 33 +++-- net/tipc/subscr.h | 6 -- 3 files changed, 37

[PATCH net-next v1 00/10] tipc: cleanups, fixes & improvements for topology server

2016-02-01 Thread Parthasarathy Bhuvaragan
that pop up under different situations. Improvements in #9-#10: Updates to decrease timer usage and improve readability. Parthasarathy Bhuvaragan (10): tipc: remove incorrect check for subscription timeout value tipc: remove filter and timeout elements from struct tipc_subscription tipc: remove

[PATCH net-next v1 04/10] tipc: introduce tipc_subscrb_subscribe() routine

2016-02-01 Thread Parthasarathy Bhuvaragan
. In future commits, the purpose of tipc_subscrb_rcv_cb() will be to either subscribe or cancel a subscription. There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarath

[PATCH net-next v1 05/10] tipc: fix connection abort during subscription cancellation

2016-02-01 Thread Parthasarathy Bhuvaragan
ewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/net/tipc/subscr.c b/net/tipc/sub

[PATCH net-next v1 06/10] tipc: fix connection abort when receiving invalid cancel request

2016-02-01 Thread Parthasarathy Bhuvaragan
sson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c index 531227208ae2..24d2c8128bac 100644 --- a/net/tipc/subscr.

[PATCH net-next v1 01/10] tipc: remove incorrect check for subscription timeout value

2016-02-01 Thread Parthasarathy Bhuvaragan
value of TIPC_WAIT_FOREVER, msecs_to_jiffies(TIPC_WAIT_FOREVER) returns MAX_JIFFY_OFFSET (0xfffe). This is not equal to TIPC_WAIT_FOREVER (0x). In this commit, we remove this check. Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off

[PATCH net-next v1 10/10] tipc: use alloc_ordered_workqueue() instead of WQ_UNBOUND w/ max_active = 1

2016-02-01 Thread Parthasarathy Bhuvaragan
nges. In this commit we replace alloc_workqueue() with more readable alloc_ordered_workqueue(). Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/server.c |

[PATCH net-next v2 00/10] tipc: cleanups, fixes & improvements for topology server

2016-02-02 Thread Parthasarathy Bhuvaragan
that pop up under different situations. Improvements in #9-#10: Updates to decrease timer usage and improve readability. v2: Updated commit message in patch 6 based on feedback from Sergei Shtylyov sergei.shtyl...@cogentembedded.com Parthasarathy Bhuvaragan (10): tipc: remove incorrect check

[PATCH net-next v2 05/10] tipc: fix connection abort during subscription cancellation

2016-02-02 Thread Parthasarathy Bhuvaragan
ewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/net/tipc/subscr.c b/net/tipc/sub

[PATCH net-next v2 01/10] tipc: remove incorrect check for subscription timeout value

2016-02-02 Thread Parthasarathy Bhuvaragan
value of TIPC_WAIT_FOREVER, msecs_to_jiffies(TIPC_WAIT_FOREVER) returns MAX_JIFFY_OFFSET (0xfffe). This is not equal to TIPC_WAIT_FOREVER (0x). In this commit, we remove this check. Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off

[PATCH net-next v2 07/10] tipc: hold subscriber->lock for tipc_nametbl_subscribe()

2016-02-02 Thread Parthasarathy Bhuvaragan
of subscriber lock Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/t

[PATCH net-next v2 03/10] tipc: remove struct tipc_name_seq from struct tipc_subscription

2016-02-02 Thread Parthasarathy Bhuvaragan
y: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/name_table.c | 14 ++ net/tipc/subscr.c | 33 +++-- net/tipc/subscr.h | 6 -- 3 files changed, 37

[PATCH net-next v2 08/10] tipc: protect tipc_subscrb_get() with subscriber spin lock

2016-02-02 Thread Parthasarathy Bhuvaragan
tion to subscriber's subscription list. Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH net-next v2 06/10] tipc: fix connection abort when receiving invalid cancel request

2016-02-02 Thread Parthasarathy Bhuvaragan
...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tipc/subscr.c b/net/tipc/subscr.c index 531227208ae2..24d2c8128bac 100644 --- a/net/tipc/subscr.

[PATCH net-next v2 10/10] tipc: use alloc_ordered_workqueue() instead of WQ_UNBOUND w/ max_active = 1

2016-02-02 Thread Parthasarathy Bhuvaragan
nges. In this commit we replace alloc_workqueue() with more readable alloc_ordered_workqueue(). Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/server.c |

[PATCH net-next v2 09/10] tipc: donot create timers if subscription timeout = TIPC_WAIT_FOREVER

2016-02-02 Thread Parthasarathy Bhuvaragan
-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/net/tipc/s

[PATCH net-next v2 02/10] tipc: remove filter and timeout elements from struct tipc_subscription

2016-02-02 Thread Parthasarathy Bhuvaragan
tipc_subscription and replace them with elements from struct tipc_subscr. Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 15 ---

[PATCH net-next v2 04/10] tipc: introduce tipc_subscrb_subscribe() routine

2016-02-02 Thread Parthasarathy Bhuvaragan
. In future commits, the purpose of tipc_subscrb_rcv_cb() will be to either subscribe or cancel a subscription. There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarath

[PATCH net] tipc: fix connection abort during subscription cancel

2016-01-26 Thread Parthasarathy Bhuvaragan
commit, we terminate the connection based on the return value of tipc_subscrp_create(). Fixes: commit 7fe8097cef5f ("tipc: fix nullpointer bug when subscribing to events") Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 10 +++

[PATCH net v2] tipc: fix connection abort during subscription cancel

2016-01-27 Thread Parthasarathy Bhuvaragan
commit, we terminate the connection based on the return value of tipc_subscrp_create(). Fixes: commit 7fe8097cef5f ("tipc: fix nullpointer bug when subscribing to events") Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bh

[PATCH net v1 1/1] tipc: Revert "tipc: use existing sk_write_queue for outgoing packet chain"

2016-03-01 Thread Parthasarathy Bhuvaragan
l_fastpath+0x16/0x1b In this commit, we maintain the skb list always in the stack. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> --- net/tipc/socket.c | 33 +++

[PATCH net-next v1 1/1] tipc: fix a race condition leading to subscriber refcnt bug

2016-04-12 Thread Parthasarathy Bhuvaragan
during connection release procedure rather than connection shutdown procedure. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> Acked-by: Ying Xue <ying@windriver.com> --- net/tipc/server.c | 19 +-- net/tipc/server.h | 4 ++-- net/t

[PATCH net-next v1 1/1] tipc: Revert "tipc: use existing sk_write_queue for outgoing packet chain"

2016-03-04 Thread Parthasarathy Bhuvaragan
0x1b In this commit, we maintain the skb list always in the stack. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> --- net/tipc/socket.c | 33 +++

[PATCH net v1 1/1] tipc: fix nullptr crash during subscription cancel

2016-03-03 Thread Parthasarathy Bhuvaragan
is passed to tipc_nametbl_subscribe() resulting in exception. In this commit, we call tipc_nametbl_subscribe() only for a valid subscription. Fixes: 4d5cfcba2f6e ('tipc: fix connection abort during subscription cancel') Reported-by: Anders Widell <anders.wid...@ericsson.com> Signed-off-by: Parthas

[PATCH net-next v1 1/1] tipc: fix stale links after re-enabling bearer

2016-04-21 Thread Parthasarathy Bhuvaragan
correctly. Fixes: 42b18f605fea ("tipc: refactor function tipc_link_timeout()") Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/link.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

[PATCH net-next v2 2/5] tipc: make cluster size threshold for monitoring configurable

2016-07-26 Thread Parthasarathy Bhuvaragan
In this commit, we introduce support to configure the minimum threshold to activate the new link monitoring algorithm. Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- include/uapi/linux/tipc_ne

[PATCH net-next v2 4/5] tipc: add a function to get the bearer name

2016-07-26 Thread Parthasarathy Bhuvaragan
Introduce a new function to get the bearer name from its id. This is used in subsequent commit. Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/bearer.c | 21 + net/tipc/b

[PATCH net-next v2 1/5] tipc: introduce constants for tipc address validation

2016-07-26 Thread Parthasarathy Bhuvaragan
In this commit, we introduce defines for tipc address size, offset and mask specification for Zone.Cluster.Node. There is no functional change in this commit. Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@eri

[PATCH net-next v2 3/5] tipc: get monitor threshold for the cluster

2016-07-26 Thread Parthasarathy Bhuvaragan
In this commit, we add support to fetch the configured cluster monitoring threshold. Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- include/uapi/linux/tipc_netlink.h | 1 + net/ti

[PATCH net-next v2 5/5] tipc: dump monitor attributes

2016-07-26 Thread Parthasarathy Bhuvaragan
<jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- include/uapi/linux/tipc_netlink.h | 25 +++ net/tipc/monitor.c| 133 ++ net/tipc/monitor.h| 6

[PATCH net-next v2 0/5] tipc: netlink updates for neighbour monitor

2016-07-26 Thread Parthasarathy Bhuvaragan
This series contains the updates to configure and read the attributes for neighbour monitor. v2: rebase on top of net-next Parthasarathy Bhuvaragan (5): tipc: introduce constants for tipc address validation tipc: make cluster size threshold for monitoring configurable tipc: get monitor

[PATCH net-next v1 4/5] tipc: add a function to get the bearer name

2016-07-22 Thread Parthasarathy Bhuvaragan
Introduce a new function to get the bearer name from its id. This is used in subsequent commit. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> --- net/tipc/bearer.c | 21 + net/tipc/b

[PATCH net-next v1 5/5] tipc: dump monitor attributes

2016-07-22 Thread Parthasarathy Bhuvaragan
-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> --- include/uapi/linux/tipc_netlink.h | 25 +++ net/tipc/monitor.c| 133 ++ net/tipc/monitor.h| 6

[PATCH net-next v1 3/5] tipc: get monitor threshold for the cluster

2016-07-22 Thread Parthasarathy Bhuvaragan
In this commit, we add support to fetch the configured cluster monitoring threshold. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> --- include/uapi/linux/tipc_netlink.h | 1 + net/ti

[PATCH net-next v1 2/5] tipc: make cluster size threshold for monitoring configurable

2016-07-22 Thread Parthasarathy Bhuvaragan
In this commit, we introduce support to configure the minimum threshold to activate the new link monitoring algorithm. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> --- include/uapi/linux/tipc_ne

[PATCH net-next v1 0/5] tipc: netlink updates for neighbour monitor

2016-07-22 Thread Parthasarathy Bhuvaragan
This series contains the updates to configure and read the attributes for neighbour monitor. Parthasarathy Bhuvaragan (5): tipc: introduce constants for tipc address validation tipc: make cluster size threshold for monitoring configurable tipc: get monitor threshold for the cluster tipc

[PATCH net-next v1 1/5] tipc: introduce constants for tipc address validation

2016-07-22 Thread Parthasarathy Bhuvaragan
In this commit, we introduce defines for tipc address size, offset and mask specification for Zone.Cluster.Node. There is no functional change in this commit. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> Reviewed-by: Jon Maloy <jon.ma...@eri

[PATCH net v1 1/1] tipc: fix variable dereference before NULL check

2016-08-10 Thread Parthasarathy Bhuvaragan
commit, we check for a valid monitor before proceeding with any other operation. Fixes: cf6f7e1d5109 ("tipc: dump monitor attributes") Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- ne

[PATCH net v1 5/6] tipc: ignore requests when the connection state is not CONNECTED

2017-01-24 Thread Parthasarathy Bhuvaragan
ing@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Tested-by: John Thompson <thompa@gmail.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/server.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-

[PATCH net v1 0/6] topology server fixes for nametable soft lockup

2017-01-24 Thread Parthasarathy Bhuvaragan
described by patch#4. Parthasarathy Bhuvaragan (6): tipc: fix nametbl_lock soft lockup at node/link events tipc: add subscription refcount to avoid invalid delete tipc: fix connection refcount error tipc: fix nametbl_lock soft lockup at module exit tipc: ignore requests when the connec

[PATCH net v1 2/6] tipc: add subscription refcount to avoid invalid delete

2017-01-24 Thread Parthasarathy Bhuvaragan
Thompson <thompa@gmail.com> Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 124 ++---

[PATCH net v1 1/6] tipc: fix nametbl_lock soft lockup at node/link events

2017-01-24 Thread Parthasarathy Bhuvaragan
scribe() to use the fast variants. Reported-and-Tested-by: John Thompson <thompa@gmail.com> Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> ---

[PATCH net v1 4/6] tipc: fix nametbl_lock soft lockup at module exit

2017-01-24 Thread Parthasarathy Bhuvaragan
3f796235a527. Hence we can now revert the commit. Fixes: 333f796235a52727 ("tipc: fix a race condition leading to subscriber refcnt bug") Reported-and-Tested-by: John Thompson <thompa@gmail.com> Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <j

[PATCH net v1 3/6] tipc: fix connection refcount error

2017-01-24 Thread Parthasarathy Bhuvaragan
<ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/server.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/net/tipc/server.c b

[PATCH net v1 6/6] tipc: fix cleanup at module unload

2017-01-24 Thread Parthasarathy Bhuvaragan
ing@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Tested-by: John Thompson <thompa@gmail.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/server.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -

[PATCH net v1] tipc: fix random link resets while adding a second bearer

2016-09-01 Thread Parthasarathy Bhuvaragan
ever reached leading to link timeout. In this commit, we adjust the size of name distributor message so that they can be tunnelled. Reviewed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/name_distr.c

[PATCH iproute2 net-next v1 0/7] tipc: updates for neighbour monitor

2016-09-12 Thread Parthasarathy Bhuvaragan
We add configuration support for the new link monitoring attributes. Parthasarathy Bhuvaragan (7): tipc: remove dead code tipc: add link monitor set threshold tipc: add link monitor get threshold tipc: add link monitor summary tipc: refractor bearer to facilitate link monitor tipc

[PATCH iproute2 net-next v1 4/7] tipc: add link monitor summary

2016-09-12 Thread Parthasarathy Bhuvaragan
algorithm overlapping-ring $ tipc link monitor summary -h Usage: tipc monitor summary Acked-by: Jon Maloy <jon.ma...@ericsson.com> Tested-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> ---

[PATCH iproute2 net-next v1 2/7] tipc: add link monitor set threshold

2016-09-12 Thread Parthasarathy Bhuvaragan
<jon.ma...@ericsson.com> Tested-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- tipc/link.c | 69 - 1 file changed, 68 insertions(+), 1 delet

[PATCH iproute2 net-next v1 5/7] tipc: refractor bearer to facilitate link monitor

2016-09-12 Thread Parthasarathy Bhuvaragan
In this commit, we: 1. Export print_bearer_media() 2. Move the bearer name handling from nl_add_bearer_name() into a new function cmd_get_unique_bearer_name(). These exported functions will be used by link monitor used in subsequent commits. Signed-off-by: Parthasarathy Bhuvaragan

[PATCH iproute2 net-next v1 3/7] tipc: add link monitor get threshold

2016-09-12 Thread Parthasarathy Bhuvaragan
Tested-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- tipc/link.c | 56 +++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/tipc/link.c b

[PATCH iproute2 net-next v1 7/7] tipc: update man page for link monitor

2016-09-12 Thread Parthasarathy Bhuvaragan
Add description for the new link monitor commands. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- man/man8/tipc-link.8 | 104 +++ 1 file changed, 104 insertions(+) diff --git a/man/man8/tipc-link.8 b/ma

[PATCH iproute2 net-next v1 1/7] tipc: remove dead code

2016-09-12 Thread Parthasarathy Bhuvaragan
remove dead code and a newline. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- tipc/link.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tipc/link.c b/tipc/link.c index 061b1c534389..8bdc98224d39 100644 --- a/tipc/link.c +++ b/tipc/link.c @@

[PATCH iproute2 net-next v1 6/7] tipc: add link monitor list

2016-09-12 Thread Parthasarathy Bhuvaragan
Acked-by: Jon Maloy <jon.ma...@ericsson.com> Tested-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- tipc/link.c | 237 1 file changed, 237 inserti

[PATCH net-next v1 03/16] tipc: set kern=0 in sk_alloc() during tipc_accept()

2016-10-27 Thread Parthasarathy Bhuvaragan
com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index cd01deb1da9c..8

[PATCH net-next v1 13/16] tipc: create TIPC_DISCONNECTING as a new sk_state

2016-10-27 Thread Parthasarathy Bhuvaragan
an error message on the connection. There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- include/uapi/linux/

[PATCH net-next v1 16/16] tipc: remove SS_CONNECTED sock state

2016-10-27 Thread Parthasarathy Bhuvaragan
.@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 100 +- 1 file changed, 47 insertions(+), 53 deletions(-) diff

[PATCH net-next v1 07/16] tipc: remove tsk->connected from tipc_sock

2016-10-27 Thread Parthasarathy Bhuvaragan
c_sock and derive socket connection status from the following condition: sock->state == SS_CONNECTED => tsk->connected There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-b

[PATCH net-next v1 05/16] tipc: rename tsk->remote to tsk->peer for consistent naming

2016-10-27 Thread Parthasarathy Bhuvaragan
t. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/n

[PATCH net-next v1 01/16] tipc: return early for non-blocking sockets at link congestion

2016-10-27 Thread Parthasarathy Bhuvaragan
, we exhaust the memory. In this commit, we return immediately at stream/mcast send() for non-blocking sockets. Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 6 ++ 1 fil

[PATCH net-next v1 15/16] tipc: create TIPC_CONNECTING as a new sk_state

2016-10-27 Thread Parthasarathy Bhuvaragan
In this commit, we create a new tipc socket state TIPC_CONNECTING by primarily replacing the SS_CONNECTING with TIPC_CONNECTING. There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: P

[PATCH net-next v1 08/16] tipc: remove probing_intv from tipc_sock

2016-10-27 Thread Parthasarathy Bhuvaragan
. There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 19 +-- 1 file changed, 9 insertion

[PATCH net-next v1 12/16] tipc: create TIPC_OPEN as a new sk_state

2016-10-27 Thread Parthasarathy Bhuvaragan
In this commit, we create a new tipc socket state TIPC_OPEN in sk_state. We primarily replace the SS_UNCONNECTED sock->state with TIPC_OPEN. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <par

[PATCH net-next v1 02/16] tipc: wakeup sleeping users at disconnect

2016-10-27 Thread Parthasarathy Bhuvaragan
the connection is being terminated, we fail to wakeup that socket. In this commit, we wakeup sleeping sockets at connection termination. Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c |

[PATCH net-next v1 04/16] tipc: rename struct tipc_skb_cb member handle to bytes_read

2016-10-27 Thread Parthasarathy Bhuvaragan
In this commit, we rename handle to bytes_read indicating the purpose of the member. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/msg.h

[PATCH net-next v1 00/16] tipc: socket layer improvements

2016-10-27 Thread Parthasarathy Bhuvaragan
---+++ | TIPC_CLOSING |<---| TIPC_DISCONNECTING | +--+++ NOTE: This is just a base refractoring required for socket diagnostics. TIPC socket diagnostics support will be introduced in a later series. Parthasarathy Bhuvaragan (16): tip

[PATCH net-next v1 09/16] tipc: remove socket state SS_READY

2016-10-27 Thread Parthasarathy Bhuvaragan
Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 49 +++-- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c

[PATCH net-next v1 14/16] tipc: create TIPC_CLOSING as a new sk_state

2016-10-27 Thread Parthasarathy Bhuvaragan
TIPC_CLOSING | +---+ +--+ +--+ There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- include/uapi/linux/tipc.h | 1 + net/tipc/socket.c

[PATCH net-next v1 11/16] tipc: create TIPC_PROBING/TIPC_ESTABLISHED as new sk_states

2016-10-27 Thread Parthasarathy Bhuvaragan
ate is set to TIPC_ESTABLISHED instead of TIPC_CONN_OK. There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- incl

[PATCH net-next v1 06/16] tipc: remove tsk->connected for connectionless sockets

2016-10-27 Thread Parthasarathy Bhuvaragan
ed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 8bc9c32c41b5..ebe000888667 1006

[PATCH net-next v1 10/16] tipc: create TIPC_LISTEN as a new sk_state

2016-10-27 Thread Parthasarathy Bhuvaragan
by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- include/uapi/linux/tipc.h | 7 ++ net/tipc/socket.c | 59 --

[PATCH net-next v2 06/16] tipc: remove tsk->connected for connectionless sockets

2016-11-01 Thread Parthasarathy Bhuvaragan
ed-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 0546556d3517..524abe47560d 1006

[PATCH net-next v2 08/16] tipc: remove probing_intv from tipc_sock

2016-11-01 Thread Parthasarathy Bhuvaragan
. There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 19 +-- 1 file changed, 9 insertion

[PATCH net-next v2 07/16] tipc: remove tsk->connected from tipc_sock

2016-11-01 Thread Parthasarathy Bhuvaragan
c_sock and derive socket connection status from the following condition: sock->state == SS_CONNECTED => tsk->connected There is no functional change in this commit. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-b

[PATCH net-next v2 04/16] tipc: rename struct tipc_skb_cb member handle to bytes_read

2016-11-01 Thread Parthasarathy Bhuvaragan
In this commit, we rename handle to bytes_read indicating the purpose of the member. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- v2: Remove unnecessary cast and parenthesis as suggested by David S. Miller. --- net/tipc/msg.h| 2 +- net/tipc/so

[PATCH net-next v2 02/16] tipc: wakeup sleeping users at disconnect

2016-11-01 Thread Parthasarathy Bhuvaragan
the connection is being terminated, we fail to wakeup that socket. In this commit, we wakeup sleeping sockets at connection termination. Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c |

[PATCH net-next v2 00/16] tipc: socket layer improvements

2016-11-01 Thread Parthasarathy Bhuvaragan
lace the TIPC_CLOSING state in v1 with sk_shutdown flag in #14. - introduce __tipc_shutdown() to avoid code duplication in #14. Parthasarathy Bhuvaragan (16): tipc: return early for non-blocking sockets at link congestion tipc: wakeup sleeping users at disconnect tipc: set kern=0 in sk_al

[PATCH net-next v2 05/16] tipc: rename tsk->remote to tsk->peer for consistent naming

2016-11-01 Thread Parthasarathy Bhuvaragan
t. Acked-by: Ying Xue <ying@windriver.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/n

[PATCH net-next v2 03/16] tipc: set kern=0 in sk_alloc() during tipc_accept()

2016-11-01 Thread Parthasarathy Bhuvaragan
com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index cd01deb1da9c..8

[PATCH net-next v2 01/16] tipc: return early for non-blocking sockets at link congestion

2016-11-01 Thread Parthasarathy Bhuvaragan
, we exhaust the memory. In this commit, we return immediately at stream/mcast send() for non-blocking sockets. Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 6 ++ 1 fil

[PATCH net-next v2 09/16] tipc: remove socket state SS_READY

2016-11-01 Thread Parthasarathy Bhuvaragan
Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 49 +++-- 1 file changed, 31 insertions(+), 18 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c

[PATCH net-next v2 15/16] tipc: create TIPC_CONNECTING as a new sk_state

2016-11-01 Thread Parthasarathy Bhuvaragan
In this commit, we create a new tipc socket state TIPC_CONNECTING by primarily replacing the SS_CONNECTING with TIPC_CONNECTING. There is no functional change in this commit. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- v2: set TIPC_CONN

[PATCH net-next v2 14/16] tipc: remove SS_DISCONNECTING state

2016-11-01 Thread Parthasarathy Bhuvaragan
In this commit, we replace the references to SS_DISCONNECTING with the combination of sk_state TIPC_DISCONNECTING and flags set in sk_shutdown. We introduce a new function _tipc_shutdown(), which provides the common code required by tipc_release() and tipc_shutdown(). Signed-off-by: Parthasarathy

[PATCH net-next v2 10/16] tipc: create TIPC_LISTEN as a new sk_state

2016-11-01 Thread Parthasarathy Bhuvaragan
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- v2: set TIPC_LISTEN value to TCP_LISTEN to permit the usage of generic sk_* helpers as suggested by Eric Dumazet. --- net/tipc/socket.c | 62 ++- 1 file chan

[PATCH net-next v2 11/16] tipc: create TIPC_ESTABLISHED as a new sk_state

2016-11-01 Thread Parthasarathy Bhuvaragan
ing state TIPC_CONN_OK, we create a new state TIPC_ESTABLISHED. There is no functional change in this commit. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- v2: remove TIPC_PROBING state and replace it with probe_unacked flag. --- net/tipc/sock

[PATCH net-next v2 16/16] tipc: remove SS_CONNECTED sock state

2016-11-01 Thread Parthasarathy Bhuvaragan
IPC_ESTABLISHED | | +--+ | ^ | | | | | | v | ++ | | TIPC_DISCONNECTING |<--+ ++ Signed-off

[PATCH net-next v2 13/16] tipc: create TIPC_DISCONNECTING as a new sk_state

2016-11-01 Thread Parthasarathy Bhuvaragan
an error message on the connection. There is no functional change in this commit. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- v2: set TIPC_DISCONNECTING to TCP_CLOSE_WAIT. --- net/tipc/socket.c | 39 --- 1 file c

[PATCH net-next v2 12/16] tipc: create TIPC_OPEN as a new sk_state

2016-11-01 Thread Parthasarathy Bhuvaragan
In this commit, we create a new tipc socket state TIPC_OPEN in sk_state. We primarily replace the SS_UNCONNECTED sock->state with TIPC_OPEN. Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- v2: TIPC_OPEN is set to the default sk_state TCP_CLOSE. ---

Re: [PATCH net-next v1 13/16] tipc: create TIPC_DISCONNECTING as a new sk_state

2016-10-28 Thread Parthasarathy Bhuvaragan
On 10/27/2016 05:03 PM, Eric Dumazet wrote: On Thu, 2016-10-27 at 16:22 +0200, Parthasarathy Bhuvaragan wrote: In this commit, we create a new tipc socket state TIPC_DISCONNECTING in sk_state. TIPC_DISCONNECTING is replacing the socket connection status update using SS_DISCONNECTING

[PATCH net v1 1/1] tipc: allocate user memory with GFP_KERNEL flag

2017-01-13 Thread Parthasarathy Bhuvaragan
with GFP_KERNEL for all user allocation. Reported-by: Rune Torgersen <ru...@innovsys.com> Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/discover.c | 4 ++-- net/tipc/link.c | 2

[PATCH net-next v1 1/2] tipc: advance the time of deleting subscription from subscriber->subscrp_list

2017-03-28 Thread Parthasarathy Bhuvaragan
k. Acked-by: Jon Maloy <jon.ma...@ericsson.com> Signed-off-by: Ying Xue <ying@windriver.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/subscr.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/n

[PATCH net-next v1 2/2] tipc: adjust the policy of holding subscription kref

2017-03-28 Thread Parthasarathy Bhuvaragan
From: Ying Xue When a new subscription object is inserted into name_seq->subscriptions list, it's under name_seq->lock protection; when a subscription is deleted from the list, it's also under the same lock protection; similarly, when accessing a subscription by going

[PATCH net-next v1 0/2] tipc: subscription refcount simplifications

2017-03-28 Thread Parthasarathy Bhuvaragan
The first patch makes the subscription refcount cleanup lockless and the second updates the subscription refcount policy. Ying Xue (2): tipc: advance the time of deleting subscription from subscriber->subscrp_list tipc: adjust the policy of holding subscription kref

[PATCH net-next v1 2/2] tipc: allow rdm/dgram socketpairs

2017-03-29 Thread Parthasarathy Bhuvaragan
From: Erik Hugne <erik.hu...@gmail.com> for socketpairs using connectionless transport, we cache the respective node local TIPC portid to use in subsequent calls to send() in the socket's private data. Signed-off-by: Erik Hugne <erik.hu...@gmail.com> Signed-off-by: Parthasarath

[PATCH net-next v1 1/2] tipc: add support for stream/seqpacket socketpairs

2017-03-29 Thread Parthasarathy Bhuvaragan
From: Erik Hugne <erik.hu...@gmail.com> sockets A and B are connected back-to-back, similar to what AF_UNIX does. Signed-off-by: Erik Hugne <erik.hu...@gmail.com> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvara...@ericsson.com> --- net/tipc/socket.c | 14

[PATCH net-next v1 0/2] tipc: add socketpair support

2017-03-29 Thread Parthasarathy Bhuvaragan
We add socketpair support for connection oriented sockets in the first patch and for connection less in the second. Erik Hugne (2): tipc: add support for stream/seqpacket socketpairs tipc: allow rdm/dgram socketpairs net/tipc/socket.c | 28 +--- 1 file changed, 25

  1   2   >