[PATCH] 7990 : Various fixes and cleanups

2007-07-06 Thread Philippe De Muyter
ETH_ZLEN Signed-off-by: Philippe De Muyter [EMAIL PROTECTED] diff -r 6c0a10cc415a drivers/net/7990.c --- a/drivers/net/7990.cThu Jul 5 16:10:16 2007 -0700 +++ b/drivers/net/7990.cFri Jul 6 11:27:20 2007 +0200 @@ -179,12 +179,14 @@ static void lance_init_ring (struct net_ lp

Re: [PATCH] net : make netlink_seq_ops const

2007-07-06 Thread Philippe De Muyter
On Fri, Jul 06, 2007 at 02:52:11PM +0200, Patrick McHardy wrote: [please send networking patches to netdev] Philippe De Muyter wrote: Hi all, Make netlink_seq_ops const Might make more sense to do a big patch for all occurences of this in net/: # grep ^static struct

[PATCH] make all initialized struct seq_operations const

2007-07-06 Thread Philippe De Muyter
Hi all Make all initialized struct seq_operations in net/ const Signed-off-by: Philippe De Muyter [EMAIL PROTECTED] diff -r 6c0a10cc415a net/802/tr.c --- a/net/802/tr.c Thu Jul 5 16:10:16 2007 -0700 +++ b/net/802/tr.c Fri Jul 6 15:17:53 2007 +0200 @@ -567,7 +567,7 @@ static int

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-09 Thread Philippe De Muyter
Paul Mackerras wrote : Jeff Garzik writes: From: Philippe De Muyter [EMAIL PROTECTED] Avoid ppp-generated kernel crashes on machines where unaligned accesses are forbidden (ie: 68000-based CPUs) This patch seems a bit strange and/or incomplete. Are we trying to get 2-byte

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-09 Thread Philippe De Muyter
Paul Mackerras wrote : Philippe De Muyter writes: This patch seems a bit strange and/or incomplete. Are we trying to get 2-byte alignment or 4-byte alignment of the payload? It seems Actually, we try to get a 4n+2 alignment for skb-data, to get the ip-addresses field 4bytes

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-10 Thread Philippe De Muyter
Paul Mackerras wrote : Philippe De Muyter writes: Actually, that's probably the case I had, but my fix gets the ip adresses 4byte aligned in my case : I had verified the address of the saddr field, and I needed to shift the buffer by 3, not 1, to get it 4byte aligned. Please outline

Re: [Fwd: [patch 11/15] ppp: handle misaligned accesses]

2005-08-11 Thread Philippe De Muyter
-by: Philippe De Muyter [EMAIL PROTECTED] --- drivers/net/ppp_async.c 2004/05/07 08:38:32 1.1.1.1 +++ drivers/net/ppp_async.c 2005/08/11 11:21:33 @@ -30,6 +30,7 @@ #include linux/spinlock.h #include linux/init.h #include asm/uaccess.h +#include asm/string.h #define PPP_VERSION2.4.2

Re: [PATCH 1/4] IP100A: Fix TX Pause bug (reset_tx, intr_handler)

2006-09-15 Thread Philippe De Muyter
On Thu, Sep 14, 2006 at 12:58:30AM +, Jesse Huang wrote: [...] @@ -262,8 +262,6 @@ enum alta_offsets { ASICCtrl = 0x30, EEData = 0x34, EECtrl = 0x36, - TxStartThresh = 0x3c, - RxEarlyThresh = 0x3e, Why ? FlashAddr = 0x40, FlashData = 0x44,

Re: [PATCH 1/4] IP100A: Fix TX Pause bug (reset_tx, intr_handler)

2006-09-18 Thread Philippe De Muyter
. Is was even commented as not being tested. On DFE-580TX boards, the current way has been verified by me and others to work, so please do not break it. Best regards Philippe Thanks you very mutch. Best Regards, Jesse Huang. - Original Message - From: Philippe De Muyter [EMAIL

Re: [PATCH 1/4] IP100A: Fix TX Pause bug (reset_tx, intr_handler)

2006-09-18 Thread Philippe De Muyter
this as a new patch? I do not know about the other patches, but for this one of course you should Philippe Thanks very much! Best Regards, Jesse Huang. - Original Message - From: Philippe De Muyter [EMAIL PROTECTED] To: Jesse Huang [EMAIL PROTECTED] Cc: netdev@vger.kernel.org

Q: link up/down, netif_carrier_on/off tx_timeout

2006-01-26 Thread Philippe De Muyter
Hi all, I work with the fec driver (used with embedded linuxes), and I am not very satisfied of the behaviour regarding link down / link up. So here are my questions : 1. When/where should netif_carrierr_on/off or another similar routine be called ? 2. If the above are called properly, will

Re: [patch 3/8] sundance: remove TxStartThresh and RxEarlyThresh

2006-10-22 Thread Philippe De Muyter
On Fri, Oct 20, 2006 at 02:42:05PM -0700, [EMAIL PROTECTED] wrote: From: Jesse Huang [EMAIL PROTECTED] For patent issue need to remove TxStartThresh and RxEarlyThresh. This patent is cut-through patent. If use this function, Tx will start to transmit after few data be move in to Tx FIFO. We

[PATCH] sundance: small cleanup

2006-08-03 Thread Philippe De Muyter
This patch uses the sundance_reset function everywhere a reset is done, and adds a link to the archives of the original mailing list. Signed-off-by: Philippe De Muyter [EMAIL PROTECTED] diff -r 9062402c439c drivers/net/sundance.c --- a/drivers/net/sundance.cThu Aug 3 12:35:26 2006 +0700

Re: [PATCH] 7990 : Various fixes and cleanups

2007-07-13 Thread Philippe De Muyter
On Tue, Jul 10, 2007 at 12:38:45PM -0400, Jeff Garzik wrote: Philippe De Muyter wrote: This patch - avoids 7990 blocking when no tx buffer is available, [...] diff -r 6c0a10cc415a drivers/net/7990.c --- a/drivers/net/7990.c Thu Jul 5 16:10:16 2007 -0700 +++ b/drivers/net/7990.c Fri

Re: [PATCH net-next 1/1] net: fec: clear receive interrupts before processing a packet

2015-09-03 Thread Philippe De Muyter
Hi Andy, can you resubmit it, adding also my Reported-by: Philippe De Muyter <p...@macqel.be> and explaining that it also prevents a complete rx blockage failure ? Philippe On Wed, Sep 02, 2015 at 11:40:15AM +0200, Philippe De Muyter wrote: > On Wed, Sep 02, 2015 at 05:24:14PM +080

Re: [PATCH net-next 1/1] net: fec: clear receive interrupts before processing a packet

2015-09-02 Thread Philippe De Muyter
On Wed, Sep 02, 2015 at 05:24:14PM +0800, Fugang Duan wrote: > From: Russell King > > The patch just to re-submit the patch "db3421c114cfa6326" because the > patch "4d494cdc92b3b9a0" remove the change. I think you should mention also the titles of the commits. And