ocess/license-rules.rst
[2] https://github.com/spdx/license-list-data/tree/v2.6
>> :-( I had it originally as GPL-2.0 and then it was pointed out that it
>> was being deprecated, so rather than creating future thrash over the
>> change, figured I would be ahead of the game.
>>
>> >
>> > > diff --git a/drivers/net/ethernet/intel/e100.c
>> > > b/drivers/net/ethernet/intel/e100.c
>> >
>> > []
>> > > @@ -1,3 +1,4 @@
>> > > +// SPDX-License-Identifier: GPL-2.0-only
>> >
>> > etc...
--
Cordially
Philippe Ombredanne
h
> index e42f96900318..f85906533cdd 100644
> --- a/tools/lib/bpf/libbpf.h
> +++ b/tools/lib/bpf/libbpf.h
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: LGPL-2.1 */
> +
> /*
> * Common eBPF ELF object loading operations.
> *
> --
> 2.15.1
>
--
Cordially
Philippe Ombredanne
// SPDX-License-Identifier: LGPL-2.1
> +// NETLINK Netlink attributes
> +// Copyright (c) 2003-2013 Thomas Graf
--
Cordially
Philippe Ombredanne
ject loading operations.
> *
> diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
> index e42f96900318..f85906533cdd 100644
> --- a/tools/lib/bpf/libbpf.h
> +++ b/tools/lib/bpf/libbpf.h
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: LGPL-2.1 */
> +
> /*
istoph Hellwig.
> + * License: LGPLv2.1 or later.
Would you consider using an SPDX tag instead as documented in Thomas
doc patches [1]? This rather close to what you use today and would
come out as this, on the first line:
SPDX-License-Identifier: LGPL-2.1+
Thank you!
[1] https://lkml.org/lkml/201
rk properly, as there is no need to unwind the
> unneeded dereference.
>
> Cc: "David S. Miller"
> Cc: Andreas Kemnade
> Cc: Johan Hovold
> Reported-by: Philippe Ombredanne
> Signed-off-by: Greg Kroah-Hartman
Reviewed-by: Philippe Ombredanne
--
Cordially
Philippe Ombredanne
t; + * License as published by the Free Software Foundation.
> + */
I think an SPDX id would be better here e.g. just this may be?
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2017 Facebook
It should be on the first line as requested by Linus and documented by
Thomas (tglx) and Greg (greg-kh). And it should use // comments.
See threads on these topics.
--
Cordially
Philippe Ombredanne
file "COPYING" in the main directory of this archive
>> + * for more details.
>> + *
>> + * Copyright (C) 2017 Cavium, Inc.
>> + */
Since you nicely included an SPDX id, you would not need the
boilerplate anymore. e.g. these can go alright?
>> + * This file is subject to the terms and conditions of the GNU General
>> Public
>> + * License. See the file "COPYING" in the main directory of this archive
>> + * for more details.
--
Cordially
Philippe Ombredanne
David, Greg,
On Fri, Dec 1, 2017 at 6:42 PM, David Daney wrote:
> On 11/30/2017 11:53 PM, Philippe Ombredanne wrote:
[...]
>>>> --- /dev/null
>>>> +++ b/arch/mips/cavium-octeon/resource-mgr.c
>>>> @@ -0,0 +1,371 @@
>>>> +// SPDX-License-Identif
David,
On Fri, Dec 1, 2017 at 9:01 PM, David Daney wrote:
> On 12/01/2017 11:49 AM, Philippe Ombredanne wrote:
>>
>> David, Greg,
>>
>> On Fri, Dec 1, 2017 at 6:42 PM, David Daney
>> wrote:
>>>
>>> On 11/30/2017 11:53 PM, Philippe Ombred
On Fri, Dec 1, 2017 at 9:56 PM, David Daney wrote:
> On 12/01/2017 12:41 PM, Philippe Ombredanne wrote:
>>
>> David,
>>
>> On Fri, Dec 1, 2017 at 9:01 PM, David Daney
>> wrote:
>>>
>>> On 12/01/2017 11:49 AM, Philippe Ombredanne wrote:
>>&
ith perf_kprobe (function addr) takes 80.010731 seconds
>
> Signed-off-by: Song Liu
> Reviewed-by: Josef Bacik
> Reviewed-by: Philippe Ombredanne
> ---
> samples/bpf/Makefile| 3 +
> samples/bpf/bpf_load.c | 5 +-
> samp
gt; Remove fixed type PERF_TYPE_KPROBE and PERF_TYPE_UPROBE, use dynamic
> type instead.
> Update userspace (samples/bpf, bcc) to look up type from sysfs.
> Change License info in test_many_kprobe_user.c as Philippe Ombredanne
> suggested.
>
> Changes PATCH v1 to PATCH v2:
>
yright 2005-2006 Openedhand Ltd.
> + * Author: Richard Purdie
> + *
> + */
This is cleaner and simpler, don't you think?
--
Cordially
Philippe Ombredanne
on't you love it with less boilerplate and a better code/comments ratio?
BTW the comment style may surprise you here: this is a suggestion, but
not just. Check the posts from Linus on this topic and Thomas's doc
patches for the rationale.
Thank you for your kind consideration!
--
Cordially
Philippe Ombredanne
David,
On Fri, Dec 8, 2017 at 1:09 AM, David Daney wrote:
[]
> Changes in v5:
[]
> o Removed redundant licensing text boilerplate.
Thank you very much!
Acked-by: Philippe Ombredanne
--
Cordially
Philippe Ombredanne, the licensing scruffy
you considered using the new SPDX ids instead of this fine legalese?
e.g.:
// SPDX-License-Identifier: GPL-2.0
// Copyright (C) 2005-2017 Andes Technology Corporation
This is much shorter and neater (unless you are a legalese lover of course!)
Check also Thomas doc patches and Linus comments o
ou could use instead this SPDX shorthand to the same effect without
turning the kernel code into a billboard:
// SPDX-License-Identifier: (GPL-2.0 OR MIT)
--
Cordially
Philippe Ombredanne, your ad-sensitive licensing scruffy
rd at FB, that would we awesome!
[1] https://lkml.org/lkml/2017/11/2/715
[2] https://lkml.org/lkml/2017/11/25/125
[3] https://lkml.org/lkml/2017/11/25/133
[4] https://lkml.org/lkml/2017/11/2/805
[5] https://lkml.org/lkml/2017/10/19/165
[6] https://lwn.net/Articles/739183/
--
Cordially
Philippe Ombredanne
Pavel,
On Fri, Dec 8, 2017 at 3:27 PM, Pavel Machek wrote:
> On Thu 2017-12-07 14:01:39, Philippe Ombredanne wrote:
>> Ben,
>>
>> On Thu, Dec 7, 2017 at 12:46 PM, Ben Whitten wrote:
>> > From: Ben Whitten
>> >
>> > This commit introduces
ter version.
> + */
Why not use the new SPDX ids?
e.g.
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/* Copyright (c) 2016-2017 Hisilicon Limited. */
See Linus posts and Thomas doc patches for details.
--
Cordially
Philippe Ombredanne
On Sun, Dec 10, 2017 at 5:24 PM, Ben Whitten wrote:
> This commit introduces a NETDEV trigger for named device
> activity. Available triggers are link, rx, and tx.
>
> Signed-off-by: Ben Whitten
>
> ---
> Changes in v4:
> Adopt SPDX licence header
Thanks you!
Acked
GPL-2.0
> +// sni_ave.c - Socionext UniPhier AVE ethernet driver
> +// Copyright 2014 Panasonic Corporation
> +// Copyright 2015-2017 Socionext Inc.
Thank you for your kind consideration!
--
Cordially
Philippe Ombredanne
ers (add SPDX tags, remove advertisment) (Philippe
> Ombredanne)
Thank you.
Acked-by: Philippe Ombredanne
--
Cordially
Philippe Ombredanne
cussion and
to me the benefit of the first form is that you have removed two
lines. Both forms work fine.
--
Cordially
Philippe Ombredanne
with the PF driver.
>
> Signed-off-by: Salil Mehta
> Signed-off-by: lipeng
> ---
> Patch V3: Addressed SPDX change requested by Philippe Ombredanne
> Link: https://lkml.org/lkml/2017/12/8/874
> Patch V2: Addressed some internal comments
> Patch V1: Initial Submit
>
that's your call to consider it this way.
--
Cordially
Philippe Ombredanne
Just like PF driver, this driver is also PCI
> Express based.
>
> Change Log Summary:
> Patch V4: Addressed SPDX related comment by Philippe Ombredanne
> Patch V3: Addressed SPDX change requested by Philippe Ombredanne
Thank you.
For the use of SPDX tags (and this only!) you have
e.c
> @@ -0,0 +1,1352 @@
> +// SPDX-License-Identifier: GPL-2.0
> +MODULE_LICENSE("GPL");
This does not match your license above. Per module.h "GPL" would mean "GPL-2.0+"
Can you use one or the other an\d ensure both of these are in sync?
--
Cordially
Philippe Ombredanne
29 matches
Mail list logo
