[RFC net-next af_unix v1 1/1] af_unix: Allow delivery of SIGURG on AF_UNIX streams socket

2020-11-14 Thread rao . shoaib
From: Rao Shoaib For AF_UNIX stream socket send SIGURG to the peer if the msg has MSG_OOB flag set. Signed-off-by: Rao Shoaib --- net/unix/af_unix.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 92784e5..4f01d74 100644

[RFC net-next af_unix v1 0/1] Allow delivery of SIGURG on AF_UNIX streams socket

2020-11-14 Thread rao . shoaib
From: Rao Shoaib The use of AF_UNIX sockets is on the rise. We have a case where thousands of processes connect locally to a database and issue queries that are serviced by a pool of threads. Communication is done over AF_UNIX sockets. Currently, there is no way for the submitter to signal the

Re: [PATCH net-next 01/14] tcp: Add clean acked data hook

2018-03-20 Thread Rao Shoaib
On 03/19/2018 07:44 PM, Saeed Mahameed wrote: From: Ilya Lesokhin Called when a TCP segment is acknowledged. Could be used by application protocols who hold additional metadata associated with the stream data. This is required by TLS device offload to release metadata associated with acknowl

Re: [PATCH net-next 01/14] tcp: Add clean acked data hook

2018-03-21 Thread Rao Shoaib
On 03/21/2018 04:21 AM, Boris Pismenny wrote: On 3/20/2018 10:36 PM, Rao Shoaib wrote: On 03/19/2018 07:44 PM, Saeed Mahameed wrote: From: Ilya Lesokhin Called when a TCP segment is acknowledged. Could be used by application protocols who hold additional metadata associated with the

Few questions about submitting patches

2018-03-21 Thread Rao Shoaib
I am new to Linux. I would like to understand the rules and etiquettes of engaging with the community. I have read the materials that I could find. As I work with Linux I come across situations for which I can not seem to find any answers. Hopefully folks on the list can answer them. * Submitt

Use of Indirect function calls

2018-03-06 Thread Rao Shoaib
I am working on a change which introduces a couple of indirect function calls in the fast path. I used indirect function calls instead of "if/else" as it keeps the code cleaner and more readable and provides for extensibility. I do not expect any measurable overhead as modern CPU's use pre-fet

Re: Use of Indirect function calls

2018-03-06 Thread Rao Shoaib
little different behavior is desired it can be achieved and common code could still be shared. Of course you can not say much without looking at the code but will you even entertain such a change ? Regards, Rao. On 03/06/2018 08:43 PM, David Miller wrote: From: Rao Shoaib Date: Tue, 6 Mar 2018

Re: Use of Indirect function calls

2018-03-06 Thread Rao Shoaib
On 03/06/2018 10:32 PM, Eric Dumazet wrote: On Tue, 2018-03-06 at 21:53 -0800, Rao Shoaib wrote: David, Thanks a lot for your prompt response. Do you have a specific solution in mind or will the calls be replaced with simple checks ? There is upcoming work for that, but not specific to TCP

[RFC net-next af_unix v1 1/1] af_unix: Allow delivery of SIGURG on AF_UNIX streams socket

2020-10-08 Thread rao . shoaib
From: Rao Shoaib For AF_UNIX stream socket send SIGURG to the peer if the msg has MSG_OOB flag set. Signed-off-by: Rao Shoaib --- net/unix/af_unix.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 92784e5..4f01d74 100644

[RFC net-next af_unix v1 0/1] Allow delivery of SIGURG on AF_UNIX streams socket

2020-10-08 Thread rao . shoaib
From: Rao Shoaib The use of AF_UNIX sockets is on the rise. We have a case where thousands of processes connect locally to a database and issue queries that are serviced by a pool of threads. Communication is done over AF_UNIX sockets. Currently, there is no way for the submitter to signal the

[PATCH v2] rds: transport module should be auto loaded when transport is set

2020-06-25 Thread rao . shoaib
From: Rao Shoaib This enhancement auto loads transport module when the transport is set via SO_RDS_TRANSPORT socket option. Reviewed-by: Ka-Cheong Poon Reviewed-by: Håkon Bugge Signed-off-by: Rao Shoaib Signed-off-by: Somasundaram Krishnasamy --- include/uapi/linux/rds.h | 4 +++- net/rds

[PATCH v1] rds: If one path needs re-connection, check all and re-connect

2020-06-26 Thread rao . shoaib
From: Rao Shoaib In testing with mprds enabled, Oracle Cluster nodes after reboot were not able to communicate with others nodes and so failed to rejoin the cluster. Peers with lower IP address initiated connection but the node could not respond as it choose a different path and could not

Re: [PATCH v1] rds: If one path needs re-connection, check all and re-connect

2020-06-29 Thread Rao Shoaib
On 6/26/20 4:31 PM, David Miller wrote: From: rao.sho...@oracle.com Date: Fri, 26 Jun 2020 11:34:38 -0700 +/* Check connectivity of all paths + */ +void rds_check_all_paths(struct rds_connection *conn) +{ + int i = 0; + + do { + rds_conn_path_connect_if_down(&conn->c

[PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-05-27 Thread rao . shoaib
From: Rao Shoaib This enhancement auto loads transport module when the transport is set via SO_RDS_TRANSPORT socket option. Orabug: 31032127 Reviewed-by: Ka-Cheong Poon Reviewed-by: Håkon Bugge Signed-off-by: Rao Shoaib Signed-off-by: Somasundaram Krishnasamy --- include/uapi/linux/rds.h

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-06-01 Thread Rao Shoaib
On 5/29/20 4:41 PM, David Miller wrote: From: rao.sho...@oracle.com Date: Wed, 27 May 2020 01:17:42 -0700 diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h index cba368e55863..7273c681e6c1 100644 --- a/include/uapi/linux/rds.h +++ b/include/uapi/linux/rds.h @@ -64,7 +64,7 @@

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-06-01 Thread Rao Shoaib
On 5/31/20 3:08 AM, Leon Romanovsky wrote: On Wed, May 27, 2020 at 01:17:42AM -0700, rao.sho...@oracle.com wrote: From: Rao Shoaib This enhancement auto loads transport module when the transport is set via SO_RDS_TRANSPORT socket option. Orabug: 31032127 I think that it is internal to

Re: [PATCH net-next] rds: transport module should be auto loaded when transport is set

2020-06-02 Thread Rao Shoaib
On 6/1/20 11:17 PM, Leon Romanovsky wrote: On Mon, Jun 01, 2020 at 09:59:30AM -0700, Rao Shoaib wrote: On 5/29/20 4:41 PM, David Miller wrote: From: rao.sho...@oracle.com Date: Wed, 27 May 2020 01:17:42 -0700 diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h index

[PATCH v1] rds: If one path needs re-connection, check all and re-connect

2020-07-01 Thread rao . shoaib
From: Rao Shoaib In testing with mprds enabled, Oracle Cluster nodes after reboot were not able to communicate with others nodes and so failed to rejoin the cluster. Peers with lower IP address initiated connection but the node could not respond as it choose a different path and could not

What is the correct behavior ipv4/ipv6

2017-07-17 Thread Rao Shoaib
I am looking at a system which is configured for IPv6 only but sits in a network that serves both IPv4 and IPv6. When an IPv4 packet with a destination broadcast address is sent out (in this case DHCP) the system accepts it and since it does not have any route to the sender it prints the Marti

[PATCH] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-07 Thread Rao Shoaib
Signed-off-by: Rao Shoaib --- net/ipv4/tcp.c | 10 -- net/ipv4/tcp_timer.c | 9 + 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 71ce33d..f2af44d 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2628,7 +2628,9

[PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-07 Thread Rao Shoaib
than that of the adopted USER TIMEOUT. This patch enforces the MUST and also dis-associates user timeout from keep alive. A man page patch will be submitted separately. Signed-off-by: Rao Shoaib --- net/ipv4/tcp.c | 10 -- net/ipv4/tcp_timer.c | 9 + 2 files changed, 9

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Rao Shoaib
On 08/09/2017 05:20 PM, Joe Smith wrote: On Wed, Aug 9, 2017 at 4:52 PM, Jerry Chu wrote: [try to recover from long lost memory] On Tue, Aug 8, 2017 at 10:25 AM, Yuchung Cheng wrote: On Mon, Aug 7, 2017 at 11:16 AM, Rao Shoaib wrote: Change from version 0: Rationale behind the change

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-09 Thread Rao Shoaib
On 08/09/2017 05:30 PM, David Miller wrote: From: Joe Smith Date: Wed, 9 Aug 2017 17:20:32 -0700 Making Linux conform to standards and behavior that is logical seems like a good enough reason. That's an awesome attitude to have when we're implementing something new and don't have the facili

Re: [PATCH v1 net] TCP_USER_TIMEOUT and tcp_keepalive should conform to RFC5482

2017-08-10 Thread Rao Shoaib
On 08/09/2017 09:59 PM, Jerry Chu wrote: On Wed, Aug 9, 2017 at 8:32 PM, Jerry Chu wrote: On Wed, Aug 9, 2017 at 5:47 PM, Rao Shoaib wrote: On 08/09/2017 05:30 PM, David Miller wrote: From: Joe Smith Date: Wed, 9 Aug 2017 17:20:32 -0700 Making Linux conform to standards and behavior