Re: [PATCH iproute2-next 5/9] libnetlink: Add helper to create nexthop dump request

2019-05-30 Thread Roopa Prabhu
On Wed, May 29, 2019 at 9:04 PM David Ahern wrote: > > From: David Ahern > > Add rtnl_nexthopdump_req to initiate a dump request of nexthop objects. > > Signed-off-by: David Ahern > --- > include/libnetlink.h | 4 > lib/libnetlink.c | 27 +++ > 2 files changed,

Re: [PATCH iproute2-next 8/9] ip route: Add option to use nexthop objects

2019-05-30 Thread Roopa Prabhu
On Wed, May 29, 2019 at 9:04 PM David Ahern wrote: > > From: David Ahern > > Add nhid option for routes to use nexthop objects by id. > > Signed-off-by: David Ahern > --- man page needs an update ? :) > ip/iproute.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > >

Re: [PATCH iproute2-next 7/9] Add support for nexthop objects

2019-05-30 Thread Roopa Prabhu
On Wed, May 29, 2019 at 9:04 PM David Ahern wrote: > > From: David Ahern > > Add nexthop subcommand to ip. Implement basic commands for creating, > deleting and dumping nexthop objects. Syntax follows 'nexthop' syntax > from existing 'ip route' command. > > Signed-off-by: David Ahern If you are

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-08 Thread Roopa Prabhu
On Fri, Jul 19, 2019 at 4:00 AM Jiri Pirko wrote: > > From: Jiri Pirko > > Add two commands to add and delete alternative ifnames for net device. > Each net device can have multiple alternative names. > > Signed-off-by: Jiri Pirko > --- > include/linux/netdevice.h | 4 ++ > include/uapi/

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-09 Thread Roopa Prabhu
On Thu, Aug 8, 2019 at 11:25 PM Jiri Pirko wrote: > > Fri, Aug 09, 2019 at 06:11:30AM CEST, ro...@cumulusnetworks.com wrote: > >On Fri, Jul 19, 2019 at 4:00 AM Jiri Pirko wrote: > >> > >> From: Jiri Pirko > >> > >> Add two commands to add and delete alternative ifnames for net device. > >> Each

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-10 Thread Roopa Prabhu
On Fri, Aug 9, 2019 at 8:46 AM Michal Kubecek wrote: > > On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > > to that point, I am also not sure why we have a new API For multiple > > names. I mean why support more than two names (existing old name and > >

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-10 Thread Roopa Prabhu
On Sat, Aug 10, 2019 at 8:50 AM Michal Kubecek wrote: > > On Sat, Aug 10, 2019 at 06:46:57AM -0700, Roopa Prabhu wrote: > > On Fri, Aug 9, 2019 at 8:46 AM Michal Kubecek wrote: > > > > > > On Fri, Aug 09, 2019 at 08:40:25AM -0700, Roopa Prabhu wrote: > > >

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-12 Thread Roopa Prabhu
On Mon, Aug 12, 2019 at 1:31 AM Jiri Pirko wrote: > > Mon, Aug 12, 2019 at 03:37:26AM CEST, dsah...@gmail.com wrote: > >On 8/11/19 7:34 PM, David Ahern wrote: > >> On 8/10/19 12:30 AM, Jiri Pirko wrote: > >>> Could you please write me an example message of add/remove? > >> > >> altnames are for ex

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-12 Thread Roopa Prabhu
On Sun, Aug 11, 2019 at 3:10 PM Michal Kubecek wrote: > > On Sat, Aug 10, 2019 at 12:39:31PM -0700, Roopa Prabhu wrote: > > On Sat, Aug 10, 2019 at 8:50 AM Michal Kubecek wrote: > > > > > > On Sat, Aug 10, 2019 at 06:46:57AM -0700, Roopa Prabhu wrote: > >

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-12 Thread Roopa Prabhu
On Mon, Aug 12, 2019 at 8:40 AM Stephen Hemminger wrote: > > On Mon, 12 Aug 2019 10:31:39 +0200 > Jiri Pirko wrote: > > > Mon, Aug 12, 2019 at 03:37:26AM CEST, dsah...@gmail.com wrote: > > >On 8/11/19 7:34 PM, David Ahern wrote: > > >> On 8/10/19 12:30 AM, Jiri Pirko wrote: > > >>> Could you plea

Re: VDPA Debug/Statistics

2020-08-11 Thread Roopa Prabhu
On 8/11/20 5:44 AM, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Tue, Aug 11, 2020 at 11:58:23AM +, Eli Cohen wrote: On Tue, Aug 11, 2020 at 11:26:20AM +, Eli Cohen wrote: Hi All Currently, the only statistics we get for a VDPA instance come

Re: [PATCH ethtool v5] Add QSFP-DD support

2020-08-13 Thread Roopa Prabhu
On 8/13/20 8:08 AM, Adrian Pop wrote: The Common Management Interface Specification (CMIS) for QSFP-DD shares some similarities with other form factors such as QSFP or SFP, but due to the fact that the module memory map is different, the current ethtool version is not able to provide relevant i

[PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support for recently added link IFLA_PROTO_DOWN_REASON attribute. IFLA_PROTO_DOWN_REASON enumerates reasons for the already existing IFLA_PROTO_DOWN link attribute. $ cat /etc/iproute2/protodown_reasons.d/r.conf 0 mlag 1 evpn 2 vrrp 3 psecurity $ ip link set

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-20 Thread Roopa Prabhu
On 8/20/20 9:36 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2020 20:52:02 -0700 Roopa Prabhu wrote: + if (tb[IFLA_PROTO_DOWN]) { + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN])) + print_bool(PRINT_ANY, +"proto

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-21 Thread Roopa Prabhu
On 8/20/20 10:18 PM, Roopa Prabhu wrote: On 8/20/20 9:36 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2020 20:52:02 -0700 Roopa Prabhu wrote: + if (tb[IFLA_PROTO_DOWN]) { + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN])) + print_bool(PRINT_ANY

Re: [PATCH net] vxlan: do not destroy fdb if register_netdevice() is failed

2019-06-24 Thread Roopa Prabhu
On Sun, Jun 23, 2019 at 7:18 PM Taehee Yoo wrote: > > On Mon, 24 Jun 2019 at 03:07, David Miller wrote: > > > > Hi David, > > Thank you for the review! > > > From: Taehee Yoo > > Date: Thu, 20 Jun 2019 20:51:08 +0900 > > > > > __vxlan_dev_create() destroys FDB using specific pointer which indica

Re: [PATCH net] vxlan: do not destroy fdb if register_netdevice() is failed

2019-06-25 Thread Roopa Prabhu
On Tue, Jun 25, 2019 at 9:08 AM Taehee Yoo wrote: > > On Tue, 25 Jun 2019 at 13:12, Roopa Prabhu wrote: > > > > Hi Roopa, > > Thank you for the review! > > > On Sun, Jun 23, 2019 at 7:18 PM Taehee Yoo wrote: > > > > > > On Mon, 24 Jun 2019 at

[PATCH net-next v2 0/3] fib rule selftest

2018-05-06 Thread Roopa Prabhu
From: Roopa Prabhu This series adds a new test to test fib rules. ip route get is used to test fib rule matches. This series also extends ip route get to match on sport and dport to test recent support of sport and dport fib rule match. v2 - address ido's commemt to make sport dport ip

[PATCH net-next v2 1/3] ipv4: support sport and dport in RTM_GETROUTE

2018-05-06 Thread Roopa Prabhu
From: Roopa Prabhu This is a followup to fib rules sport, dport match support. Having them supported in getroute makes it easier to test fib rule lookups. Used by fib rule self tests. Before this patch getroute used same skb to pass through the route lookup and for the netlink getroute reply msg

[PATCH net-next v2 2/3] ipv6: support sport and dport in RTM_GETROUTE

2018-05-06 Thread Roopa Prabhu
From: Roopa Prabhu This is a followup to fib6 rules sport and dport match support. Having them supported in getroute makes it easier to test fib6 rule lookups. Used by fib6 rule self tests. Signed-off-by: Roopa Prabhu --- net/ipv6/route.c | 25 + 1 file changed, 25

[PATCH net-next v2 3/3] selftests: net: initial fib rule tests

2018-05-06 Thread Roopa Prabhu
From: Roopa Prabhu This adds a first set of tests for fib rule match/action for ipv4 and ipv6. Initial tests only cover action lookup table. can be extended to cover other actions in the future. Uses ip route get to validate the rule lookup. Signed-off-by: Roopa Prabhu --- tools/testing

Re: [PATCH net-next v2 1/3] ipv4: support sport and dport in RTM_GETROUTE

2018-05-07 Thread Roopa Prabhu
On Sun, May 6, 2018 at 6:46 PM, David Ahern wrote: > On 5/6/18 6:59 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This is a followup to fib rules sport, dport match support. >> Having them supported in getroute makes it easier to test >> fib rule loo

Re: [PATCH net-next 3/5] ipv4: support sport, dport and ip protocol in RTM_GETROUTE

2018-04-17 Thread Roopa Prabhu
On Tue, Apr 17, 2018 at 1:10 AM, Ido Schimmel wrote: > On Mon, Apr 16, 2018 at 01:41:36PM -0700, Roopa Prabhu wrote: >> @@ -2757,6 +2796,12 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, >> struct nlmsghdr *nlh, >> fl4.flowi4_oif = tb[RTA_OIF] ? nla_get

[PATCH net-next v2 2/2] net: fib_rules: add extack support

2018-04-21 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- include/net/fib_rules.h | 3 ++- net/core/fib_rules.c| 55 + net/decnet/dn_rules.c | 7 +-- net/ipv4/fib_rules.c| 7 +-- net/ipv4/ipmr.c | 3 ++- net/ipv6

[PATCH net-next v2 0/2] fib rules extack support

2018-04-21 Thread Roopa Prabhu
From: Roopa Prabhu First patch refactors code to move fib rule netlink handling into a common function. This became obvious when adding duplicate extack msgs in add and del paths. Second patch adds extack msgs. v2 - Dropped the ip route get support and selftests from the series to look at

[PATCH net-next v2 1/2] fib_rules: move common handling of newrule delrule msgs into fib_nl2rule

2018-04-21 Thread Roopa Prabhu
From: Roopa Prabhu This reduces code duplication in the fib rule add and del paths. Get rid of validate_rulemsg. This became obvious when adding duplicate extack support in fib newrule/delrule error paths. Signed-off-by: Roopa Prabhu --- net/core/fib_rules.c | 436

Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

2018-04-22 Thread Roopa Prabhu
On Sun, Apr 22, 2018 at 11:54 AM, David Miller wrote: > From: Johannes Berg > Date: Thu, 19 Apr 2018 17:26:57 +0200 > >> On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: >>> >>> Maybe this could be in followup patches? It's going to touch a lot of >>> files, >>> and might be hell to get mer

[PATCH net-next] net: fib_rules: fix l3mdev netlink attr processing

2018-04-23 Thread Roopa Prabhu
From: Roopa Prabhu Fixes: b16fb418b1bf ("net: fib_rules: add extack support") Signed-off-by: Roopa Prabhu --- Looks like I broke this when i split extack changes into a separate patch :( net/core/fib_rules.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/fib_rules.c

Re: [PATCH net-next v2 0/2] fib rules extack support

2018-04-23 Thread Roopa Prabhu
On Mon, Apr 23, 2018 at 7:21 AM, David Miller wrote: > From: Roopa Prabhu > Date: Sat, 21 Apr 2018 09:41:29 -0700 > >> From: Roopa Prabhu >> >> First patch refactors code to move fib rule netlink handling >> into a common function. This became obvious when addin

Re: [PATCH net v2] net: ethtool: Add missing kernel doc for FEC parameters

2018-04-23 Thread Roopa Prabhu
> Signed-off-by: Florian Fainelli Acked-by: Roopa Prabhu Thanks Florian.

Re: [net-next regression] kselftest failure in fib_nl_newrule()

2018-04-24 Thread Roopa Prabhu
On Tue, Apr 24, 2018 at 2:46 AM, Anders Roxell wrote: > Hi, > > fib-onlink-tests.sh (from kselftest) found a regression between > next-20180424 [1] (worked with tag next-20180423 [2]) > > here is tree commits that look suspicious specially this patch (sha: > f9d4b0c1e969) > rewrites fib_nl_newrule

[PATCH net-next] neighbour: support for NTF_EXT_LEARNED flag

2018-04-24 Thread Roopa Prabhu
From: Roopa Prabhu This patch extends NTF_EXT_LEARNED support to the neighbour system. Example use-case: An Ethernet VPN implementation (eg in FRR routing suite) can use this flag to add dynamic reachable external neigh entires learned via control plane. The use of neigh NTF_EXT_LEARNED in this

Re: [PATCH net-next] neighbour: support for NTF_EXT_LEARNED flag

2018-04-25 Thread Roopa Prabhu
On Wed, Apr 25, 2018 at 10:20 AM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 24 Apr 2018 13:49:34 -0700 > >> From: Roopa Prabhu >> >> This patch extends NTF_EXT_LEARNED support to the neighbour system. >> Example use-case: An Ethernet VPN implem

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

2018-03-22 Thread Roopa Prabhu
On Thu, Mar 22, 2018 at 3:55 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset resolves 2 issues we have right now: > 1) There are many netdevices / ports in the system, for port, pf, vf >represenatation but the user has no way to see which is which > 2) The ndo_get_phys_port_name is

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

2018-03-22 Thread Roopa Prabhu
On Thu, Mar 22, 2018 at 8:34 AM, David Ahern wrote: > On 3/22/18 4:55 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This patchset resolves 2 issues we have right now: >> 1) There are many netdevices / ports in the system, for port, pf, vf >>represenatation but the user has no way to see whi

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-03-22 Thread Roopa Prabhu
he user only needs to set a larger MTU on the member > ports that are participating in the large MTU VLANS. > > Signed-off-by: Chas Williams <3ch...@gmail.com> > --- Acked-by: Roopa Prabhu This or an equivalent fix is necessary: as stated above, today the bridge mtu capped at min

Re: [PATCH net-next] bridge: Allow max MTU when multiple VLANs present

2018-03-29 Thread Roopa Prabhu
On Thu, Mar 22, 2018 at 9:53 PM, Roopa Prabhu wrote: > On Thu, Mar 22, 2018 at 8:34 AM, Chas Williams <3ch...@gmail.com> wrote: >> If the bridge is allowing multiple VLANs, some VLANs may have >> different MTUs. Instead of choosing the minimum MTU for the >> bridge in

Re: [PATCH net v2] vxlan: do not destroy fdb if register_netdevice() is failed

2019-06-27 Thread Roopa Prabhu
nl_newlink+0xb75/0x1180 > [ 213.554119] ? rtnl_link_unregister+0x230/0x230 > [ ... ] > > Fixes: 0241b836732f ("vxlan: fix default fdb entry netlink notify ordering > during netdev create") > Suggested-by: Roopa Prabhu > Signed-off-by: Taehee Y

Re: [PATCH net v3] vxlan: do not destroy fdb if register_netdevice() is failed

2019-06-30 Thread Roopa Prabhu
_rtnl_newlink+0xb75/0x1180 > [ 213.554119] ? rtnl_link_unregister+0x230/0x230 > [ ... ] > > Fixes: 0241b836732f ("vxlan: fix default fdb entry netlink notify ordering > during netdev create") > Suggested-by: Roopa Prabhu > Signed-off-by: Taehee Yoo Acke

Re: [net-next] net: fib_rules: do not flow dissect local packets

2019-07-11 Thread Roopa Prabhu
On Mon, Jul 8, 2019 at 4:12 PM David Miller wrote: > > From: Petar Penkov > Date: Fri, 5 Jul 2019 11:46:43 -0700 > > > Rules matching on loopback iif do not need early flow dissection as the > > packet originates from the host. Stop counting such rules in > > fib_rule_requires_fldissect > > > >

Re: general protection fault in fib_dump_info

2017-08-15 Thread Roopa Prabhu
On Tue, Aug 15, 2017 at 5:05 AM, Florian Westphal wrote: > idaifish wrote: >> Syzkaller hit 'general protection fault in fib_dump_info' bug on >> commit 4.13-rc5.. > > CC Roopa > >> Guilty file: net/ipv4/fib_semantics.c >> >> kasan: GPF could be caused by NULL-ptr deref or user memory access >> g

[PATCH net] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

2017-08-15 Thread Roopa Prabhu
From: Roopa Prabhu Syzkaller hit 'general protection fault in fib_dump_info' bug on commit 4.13-rc5.. Guilty file: net/ipv4/fib_semantics.c kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN Modules linked in:

Re: [PATCH net] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

2017-08-15 Thread Roopa Prabhu
On Tue, Aug 15, 2017 at 7:56 PM, David Ahern wrote: > On 8/15/17 8:50 PM, Roopa Prabhu wrote: >> diff --git a/net/ipv4/route.c b/net/ipv4/route.c >> index 7effa62..49a018f 100644 >> --- a/net/ipv4/route.c >> +++ b/net/ipv4/route.c >> @@ -2763,14 +2763,21 @@ st

Re: [PATCH 1/2] mpls: add handlers

2017-08-15 Thread Roopa Prabhu
On Tue, Aug 15, 2017 at 2:37 AM, David Lamparter wrote: [snip] > I think the reverse is the better option, removing the vpls device > information and just going with the route table. My approach to this > would be to add a new netlink route attribute "RTA_VPLS" which > identifies the vpls devic

[PATCH net v2] net: check and errout if res->fi is NULL when RTM_F_FIB_MATCH is set

2017-08-16 Thread Roopa Prabhu
From: Roopa Prabhu Syzkaller hit 'general protection fault in fib_dump_info' bug on commit 4.13-rc5.. Guilty file: net/ipv4/fib_semantics.c kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] SMP KASAN Modules linked in: CPU: 0 PID:

Re: [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

2017-08-21 Thread Roopa Prabhu
On Mon, Aug 21, 2017 at 10:15 AM, David Lamparter wrote: > Hi all, > > > this is an update on the earlier "[RFC net-next] VPLS support". Note > I've changed the subject lines on some of the patches to better reflect > what they really do (tbh the earlier subject lines were crap.) > > As previousl

[PATCH net] bridge: check for null fdb->dst before notifying switchdev drivers

2017-08-26 Thread Roopa Prabhu
From: Roopa Prabhu current switchdev drivers dont seem to support offloading fdb entries pointing to the bridge device which have fdb->dst not set to any port. This patch adds a NULL fdb->dst check in the switchdev notifier code. This patch fixes the below NULL ptr dereference: $bridge f

[PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-27 Thread Roopa Prabhu
From: Roopa Prabhu Tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu --- include/trace/events/bridge.h | 98 +++ net/bridge/br_fdb.c | 7 net/core/net-traces.c | 6 +++ 3 files changed, 111

Re: [PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-28 Thread Roopa Prabhu
On Sun, Aug 27, 2017 at 7:11 PM, Florian Fainelli wrote: > On 08/27/2017 02:33 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Tracepoints to trace bridge forwarding database updates. > > Thanks for adding this! > >> >> Signed-off-by: Roopa Prabhu

Re: [PATCH net-next] bridge: fdb add and delete tracepoints

2017-08-28 Thread Roopa Prabhu
On Sun, Aug 27, 2017 at 7:11 PM, Florian Fainelli wrote: > On 08/27/2017 02:33 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Tracepoints to trace bridge forwarding database updates. > > Thanks for adding this! > >> >> Signed-off-by: Roopa Prabhu

Re: mlxsw and rtnl lock

2017-08-28 Thread Roopa Prabhu
On Sat, Aug 26, 2017 at 10:04 AM, Ido Schimmel wrote: > On Fri, Aug 25, 2017 at 01:26:07PM -0700, David Ahern wrote: >> Jiri / Ido: >> >> [snip] > > Regarding the silent abort, that's intentional. You can look at the same > code in v4.9 - when the chain was still blocking - and you'll see that > w

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-27 Thread Roopa Prabhu
On Tue, Aug 27, 2019 at 2:35 AM Jiri Pirko wrote: > > Tue, Aug 27, 2019 at 10:22:42AM CEST, da...@davemloft.net wrote: > >From: Jiri Pirko > >Date: Tue, 27 Aug 2019 09:08:08 +0200 > > > >> Okay, so if I understand correctly, on top of separate commands for > >> add/del of alternative names, you s

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-28 Thread Roopa Prabhu
On Wed, Aug 28, 2019 at 12:07 AM Jiri Pirko wrote: > > Tue, Aug 27, 2019 at 05:14:49PM CEST, ro...@cumulusnetworks.com wrote: > >On Tue, Aug 27, 2019 at 2:35 AM Jiri Pirko wrote: > >> > >> Tue, Aug 27, 2019 at 10:22:42AM CEST, da...@davemloft.net wrote: > >> >From: Jiri Pirko > >> >Date: Tue, 27

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-08-30 Thread Roopa Prabhu
On Wed, Aug 28, 2019 at 10:26 PM Michal Kubecek wrote: > > On Wed, Aug 28, 2019 at 09:36:41PM -0700, Roopa Prabhu wrote: > > > > yes, correct. I mentioned that because I was wondering if we can > > think along the same lines for this API. > > eg > > (a)

Re: [PATCH][net-next] bridge: remove redundant check on err in br_multicast_ipv4_rcv

2019-02-19 Thread Roopa Prabhu
On Mon, Feb 18, 2019 at 6:17 PM Li RongQing wrote: > > br_ip4_multicast_mrd_rcv only return 0 and -ENOMSG, > no other negative value > > Signed-off-by: Li RongQing Acked-by: Roopa Prabhu looks fine to me. CC Nikolay > net/bridge/br_multicast.c | 7 +-- > 1 file

[PATCH net-next] trace: events: neigh_update: print new state in string format

2019-02-23 Thread Roopa Prabhu
From: Roopa Prabhu Also, extend neigh_state_str to include neigh dummy states noarp and permanent Fixes: 9c03b282badb ("trace: events: add a few neigh tracepoints") Signed-off-by: Roopa Prabhu --- include/trace/events/neigh.h | 8 +--- 1 file changed, 5 insertions(+), 3 deletion

[PATCH net-next 0/2] vxlan: create and changelink extack support

2019-02-25 Thread Roopa Prabhu
From: Roopa Prabhu This series adds extack support to changelink paths. In the process re-factors flag sets to a separate helper. Also adds some changelink testcases to rtnetlink.sh (This series was initially part of another series that tried to support changelink for more attributes. But after

[PATCH net-next 2/2] tools: selftests: rtnetlink: add testcases for vxlan flag sets

2019-02-25 Thread Roopa Prabhu
From: Roopa Prabhu This patch extends rtnetlink.sh to cover some vxlan flag netlink attribute sets. Signed-off-by: Roopa Prabhu --- tools/testing/selftests/net/rtnetlink.sh | 52 1 file changed, 52 insertions(+) diff --git a/tools/testing/selftests/net

[PATCH net-next 1/2] vxlan: add extack support for create and changelink

2019-02-25 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds extack coverage in vxlan link create and changelink paths. Introduces a new helper vxlan_nl2flags to consolidate flag attribute validation. thanks to Johannes Berg for some tips to construct the generic vxlan flag extack strings. Signed-off-by: Roopa Prabhu

Re: [PATCH net-next 1/2] vxlan: add extack support for create and changelink

2019-02-26 Thread Roopa Prabhu
On Tue, Feb 26, 2019 at 5:51 AM Petr Machata wrote: > > > Roopa Prabhu writes: > > > From: Roopa Prabhu > > > > This patch adds extack coverage in vxlan link > > create and changelink paths. Introduces a new helper > > vxlan_nl2flags to consolidate fl

Re: [PATCH net-next 1/2] vxlan: add extack support for create and changelink

2019-02-26 Thread Roopa Prabhu
On Tue, Feb 26, 2019 at 9:45 AM Petr Machata wrote: > > > Roopa Prabhu writes: > > > On Tue, Feb 26, 2019 at 5:51 AM Petr Machata wrote: > >> > >> Many of the flags for which you call this don't actually have the else > >> branch. Howeve

[PATCH iproute2-next] bridge: fdb: add support for src_vni option

2019-03-03 Thread Roopa Prabhu
From: Roopa Prabhu We already print src_vni for a fdb entry when present. This patch adds the ability to set src_vni on a fdb entry. When not specified, kernel will use vni specified on the vxlan device. This can be used on a vxlan fdb entry when the vxlan device is in external or collect

Re: [RFC PATCH net-next 1/3] net: rtnetlink: Add link-down reason to RTNL messages

2019-03-17 Thread Roopa Prabhu
On Fri, Mar 15, 2019 at 10:56 AM Petr Machata wrote: > > In general, after a port is put administratively up, certain handshake > protocols have to finish successfully, otherwise the port is left in a > NO-CARRIER or DORMANT state. When that happens, it would be useful to > communicate the reasons

Re: getneigh: add nondump to retrieve single entry

2019-05-14 Thread Roopa Prabhu
ow commit already in the tree ? commit 82cbb5c631a07b3aa6df6eab644d55da9de5a645 Author: Roopa Prabhu Date: Wed Dec 19 12:51:38 2018 -0800 neighbour: register rtnl doit handler

Re: [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-05 Thread Roopa Prabhu
On Wed, Oct 4, 2017 at 3:52 PM, David Miller wrote: > From: Roopa Prabhu > Date: Tue, 3 Oct 2017 22:12:31 -0700 > >> BR_ARP_PROXY flag but has a few semantic differences to conform > > This should be "BR_PROXYARP". ack, will fix. > > Otherwise this ser

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-10-06 Thread Roopa Prabhu
On Thu, Oct 5, 2017 at 11:30 AM, Jakub Kicinski wrote: > On Fri, 28 Jul 2017 23:28:26 -0700, Roopa Prabhu wrote: >> On Fri, Jul 28, 2017 at 9:46 AM, Jakub Kicinski wrote: >> > On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote: >> >> On Thu, Jul 27, 2017 at

[PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few semantic

[PATCH net-next v5 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 11

[PATCH net-next v5 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 188

[PATCH net-next v5 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few

Re: [PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
On Fri, Oct 6, 2017 at 11:34 AM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 > https://tools.ietf.org/html/rfc7432#section-10 > for ethernet VPN deployme

[PATCH net-next v6 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few

[PATCH net-next v6 0/3] bridge: neigh msg proxy and flood suppression support

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP* flags but has a few semantic

[PATCH net-next v6 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 188

[PATCH net-next v6 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

2017-10-06 Thread Roopa Prabhu
From: Roopa Prabhu This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge/br_device.c | 11 ++ net/bridge/br_input.c| 11

[PATCH iproute2] iplink: new option to set neigh suppression on a bridge port

2017-10-09 Thread Roopa Prabhu
From: Roopa Prabhu neigh suppression can be used to suppress arp and nd flood to bridge ports. It maps to the recently added kernel support for bridge port flag IFLA_BRPORT_NEIGH_SUPPRESS. Signed-off-by: Roopa Prabhu --- bridge/link.c| 13 + ip/iplink_bridge_slave.c

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: > Adds a devlink command for getting & setting device configuration > parameters, and enumerates a bunch of those parameters as devlink > attributes. Also introduces an attribute that can be set by a > driver to indicate that the config change doe

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin wrote: >>> Adds a devlink command for getting & setting device configuration >>> parameters, and enumerates a bunch of those par

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 7:45 AM, Steve Lin wrote: > Hi Roopa, > > The attributes added in this patchset are not really the same type as > ethtool - these are more device configuration type attributes. The > speeds you saw, for example, affect the pre-OS [i.e. PXE boot time] > configuration for a

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 8:04 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: >>> Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulusnetworks.com wrote: On Thu, Oct 12, 2017 at 6:34 AM, Steve Li

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 8:43 AM, Florian Fainelli wrote: > On October 12, 2017 8:04:19 AM PDT, Jiri Pirko wrote: >>Thu, Oct 12, 2017 at 04:46:24PM CEST, ro...@cumulusnetworks.com wrote: >>>On Thu, Oct 12, 2017 at 7:40 AM, Jiri Pirko wrote: Thu, Oct 12, 2017 at 04:35:10PM CEST, ro...@cumulus

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli wrote: > On 10/12/2017 12:06 PM, David Miller wrote: >> From: Florian Fainelli >> Date: Thu, 12 Oct 2017 08:43:59 -0700 >> >>> Once we move ethtool (or however we name its successor) over to >>> netlink there is an opportunity for accessing objec

Re: Ethtool question

2017-10-12 Thread Roopa Prabhu
On Thu, Oct 12, 2017 at 2:45 PM, Ben Greear wrote: > On 10/11/2017 01:49 PM, David Miller wrote: >> >> From: "John W. Linville" >> Date: Wed, 11 Oct 2017 16:44:07 -0400 >> >>> On Wed, Oct 11, 2017 at 09:51:56AM -0700, Ben Greear wrote: I noticed today that setting some ethtool settings

Re: [RFC 0/3] Adding config get/set to devlink

2017-10-13 Thread Roopa Prabhu
On Fri, Oct 13, 2017 at 12:11 AM, Jiri Pirko wrote: > Thu, Oct 12, 2017 at 11:53:56PM CEST, ro...@cumulusnetworks.com wrote: >>On Thu, Oct 12, 2017 at 12:20 PM, Florian Fainelli >>wrote: >>> On 10/12/2017 12:06 PM, David Miller wrote: From: Florian Fainelli Date: Thu, 12 Oct 2017 08:4

Re: [PATCH] fib_rules: match rules based on suppress_* properties too

2018-06-25 Thread Roopa Prabhu
On Sat, Jun 23, 2018 at 8:59 AM, Jason A. Donenfeld wrote: > Two rules with different values of suppress_prefix or suppress_ifgroup > are not the same. This fixes an -EEXIST when running: > >$ ip -4 rule add table main suppress_prefixlength 0 > > Signed-off-by: Jason A. Donenfeld > Fixes: f9d

Re: [net regression] "fib_rules: move common handling of newrule delrule msgs into fib_nl2rule" breaks suppress_prefixlength

2018-06-25 Thread Roopa Prabhu
On Sat, Jun 23, 2018 at 8:46 AM, Jason A. Donenfeld wrote: > Hey Roopa, > > On a kernel with a minimal networking config, > CONFIG_IP_MULTIPLE_TABLES appears to be broken for certain rules after > f9d4b0c1e9695e3de7af3768205bacc27312320c. > > Try, for example, running: > > $ ip -4 rule add table m

Re: [net regression] "fib_rules: move common handling of newrule delrule msgs into fib_nl2rule" breaks suppress_prefixlength

2018-06-25 Thread Roopa Prabhu
On Mon, Jun 25, 2018 at 8:23 AM, Roopa Prabhu wrote: > On Sat, Jun 23, 2018 at 8:46 AM, Jason A. Donenfeld wrote: >> Hey Roopa, >> >> On a kernel with a minimal networking config, >> CONFIG_IP_MULTIPLE_TABLES appears to be bro

[PATCH net-next] neighbour: force neigh_invalidate when NUD_FAILED update is from admin

2018-06-25 Thread Roopa Prabhu
From: Roopa Prabhu In systems where neigh gc thresh holds are set to high values, admin deleted neigh entries (eg ip neigh flush or ip neigh del) can linger around in NUD_FAILED state for a long time until periodic gc kicks in. This patch forces neigh_invalidate when NUD_FAILED neigh_update is

Re: [PATCH v2] fib_rules: match rules based on suppress_* properties too

2018-06-26 Thread Roopa Prabhu
On Mon, Jun 25, 2018 at 4:39 PM, Jason A. Donenfeld wrote: > Two rules with different values of suppress_prefix or suppress_ifgroup > are not the same. This fixes an -EEXIST when running: > >$ ip -4 rule add table main suppress_prefixlength 0 > > Signed-off-by: Jason A. Donenfeld > Fixes: f9d

Re: [PATCH v2] fib_rules: match rules based on suppress_* properties too

2018-06-26 Thread Roopa Prabhu
On Tue, Jun 26, 2018 at 6:34 PM, David Miller wrote: > From: "Jason A. Donenfeld" > Date: Tue, 26 Jun 2018 01:39:32 +0200 > >> Two rules with different values of suppress_prefix or suppress_ifgroup >> are not the same. This fixes an -EEXIST when running: >> >>$ ip -4 rule add table main suppr

[PATCH net] net: fib_rules: add protocol check in rule_find

2018-06-27 Thread Roopa Prabhu
From: Roopa Prabhu After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs into fib_nl2rule"), rule_find is strict about checking for an existing rule. rule_find must check against all user given attributes, else it may match against a subset of attributes

Re: [PATCH net] net: fib_rules: add protocol check in rule_find

2018-06-28 Thread Roopa Prabhu
On Wed, Jun 27, 2018 at 6:27 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule > delrule msgs into fib_nl2rule"), rule_find is strict about checking > for an existing rule. rule_find must check

Re: [PATCH net] net: fib_rules: add protocol check in rule_find

2018-06-29 Thread Roopa Prabhu
On Thu, Jun 28, 2018 at 9:59 PM, Roopa Prabhu wrote: > On Wed, Jun 27, 2018 at 6:27 PM, Roopa Prabhu > wrote: >> From: Roopa Prabhu >> >> After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule >> delrule msgs into fib_nl2rule"), rule

[PATCH net] net: fib_rules: bring back rule_exists to match rule during add

2018-06-29 Thread Roopa Prabhu
From: Roopa Prabhu After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs into fib_nl2rule"), rule_exists got replaced by rule_find for existing rule lookup in both the add and del paths. While this is good for the delete path, it solves a few problems but

[PATCH net-next 4/4] vxlan: fix default fdb entry netlink notify ordering during netdev create

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu Problem: In vxlan_newlink, a default fdb entry is added before register_netdev. The default fdb creation function also notifies user-space of the fdb entry on the vxlan device which user-space does not know about yet. (RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex

[PATCH net-next 3/4] vxlan: make netlink notify in vxlan_fdb_destroy optional

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu Add a new option do_notify to vxlan_fdb_destroy to make sending netlink notify optional. Used by a later patch. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c b

[PATCH net-next 1/4] rtnetlink: add rtnl_link_state check in rtnl_configure_link

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu rtnl_configure_link sets dev->rtnl_link_state to RTNL_LINK_INITIALIZED and unconditionally calls __dev_notify_flags to notify user-space of dev flags. current call sequence for rtnl_configure_link rtnetlink_newlink rtnl_link_ops->newlink rtnl_configur

[PATCH net-next 0/4] vxlan: fix default fdb entry user-space notify ordering/race

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu Problem: In vxlan_newlink, a default fdb entry is added before register_netdev. The default fdb creation function notifies user-space of the fdb entry on the vxlan device which user-space does not know about yet. (RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex

[PATCH net-next 2/4] vxlan: add new fdb alloc and create helpers

2018-07-04 Thread Roopa Prabhu
From: Roopa Prabhu - Add new vxlan_fdb_alloc helper - rename existing vxlan_fdb_create into vxlan_fdb_update: because it really creates or updates an existing fdb entry - move new fdb creation into a separate vxlan_fdb_create Main motivation for this change is to introduce the

Re: [PATCH net-next 0/4] vxlan: fix default fdb entry user-space notify ordering/race

2018-07-07 Thread Roopa Prabhu
On Sat, Jul 7, 2018 at 4:23 AM, David Miller wrote: > From: Roopa Prabhu > Date: Wed, 4 Jul 2018 16:46:28 -0700 > >> From: Roopa Prabhu >> >> Problem: >> In vxlan_newlink, a default fdb entry is added before register_netdev. >> The default fdb creat

  1   2   3   4   5   6   7   8   9   >