Re: [PATCH] DM9000 - spinlock fixes

) 3) move the locking around the phy reg for read/write to only keep the lock when actually reading or writing to the phy. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Good to see someone else has better eyes than me ;) acked-by: Sascha Hauer [EMAIL PROTECTED] Sascha - To unsubscribe from

bus id in PHY Abstraction Layer

Hi, I made a quick shot to port the at91 network driver to the phy abstraction layer. While doing so I stumbled upon the (struct mii_bus)-id field. Currently the network driver registering the bus has to set this field. au1000_eth.c for example uses 0 or 1. mii-fec.c uses the id field of the

Re: [PATCH] Fix dm9000 release_resource

this was fixed long ago, it must have been lost somewhere. Anyway: Acked-by: Sascha Hauer [EMAIL PROTECTED] -- Dipl.-Ing. Sascha Hauer | http://www.pengutronix.de Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Hannoversche Str

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

Hi Domen, On Sun, Sep 02, 2007 at 09:41:43AM +0200, Domen Puncer wrote: + */ +static void fec_start(struct net_device *dev) +{ + struct fec_priv *priv = netdev_priv(dev); + struct mpc52xx_fec __iomem *fec = priv-fec; + u32 rcntrl; + u32 tcntrl; + u32 tmp; + + /*

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

On Fri, Dec 11, 2015 at 10:40:22AM +0100, Gregory CLEMENT wrote: > Hi Sascha, > > On ven., déc. 11 2015, Sascha Hauer <s.ha...@pengutronix.de> wrote: > > > On Thu, Dec 10, 2015 at 04:08:08PM +0100, Gregory CLEMENT wrote: > >> Hi Sascha, > >> >

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

Hi Gregory, On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: > With device tree it is no more possible to reset the PHY at board > level. Furthermore, doing in the driver allow to power down the PHY when > the network interface is no more used. > > The patch introduces a new

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

On Thu, Dec 10, 2015 at 04:08:08PM +0100, Gregory CLEMENT wrote: > Hi Sascha, > > On jeu., déc. 10 2015, Sascha Hauer <s.ha...@pengutronix.de> wrote: > > > Hi Gregory, > > > > On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: > >> Wit

Re: Micrel Phy KSZ8031 clock select setting in dts

On Sun, Jun 19, 2016 at 09:29:41PM +0200, Oliver Graute wrote: > On 17/06/16, Sergei Shtylyov wrote: > > On 06/17/2016 04:04 PM, Oliver Graute wrote: > > > > >I try to enable a Micrel KSZ8031 in my imx6ul board device tree. But i'am > > >struggeling with the setting for KSZPHY_RMII_REF_CLK_SEL

Re: Micrel Phy KSZ8031 clock select setting in dts

On Mon, Jun 20, 2016 at 03:56:10PM +0300, Sergei Shtylyov wrote: > Hello. > > On 6/20/2016 3:08 PM, Oliver Graute wrote: > > >thx you both for confirming that. Can you tell me also if the clock > >statement s fine in my dts? > > > > { > > pinctrl-names = "default"; > > pinctrl-0 =

Re: Micrel Phy KSZ8031 clock select setting in dts

On Mon, Jun 20, 2016 at 07:14:06PM +0200, Oliver Graute wrote: > On 20/06/16, Andrew Lunn wrote: > > > { > > > pinctrl-names = "default"; > > > pinctrl-0 = <_enet1>; > > > phy-mode = "rmii"; > > > micrel,rmii-reference-clock-select-25-mhz; > > > clocks,rmii-ref; > > > > You are adding

[PATCH 2/2] net: dsa: remove phy_disconnect from error path

The phy has not been initialized, disconnecting it in the error path results in a NULL pointer exception. Drop the phy_disconnect from the error path. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> --- net/dsa/slave.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/dsa/slave.c

[PATCH 1/2] net: dsa: mv88e6xxx: Add support for Marvell 88E6240

The Marvell 88E6240 has been tested successfully without further changes. Add entry to the table of supported devices. Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> --- drivers/net/dsa/mv88e6352.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mv88e6352.c b/d