Re: [PATCH RFC net-next 00/11] udp gso

2018-04-20 Thread Tushar Dave
On 04/18/2018 11:12 AM, Alexander Duyck wrote: On Wed, Apr 18, 2018 at 10:28 AM, David Miller wrote: From: Sowmini Varadhan Date: Wed, 18 Apr 2018 08:31:03 -0400 However, I share Sridhar's concerns about the very fundamental change to UDP message boundary semantics here. There is actually

Re: [PATCH RFC net-next 00/11] udp gso

2018-04-20 Thread Tushar Dave
On 04/20/2018 01:08 PM, Alexander Duyck wrote: On Fri, Apr 20, 2018 at 11:27 AM, Tushar Dave wrote: On 04/18/2018 11:12 AM, Alexander Duyck wrote: On Wed, Apr 18, 2018 at 10:28 AM, David Miller wrote: From: Sowmini Varadhan Date: Wed, 18 Apr 2018 08:31:03 -0400 However, I share

Query: eBPF socket filter

2018-04-20 Thread Tushar Dave
Hi, I am dealing with Reliable Datagram Socket (RDS) protocol and exploring ways to filter RDS traffic using eBPF. FYI, RDS sits on top of transport layer and works with transport such as TCP and IB/RDMA. So RDS messages arrive in form of skb (over TCP)and scatterlist (over IB/RDMA). For RDS tr

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-03-26 Thread Tushar Dave
On 03/26/2018 09:38 AM, Jesper Dangaard Brouer wrote: On Mon, 26 Mar 2018 09:06:54 -0700 William Tu wrote: On Wed, Jan 31, 2018 at 5:53 AM, Björn Töpel wrote: From: Björn Töpel This RFC introduces a new address family called AF_XDP that is optimized for high performance packet processin

Re: [RFC PATCH 00/24] Introducing AF_XDP support

2018-03-26 Thread Tushar Dave
On 03/26/2018 04:03 PM, Alexander Duyck wrote: On Mon, Mar 26, 2018 at 3:54 PM, Tushar Dave wrote: On 03/26/2018 09:38 AM, Jesper Dangaard Brouer wrote: On Mon, 26 Mar 2018 09:06:54 -0700 William Tu wrote: On Wed, Jan 31, 2018 at 5:53 AM, Björn Töpel wrote: From: Björn Töpel

[RFC v2 PATCH 0/4] eBPF and struct scatterlist

2018-06-19 Thread Tushar Dave
list. Finally, patch 4 allows rds_recv_incoming to invoke socket filter program which deals with scatterlist. Thanks. -Tushar Tushar Dave (4): eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER ebpf: Add sg_filter_run and sg helper ebpf: Add sample ebpf program for SOCKET_SG_FILTER

[RFC v2 PATCH 1/4] eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER

2018-06-19 Thread Tushar Dave
entities that don't have skb to represent packet data but want to run eBPF socket filter on packet data that is in form of struct scatterlist e.g. IB/RDMA Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- include/linux/bpf_types.h | 1 + include/linux/filter.h

[RFC v2 PATCH 4/4] rds: invoke socket sg filter attached to rds socket

2018-06-19 Thread Tushar Dave
one filtering solution for RDS, it seems that the common denominator between sk_buff and scatterlist is scatterlist. Therefore, this patch converts skb to sgvec and invoke sg_filter_run for rds_tcp and simply invoke sg_filter_run for IB/rds_rdma. Signed-off-by: Tushar Dave Reviewed-by: Sowmini

[RFC v2 PATCH 3/4] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-06-19 Thread Tushar Dave
Similary specifying '-t ib' will run this on IB link. Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- samples/bpf/Makefile | 3 + samples/bpf/rds_filter_kern.c | 78 ++ samples/bpf/rds_filter_user.c | 339 ++ 3 files ch

[RFC v2 PATCH 2/4] ebpf: Add sg_filter_run and sg helper

2018-06-19 Thread Tushar Dave
When sg_filter_run() is invoked it runs the attached eBPF SOCKET_SG_FILTER program which deals with struct scatterlist. In addition, this patch also adds bpf_sg_next helper function that allows users to retrieve the next sg element from sg list. Signed-off-by: Tushar Dave Acked-by: Sowmini

Re: [RFC v2 PATCH 0/4] eBPF and struct scatterlist

2018-06-25 Thread Tushar Dave
On 06/19/2018 11:00 AM, Tushar Dave wrote: This follows up on https://patchwork.ozlabs.org/cover/927050/ where the review feedback was to use bpf_skb_load_bytes() to deal with linear and non-linear skbs. While that feedback is valid and correct, the motivation for this work is to allow eBPF

Re: [RFC v2 PATCH 1/4] eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER

2018-06-29 Thread Tushar Dave
On 06/29/2018 01:48 AM, Daniel Borkmann wrote: On 06/29/2018 09:25 AM, Daniel Borkmann wrote: On 06/19/2018 08:00 PM, Tushar Dave wrote: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER which uses the existing socket filter infrastructure for bpf program attach and load

Re: [RFC v2 PATCH 2/4] ebpf: Add sg_filter_run and sg helper

2018-06-29 Thread Tushar Dave
On 06/29/2018 01:18 AM, Daniel Borkmann wrote: On 06/19/2018 08:00 PM, Tushar Dave wrote: When sg_filter_run() is invoked it runs the attached eBPF SOCKET_SG_FILTER program which deals with struct scatterlist. In addition, this patch also adds bpf_sg_next helper function that allows users

Re: [RFC v2 PATCH 2/4] ebpf: Add sg_filter_run and sg helper

2018-06-29 Thread Tushar Dave
On 06/29/2018 01:32 AM, Daniel Borkmann wrote: On 06/19/2018 08:00 PM, Tushar Dave wrote: [...] +int sg_filter_run(struct sock *sk, struct scatterlist *sg) +{ + struct sk_filter *filter; + int err; + + rcu_read_lock(); + filter = rcu_dereference(sk->sk_fil

Re: [RFC v2 PATCH 1/4] eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER

2018-06-29 Thread Tushar Dave
On 06/29/2018 01:27 AM, Daniel Borkmann wrote: On 06/19/2018 08:00 PM, Tushar Dave wrote: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER which uses the existing socket filter infrastructure for bpf program attach and load. SOCKET_SG_FILTER eBPF program receives struct scatterlist as

Re: XDP performance regression due to CONFIG_RETPOLINE Spectre V2

2018-04-13 Thread Tushar Dave
On 04/12/2018 07:56 AM, Christoph Hellwig wrote: On Thu, Apr 12, 2018 at 04:51:23PM +0200, Christoph Hellwig wrote: On Thu, Apr 12, 2018 at 03:50:29PM +0200, Jesper Dangaard Brouer wrote: --- Implement support for keeping the DMA mapping through the XDP return call, to remove RX m

[PATCH] selftests/bpf: Add bpf_probe_read_str to bpf_helpers.h

2018-02-27 Thread Tushar Dave
nerated. Add bpf_probe_read_str() to bpf_helpers.h so it can be used by samples/bpf programs. Signed-off-by: Tushar Dave --- tools/testing/selftests/bpf/bpf_helpers.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/

Re: [PATCH] selftests/bpf: Add bpf_probe_read_str to bpf_helpers.h

2018-02-28 Thread Tushar Dave
On 02/28/2018 08:57 AM, Daniel Borkmann wrote: Hi Tushar, On 02/28/2018 01:33 AM, Tushar Dave wrote: Using bpf_probe_read_str() from samples/bpf causes compiler warning. e.g. warning: implicit declaration of function 'bpf_probe_read_str' is invalid in C99 [-Wimplici

[RFC v3 net-next 0/5] eBPF and struct scatterlist

2018-08-17 Thread Tushar Dave
am along with various start and end values for bpf_msg_pull_data(). All such tests shows accurate results. Thanks. -Tushar Tushar Dave (5): eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER ebpf: Add sg_filter_run() ebpf: fix bpf_msg_pull_data rds: invoke socket sg filter at

[RFC v3 net-next 1/5] eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER

2018-08-17 Thread Tushar Dave
entities that don't have skb to represent packet data but want to run eBPF socket filter on packet data that is in form of struct scatterlist e.g. IB/RDMA Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- include/linux/bpf_types.h | 1 + include/uapi/linux/bpf.h | 1 + k

[RFC v3 net-next 2/5] ebpf: Add sg_filter_run()

2018-08-17 Thread Tushar Dave
When sg_filter_run() is invoked it runs the attached eBPF prog of type BPF_PROG_TYPE_SOCKET_SG_FILTER which deals with struct scatterlist. Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- include/linux/filter.h | 8 include/uapi/linux/bpf.h | 6 ++ net

[RFC v3 net-next 3/5] ebpf: fix bpf_msg_pull_data

2018-08-17 Thread Tushar Dave
that page allocated via slab (in this case) can be freed without any issue. Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- net/core/filter.c | 61 +-- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/net/core/filter.c

[RFC v3 net-next 4/5] rds: invoke socket sg filter attached to rds socket

2018-08-17 Thread Tushar Dave
one filtering solution for RDS, it seems that the common denominator between sk_buff and scatterlist is scatterlist. Therefore, this patch converts skb to sgvec and invoke sg_filter_run for rds_tcp and simply invoke sg_filter_run for IB/rds_rdma. Signed-off-by: Tushar Dave Reviewed-by: Sowmini

[RFC v3 net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-08-17 Thread Tushar Dave
/sys/kernel/debug/tracing/trace_pipe -0 [038] ..s. 146.947362: 0: 30 31 32 -0 [038] ..s. 146.947364: 0: 33 34 35 Similarly specifying '-t ib' will run this on IB link. Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- samples/bpf/Makefile

Re: [RFC v3 net-next 3/5] ebpf: fix bpf_msg_pull_data

2018-08-26 Thread Tushar Dave
On 08/24/2018 06:02 PM, John Fastabend wrote: On 08/17/2018 04:08 PM, Tushar Dave wrote: Like sockmap (sk_msg), socksg also deals with struct scatterlist therefore socksg programs can use existing bpf helper bpf_msg_pull_data to access packet data contained in struct scatterlist. While doing

[PATCH net] ebpf: fix bpf_msg_pull_data

2018-08-29 Thread Tushar Dave
While doing some preliminary testing it is found that bpf helper bpf_msg_pull_data does not calculate the data and data_end offset correctly. Fix it! Fixes: 015632bb30da ("bpf: sk_msg program helper bpf_sk_msg_pull_data") Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan ---

Re: [PATCH net] ebpf: fix bpf_msg_pull_data

2018-08-29 Thread Tushar Dave
On 08/29/2018 05:07 PM, Tushar Dave wrote: While doing some preliminary testing it is found that bpf helper bpf_msg_pull_data does not calculate the data and data_end offset correctly. Fix it! Fixes: 015632bb30da ("bpf: sk_msg program helper bpf_sk_msg_pull_data") Signed-off-by: T

Re: [PATCH net] ebpf: fix bpf_msg_pull_data

2018-08-31 Thread Tushar Dave
On 08/30/2018 12:20 AM, Daniel Borkmann wrote: On 08/30/2018 02:21 AM, Tushar Dave wrote: On 08/29/2018 05:07 PM, Tushar Dave wrote: While doing some preliminary testing it is found that bpf helper bpf_msg_pull_data does not calculate the data and data_end offset correctly. Fix it! Fixes

Re: [PATCH net] ebpf: fix bpf_msg_pull_data

2018-08-31 Thread Tushar Dave
On 08/31/2018 05:15 AM, Daniel Borkmann wrote: On 08/31/2018 10:37 AM, Tushar Dave wrote: On 08/30/2018 12:20 AM, Daniel Borkmann wrote: On 08/30/2018 02:21 AM, Tushar Dave wrote: On 08/29/2018 05:07 PM, Tushar Dave wrote: While doing some preliminary testing it is found that bpf helper

[PATCH net] bpf: Fix bpf_msg_pull_data()

2018-08-31 Thread Tushar Dave
name while linearizing multiple scatterlist elements so that value contained in variable 'offset' won't get overwritten. Fixes: 015632bb30da ("bpf: sk_msg program helper bpf_sk_msg_pull_data") Signed-off-by: Tushar Dave --- net/core/filter.c | 7 +++ 1 file change

[PATCH net-next 4/5] rds: invoke socket sg filter attached to rds socket

2018-09-11 Thread Tushar Dave
one filtering solution for RDS, it seems that the common denominator between sk_buff and scatterlist is scatterlist. Therefore, this patch converts skb to sgvec and invoke sg_filter_run for rds_tcp and simply invoke sg_filter_run for IB/rds_rdma. Signed-off-by: Tushar Dave Reviewed-by: Sowmini

[PATCH net-next 3/5] ebpf: Add sg_filter_run()

2018-09-11 Thread Tushar Dave
When sg_filter_run() is invoked it runs the attached eBPF prog of type BPF_PROG_TYPE_SOCKET_SG_FILTER which deals with struct scatterlist. Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- include/linux/filter.h | 8 include/uapi/linux/bpf.h | 6 ++ net

[PATCH net-next 0/5] eBPF and struct scatterlist

2018-09-11 Thread Tushar Dave
various start and end values for bpf_msg_pull_data(). All such tests shows accurate results. Thanks. -Tushar Tushar Dave (5): bpf: use __GFP_COMP while allocating page eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER ebpf: Add sg_filter_run() rds: invoke socket sg filter atta

[PATCH net-next 2/5] eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER

2018-09-11 Thread Tushar Dave
entities that don't have skb to represent packet data but want to run eBPF socket filter on packet data that is in form of struct scatterlist e.g. IB/RDMA Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- include/linux/bpf_types.h | 1 + include/uapi/linux/bpf.h | 1 + k

[PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-11 Thread Tushar Dave
/sys/kernel/debug/tracing/trace_pipe -0 [038] ..s. 146.947362: 0: 30 31 32 -0 [038] ..s. 146.947364: 0: 33 34 35 Similarly specifying '-t ib' will run this on IB link. Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- samples/bpf/Makefile

[PATCH net-next 1/5] bpf: use __GFP_COMP while allocating page

2018-09-11 Thread Tushar Dave
825 page_copy_sane.part.8+0x0/0x8 To avoid above warning, use __GFP_COMP while allocating multiple contiguous pages. Signed-off-by: Tushar Dave --- net/core/filter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index d301134..0b40f95 100

Re: [PATCH net-next 1/5] bpf: use __GFP_COMP while allocating page

2018-09-12 Thread Tushar Dave
On 09/11/2018 12:38 PM, Tushar Dave wrote: Helper bpg_msg_pull_data() can allocate multiple pages while linearizing multiple scatterlist elements into one shared page. However, if the shared page has size > PAGE_SIZE, using copy_page_to_iter() causes below warning. e.g. [ 6367.019

Re: [PATCH net-next 2/5] eBPF: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER

2018-09-12 Thread Tushar Dave
On 09/11/2018 08:57 PM, Alexei Starovoitov wrote: On Tue, Sep 11, 2018 at 09:38:01PM +0200, Tushar Dave wrote: Add new eBPF prog type BPF_PROG_TYPE_SOCKET_SG_FILTER which uses the existing socket filter infrastructure for bpf program attach and load. SOCKET_SG_FILTER eBPF program receives

Re: [PATCH net-next 3/5] ebpf: Add sg_filter_run()

2018-09-12 Thread Tushar Dave
On 09/11/2018 08:58 PM, Alexei Starovoitov wrote: On Tue, Sep 11, 2018 at 09:38:02PM +0200, Tushar Dave wrote: When sg_filter_run() is invoked it runs the attached eBPF prog of type BPF_PROG_TYPE_SOCKET_SG_FILTER which deals with struct scatterlist. Signed-off-by: Tushar Dave Acked-by

Re: [PATCH net-next 5/5] ebpf: Add sample ebpf program for SOCKET_SG_FILTER

2018-09-12 Thread Tushar Dave
On 09/11/2018 09:00 PM, Alexei Starovoitov wrote: On Tue, Sep 11, 2018 at 09:38:04PM +0200, Tushar Dave wrote: Add a sample program that shows how socksg program is used and attached to socket filter. The kernel sample program deals with struct scatterlist that is passed as bpf context

[PATCH bpf] bpf: use __GFP_COMP while allocating page

2018-09-12 Thread Tushar Dave
825 page_copy_sane.part.8+0x0/0x8 To avoid above warning, use __GFP_COMP while allocating multiple contiguous pages. Signed-off-by: Tushar Dave --- net/core/filter.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index d301134..0b40f95 100

Re: [PATCH net-next 1/5] bpf: use __GFP_COMP while allocating page

2018-09-12 Thread Tushar Dave
On 09/12/2018 09:51 AM, John Fastabend wrote: On 09/12/2018 09:21 AM, Tushar Dave wrote: On 09/11/2018 12:38 PM, Tushar Dave wrote: Helper bpg_msg_pull_data() can allocate multiple pages while linearizing multiple scatterlist elements into one shared page. However, if the shared page has

[RFC PATCH 0/3] BPF socket filter to deal with skb frags

2018-06-08 Thread Tushar Dave
tering for IB/RDMA use cases that do not have an sk_buff. Thanks. -Tushar Tushar Dave (3): ebpf: add next_skb_frag bpf helper for sk filter samples/bpf: add sample RDS program rds: invoke sk filter attached to rds socket include/linux/filter.h| 2 + includ

[RFC PATCH 1/3] ebpf: add next_skb_frag bpf helper for sk filter

2018-06-08 Thread Tushar Dave
Today socket filter only deals with linear skbs. This change allows ebpf programs to look into non-linear skb e.g. skb frags. This will be useful when users need to look into data which is not contained in the linear part of skb. Signed-off-by: Tushar Dave Reviewed-by: Shannon Nelson Reviewed

[RFC PATCH 2/3] samples/bpf: add sample RDS program

2018-06-08 Thread Tushar Dave
Note: changing MTU to 9000 help assure that RDS get skb with fragments. Signed-off-by: Tushar Dave Reviewed-by: Shannon Nelson Reviewed-by: Sowmini Varadhan --- samples/bpf/Makefile | 3 + samples/bpf/rds_skb_kern.c | 87 + samples/bpf/rds_skb_user.c | 311

[RFC PATCH 3/3] rds: invoke sk filter attached to rds socket

2018-06-08 Thread Tushar Dave
indirections to get the skb. Signed-off-by: Tushar Dave Reviewed-by: Shannon Nelson Reviewed-by: Sowmini Varadhan --- net/rds/recv.c | 17 + 1 file changed, 17 insertions(+) diff --git a/net/rds/recv.c b/net/rds/recv.c index dc67458..3be9628 100644 --- a/net/rds/recv.c +++ b/net

Re: [RFC PATCH 1/3] ebpf: add next_skb_frag bpf helper for sk filter

2018-06-08 Thread Tushar Dave
On 06/08/2018 02:27 PM, Daniel Borkmann wrote: On 06/08/2018 11:00 PM, Tushar Dave wrote: Today socket filter only deals with linear skbs. This change allows ebpf programs to look into non-linear skb e.g. skb frags. This will be useful when users need to look into data which is not contained

Re: [RFC PATCH 1/3] ebpf: add next_skb_frag bpf helper for sk filter

2018-06-08 Thread Tushar Dave
On 06/08/2018 02:46 PM, Tushar Dave wrote: On 06/08/2018 02:27 PM, Daniel Borkmann wrote: On 06/08/2018 11:00 PM, Tushar Dave wrote: Today socket filter only deals with linear skbs. This change allows ebpf programs to look into non-linear skb e.g. skb frags. This will be useful when users

Re: [e1000_shutdown] e1000 0000:00:03.0: disabling already-disabled device

2017-11-21 Thread Tushar Dave
On 11/21/2017 06:11 PM, Fengguang Wu wrote: Hello, FYI this happens in mainline kernel 4.14.0-01330-g3c07399. It happens since 4.13 . It occurs in 3 out of 162 boots. [ 44.637743] advantechwdt: Unexpected close, not stopping watchdog! [ 44.997548] input: ImExPS/2 Generic Explorer Mouse

Re: [e1000_shutdown] e1000 0000:00:03.0: disabling already-disabled device

2017-11-27 Thread Tushar Dave
On 11/23/2017 04:43 AM, Fengguang Wu wrote: On Wed, Nov 22, 2017 at 03:40:52AM +0530, Tushar Dave wrote: On 11/21/2017 06:11 PM, Fengguang Wu wrote: Hello, FYI this happens in mainline kernel 4.14.0-01330-g3c07399. It happens since 4.13 . It occurs in 3 out of 162 boots. [   44.637743

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-02 Thread Tushar Dave
On 11/02/2017 03:06 AM, Björn Töpel wrote: On 2017-11-02 02:45, Willem de Bruijn wrote: On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: From: Björn Töpel This patch adds the necessary AF_PACKET V4 structures for usage from userspace. AF_PACKET V4 is a new interface optimized for high p

Re: [RFC PATCH] bpf: Add helpers to read useful task_struct members

2017-11-06 Thread Tushar Dave
On 11/02/2017 11:58 PM, Sandipan Das wrote: For added security, the layout of some structures can be randomized by enabling CONFIG_GCC_PLUGIN_RANDSTRUCT. One such structure is task_struct. To build BPF programs, we use Clang which does not support this feature. So, if we attempt to read a field

Re: [PATCH net] i40e: fix the calculation of VFs mac addresses

2017-11-07 Thread Tushar Dave
Signed-off-by: Zijie Pan Signed-off-by: Nicolas Dichtel --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) Thanks for fix. Reviewed-by: Tushar Dave diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtch

Re: [PATCH] [net-next,v3] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-09 Thread Tushar Dave
On 11/09/2017 11:00 AM, Desnes Augusto Nunes do Rosario wrote: This patch implements and enables VDP support for the ibmvnic driver. Moreover, it includes the implementation of suitable structs, signal transmission/handling and functions which allows the retrival of firmware information fro

[next-queue PATCH] i40evf: Use le32_to_cpu before evaluating HW desc fields

2017-06-22 Thread Tushar Dave
: Expected response 7 from PF, received 117440512 Signed-off-by: Tushar Dave Reviewed-by: Shannon Nelson --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers

[next-queue PATCH] i40evf: remove unnecessary __packed

2017-06-22 Thread Tushar Dave
This is similar to 'commit 9588397d24eec ("i40e: remove unnecessary __packed")' to avoid unaligned access. Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40evf/i40e_osdep.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e

Re: [e1000_shutdown] e1000 0000:00:03.0: disabling already-disabled device

2017-12-05 Thread Tushar Dave
On 12/04/2017 05:03 PM, Fengguang Wu wrote: Hi Tushar, On Tue, Nov 28, 2017 at 01:01:23AM +0530, Tushar Dave wrote: On 11/23/2017 04:43 AM, Fengguang Wu wrote: On Wed, Nov 22, 2017 at 03:40:52AM +0530, Tushar Dave wrote: On 11/21/2017 06:11 PM, Fengguang Wu wrote: Hello, FYI this

[next-queue PATCH] e1000: fix disabling already-disabled warning

2017-12-05 Thread Tushar Dave
sleep state S5 Tested-by: Fengguang Wu Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/e1000/e1000.h | 3 ++- drivers/net/ethernet/intel/e1000/e1000_main.c | 27 ++- 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel

[net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect

2018-02-09 Thread Tushar Dave
Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. e.g. [root@labbpf]# ./xdp_redirect $( $( --- samples/bpf/xdp_redirect_user.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/samples/bpf/xdp_redirect_user.c b/samples/bpf/xdp_redirect_user.c index 4475d83..2490235 100644 ---

[PATCH] i40e: Fix incorrect pf->flags

2017-05-19 Thread Tushar Dave
Fix bug introduced by 'commit 47994c119a36e ("i40e: remove hw_disabled_flags in favor of using separate flag bits")' that mistakenly wipes out pf->flags. Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- 1 file changed, 2 insertions(+

[PATCH net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp1

2017-10-27 Thread Tushar Dave
Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. e.g. [root@lab bpf]#./xdp1 -N $( --- samples/bpf/xdp1_user.c | 8 1 file changed, 8 insertions(+) diff --git a/samples/bpf/xdp1_user.c b/samples/bpf/xdp1_user.c index 2431c03..fdaefe9 100644 --- a/samples/bpf/xdp1_user.c +++

[PATCH net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect_map

2017-10-27 Thread Tushar Dave
Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. e.g. [root@labbpf]# ./xdp_redirect_map $( $( --- samples/bpf/xdp_redirect_map_user.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/samples/bpf/xdp_redirect_map_user.c b/samples/bpf/xdp_redirect_map_user.c index d4d86a2..9

[PATCH] i40e: Fix errors resulted while turning off TSO

2016-05-16 Thread Tushar Dave
sary check. Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40e/i40e.h |1 + drivers/net/ethernet/intel/i40e/i40e_main.c |8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i4

[PATCH] i40e: Explicitly write platform-specific mac address after PF reset

2016-07-01 Thread Tushar Dave
ethtool. Signed-off-by: Tushar Dave Acked-by: Sowmini Varadhan --- drivers/net/ethernet/intel/i40e/i40e_main.c | 87 - 1 file changed, 49 insertions(+), 38 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e

[PATCH net-next] ixgbe: Fix for RAR0 not being set to default MAC addr

2016-01-06 Thread Tushar Dave
F:FF:FF:FF:FF. This commit sets RAR0 correctly to default HW mac address. Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_

[PATCH] ixgbe: Check for skb->queue_mapping

2017-03-29 Thread Tushar Dave
[00486410]: worker_thread+0x170/0x4c0 Caller[0048c6b8]: kthread+0xd8/0x120 Caller[00406064]: ret_from_fork+0x1c/0x2c Caller[0000]: (null) Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 32 ++

[PATCH] i40e: Check for skb->queue_mapping

2017-03-29 Thread Tushar Dave
ber of tx queues via ethtool on same device. This patch adds check for skb->queue_mapping and uses simple arithmetic to select available tx queue from driver. Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 13 +++-- 1 file changed, 11 insertions(+),

[PATCH] netpoll: Check for skb->queue_mapping

2017-04-05 Thread Tushar Dave
0406064]: ret_from_fork+0x1c/0x2c Caller[]: (null) Signed-off-by: Tushar Dave --- net/core/netpoll.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 9424673..c572e49 100644 --- a/net/core/netpoll.c +++ b/net/core

[PATCH v2] netpoll: Check for skb->queue_mapping

2017-04-20 Thread Tushar Dave
0406064]: ret_from_fork+0x1c/0x2c Caller[]: (null) Signed-off-by: Tushar Dave --- v1->v2: - addressed comments from Eric Dumazet. net/core/netpoll.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/core/netpoll.c b/net/core/ne

[PATCH] i40evf: Use le32_to_cpu before evaluating HW desc fields.

2017-05-01 Thread Tushar Dave
: Expected response 0 from PF, received 285212672 Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf

[PATCH] i40e: fix panic on SPARC while changing num of desc

2016-10-26 Thread Tushar Dave
Kernel panic - not syncing: Fatal exception Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c i

[PATCH 0/2] net: Fix compiler warnings

2016-10-14 Thread Tushar Dave
Recently, ATU (iommu) changes are submitted to linux-sparc that enables 64bit DMA on SPARC. However, this change also makes 'incompatible pointer type' compiler warnings inevitable on sunqe and sunbmac driver. The two patches in series fix compiler warnings. Tushar Dave (2):

[PATCH 1/2] sunqe: Fix compiler warnings

2016-10-14 Thread Tushar Dave
rgument is of type ‘__u32 *’ This patch resolves above compiler warnings. Signed-off-by: Tushar Dave Reviewed-by: chris hyser --- drivers/net/ethernet/sun/sunqe.c | 11 ++- drivers/net/ethernet/sun/sunqe.h | 4 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH 2/2] sunbmac: Fix compiler warning

2016-10-14 Thread Tushar Dave
le pointer type ./include/linux/dma-mapping.h:445: note: expected ‘dma_addr_t *’ but argument is of type ‘__u32 *’ This patch resolves above compiler warning. Signed-off-by: Tushar Dave Reviewed-by: chris hyser --- drivers/net/ethernet/sun/sunbmac.c | 5 +++-- drivers/net/ethernet/sun/s

[RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-05 Thread Tushar Dave
i40e performance numbers on x86. Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 69 - drivers/net/ethernet/intel/i40e/i40e_txrx.h | 1 + 2 files changed, 49 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/intel

[PATCH] i40e: remove unnecessary __packed

2016-11-19 Thread Tushar Dave
dma_mem' and 'struct i40e_virt_mem' unpacked. Signed-off-by: Tushar Dave --- drivers/net/ethernet/intel/i40e/i40e_osdep.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_osdep.h b/drivers/net/ethernet/intel/i40e/i40e_