Re: [PATCH] ibmvnic: Fix unused variable warning

2017-08-09 Thread Tyrel Datwyler
On 08/09/2017 04:16 AM, Michal Suchanek wrote: > Fixes: a248878d7a1d ("ibmvnic: Check for transport event on driver resume") > > Signed-off-by: Michal Suchanek <msucha...@suse.de> > --- Reviewed-by: Tyrel Datwyler <tyr...@linux.vnet.ibm.com>

Re: [PATCH 19/31] timer: Remove open-coded casts for .data and .function

2017-08-31 Thread Tyrel Datwyler
On 08/31/2017 04:29 PM, Kees Cook wrote: > This standardizes the callback and data prototypes in several places that > perform casting, in an effort to remove more open-coded .data and > .function uses in favor of setup_timer(). > > Cc: Samuel Ortiz <sam...@sortiz.org> >

Re: [PATCH 19/31] timer: Remove open-coded casts for .data and .function

2017-08-31 Thread Tyrel Datwyler
On 08/31/2017 04:29 PM, Kees Cook wrote: > This standardizes the callback and data prototypes in several places that > perform casting, in an effort to remove more open-coded .data and > .function uses in favor of setup_timer(). > > Cc: Samuel Ortiz <sam...@sortiz.org> >

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-02 Thread Tyrel Datwyler
iew. -Tyrel > > Thank you for your review, > > On 02/01/2018 07:02 PM, Tyrel Datwyler wrote: >> On 02/01/2018 10:04 AM, Desnes Augusto Nunes do Rosario wrote: >>> Older versions of VIOS servers do not send the firmware level in the VPD >>> buffer for the ib

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-01 Thread Tyrel Datwyler
On 02/01/2018 10:04 AM, Desnes Augusto Nunes do Rosario wrote: > Older versions of VIOS servers do not send the firmware level in the VPD > buffer for the ibmvnic driver. Thus, not only the current message is mis- > leading but the firmware version in the ethtool will be NULL. Therefore, > this