[GIT] Networking

2018-11-18 Thread David Miller
1) Fix some potentially uninitialized variables and use-after-free in kvaser_usb can drier, from Jimmy Assarsson. 2) Fix leaks in qed driver, from Denis Bolotin. 3) Socket leak in l2tp, from Xin Long. 4) RSS context allocation fix in bnxt_en from Michael Chan. 5) Fix cxgb4 build errors,

Re: [GIT] Networking

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 7:46 PM David Miller wrote: > > Please pull, thanks a lot! Pulled, Linus

[GIT] Networking

2018-10-28 Thread David Miller
1) GRO overflow entries are not unlinked properly, resulting in list poison pointers being dereferenced. 2) Fix bridge build with ipv6 disabled, from Nikolay Aleksandrov. 3) Direct packet access and other fixes in BPF from Daniel Borkmann. 4) gred_change_table_def() gets passed the wrong

[GIT] Networking

2018-05-25 Thread David Miller
Let's begin the holiday weekend with some networking fixes: 1) Whoops need to restrict cfg80211 wiphy names even more to 64 bytes. From Eric Biggers. 2) Fix flags being ignored when using kernel_connect() with SCTP, from Xin Long. 3) Use after free in DCCP, from Alexey Kodanev. 4) Need

[GIT] Networking

2018-05-20 Thread David Miller
Sorry, no drug fuelled pull request this time. As for the commits themselves, I can't say for sure :-) 1) Fix refcounting bug for connections in on-packet scheduling mode of IPVS, from Julian Anastasov. 2) Set network header properly in AF_PACKET's packet_snd, from Willem de Bruijn.

Re: [GIT] Networking

2018-05-11 Thread Linus Torvalds
On Fri, May 11, 2018 at 5:10 PM David Miller wrote: > I guess this is my reward for trying to break the monotony of > pull requests :-) I actually went back and checked a few older pull requests to see if this had been going on for a while and I just hadn't noticed. It

Re: [GIT] Networking

2018-05-11 Thread David Miller
From: Linus Torvalds Date: Fri, 11 May 2018 14:25:59 -0700 > David, is there something you want to tell us? > > Drugs are bad, m'kay.. I guess this is my reward for trying to break the monotony of pull requests :-)

Re: [GIT] Networking

2018-05-11 Thread Linus Torvalds
David, is there something you want to tell us? Drugs are bad, m'kay.. Linus On Fri, May 11, 2018 at 2:00 PM David Miller wrote: > "from Kevin Easton", "Thanks to Bhadram Varka", "courtesy of Gustavo A. > R. Silva", "To Eric Dumazet we are most grateful for

[GIT] Networking

2018-05-11 Thread David Miller
1) Verify lengths of keys provided by the user is AF_KEY, from Kevin Easton. 2) Add device ID for BCM89610 PHY. Thanks to Bhadram Varka. 3) Add Spectre guards to some ATM code, courtesy of Gustavo A. R. Silva. 4) Fix infinite loop in NSH protocol code. To Eric Dumazet we are most

[GIT] Networking

2018-05-03 Thread David Miller
1) Various sockmap fixes from John Fastabend (pinned map handling, blocking in recvmsg, double page put, error handling during redirect failures, etc.) 2) Fix dead code handling in x86-64 JIT, from Gianluca Borello. 3) Missing device put in RDS IB code, from Dag Moxnes. 4) Don't process

[GIT] Networking

2018-04-24 Thread David Miller
1) Fix rtnl deadlock in ipvs, from Julian Anastasov. 2) s390 qeth fixes from Julian Wiedmann (control IO completion stalls, bad MAC address update sequence, request side races on command IO timeouts). 3) Handle seq_file overflow properly in l2tp, from Guillaume Nault. 4) Fix VLAN priority

[GIT] Networking

2018-04-19 Thread David Miller
1) Unbalanced refcounting in TIPC, from Jon Maloy. 2) Only allow TCP_MD5SIG to be set on sockets in close or listen state. Once the connection is established it makes no sense to change this. From Eric Dumazet. 3) Missing attribute validation in neigh_dump_table(), also from Eric

[GIT] Networking

2018-04-11 Thread David Miller
1) In ip_gre tunnel, handle the conflict between TUNNEL_{SEQ,CSUM} and GSO/LLTX properly. From Sabrina Dubroca. 2) Stop properly on error in lan78xx_read_otp(), from Phil Elwell. 3) Don't uncompress in slip before rstate is initialized, from Tejaswi Tanikella. 4) When using 1.x firmware

[GIT] Networking

2018-04-08 Thread David Miller
1) The sockmap code has to free socket memory on close if there is corked data, from John Fastabend. 2) Tunnel names coming from userspace need to be length validated. From Eric Dumazet. 3) arp_filter() has to take VRFs properly into account, from Miguel Fadon Perlines. 4) Fix oops

[GIT] Networking

2018-04-04 Thread David Miller
This fixes some fallout from the net-next merge the other day, plus some non-merge-window-related bug fixes: 1) Fix sparse warnings in bcmgenet,systemport, b53, and mt7530, from Florian Fainelli. 2) pptp does a bogus dst_release() on a route we have a single refcount on, and attached to a

Re: [GIT] Networking

2018-04-02 Thread David Miller
Sorry, this is a dup of the bug fix pull request from last week. I'll send you the right one.

[GIT] Networking

2018-04-02 Thread David Miller
1) Fix RCU locking in xfrm_local_error(), from Taehee Yoo. 2) Fix return value assignments and thus error checking in iwl_mvm_start_ap_ibss(), from Johannes Berg. 3) Don't count header length twice in vti4, from Stefano Brivio. 4) Fix deadlock in rt6_age_examine_exception, from Eric

[GIT] Networking

2018-03-30 Thread David Miller
1) Fix RCU locking in xfrm_local_error(), from Taehee Yoo. 2) Fix return value assignments and thus error checking in iwl_mvm_start_ap_ibss(), from Johannes Berg. 3) Don't count header length twice in vti4, from Stefano Brivio. 4) Fix deadlock in rt6_age_examine_exception, from Eric

[GIT] Networking

2018-03-22 Thread David Miller
1) Always validate XFRM esn replay attribute, from Florian Westphal. 2) Fix RCU read lock imbalance in xfrm_get_tos(), from Xin Long. 3) Don't try to get firmware dump if not loaded in iwlwifi, from Shaul Triebitz. 4) Fix BPF helpers to deal with SCTP GSO SKBs properly, from Daniel

[GIT] Networking

2018-03-04 Thread David Miller
1) Use an appropriate TSQ pacing shift in mac80211, from Toke Høiland-Jørgensen. 2) Just like ipv4's ip_route_me_harder(), we have to use skb_to_full_sk in ip6_route_me_harder, from Eric Dumazet. 3) Fix several shutdown races and similar other problems in l2tp, from James Chapman. 4)

[GIT] Networking

2018-02-23 Thread David Miller
1) Fix TTL offset calculation in mac80211 mesh code, from Peter Oh. 2) Fix races with procfs in ipt_CLUSTERIP, from Cong Wang. 3) Memory leak fix in lpm_trie BPF map code, from Yonghong Song. 4) Need to use GFP_ATOMIC in BPF cpumap allocations, from Jason Wang. 5) Fix potential deadlocks in

[GIT] Networking

2018-02-19 Thread David Miller
1) Prevent index integer overflow in ptr_ring, from Jason Wang. 2) Program mvpp2 multicast filter properly, from Mikulas Patocka. 3) The bridge brport attribute file is write only and doesn't have a ->show() method, don't blindly invoke it. From Xin Long. 4) Inverted mask used in

[GIT] Networking

2018-02-09 Thread David Miller
1) Make allocations less aggressive in x_tables, from Minchal Hocko. 2) Fix netfilter flowtable Kconfig deps, from Pablo Neira Ayuso. 3) Fix connection loss problems in rtlwifi, from Larry Finger. 4) Correct DRAM dump length for some chips in ath10k driver, from Yu Wang. 5) Fix ABORT

[GIT] Networking

2018-02-06 Thread David Miller
1) Fix error path in netdevsim, from Jakub Kicinski. 2) Default values listed in tcp_wmem and tcp_rmem documentation were inaccurate, from Tonghao Zhang. 3) Fix route leaks in SCTP, both for ipv4 and ipv6. From Alexey Kodanev and Tommi Rantala. 4) Fix "MASK < Y" meant to be "MASK << Y"

[GIT] Networking

2018-02-02 Thread David Miller
1) The bnx2x can hang if you give it a GSO packet with a segment size which is too big for the hardware, detect and drop in this case. From Daniel Axtens. 2) Fix some overflows and pointer leaks in xtables, from Dmitry Vyukov. 3) Missing RCU locking in igmp, from Eric Dumazet. 4) Fix

[GIT] Networking

2018-01-26 Thread David Miller
1) The per-network-namespace loopback device, and thus it's namespace, can have it's teardown deferred for a long time if a kernel created TCP socket closes and the namespace is exiting meanwhile. The kernel keeps trying to finish the close sequence until it times out (which takes

[GIT] Networking

2018-01-24 Thread David Miller
1) Avoid negative netdev refcount in error flow of xfrm state add, from Aviad Yehezkel. 2) Fix tcpdump decoding of IPSEC decap'd frames by filling in the ethernet header protocol field in xfrm{4,6}_mode_tunnel_input(). From Yossi Kuperman. 3) Fix a syzbot triggered skb_under_panic in

[GIT] Networking

2018-01-23 Thread David Miller
1) Fix divide by zero in mlx5, from Talut Batheesh. 2) Guard against invalid GSO packets coming from untrusted guests and arriving in qdisc_pkt_len_init(), from Eric Dumazet. 3) Similarly add such protection to the various protocol GSO handlers. From Willem de Bruijn. 4) Fix regression

[GIT] Networking

2018-01-18 Thread David Miller
1) Fix BPF divides by zero, from Eric Dumazet and Alexei Starovoitov. 2) Reject stores into bpf context via st and xadd, from Daniel Borkmann. 3) Fix a memory leak in TUN, from Cong Wang. 4) Disable RX aggregation on a specific troublesome configuration of r8152 in a Dell TB16b dock. 5)

[GIT] Networking

2018-01-16 Thread David Miller
1) Two read past end of buffer fixes in AF_KEY, from Eric Biggers. 2) Memory leak in key_notify_policy(), from Steffen Klassert. 3) Fix overflow with bpf arrays, from Daniel Borkmann. 4) Fix RDMA regression with mlx5 due to mlx5 no longer using pci_irq_get_affinity(), from Saeed Mahameed.

[GIT] Networking

2018-01-10 Thread David Miller
1) BPF speculation prevention and BPF_JIT_ALWAYS_ON, from Alexei Starovoitov. 2) Revert dev_get_random_name() changes as adjust the error code returns seen by userspace definitely breaks stuff. 3) Fix TX DMA map/unmap on older iwlwifi devices, from Emmanuel Grumbach. 4) From wrong AF

[GIT] Networking

2018-01-08 Thread David Miller
Highlights: 1) Frag and UDP handling fixes in i40e driver, from Amritha Nambiar and Alexander Duyck. 2) Undo unintentional UAPI change in netfilter conntrack, from Florian Westphal. 3) Revert a change to how error codes are returned from dev_get_valid_name(), it broke some apps. 4)

[GIT] Networking

2017-12-28 Thread David Miller
1) IPv6 gre tunnels end up with different default features enabled depending upon whether netlink or ioctls are used to bring them up. Fix from Alexey Kodanev. 2) Fix read past end of user control message in RDS< from Avinash Repaka. 3) Missing RCU barrier in mini qdisc code, from

[GIT] Networking

2017-12-21 Thread David Miller
What's a holiday weekend without some networking bug fixes? 1) Fix some eBPF JIT bugs wrt. SKB pointers across helper function calls, from Daniel Borkmann. 2) Fix regression from errata limiting change to marvell PHY driver, from Zhao Qiang. 3) Fix u16 overflow in SCTP, from Xin Long.

[GIT] Networking

2017-12-15 Thread David Miller
1) Clamp timeouts to INT_MAX in conntrack, from Jay Elliot. 2) Fix broken UAPI for BPF_PROG_TYPE_PERF_EVENT, from Hendrik Brueckner. 3) Fix locking in ieee80211_sta_tear_down_BA_sessions, from Johannes Berg. 4) Add missing barriers to ptr_ring, from Michael S. Tsirkin. 5) Don't advertise

[GIT] Networking

2017-12-08 Thread David Miller
1) CAN fixes from Martin Kelly (cancel URBs properly in all the CAN usb drivers). 2) Revert returning -EEXIST from __dev_alloc_name() as this propagates to userspace and broke some apps. From Johannes Berg. 3) Fix conn memory leaks and crashes in TIPC, from Jon Malloc and Cong Wang.

[GIT] Networking

2017-12-03 Thread David Miller
1) Various TCP control block fixes, including one that crashes with SELINUX, from David Ahern and Eric Dumazet. 2) Fix ACK generation in rxrpc, from David Howells. 3) ipvlan doesn't set the mark properly in the ipv4 route lookup key, from Gao Feng. 4) SIT configuration doesn't take on

[GIT] Networking

2017-11-29 Thread David Miller
There is a small overlapping conflict to net/rxrpc/call_object.c, it should be easy to resolve. In your tree there was a setup_timer() --> timer_setup() conversion, and in my tree there are new lines adding a lockdep_set_class() call right beforehand. 1) The forcedeth conversion from pci_*()

[GIT] Networking

2017-11-23 Thread David Miller
1) Fix PCI IDs of 9000 series iwlwifi devices, from Luca Coelho. 2) bpf offload bug fixes from Jakub Kicinski. 3) Fix bpf verifier to NOP out code which is dead at run time because due to branch pruning the verifier will not explore such instructions. From Alexei Starovoitov. 4) Fix

[GIT] Networking

2017-11-21 Thread David Miller
1) Fix a reference to a module parameter which was lost during the GREv6 receive path rewrite, from Alexey Kodanev. 2) Fix deref before NULL check in ipheth, from Gustavo A. R. Silva. 3) RCU read lock imbalance in tun_build_skb(), from Xin Long. 4) Some stragglers from the mac80211 folks:

[GIT] Networking

2017-11-17 Thread David Miller
1) Revert regression inducing change to the IPSEC template resolver, from Steffen Klassert. 2) Peeloffs can cause the wrong sk to be waken up in SCTP, fix from Xin Long. 3) Min packet MTU size is wrong in cpsw driver, from Grygorii Strashko. 4) Fix build failure in netfilter ctnetlink,

Re: [GIT] Networking

2017-11-15 Thread David Miller
From: Daniel Borkmann Date: Wed, 15 Nov 2017 23:15:20 +0100 > On 11/15/2017 09:19 PM, Linus Torvalds wrote: >> On Wed, Nov 15, 2017 at 3:33 AM, David Miller wrote: >>> >>> Highlights: >> >> Lowlights: >> >> 1) it duplicated a commit from the hrtimer

Re: [GIT] Networking

2017-11-15 Thread Daniel Borkmann
On 11/15/2017 09:19 PM, Linus Torvalds wrote: > On Wed, Nov 15, 2017 at 3:33 AM, David Miller wrote: >> >> Highlights: > > Lowlights: > > 1) it duplicated a commit from the hrtimer tree, which had been > cleaned up and rewritten, but then merging the second copy of the >

Re: [GIT] Networking

2017-11-15 Thread Linus Torvalds
On Wed, Nov 15, 2017 at 3:33 AM, David Miller wrote: > > Highlights: Lowlights: 1) it duplicated a commit from the hrtimer tree, which had been cleaned up and rewritten, but then merging the second copy of the commit re-introduced the bad code that had been cleaned up.

[GIT] Networking

2017-11-11 Thread David Miller
1) Use after free in vlan, from Cong Wang. 2) Handle NAPI poll with a zero budget properly in mlx5 driver, from Saeed Mahameed. 3) If DMA mapping fails in mlx5 driver, NULL out page, from Inbar Karmy. 4) Handle overrun in RX FIFO of sun4i CAN driver, from Gerhard Bertelsmann. 5)

[GIT] Networking

2017-11-08 Thread David Miller
1) Fix use-after-free in IPSEC input parsing, desintation address pointer was loaded before pskb_may_pull() which can change the SKB data pointers. From Florian Westphal. 2) Stack out-of-bounds read in xfrm_state_find(), from Steffen Klassert. 3) IPVS state of SKB is not properly

[GIT] Networking

2017-11-02 Thread David Miller
Hopefully this is the last batch of networking fixes for 4.14 Fingers crossed... 1) Fix stmmac to use the proper sized OF property read, from Bhadram Varka. 2) Fix use after free in net scheduler tc action code, from Cong Wang. 3) Fix SKB control block mangling in tcp_make_synack(). 4)

[GIT] Networking

2017-11-01 Thread David Miller
1) Fix refcounting in xfrm_bundle_lookup() when using a dummy bundle, from Steffen Klassert. 2) Fix crypto header handling in rx data frames in ath10k driver, from Vasanthakumar Thiagarajan. 3) Fix use after free of qdisc when we defer tcp_chain_flush() to a workqueue. From Cong Wang.

[GIT] Networking

2017-10-29 Thread David Miller
1) Fix route leak in xfrm_bundle_create(). 2) In mac80211, validate user rate mask before configuring it. From Johannes Berg. 3) Properly enforce memory limits in fair queueing code, from Toke Hoiland-Jorgensen. 4) Fix lockdep splat in inet_csk_route_req(), from Eric Dumazet. 5) Fix TSO

[GIT] Networking

2017-10-21 Thread David Miller
A little more than usual this time around. Been travelling, so that is part of it. Anyways, here are the highlights: 1) Deal with memcontrol races wrt. listener dismantle, from Eric Dumazet. 2) Handle page allocation failures properly in nfp driver, from Jaku Kicinski. 3) Fix memory

[GIT] Networking

2017-10-09 Thread David Miller
1) Fix object leak on IPSEC offload failure, from Steffen Klassert. 2) Fix range checks in ipset address range addition operations, from Jozsef Kadlecsik. 3) Fix pernet ops unregistration order in ipset, from Florian Westphal. 4) Add missing netlink attribute policy for nl80211 packet

[GIT] Networking

2017-10-04 Thread David Miller
1) Check iwlwifi 9000 reorder buffer out-of-space condition properly, from Sara Sharon. 2) Fix RCU splat in qualcomm rmnet driver, from Subash Abhinov Kasiviswanathan. 3) Fix session and tunnel release races in l2tp, from Guillaume Nault and Sabrina Dubroca. 4) Fix endian bug in

[GIT] Networking

2017-09-22 Thread David Miller
1) Fix NAPI poll list corruption in enic driver, from Christian Lamparter. 2) Fix route use after free, from Eric Dumazet. 3) Fix regression in reuseaddr handling, from Josef Bacik. 4) Assert the size of control messages in compat handling since we copy it in from userspace twice. From

[GIT] Networking

2017-09-16 Thread David Miller
1) Fix hotplug deadlock in hv_netvsc, from Stephen Hemminger. 2) Fix double-free in rmnet driver, from Dan Carpenter. 3) INET connection socket layer can double put request sockets, fix from Eric Dumazet. 4) Don't match collect metadata-mode tunnels if the device is down, from Haishuang

[GIT] Networking

2017-09-08 Thread David Miller
The iwlwifi firmware compat fix is in here as well as some other stuff: 1) Fix request socket leak introduced by BPF deadlock fix, from Eric Dumazet. 2) Fix VLAN handling with TXQs in mac80211, from Johannes Berg. 3) Missing __qdisc_drop conversions in prio and qfq schedulers, from Gao

Re: [GIT] Networking

2017-09-06 Thread Linus Torvalds
On Wed, Sep 6, 2017 at 10:40 PM, Luca Coelho wrote: > > This patch is not very important (unless you really like blinking lights > -- maybe I'll change my mind when the holidays approach :P). so it is > fine if you just want to revert it for now. > > In any case, I'll send a patch

Re: [GIT] Networking

2017-09-06 Thread Luca Coelho
On Thu, 2017-09-07 at 05:04 +, Coelho, Luciano wrote: > On Wed, 2017-09-06 at 21:57 -0700, Linus Torvalds wrote: > > On Wed, Sep 6, 2017 at 9:11 PM, Coelho, Luciano > > wrote: > > > > > > This seems to be a problem with backwards-compatibility with FW version > > >

Re: [GIT] Networking

2017-09-06 Thread Coelho, Luciano
On Wed, 2017-09-06 at 21:57 -0700, Linus Torvalds wrote: > On Wed, Sep 6, 2017 at 9:11 PM, Coelho, Luciano > wrote: > > > > This seems to be a problem with backwards-compatibility with FW version > > 27. We are now in version 31[1] and upgrading will probably fix that.

Re: [GIT] Networking

2017-09-06 Thread Linus Torvalds
On Wed, Sep 6, 2017 at 9:11 PM, Coelho, Luciano wrote: > > This seems to be a problem with backwards-compatibility with FW version > 27. We are now in version 31[1] and upgrading will probably fix that. I can confirm that fw version 31 works. > But obviously the

Re: [GIT] Networking

2017-09-06 Thread Coelho, Luciano
On Wed, 2017-09-06 at 16:27 -0700, Linus Torvalds wrote: > This pull request completely breaks Intel wireless for me. > > This is my trusty old XPS 13 (9350), using Intel Wireless 8260 (rev 3a). > > That remains a very standard Intel machine with absolutely zero odd > things going on. > > The

Re: [GIT] Networking

2017-09-06 Thread Linus Torvalds
On Wed, Sep 6, 2017 at 4:27 PM, Linus Torvalds wrote: > > The firmware is iwlwifi-8000C-28.ucode from > iwl7260-firmware-25.30.13.0-75.fc26.noarch, and the kernel reports > > iwlwifi :3a:00.0: loaded firmware version 27.455470.0 op_mode iwlmvm And when I said

Re: [GIT] Networking

2017-09-06 Thread David Miller
From: Linus Torvalds Date: Wed, 6 Sep 2017 16:27:15 -0700 > This pull request completely breaks Intel wireless for me. > > This is my trusty old XPS 13 (9350), using Intel Wireless 8260 (rev 3a). > > That remains a very standard Intel machine with absolutely zero

Re: [GIT] Networking

2017-09-06 Thread Linus Torvalds
This pull request completely breaks Intel wireless for me. This is my trusty old XPS 13 (9350), using Intel Wireless 8260 (rev 3a). That remains a very standard Intel machine with absolutely zero odd things going on. The firmware is iwlwifi-8000C-28.ucode from

[GIT] Networking

2017-09-01 Thread David Miller
1) Fix handling of pinned BPF map nodes in hash of maps, from Daniel Borkmann. 2) IPSEC ESP error paths leak memory, from Steffen Klassert. 3) We need an RCU grace period before freeing fib6_node objects, from Wei Wang. 4) Must check skb_put_padto() return value in HSR driver, from

Re: [GIT] Networking

2017-08-31 Thread Kalle Valo
(Adding linux-wireless) Pavel Machek writes: > On Thu 2017-08-31 07:44:58, Kalle Valo wrote: >> David Miller writes: >> >> > From: Kalle Valo >> > Date: Wed, 30 Aug 2017 20:31:31 +0300 >> > >> >> AFAICS the bug was introduced by

Re: [GIT] Networking

2017-08-31 Thread Pavel Machek
On Thu 2017-08-31 07:44:58, Kalle Valo wrote: > David Miller writes: > > > From: Kalle Valo > > Date: Wed, 30 Aug 2017 20:31:31 +0300 > > > >> AFAICS the bug was introduced by 9df86e2e702c6 back in 2010. If the bug > >> has been there for 7 years so

Re: [GIT] Networking

2017-08-30 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Wed, 30 Aug 2017 20:31:31 +0300 > >> AFAICS the bug was introduced by 9df86e2e702c6 back in 2010. If the bug >> has been there for 7 years so waiting for a few more weeks should not >> hurt. > > As a

Re: [GIT] Networking

2017-08-30 Thread David Miller
From: Kalle Valo Date: Wed, 30 Aug 2017 20:31:31 +0300 > AFAICS the bug was introduced by 9df86e2e702c6 back in 2010. If the bug > has been there for 7 years so waiting for a few more weeks should not > hurt. As a maintainer you have a right to handle bug fixing in that

Re: [GIT] Networking

2017-08-30 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Wed, 30 Aug 2017 17:45:31 +0300 > >> Pavel Machek writes: >> >>> Could we get this one in? >>> >>> wl1251 misses a spin_lock_init(). >>> >>>

Re: [GIT] Networking

2017-08-30 Thread David Miller
From: Kalle Valo Date: Wed, 30 Aug 2017 17:45:31 +0300 > Pavel Machek writes: > >> Could we get this one in? >> >> wl1251 misses a spin_lock_init(). >> >> https://www.mail-archive.com/netdev@vger.kernel.org/msg177031.html >> >> It seems pretty trivial, yet

Re: [GIT] Networking

2017-08-30 Thread Kalle Valo
Pavel Machek writes: > Could we get this one in? > > wl1251 misses a spin_lock_init(). > > https://www.mail-archive.com/netdev@vger.kernel.org/msg177031.html > > It seems pretty trivial, yet getting the backtraces is not nice. It's in wireless-drivers-next and will be in 4.14-rc1:

Re: [GIT] Networking

2017-08-30 Thread Pavel Machek
Hi! Could we get this one in? wl1251 misses a spin_lock_init(). https://www.mail-archive.com/netdev@vger.kernel.org/msg177031.html It seems pretty trivial, yet getting the backtraces is not nice. Thanks, Pavel -- (english)

[GIT] Networking

2017-08-20 Thread David Miller
1) Fix IGMP handling wrt VRF, from David Ahern. 2) Fix timer access to freed object in dccp, from Eric Dumazet. 3) Use kmalloc_array() in ptr_ring to avoid overflow cases which are triggerable by userspace. Also from Eric Dumazet. 4) Fix infinite loop in unmapping cleanup of nfp driver,

Re: [GIT] Networking

2017-08-15 Thread David Miller
From: Linus Torvalds Date: Tue, 15 Aug 2017 19:21:16 -0700 > On Tue, Aug 15, 2017 at 5:52 PM, David Miller wrote: >> >> dingtianhong (4): >> PCI: Disable PCIe Relaxed Ordering if unsupported >> PCI: Disable Relaxed Ordering for

Re: [GIT] Networking

2017-08-15 Thread Linus Torvalds
On Tue, Aug 15, 2017 at 5:52 PM, David Miller wrote: > > dingtianhong (4): > PCI: Disable PCIe Relaxed Ordering if unsupported > PCI: Disable Relaxed Ordering for some Intel processors > PCI: Disable Relaxed Ordering Attributes for AMD A1100 > PCI: fix

[GIT] Networking

2017-08-15 Thread David Miller
1) Fix TCP checksum offload handling in iwlwifi driver, from Emmanuel Grumbach. 2) In ksz DSA tagging code, free SKB if skb_put_padto() fails. From Vivien Didelot. 3) Fix two regressions with bonding on wireless, from Andreas Born. 4) Fix build when busypoll is disabled, from Daniel

[GIT] Networking

2017-08-10 Thread David Miller
1) Fix handling of initial STATE message in TIPC, from Jon Paul Maloy. 2) Fix stats handling in bcm_sysport_get_stats(), from Florian Fainelli. 3) Reject 16777215 VNI value in geneve_validate(), from Girish Moodalbail. 4) Fix initial IGMP sysctl setting regression, from Nikolay

[GIT] Networking

2017-08-09 Thread David Miller
The pull requests are getting smaller, that's progress I suppose :-) 1) Fix infinite loop in CIPSO option parsing, from Yujuan Qi. 2) Fix remote checksum handling in VXLAN and GUE tunneling drivers, from Koichiro Den. 3) Missing u64_stats_init() calls in several drivers, from Florian

[GIT] Networking

2017-07-31 Thread David Miller
1) Handle notifier registry failures properly in tun/tap driver, from Tonghao Zhang. 2) Fix bpf verifier handling of subtraction bounds and add a testcase for this, from Edward Cree. 3) Increase reset timeout in ftgmac100 driver, from Ben Herrenschmidt. 4) Fix use after free in

[GIT] Networking

2017-07-20 Thread David Miller
1) BPF verifier signed/unsigned value tracking fix, from Daniel Borkmann, Edward Cree, and Josef Bacik. 2) Fix memory allocation length when setting up calls to ->ndo_set_mac_address, from Cong Wang. 3) Add a new cxgb4 device ID, from Ganesh Goudar. 4) Fix FIB refcount handling, we have

[GIT] Networking

2017-07-12 Thread David Miller
Nothing super serious in here except perhaps the brcmfmac fix. 1) Fix 64-bit division in mlx5 IPSEC offload support, from Ilan Tayari and Arnd Bergmann. 2) Fix race in statistics gathering in bnxt_en driver, from Michael Chan. 3) Can't use a mutex in RCU reader protected section on tap

Re: [GIT] Networking

2017-07-11 Thread Herbert Xu
On Tue, Jul 11, 2017 at 01:31:14PM -0700, David Miller wrote: > > Acked-by: David S. Miller > > Looks good, is this going via my tree or your's? I'll push it along. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/

Re: [GIT] Networking

2017-07-11 Thread David Miller
From: Herbert Xu Date: Mon, 10 Jul 2017 22:00:48 +0800 > crypto: af_alg - Avoid sock_graft call warning > > The newly added sock_graft warning triggers in af_alg_accept. > It's harmless as we're essentially doing sock->sk = sock->sk. > > The sock_graft call is

Re: [GIT] Networking

2017-07-10 Thread Herbert Xu
On Mon, Jul 10, 2017 at 08:10:02AM -0400, Sowmini Varadhan wrote: > > The reason that the WARN_ON is triggered is that af_alg_accept() calls > sock_init_data() which does > >2636 if (sock) { > : >2639 sock->sk= sk; Oh yes. This started out with

Re: [GIT] Networking

2017-07-10 Thread Sowmini Varadhan
On (07/10/17 18:05), Herbert Xu wrote: > > Hmm, I can't see the problem in af_alg_accept. The struct socket > comes directly from sys_accept() which creates it using sock_alloc. > > So the only thing I can think of is that the memory returned by > sock_alloc is not zeroed and therefore the

Re: [GIT] Networking

2017-07-10 Thread Herbert Xu
On Sun, Jul 09, 2017 at 09:40:43PM +0100, David Miller wrote: > > > It look like PF_ALG sets up a ->sk in alg_create() (but this > > would get over-written in alg_accept()?) No it does not. The struct socket comes from sys_accept() and AFAICS it doesn't carry a struck sock with it. > > Cc'ing

Re: [GIT] Networking

2017-07-09 Thread David Miller
From: Sowmini Varadhan Date: Sun, 9 Jul 2017 15:11:31 -0400 > On (07/09/17 11:49), Linus Torvalds wrote: >> >> On Sat, Jul 8, 2017 at 3:36 AM, David Miller wrote: >> > >> > 8) Fix socket leak on accept() in RDS, from Sowmini Varadhan. Also >>

Re: [GIT] Networking

2017-07-09 Thread Sowmini Varadhan
On (07/09/17 11:49), Linus Torvalds wrote: > > On Sat, Jul 8, 2017 at 3:36 AM, David Miller wrote: > > > > 8) Fix socket leak on accept() in RDS, from Sowmini Varadhan. Also > >add a WARN_ON() to sock_graft() so other protocol stacks don't trip > >over this as well.

Re: [GIT] Networking

2017-07-09 Thread Linus Torvalds
On Sat, Jul 8, 2017 at 3:36 AM, David Miller wrote: > > 8) Fix socket leak on accept() in RDS, from Sowmini Varadhan. Also >add a WARN_ON() to sock_graft() so other protocol stacks don't trip >over this as well. Hmm. This one triggers for me on both my desktop and

[GIT] Networking

2017-07-08 Thread David Miller
Mostly fixing some light fallout from the changes that went into the merge window. 1) Fix memory leaks on network namespace teardown in netfilter, from Liping Zhang. 2) When comparing ipv6 nexthops, we have to take the lightweight tunnel state into account as well. From David Ahern. 3)

[GIT] Networking

2017-06-29 Thread David Miller
1) Need to access netdev->num_rx_queues behind an accessor in netvsc driver otherwise the build breaks with some configs, from Arnd Bergmann. 2) Add dummy xfrm_dev_event() so that build doesn't fail when CONFIG_XFRM_OFFLOAD is not set. From Hangbin Liu. 3) Don't OOPS when

[GIT] Networking

2017-06-20 Thread David Miller
1) Fix refcounting wrt. timers which hold onto inet6 address objects, from Xin Long. 2) Fix an ancient bug in wireless wext ioctls, from Johannes Berg. 3) Firmware handling fixes in brcm80211 driver, from Arend Van Spriel. 4) Several mlx5 driver fixes (firmware readiness, timestamp cap

[GIT] Networking

2017-06-14 Thread David Miller
1) The netlink attribute passed in to dev_set_alias() is not necessarily NULL terminated, don't use strlcpy() on it. From Alexander Potapenko. 2) Fix implementation of atomics in arm64 bpf JIT, from Daniel Borkmann. 3) Correct the release of netdevs and driver private data in

[GIT] Networking

2017-06-06 Thread David Miller
1) Made TCP congestion control documentation match current reality, from Anmol Sarma. 2) Various build warning and failure fixes from Arnd Bergmann. 3) Fix SKB list leak in ipv6_gso_segment(). 4) Use after free in ravb driver, from Eugeniu Rosca. 5) Don't use udp_poll() in ping protocol

[GIT] Networking

2017-05-26 Thread David Miller
1) Fix state pruning in bpf verifier wrt. alignment, from Daniel Borkmann. 2) Handle non-linear SKBs properly in SCTP ICMP parsing, from Davide Caratti. 3) Fix bit field definitions for rss_hash_type of descriptors in mlx5 driver, from Jesper Brouer. 4) Defer slave->link updates until

[GIT] Networking

2017-05-22 Thread David Miller
Mostly netfilter bug fixes in here, but we have some bits elsewhere as well. 1) Don't do SNAT replies for non-NATed connections in IPVS, from Julian Anastasov. 2) Don't delete conntrack helpers while they are still in use, from Liping Zhang. 3) Fix zero padding in xtables's

[GIT] Networking

2017-05-18 Thread David Miller
1) Don't allow negative TCP reordering values, from Soheil Hassas Yeganeh. 2) Don't overflow while parsing ipv6 header options, from Craig Gallek. 3) Handle more cleanly the case where an individual route entry during a dump will not fit into the allocated netlink SKB, from David Ahern. 4)

[GIT] Networking

2017-05-15 Thread David Miller
1) Track alignment in BPF verifier so that legitimate programs won't be rejected on !CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS architectures. 2) Make tail calls work properly in arm64 BPF JIT, from Deniel Borkmann. 3) Make the configuration and semantics Generic XDP make more sense and

[GIT] Networking

2017-05-09 Thread David Miller
1) Fix multiqueue in stmmac driver on PCI, from Andy Shevchenko. 2) cdc_ncm doesn't actually fully zero out the padding area is allocates on TX, from Jim Baxter. 3) Don't leak map addresses in BPF verifier, from Daniel Borkmann. 4) If we randomize TCP timestamps, we have to do it everywhere

[GIT] Networking

2017-05-04 Thread David Miller
1) The wireless rate info fix from Johannes Berg. 2) When a RAW socket is in hdrincl mode, we need to make sure that the user provided at least a minimally sized ipv4/ipv6 header. Fix from Alexander Potapenko. 3) We must emit IFLA_PHYS_PORT_NAME netlink attributes using

  1   2   3   >