Re: [PATCH] Remove useless assignment in ip_do_fragment
Hi David, While this patch was generated by a machine (CodeAI), we manually reviewed and submitted it to this mailing list. I do apologize for the marketing speech. We'll try to tone that down. -Ben On Fri, Feb 23, 2018 at 10:57 AM, David Miller wrote: > From: C0deAi > Date: Thu, 22 Feb 2018 12:10:25 -0500 > >> Hi my name is Benjamin Bales. >> >> I am the founder and creator of CodeAI, >> the first non-human contributor to your software project. CodeAI finds >> and fixes security defects for you. It fixed 327. It wants to merge a >> fix for a useless assignment. To view all 327 fixed issues from the >> run claim your free open source account at mycode.ai and the >> Dockerfile used to build and run your project in CodeAI, here- >> https://drive.google.com/drive/folders/1KB9WQQyWQgYccmiSjy2E1JWJ4vWuoLYd . >> It is always free for open source projects. >> >> If you have any questions about these results or have general >> inquiries about CodeAI, please send an email to techsupp...@mycode.ai >> >> Signed-off-by: Benjamin Bales > > Sorry, I'm not applying code emitted by a machine, and definitely not > with commit messages that look like this. > > In particular, promoting your service in a commit message is > incredibly inappropriate. > > All patch postings should be submitted by a human being, even if they > came from something which was machine generated. -- Sincerely, CodeAI Tech Support Team
Re: [PATCH] Remove useless assignment in ip_do_fragment
From: C0deAi Date: Thu, 22 Feb 2018 12:10:25 -0500 > Hi my name is Benjamin Bales. > > I am the founder and creator of CodeAI, > the first non-human contributor to your software project. CodeAI finds > and fixes security defects for you. It fixed 327. It wants to merge a > fix for a useless assignment. To view all 327 fixed issues from the > run claim your free open source account at mycode.ai and the > Dockerfile used to build and run your project in CodeAI, here- > https://drive.google.com/drive/folders/1KB9WQQyWQgYccmiSjy2E1JWJ4vWuoLYd . > It is always free for open source projects. > > If you have any questions about these results or have general > inquiries about CodeAI, please send an email to techsupp...@mycode.ai > > Signed-off-by: Benjamin Bales Sorry, I'm not applying code emitted by a machine, and definitely not with commit messages that look like this. In particular, promoting your service in a commit message is incredibly inappropriate. All patch postings should be submitted by a human being, even if they came from something which was machine generated.
[PATCH] Remove useless assignment in ip_do_fragment
Hi my name is Benjamin Bales. I am the founder and creator of CodeAI, the first non-human contributor to your software project. CodeAI finds and fixes security defects for you. It fixed 327. It wants to merge a fix for a useless assignment. To view all 327 fixed issues from the run claim your free open source account at mycode.ai and the Dockerfile used to build and run your project in CodeAI, here- https://drive.google.com/drive/folders/1KB9WQQyWQgYccmiSjy2E1JWJ4vWuoLYd . It is always free for open source projects. If you have any questions about these results or have general inquiries about CodeAI, please send an email to techsupp...@mycode.ai Signed-off-by: Benjamin Bales --- net/ipv4/ip_output.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index e8e675b..0e44434 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@ -640,7 +640,6 @@ int ip_do_fragment(struct net *net, struct sock *sk, struct sk_buff *skb, /* Everything is OK. Generate! */ - err = 0; offset = 0; frag = skb_shinfo(skb)->frag_list; skb_frag_list_init(skb); -- 2.7.4
