Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2016-12-02 Thread David Miller
From: Artem Savkov Date: Thu, 1 Dec 2016 14:06:04 +0100 > segs needs to be checked for being NULL in ipv6_gso_segment() before calling > skb_shinfo(segs), otherwise kernel can run into a NULL-pointer dereference: ... > Signed-off-by: Artem Savkov Applied and queued up for -stable.

Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 16:07 +0100, Artem Savkov wrote: > I am not, but this would have the same behavior as pre-07b26c9 code and > IS_ERR_OR_NULL is used in ipv4's inet_gso_segment(). My concern might have been that IS_ERR_OR_NULL() considers the !ptr to be unlikely. But in this code path, we re

Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 06:34 -0800, Eric Dumazet wrote: > On Thu, 2016-12-01 at 14:06 +0100, Artem Savkov wrote: > > segs needs to be checked for being NULL in ipv6_gso_segment() before calling > > skb_shinfo(segs), otherwise kernel can run into a NULL-pointer dereference: > > > > Signed-off-by: A

Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2016-12-01 Thread Artem Savkov
On Thu, Dec 01, 2016 at 06:34:07AM -0800, Eric Dumazet wrote: > On Thu, 2016-12-01 at 14:06 +0100, Artem Savkov wrote: > > segs needs to be checked for being NULL in ipv6_gso_segment() before calling > > skb_shinfo(segs), otherwise kernel can run into a NULL-pointer dereference: > > > > Signed-of

Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2016-12-01 Thread Eric Dumazet
On Thu, 2016-12-01 at 14:06 +0100, Artem Savkov wrote: > segs needs to be checked for being NULL in ipv6_gso_segment() before calling > skb_shinfo(segs), otherwise kernel can run into a NULL-pointer dereference: > Signed-off-by: Artem Savkov > --- > > diff --git a/net/ipv6/ip6_offload.c b/net

[PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2016-12-01 Thread Artem Savkov
segs needs to be checked for being NULL in ipv6_gso_segment() before calling skb_shinfo(segs), otherwise kernel can run into a NULL-pointer dereference: [ 97.811262] BUG: unable to handle kernel NULL pointer dereference at 00cc [ 97.819112] IP: [] ipv6_gso_segment+0x119/0x2f0 [