Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values

[David Miller]

From: Helge Deller 
Date: Thu, 12 Jul 2018 22:36:29 +0200

> Use the existing %pad printk format to print dma_addr_t values.
> This avoids the following warnings when compiling on the parisc platform:
> 
> warning: format '%llx' expects argument of type 'long long unsigned int', but 
> argument 2 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
> 
> Signed-off-by: Helge Deller 

Applied.

Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values

[Felix Manlunas]

On Thu, Jul 12, 2018 at 10:36:29PM +0200, Helge Deller wrote:
> Use the existing %pad printk format to print dma_addr_t values.
> This avoids the following warnings when compiling on the parisc platform:
> 
> warning: format '%llx' expects argument of type 'long long unsigned int', but 
> argument 2 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
> 
> Signed-off-by: Helge Deller 
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c 
> b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> index 1f2e75da28f8..d5d9e47daa4b 100644
> --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
> +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> @@ -110,8 +110,8 @@ int octeon_init_instr_queue(struct octeon_device *oct,
> 
>   memset(iq->request_list, 0, sizeof(*iq->request_list) * num_descs);
> 
> - dev_dbg(>pci_dev->dev, "IQ[%d]: base: %p basedma: %llx count: 
> %d\n",
> - iq_no, iq->base_addr, iq->base_addr_dma, iq->max_count);
> + dev_dbg(>pci_dev->dev, "IQ[%d]: base: %p basedma: %pad count: 
> %d\n",
> + iq_no, iq->base_addr, >base_addr_dma, iq->max_count);
> 
>   iq->txpciq.u64 = txpciq.u64;
>   iq->fill_threshold = (u32)conf->db_min;

Acked-by: Felix Manlunas 

[PATCH] liquidio: Use %pad printk format for dma_addr_t values

[Helge Deller]

Use the existing %pad printk format to print dma_addr_t values.
This avoids the following warnings when compiling on the parisc platform:

warning: format '%llx' expects argument of type 'long long unsigned int', but 
argument 2 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]

Signed-off-by: Helge Deller 

diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c 
b/drivers/net/ethernet/cavium/liquidio/request_manager.c
index 1f2e75da28f8..d5d9e47daa4b 100644
--- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
+++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
@@ -110,8 +110,8 @@ int octeon_init_instr_queue(struct octeon_device *oct,
 
memset(iq->request_list, 0, sizeof(*iq->request_list) * num_descs);
 
-   dev_dbg(>pci_dev->dev, "IQ[%d]: base: %p basedma: %llx count: 
%d\n",
-   iq_no, iq->base_addr, iq->base_addr_dma, iq->max_count);
+   dev_dbg(>pci_dev->dev, "IQ[%d]: base: %p basedma: %pad count: 
%d\n",
+   iq_no, iq->base_addr, >base_addr_dma, iq->max_count);
 
iq->txpciq.u64 = txpciq.u64;
iq->fill_threshold = (u32)conf->db_min;