Re: [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

On 03/08/2018 01:50 AM, Brad Mouring wrote: > If multiple phys share the same interrupt (e.g. a multi-phy chip), > the first device registered is the only one checked as phy_interrupt > will always return IRQ_HANDLED if the first phydev is not halted. > Move the interrupt check into phy_interrupt

Re: [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

Thanks for the feedback, Sergei. On Thu, Mar 08, 2018 at 10:41:04PM +0300, Sergei Shtylyov wrote: > Hello! > > On 03/08/2018 01:50 AM, Brad Mouring wrote: > > > If multiple phys share the same interrupt (e.g. a multi-phy chip), > > the first device registered is the only one checked as

Re: [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

On 03/08/2018 10:41 PM, Sergei Shtylyov wrote: >> If multiple phys share the same interrupt (e.g. a multi-phy chip), >> the first device registered is the only one checked as phy_interrupt >> will always return IRQ_HANDLED if the first phydev is not halted. >> Move the interrupt check into

Re: [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

Hello! On 03/08/2018 01:50 AM, Brad Mouring wrote: > If multiple phys share the same interrupt (e.g. a multi-phy chip), > the first device registered is the only one checked as phy_interrupt > will always return IRQ_HANDLED if the first phydev is not halted. > Move the interrupt check into

Re: [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

On Thu, Mar 08, 2018 at 05:29:05PM +0100, Andrew Lunn wrote: > On Wed, Mar 07, 2018 at 04:50:42PM -0600, Brad Mouring wrote: > > If multiple phys share the same interrupt (e.g. a multi-phy chip), > > the first device registered is the only one checked as phy_interrupt > > will always return

Re: [PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

On Wed, Mar 07, 2018 at 04:50:42PM -0600, Brad Mouring wrote: > If multiple phys share the same interrupt (e.g. a multi-phy chip), > the first device registered is the only one checked as phy_interrupt > will always return IRQ_HANDLED if the first phydev is not halted. > Move the interrupt check

[PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

If multiple phys share the same interrupt (e.g. a multi-phy chip), the first device registered is the only one checked as phy_interrupt will always return IRQ_HANDLED if the first phydev is not halted. Move the interrupt check into phy_interrupt and, if it was not this phydev, return IRQ_NONE to