Re: [PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open()

2016-10-17 Thread David Miller 
From: Wei Yongjun 
Date: Mon, 17 Oct 2016 15:31:58 +

> From: Wei Yongjun 
> 
> Fix to return error code -ENODEV from the of_phy_connect() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun 

Applied.

Re: [PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open()

2016-10-17 Thread Måns Rullgård 
Wei Yongjun  writes:

> From: Wei Yongjun 
>
> Fix to return error code -ENODEV from the of_phy_connect() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun 

Acked-by: Mans Rullgard 

> ---
>  drivers/net/ethernet/aurora/nb8800.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c 
> b/drivers/net/ethernet/aurora/nb8800.c
> index 453dc09..99c4055 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -975,8 +975,10 @@ static int nb8800_open(struct net_device *dev)
>   phydev = of_phy_connect(dev, priv->phy_node,
>   nb8800_link_reconfigure, 0,
>   priv->phy_mode);
> - if (!phydev)
> + if (!phydev) {
> + err = -ENODEV;
>   goto err_free_irq;
> + }
>
>   nb8800_pause_adv(dev);
>

-- 
Måns Rullgård

[PATCH -next] net: ethernet: nb8800: fix error return code in nb8800_open()

2016-10-17 Thread Wei Yongjun 
From: Wei Yongjun 

Fix to return error code -ENODEV from the of_phy_connect() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun 
---
 drivers/net/ethernet/aurora/nb8800.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/aurora/nb8800.c 
b/drivers/net/ethernet/aurora/nb8800.c
index 453dc09..99c4055 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -975,8 +975,10 @@ static int nb8800_open(struct net_device *dev)
phydev = of_phy_connect(dev, priv->phy_node,
nb8800_link_reconfigure, 0,
priv->phy_mode);
-   if (!phydev)
+   if (!phydev) {
+   err = -ENODEV;
goto err_free_irq;
+   }
 
nb8800_pause_adv(dev);