Re: [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter

2018-02-16 Thread David Miller
From: Matteo Croce 
Date: Thu, 15 Feb 2018 15:04:52 +0100

> What about the other two, removing IPv6 and change the Kconfig?
> Other devices like VXLan, Geneve and VRF uses the same architecture
> to allow conditional compilation of the IPv6 module, I think that
> IPVlan should do the same.

Ok, those parts should be reasonable, please respin.


Re: [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter

2018-02-15 Thread Matteo Croce
On Thu, Feb 15, 2018 at 2:11 AM, David Miller  wrote:
> From: Matteo Croce 
> Date: Wed, 14 Feb 2018 19:13:42 +0100
>
>> The IPVlan module currently depends on IPv6 and Netfilter.
>> Refactor the code to allow building IPVlan module regardless of the value of
>> CONFIG_IPV6 and CONFIG_NETFILTER.
>> Also change the dependency to CONFIG_NET_L3_MASTER_DEV into a select,
>> as compiling L3 Master device alone has no sense.
>
> As stated, the L3 master and netfilter are hard depenencies when using
> ipvlan in some modes.
>
> You can't just ifdef the driver like this, it changes fundamental
> pieces of functionality.
>
> I would say leave things as they are right now.

Hi David,

yes, I noticed that L3 master and netfilter are really needed in l3s
mode, so let's drop patch 2/3.

What about the other two, removing IPv6 and change the Kconfig?
Other devices like VXLan, Geneve and VRF uses the same architecture to
allow conditional compilation of the IPv6 module,
I think that IPVlan should do the same.

Regards,
-- 
Matteo Croce
per aspera ad upstream


Re: [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter

2018-02-14 Thread David Miller
From: Matteo Croce 
Date: Wed, 14 Feb 2018 19:13:42 +0100

> The IPVlan module currently depends on IPv6 and Netfilter.
> Refactor the code to allow building IPVlan module regardless of the value of
> CONFIG_IPV6 and CONFIG_NETFILTER.
> Also change the dependency to CONFIG_NET_L3_MASTER_DEV into a select,
> as compiling L3 Master device alone has no sense.

As stated, the L3 master and netfilter are hard depenencies when using
ipvlan in some modes.

You can't just ifdef the driver like this, it changes fundamental
pieces of functionality.

I would say leave things as they are right now.


Re: [PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter

2018-02-14 Thread Florian Westphal
Matteo Croce  wrote:
> The IPVlan module currently depends on IPv6 and Netfilter.
> Refactor the code to allow building IPVlan module regardless of the value of
> CONFIG_IPV6 and CONFIG_NETFILTER.
> Also change the dependency to CONFIG_NET_L3_MASTER_DEV into a select,
> as compiling L3 Master device alone has no sense.

4fbae7d83c98c30efc implies that both netfilter and l3mdev are needed
for l3s mode, yet I see no option of that in changelog or a change that
rejects this mode.

Am I missing anything?



[PATCH 0/3] Remove IPVlan module dependencies on IPv6 and Netfilter

2018-02-14 Thread Matteo Croce
The IPVlan module currently depends on IPv6 and Netfilter.
Refactor the code to allow building IPVlan module regardless of the value of
CONFIG_IPV6 and CONFIG_NETFILTER.
Also change the dependency to CONFIG_NET_L3_MASTER_DEV into a select,
as compiling L3 Master device alone has no sense.

$ grep -wE 'CONFIG_(IPV6|NETFILTER|IPVLAN)' .config
CONFIG_IPV6=y
CONFIG_NETFILTER=y
CONFIG_IPVLAN=m
$ ll drivers/net/ipvlan/ipvlan.ko
48K drivers/net/ipvlan/ipvlan.ko

$ grep -wE 'CONFIG_(IPV6|NETFILTER|IPVLAN)' .config
# CONFIG_IPV6 is not set
CONFIG_NETFILTER=y
CONFIG_IPVLAN=m
$ ll drivers/net/ipvlan/ipvlan.ko
44K drivers/net/ipvlan/ipvlan.ko

$ grep -wE 'CONFIG_(IPV6|NETFILTER|IPVLAN)' .config
CONFIG_IPV6=m
# CONFIG_NETFILTER is not set
CONFIG_IPVLAN=m
$ ll drivers/net/ipvlan/ipvlan.ko
46K drivers/net/ipvlan/ipvlan.ko

$ grep -wE 'CONFIG_(IPV6|NETFILTER|IPVLAN)' .config
# CONFIG_IPV6 is not set
# CONFIG_NETFILTER is not set
CONFIG_IPVLAN=m
$ ll drivers/net/ipvlan/ipvlan.ko
43K drivers/net/ipvlan/ipvlan.ko

Matteo Croce (3):
  ipvlan: drop ipv6 dependency
  ipvlan: drop netfilter dependency
  ipvlan: selects master_l3 device instead of depending on it

 drivers/net/Kconfig  |  4 +-
 drivers/net/ipvlan/ipvlan.h  |  2 +
 drivers/net/ipvlan/ipvlan_core.c | 73 -
 drivers/net/ipvlan/ipvlan_main.c | 79 +++-
 4 files changed, 111 insertions(+), 47 deletions(-)

-- 
2.14.3