Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

Thanks Florian, I'll keep the Asix PHY driver separate from ax88796 for now. Mainly to simplify testing. Let's see whether it can be used by any other MAC - can still fold it into ax88796 later. Cheers, Michael On Wed, Apr 18, 2018 at 6:08 AM, Florian Fainelli wrote:

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

On 04/17/2018 06:01 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 07:18:10AM +0200, Michael Karcher wrote: >> [Andrew, sorry for the dup. I did hit reply-to-auhor instead of >> reply-to-all first.] >> >> Andrew Lunn schrieb: > This should really be fixed in the PHY driver, not the MAC.

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

On Tue, Apr 17, 2018 at 07:18:10AM +0200, Michael Karcher wrote: > [Andrew, sorry for the dup. I did hit reply-to-auhor instead of > reply-to-all first.] > > Andrew Lunn schrieb: > >> > This should really be fixed in the PHY driver, not the MAC. > >> > >> OK - do you want this separate, or as

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

[Andrew, sorry for the dup. I did hit reply-to-auhor instead of reply-to-all first.] Andrew Lunn schrieb: >> > This should really be fixed in the PHY driver, not the MAC. >> >> OK - do you want this separate, or as part of this series? Might have >> a few side effects on more commonly used

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

> > This should really be fixed in the PHY driver, not the MAC. > > OK - do you want this separate, or as part of this series? Might have > a few side effects on more commonly used hardware, perhaps? Hi Michael What PHY driver is used? In the driver you can implement a .soft_reset function

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

Hi Andrew, On Tue, Apr 17, 2018 at 11:12 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote: >> From: John Paul Adrian Glaubitz >> >> The AX88796B as installed on the X-Surf-100 does not recognize a MII reset >>

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote: > From: John Paul Adrian Glaubitz > > The AX88796B as installed on the X-Surf-100 does not recognize a MII reset > request if the previous write to the MII control register also was a reset > request.

[PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

From: John Paul Adrian Glaubitz The AX88796B as installed on the X-Surf-100 does not recognize a MII reset request if the previous write to the MII control register also was a reset request. So a dummy write to the control register makes the soft reset in the PHY