The last argument passed to some calls to the p_err() functions is not
correct, it should be "*argv" instead of "**argv". This may lead to a
segmentation fault error if CPU IDs or indices from the command line
cannot be parsed correctly. Let's fix this.

Fixes: f412eed9dfde ("tools: bpftool: add simple perf event output reader")
Signed-off-by: Quentin Monnet <quentin.mon...@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com>
---
 tools/bpf/bpftool/map_perf_ring.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/bpf/bpftool/map_perf_ring.c 
b/tools/bpf/bpftool/map_perf_ring.c
index 3f108ab17797..4c5531d1a450 100644
--- a/tools/bpf/bpftool/map_perf_ring.c
+++ b/tools/bpf/bpftool/map_perf_ring.c
@@ -157,7 +157,7 @@ int do_event_pipe(int argc, char **argv)
                        NEXT_ARG();
                        ctx.cpu = strtoul(*argv, &endptr, 0);
                        if (*endptr) {
-                               p_err("can't parse %s as CPU ID", **argv);
+                               p_err("can't parse %s as CPU ID", *argv);
                                goto err_close_map;
                        }
 
@@ -168,7 +168,7 @@ int do_event_pipe(int argc, char **argv)
                        NEXT_ARG();
                        ctx.idx = strtoul(*argv, &endptr, 0);
                        if (*endptr) {
-                               p_err("can't parse %s as index", **argv);
+                               p_err("can't parse %s as index", *argv);
                                goto err_close_map;
                        }
 
-- 
2.17.1

Reply via email to