Re: [PATCH net] net: add recursion limit to GRO

2016-10-10 Thread Hannes Frederic Sowa
Hi, On Mon, Oct 10, 2016, at 16:03, Eric Dumazet wrote: > On Mon, 2016-10-10 at 15:43 +0200, Sabrina Dubroca wrote: > > Currently, GRO can do unlimited recursion through the gro_receive > > handlers. This was fixed for tunneling protocols by limiting tunnel GRO > > to one level with encap_mark, b

Re: [PATCH net] net: add recursion limit to GRO

2016-10-10 Thread Sabrina Dubroca
Hi Eric, 2016-10-10, 07:03:56 -0700, Eric Dumazet wrote: > On Mon, 2016-10-10 at 15:43 +0200, Sabrina Dubroca wrote: > > Currently, GRO can do unlimited recursion through the gro_receive > > handlers. This was fixed for tunneling protocols by limiting tunnel GRO > > to one level with encap_mark,

Re: [PATCH net] net: add recursion limit to GRO

2016-10-10 Thread Eric Dumazet
On Mon, 2016-10-10 at 15:43 +0200, Sabrina Dubroca wrote: > Currently, GRO can do unlimited recursion through the gro_receive > handlers. This was fixed for tunneling protocols by limiting tunnel GRO > to one level with encap_mark, but both VLAN and TEB still have this > problem. Thus, the kernel

[PATCH net] net: add recursion limit to GRO

2016-10-10 Thread Sabrina Dubroca
Currently, GRO can do unlimited recursion through the gro_receive handlers. This was fixed for tunneling protocols by limiting tunnel GRO to one level with encap_mark, but both VLAN and TEB still have this problem. Thus, the kernel is vulnerable to a stack overflow, if we receive a packet compose