Re: [PATCH net] net: dsa: mv88e6xxx: Fix receive time stamp race condition.

2018-04-12 Thread David Miller
From: Richard Cochran Date: Thu, 12 Apr 2018 10:35:40 -0700 > On Mon, Apr 09, 2018 at 07:19:31AM -0700, Richard Cochran wrote: >> Dave, please hold off on this patch. I am seeing new problems in my >> testing with this applied. I still need to get to the bottom of >>

Re: [PATCH net] net: dsa: mv88e6xxx: Fix receive time stamp race condition.

2018-04-12 Thread Richard Cochran
On Mon, Apr 09, 2018 at 07:19:31AM -0700, Richard Cochran wrote: > Dave, please hold off on this patch. I am seeing new problems in my > testing with this applied. I still need to get to the bottom of > this. Looks like the new problems are a HW/board glitch. The patch is good to go. Thanks,

Re: [PATCH net] net: dsa: mv88e6xxx: Fix receive time stamp race condition.

2018-04-09 Thread Richard Cochran
On Mon, Apr 09, 2018 at 12:03:14AM -0700, Richard Cochran wrote: > This patch fixes the race by moving the queue onto a list on the stack > before reading out the latched time stamp value. > > Fixes: c6fe0ad2c3499 ("net: dsa: mv88e6xxx: add rx/tx timestamping support") Dave, please hold off on

[PATCH net] net: dsa: mv88e6xxx: Fix receive time stamp race condition.

2018-04-09 Thread Richard Cochran
The DSA stack passes received PTP frames to this driver via mv88e6xxx_port_rxtstamp() for deferred delivery. The driver then queues the frame and kicks the worker thread. The work callback reads out the latched receive time stamp and then works through the queue, delivering any non-matching