Re: [PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

Hello, On Thu, 12 Apr 2018, Stephen Suryaputra wrote: > Thanks for the feedbacks. Please see the detail below: > > On Wed, Apr 11, 2018 at 3:37 PM, Julian Anastasov wrote: > [snip] > >> - __IP_INC_STATS(net, IPSTATS_MIB_INHDRERRORS); > >> + __IP_INC_STATS(net,

Re: [PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

Thanks for the feedbacks. Please see the detail below: On Wed, Apr 11, 2018 at 3:37 PM, Julian Anastasov wrote: [snip] >> - __IP_INC_STATS(net, IPSTATS_MIB_INHDRERRORS); >> + __IP_INC_STATS(net, skb_dst(skb)->dev, IPSTATS_MIB_INHDRERRORS); > > May be skb->dev if we

Re: [PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

Hi Stephen, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Stephen-Suryaputra/Per-interface-IPv4-stats-CONFIG_IP_IFSTATS_TABLE/20180412-181719 reproduce: # apt-get install sparse

Re: [PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

Hello, On Tue, 10 Apr 2018, Stephen Suryaputra wrote: > This is enhanced from the proposed patch by Igor Maravic in 2011 to > support per interface IPv4 stats. The enhancement is mainly adding a > kernel configuration option CONFIG_IP_IFSTATS_TABLE. > > Signed-off-by: Stephen

Re: [PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

I read the thread and understand some of the concerns, but these are useful for network equipments. That's why in this patch, I made it as configuration option. If you have feedbacks, I'll appreciate them. I can resend when net-next is opened again. Thanks. On Wed, Apr 11, 2018 at 12:14 PM,

Re: [PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

On Tue, 10 Apr 2018 22:55:35 -0400 Stephen Suryaputra wrote: > This is enhanced from the proposed patch by Igor Maravic in 2011 to > support per interface IPv4 stats. The enhancement is mainly adding a > kernel configuration option CONFIG_IP_IFSTATS_TABLE. > >

[PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

This is enhanced from the proposed patch by Igor Maravic in 2011 to support per interface IPv4 stats. The enhancement is mainly adding a kernel configuration option CONFIG_IP_IFSTATS_TABLE. Signed-off-by: Stephen Suryaputra --- drivers/net/vrf.c | 2 +-