Re: [PATCH net-next] can: ti_hecc: fix return value check in ti_hecc_probe()

[Marc Kleine-Budde]

On 04/25/2017 08:44 AM, Wei Yongjun wrote:
> From: Wei Yongjun 
> 
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Fixes: dabf54dd1c63 ("can: ti_hecc: Convert TI HECC driver to DT only driver")
> Signed-off-by: Wei Yongjun 

Added to linux-can-next.

Tnx,
Marc

-- 
Pengutronix e.K.  | Marc Kleine-Budde   |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund  | Fax:   +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



signature.asc
Description: OpenPGP digital signature

[PATCH net-next] can: ti_hecc: fix return value check in ti_hecc_probe()

[Wei Yongjun]

From: Wei Yongjun 

In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: dabf54dd1c63 ("can: ti_hecc: Convert TI HECC driver to DT only driver")
Signed-off-by: Wei Yongjun 
---
 drivers/net/can/ti_hecc.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index b8aac53..4d49414 100644
--- a/drivers/net/can/ti_hecc.c
+++ b/drivers/net/can/ti_hecc.c
@@ -898,9 +898,9 @@ static int ti_hecc_probe(struct platform_device *pdev)
}
 
priv->base = devm_ioremap_resource(>dev, res);
-   if (!priv->base) {
+   if (IS_ERR(priv->base)) {
dev_err(>dev, "hecc ioremap failed\n");
-   return -ENOMEM;
+   return PTR_ERR(priv->base);
}
 
/* handle hecc-ram memory */
@@ -911,9 +911,9 @@ static int ti_hecc_probe(struct platform_device *pdev)
}
 
priv->hecc_ram = devm_ioremap_resource(>dev, res);
-   if (!priv->hecc_ram) {
+   if (IS_ERR(priv->hecc_ram)) {
dev_err(>dev, "hecc-ram ioremap failed\n");
-   return -ENOMEM;
+   return PTR_ERR(priv->hecc_ram);
}
 
/* handle mbx memory */
@@ -924,9 +924,9 @@ static int ti_hecc_probe(struct platform_device *pdev)
}
 
priv->mbx = devm_ioremap_resource(>dev, res);
-   if (!priv->mbx) {
+   if (IS_ERR(priv->mbx)) {
dev_err(>dev, "mbx ioremap failed\n");
-   return -ENOMEM;
+   return PTR_ERR(priv->mbx);
}
 
irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);