Re: [PATCH net-next] ethernet/sfc: use core min/max MTU checking

[David Miller]

From: Bert Kenward 
Date: Tue, 18 Oct 2016 17:47:45 +0100

> Fixes: 61e84623 ("net: centralize net_device min/max MTU checking")
> Signed-off-by: Bert Kenward 

Applied with Fixes tag fixed up to use a 12 character SHA1-ID.

Re: [PATCH net-next] ethernet/sfc: use core min/max MTU checking

[Sergei Shtylyov]

On 10/18/2016 07:47 PM, Bert Kenward wrote:


Fixes: 61e84623 ("net: centralize net_device min/max MTU checking")


   The commit SHA1 should be at least 12 digits here.


Signed-off-by: Bert Kenward 

[...]

MBR, Sergei

[PATCH net-next] ethernet/sfc: use core min/max MTU checking

[Bert Kenward]

Fixes: 61e84623 ("net: centralize net_device min/max MTU checking")
Signed-off-by: Bert Kenward 
---
 drivers/net/ethernet/sfc/efx.c | 14 ++
 1 file changed, 2 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 3cf3557..b626da6 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -2263,18 +2263,6 @@ static int efx_change_mtu(struct net_device *net_dev, 
int new_mtu)
rc = efx_check_disabled(efx);
if (rc)
return rc;
-   if (new_mtu > EFX_MAX_MTU) {
-   netif_err(efx, drv, efx->net_dev,
- "Requested MTU of %d too big (max: %d)\n",
- new_mtu, EFX_MAX_MTU);
-   return -EINVAL;
-   }
-   if (new_mtu < EFX_MIN_MTU) {
-   netif_err(efx, drv, efx->net_dev,
- "Requested MTU of %d too small (min: %d)\n",
- new_mtu, EFX_MIN_MTU);
-   return -EINVAL;
-   }
 
netif_dbg(efx, drv, efx->net_dev, "changing MTU to %d\n", new_mtu);
 
@@ -2478,6 +2466,8 @@ static int efx_register_netdev(struct efx_nic *efx)
net_dev->priv_flags |= IFF_UNICAST_FLT;
net_dev->ethtool_ops = &efx_ethtool_ops;
net_dev->gso_max_segs = EFX_TSO_MAX_SEGS;
+   net_dev->min_mtu = EFX_MIN_MTU;
+   net_dev->max_mtu = EFX_MAX_MTU;
 
rtnl_lock();
 
-- 
2.7.4