Re: [PATCH net-next] rds: do not call ->conn_alloc with GFP_KERNEL

2018-02-13 Thread Sowmini Varadhan
On (02/13/18 12:04), David Miller wrote: > > Let's not over-engineer this. For one thing, whatever allocation bits > came down from the callers, we are going to lose here. Ok, I was wondering how much of the sk_allocation we want to keep in the future, so I did this admittedly weird thing. I'll

Re: [PATCH net-next] rds: do not call ->conn_alloc with GFP_KERNEL

2018-02-13 Thread David Miller
From: Sowmini Varadhan Date: Mon, 12 Feb 2018 15:30:38 -0800 > diff --git a/net/rds/connection.c b/net/rds/connection.c > index 94e190f..d0f5889 100644 > --- a/net/rds/connection.c > +++ b/net/rds/connection.c > @@ -221,6 +221,8 @@ static void

[PATCH net-next] rds: do not call ->conn_alloc with GFP_KERNEL

2018-02-12 Thread Sowmini Varadhan
Commit ebeeb1ad9b8a ("rds: tcp: use rds_destroy_pending() to synchronize netns/module teardown and rds connection/workq management") adds an rcu read critical section to __rds_conn_create. The memory allocations in that critcal section need to use GFP_ATOMIC to avoid sleeping. This patch was