Re: [PATCH net-next 1/1] net: vlan: Use sizeof instead of literal number
Hi David, On Tue, Oct 18, 2016 at 9:36 AM, David Miller wrote: > > It never makes sense to send the same patch for both net and net-next. > > If it's a bug fix, it goes to 'net'. And it will be eventually > be naturally merged into 'net-next'. > > Otherwise, if it's a new feature, cleanup, or optimization it goes to > 'net-next'. Because I forget add the "net-next" in the title of first patch, so I send the second patch with right title. And I have replied the first patch and said the reason. Regards Feng
Re: [PATCH net-next 1/1] net: vlan: Use sizeof instead of literal number
It never makes sense to send the same patch for both net and net-next. If it's a bug fix, it goes to 'net'. And it will be eventually be naturally merged into 'net-next'. Otherwise, if it's a new feature, cleanup, or optimization it goes to 'net-next'.
[PATCH net-next 1/1] net: vlan: Use sizeof instead of literal number
From: Gao Feng Use sizeof variable instead of literal number to enhance the readability. Signed-off-by: Gao Feng --- net/8021q/vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index 8de138d..5a3903b 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -515,8 +515,8 @@ static int vlan_ioctl_handler(struct net *net, void __user *arg) return -EFAULT; /* Null terminate this sucker, just in case. */ - args.device1[23] = 0; - args.u.device2[23] = 0; + args.device1[sizeof(args.device1) - 1] = 0; + args.u.device2[sizeof(args.u.device2) - 1] = 0; rtnl_lock(); -- 1.9.1