Re: [PATCH net-next 1/1] net sched actions: return explicit error when tunnel_key mode is not specified

2018-03-15 Thread David Miller
From: Roman Mashak Date: Mon, 12 Mar 2018 16:20:58 -0400 > If set/unset mode of the tunnel_key action is not provided, ->init() still > returns 0, and the caller proceeds with bogus 'struct tc_action *' object, > this results in crash: > > % tc actions add action tunnel_key

Re: [PATCH net-next 1/1] net sched actions: return explicit error when tunnel_key mode is not specified

2018-03-12 Thread Cong Wang
On Mon, Mar 12, 2018 at 1:20 PM, Roman Mashak wrote: > If set/unset mode of the tunnel_key action is not provided, ->init() still > returns 0, and the caller proceeds with bogus 'struct tc_action *' object, > this results in crash: ... > Fixes: d0f6dd8a914f ("net/sched:

[PATCH net-next 1/1] net sched actions: return explicit error when tunnel_key mode is not specified

2018-03-12 Thread Roman Mashak
If set/unset mode of the tunnel_key action is not provided, ->init() still returns 0, and the caller proceeds with bogus 'struct tc_action *' object, this results in crash: % tc actions add action tunnel_key src_ip 1.1.1.1 dst_ip 2.2.2.1 id 7 index 1 [ 35.805515] general protection fault: