Re: [PATCH v1 net-next 2/3] lan743x: Update Kconfig and Makefile to include lan743x driver

[Florian Fainelli]

On 02/13/2018 03:26 PM, Bryan Whitehead wrote:
> Update Kconfig and Makefile to include lan743x driver.

This should be squashed into the first patch, otherwise the first patch
introduces non buildable code, which is kind of pointless.

> 
> Signed-off-by: Bryan Whitehead 
> ---
>  drivers/net/ethernet/microchip/Kconfig  | 9 +
>  drivers/net/ethernet/microchip/Makefile | 3 +++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/net/ethernet/microchip/Kconfig 
> b/drivers/net/ethernet/microchip/Kconfig
> index 36a09d9..0c6955f 100644
> --- a/drivers/net/ethernet/microchip/Kconfig
> +++ b/drivers/net/ethernet/microchip/Kconfig
> @@ -42,4 +42,13 @@ config ENCX24J600
>To compile this driver as a module, choose M here. The module will be
>called encx24j600.
>  
> +config LAN743X
> + tristate "LAN743x support"
> + depends on PCI

There should probably be a select PHYLIB here since you use struct
mii_bus and the PHY library.
-- 
Florian

[PATCH v1 net-next 2/3] lan743x: Update Kconfig and Makefile to include lan743x driver

[Bryan Whitehead]

Update Kconfig and Makefile to include lan743x driver.

Signed-off-by: Bryan Whitehead 
---
 drivers/net/ethernet/microchip/Kconfig  | 9 +
 drivers/net/ethernet/microchip/Makefile | 3 +++
 2 files changed, 12 insertions(+)

diff --git a/drivers/net/ethernet/microchip/Kconfig 
b/drivers/net/ethernet/microchip/Kconfig
index 36a09d9..0c6955f 100644
--- a/drivers/net/ethernet/microchip/Kconfig
+++ b/drivers/net/ethernet/microchip/Kconfig
@@ -42,4 +42,13 @@ config ENCX24J600
   To compile this driver as a module, choose M here. The module will be
   called encx24j600.
 
+config LAN743X
+   tristate "LAN743x support"
+   depends on PCI
+   ---help---
+ Support for the Microchip LAN743x PCI Express Gigabit Ethernet chip
+
+ To compile this driver as a module, choose M here. The module will be
+ called lan743x.
+
 endif # NET_VENDOR_MICROCHIP
diff --git a/drivers/net/ethernet/microchip/Makefile 
b/drivers/net/ethernet/microchip/Makefile
index ff78f62..2e982cc 100644
--- a/drivers/net/ethernet/microchip/Makefile
+++ b/drivers/net/ethernet/microchip/Makefile
@@ -4,3 +4,6 @@
 
 obj-$(CONFIG_ENC28J60) += enc28j60.o
 obj-$(CONFIG_ENCX24J600) += encx24j600.o encx24j600-regmap.o
+obj-$(CONFIG_LAN743X) += lan743x.o
+
+lan743x-objs := lan743x_main.o
-- 
2.7.4