Re: [PATCH v2] cxgb3: remove VLA usage

[David Miller]

From: "Gustavo A. R. Silva" 
Date: Wed, 7 Mar 2018 12:03:33 -0600

> Remove VLA usage and change the 'len' argument to a u8 and use a 256
> byte buffer on the stack. Notice that these lengths are limited by the
> encoding field in the VPD structure, which is a u8 [1].
> 
> [1] https://marc.info/?l=linux-netdev=152044354814024=2
> 
> Signed-off-by: Gustavo A. R. Silva 
> ---
> Changes in v2:
>  - Update the code as suggested by David Miller.
>  - Update changelog based on David's comments.
>  - Update subject.

Applied to net-next, thanks.

[PATCH v2] cxgb3: remove VLA usage

[Gustavo A. R. Silva]

Remove VLA usage and change the 'len' argument to a u8 and use a 256
byte buffer on the stack. Notice that these lengths are limited by the
encoding field in the VPD structure, which is a u8 [1].

[1] https://marc.info/?l=linux-netdev=152044354814024=2

Signed-off-by: Gustavo A. R. Silva 
---
Changes in v2:
 - Update the code as suggested by David Miller.
 - Update changelog based on David's comments.
 - Update subject.

 drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c 
b/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c
index a89721f..080918a 100644
--- a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c
+++ b/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c
@@ -681,18 +681,18 @@ int t3_seeprom_wp(struct adapter *adapter, int enable)
return t3_seeprom_write(adapter, EEPROM_STAT_ADDR, enable ? 0xc : 0);
 }
 
-static int vpdstrtouint(char *s, int len, unsigned int base, unsigned int *val)
+static int vpdstrtouint(char *s, u8 len, unsigned int base, unsigned int *val)
 {
-   char tok[len + 1];
+   char tok[256];
 
memcpy(tok, s, len);
tok[len] = 0;
return kstrtouint(strim(tok), base, val);
 }
 
-static int vpdstrtou16(char *s, int len, unsigned int base, u16 *val)
+static int vpdstrtou16(char *s, u8 len, unsigned int base, u16 *val)
 {
-   char tok[len + 1];
+   char tok[256];
 
memcpy(tok, s, len);
tok[len] = 0;
-- 
2.7.4