Re: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-02 Thread Geert Uytterhoeven
Hi Chris, On Thu, Dec 1, 2016 at 7:53 PM, Chris Brandt wrote: > On 12/1/2016, Sergei Shtylyov wrote: >> >> On 12/01/2016 05:42 PM, Geert Uytterhoeven wrote: >> >> >> --- a/drivers/net/ethernet/renesas/sh_eth.c >> >> +++ b/drivers/net/ethernet/renesas/sh_eth.c >> >> @@

RE: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Chris Brandt
Hi Geert, On 12/1/2016, Sergei Shtylyov wrote: > > On 12/01/2016 05:42 PM, Geert Uytterhoeven wrote: > > >> --- a/drivers/net/ethernet/renesas/sh_eth.c > >> +++ b/drivers/net/ethernet/renesas/sh_eth.c > >> @@ -518,7 +518,7 @@ static struct sh_eth_cpu_data r7s72100_data = { > >> > >>

Re: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Sergei Shtylyov
On 12/01/2016 09:24 PM, Chris Brandt wrote: One thing you've missed so far is mentioning R7S72100 (RZ/A1) in the subject. This driver supports many SoCs, you're only fixing one of them... For the last sh_eth.c patch I submitted, I had: "net: ethernet: renesas: sh_eth: add POST registers

RE: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Chris Brandt
On 12/1/2016, Sergei Shtylyov wrote: > One thing you've missed so far is mentioning R7S72100 (RZ/A1) in the > subject. This driver supports many SoCs, you're only fixing one of them... For the last sh_eth.c patch I submitted, I had: "net: ethernet: renesas: sh_eth: add POST registers for rz"

Re: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Sergei Shtylyov
On 12/01/2016 08:36 PM, Sergei Shtylyov wrote: When streaming a lot of data and the RZ can't keep up, some status bits will get set that are not being checked or cleared which cause the following messages and the Ethernet driver to stop working. This patch fixes that issue. irq 21: nobody

Re: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Sergei Shtylyov
On 12/01/2016 05:42 PM, Geert Uytterhoeven wrote: --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -518,7 +518,7 @@ static struct sh_eth_cpu_data r7s72100_data = { .ecsr_value = ECSR_ICD, .ecsipr_value = ECSIPR_ICDIP, -

Re: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Sergei Shtylyov
On 12/01/2016 05:06 PM, Chris Brandt wrote: When streaming a lot of data and the RZ can't keep up, some status bits will get set that are not being checked or cleared which cause the following messages and the Ethernet driver to stop working. This patch fixes that issue. irq 21: nobody cared

Re: [PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Geert Uytterhoeven
Hi Chris, On Thu, Dec 1, 2016 at 3:06 PM, Chris Brandt wrote: > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -518,7 +518,7 @@ static struct sh_eth_cpu_data r7s72100_data = { > > .ecsr_value = ECSR_ICD, >

[PATCH v2] sh_eth: remove unchecked interrupts

2016-12-01 Thread Chris Brandt
When streaming a lot of data and the RZ can't keep up, some status bits will get set that are not being checked or cleared which cause the following messages and the Ethernet driver to stop working. This patch fixes that issue. irq 21: nobody cared (try booting with the "irqpoll" option)