Re: [PATCH v3 net-next 05/16] tcp: switch back to proper tcp_skb_cb size check in tcp_init()

2016-09-19 Thread Eric Dumazet
On Mon, Sep 19, 2016 at 7:37 AM, Lance Richardson wrote: > The skb local variable could be avoided via: > > BUILD_BUG_ON(sizeof(struct tcp_skb_cb) > FIELD_SIZEOF(struct sk_buff, > cb)); > Right you are, thanks !

Re: [PATCH v3 net-next 05/16] tcp: switch back to proper tcp_skb_cb size check in tcp_init()

2016-09-19 Thread Lance Richardson
Cardwell" <ncardw...@google.com>, "Yuchung Cheng" <ych...@google.com> > Sent: Sunday, September 18, 2016 6:03:42 PM > Subject: [PATCH v3 net-next 05/16] tcp: switch back to proper tcp_skb_cb size > check in tcp_init() > > From: Eric Dumazet <eduma

[PATCH v3 net-next 05/16] tcp: switch back to proper tcp_skb_cb size check in tcp_init()

2016-09-18 Thread Neal Cardwell
From: Eric Dumazet Revert to the tcp_skb_cb size check that tcp_init() had before commit b4772ef879a8 ("net: use common macro for assering skb->cb[] available size in protocol families"). As related commit 744d5a3e9fe2 ("net: move skb->dropcount to skb->cb[]") explains, the