Re: [RFC PATCH net-next 04/11] spi: spi-fsl-dspi: Cosmetic cleanup

2019-08-17 Thread Vladimir Oltean
On Fri, 16 Aug 2019 at 15:59, Mark Brown wrote: > > On Fri, Aug 16, 2019 at 03:37:46PM +0300, Vladimir Oltean wrote: > > On Fri, 16 Aug 2019 at 15:21, Mark Brown wrote: > > > > This is difficult to review since there's a bunch of largely unrelated > > > changes all munged into one patch. It'd be

Re: [RFC PATCH net-next 04/11] spi: spi-fsl-dspi: Cosmetic cleanup

2019-08-16 Thread Mark Brown
On Fri, Aug 16, 2019 at 03:37:46PM +0300, Vladimir Oltean wrote: > On Fri, 16 Aug 2019 at 15:21, Mark Brown wrote: > > This is difficult to review since there's a bunch of largely unrelated > > changes all munged into one patch. It'd be better to split this up so > > each change makes one kind o

Re: [RFC PATCH net-next 04/11] spi: spi-fsl-dspi: Cosmetic cleanup

2019-08-16 Thread Vladimir Oltean
Hi Mark, On Fri, 16 Aug 2019 at 15:21, Mark Brown wrote: > > On Fri, Aug 16, 2019 at 03:44:42AM +0300, Vladimir Oltean wrote: > > This patch addresses some cosmetic issues: > > - Alignment > > - Typos > > - (Non-)use of BIT() and GENMASK() macros > > - Unused definitions > > - Unused includes > >

Re: [RFC PATCH net-next 04/11] spi: spi-fsl-dspi: Cosmetic cleanup

2019-08-16 Thread Mark Brown
On Fri, Aug 16, 2019 at 03:44:42AM +0300, Vladimir Oltean wrote: > This patch addresses some cosmetic issues: > - Alignment > - Typos > - (Non-)use of BIT() and GENMASK() macros > - Unused definitions > - Unused includes > - Abuse of ternary operator in detriment of readability > - Reduce indentati

[RFC PATCH net-next 04/11] spi: spi-fsl-dspi: Cosmetic cleanup

2019-08-15 Thread Vladimir Oltean
This patch addresses some cosmetic issues: - Alignment - Typos - (Non-)use of BIT() and GENMASK() macros - Unused definitions - Unused includes - Abuse of ternary operator in detriment of readability - Reduce indentation level Signed-off-by: Vladimir Oltean --- drivers/spi/spi-fsl-dspi.c | 312 +