Re: [V2 PATCH net-next 1/2] xdp: implement xdp_redirect_map for generic XDP

2017-09-08 Thread Daniel Borkmann
On 09/08/2017 10:36 AM, Jesper Dangaard Brouer wrote: On Thu, 07 Sep 2017 16:09:56 +0200 Daniel Borkmann wrote: On 09/07/2017 02:33 PM, Jesper Dangaard Brouer wrote: Using bpf_redirect_map is allowed for generic XDP programs, but the appropriate map lookup was never

Re: [V2 PATCH net-next 1/2] xdp: implement xdp_redirect_map for generic XDP

2017-09-08 Thread Jesper Dangaard Brouer
On Thu, 07 Sep 2017 16:09:56 +0200 Daniel Borkmann wrote: > On 09/07/2017 02:33 PM, Jesper Dangaard Brouer wrote: > > Using bpf_redirect_map is allowed for generic XDP programs, but the > > appropriate map lookup was never performed in xdp_do_generic_redirect(). > > > >

Re: [V2 PATCH net-next 1/2] xdp: implement xdp_redirect_map for generic XDP

2017-09-07 Thread Daniel Borkmann
On 09/07/2017 02:33 PM, Jesper Dangaard Brouer wrote: Using bpf_redirect_map is allowed for generic XDP programs, but the appropriate map lookup was never performed in xdp_do_generic_redirect(). Instead the map-index is directly used as the ifindex. For the xdp_redirect_map sample in SKB-mode

[V2 PATCH net-next 1/2] xdp: implement xdp_redirect_map for generic XDP

2017-09-07 Thread Jesper Dangaard Brouer
Using bpf_redirect_map is allowed for generic XDP programs, but the appropriate map lookup was never performed in xdp_do_generic_redirect(). Instead the map-index is directly used as the ifindex. For the xdp_redirect_map sample in SKB-mode '-S', this resulted in trying sending on ifindex 0 which