Re: [bpf-next PATCH] net: avoid including xdp.h in filter.h

[John Fastabend]

On 02/13/2018 05:57 PM, Alexei Starovoitov wrote:
> On Tue, Feb 13, 2018 at 02:15:36PM +0100, Jesper Dangaard Brouer wrote:
>> If is sufficient with a forward declaration of struct xdp_rxq_info in
>> linux/filter.h, which avoids including net/xdp.h.  This was originally
>> suggested by John Fastabend during the review phase, but wasn't
>> included in the final patchset revision.  Thus, this followup.
>>
>> Suggested-by: John Fastabend 
>> Signed-off-by: Jesper Dangaard Brouer 
> 
> Applied to bpf-next, Thanks Jesper.
> 

Great thanks for the follow up Jesper.

Acked-by: John Fastabend 

Re: [bpf-next PATCH] net: avoid including xdp.h in filter.h

[Alexei Starovoitov]

On Tue, Feb 13, 2018 at 02:15:36PM +0100, Jesper Dangaard Brouer wrote:
> If is sufficient with a forward declaration of struct xdp_rxq_info in
> linux/filter.h, which avoids including net/xdp.h.  This was originally
> suggested by John Fastabend during the review phase, but wasn't
> included in the final patchset revision.  Thus, this followup.
> 
> Suggested-by: John Fastabend 
> Signed-off-by: Jesper Dangaard Brouer 

Applied to bpf-next, Thanks Jesper.

[bpf-next PATCH] net: avoid including xdp.h in filter.h

[Jesper Dangaard Brouer]

If is sufficient with a forward declaration of struct xdp_rxq_info in
linux/filter.h, which avoids including net/xdp.h.  This was originally
suggested by John Fastabend during the review phase, but wasn't
included in the final patchset revision.  Thus, this followup.

Suggested-by: John Fastabend 
Signed-off-by: Jesper Dangaard Brouer 
---
 0 files changed

diff --git a/include/linux/filter.h b/include/linux/filter.h
index 276932d75975..fdb691b520c0 100644
--- a/include/linux/filter.h
+++ b/include/linux/filter.h
@@ -20,7 +20,6 @@
 #include 
 #include 
 
-#include 
 #include 
 
 #include 
@@ -30,6 +29,7 @@ struct sk_buff;
 struct sock;
 struct seccomp_data;
 struct bpf_prog_aux;
+struct xdp_rxq_info;
 
 /* ArgX, context and stack frame pointer register positions. Note,
  * Arg1, Arg2, Arg3, etc are used as argument mappings of function