Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-18 Thread Pavel Tatashin
On 05/18/2018 01:28 PM, Sergei Shtylyov wrote: > On 05/18/2018 02:37 PM, Pavel Tatashin wrote: > >> * parallelized this function, so drop lock for the >>> >>> Parallelizing? Else the sentence doesn't parse for me. :-) > >My comment hardly makes sense when you removed all the

Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-18 Thread Sergei Shtylyov
On 05/18/2018 02:37 PM, Pavel Tatashin wrote: > * parallelized this function, so drop lock for the >> >> Parallelizing? Else the sentence doesn't parse for me. :-) My comment hardly makes sense when you removed all the context... > Hi Sergei, > > In a separate series I

Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-18 Thread Pavel Tatashin
  * parallelized this function, so drop lock for the > >     Parallelizing? Else the sentence doesn't parse for me. :-) Hi Sergei, In a separate series I parallelized device_shutdown(), see: http://lkml.kernel.org/r/20180516024004.28977-1-pasha.tatas...@oracle.com But, this particular

Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-18 Thread Sergei Shtylyov
Hello! On 5/17/2018 7:37 PM, Jeff Kirsher wrote: From: Pavel Tatashin Currently, during device_shutdown() ixgbe holds rtnl_lock for the duration of lengthy ixgbe_close_suspend(). On machines with multiple ixgbe cards this lock prevents scaling if device_shutdown()

[net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-17 Thread Jeff Kirsher
From: Pavel Tatashin Currently, during device_shutdown() ixgbe holds rtnl_lock for the duration of lengthy ixgbe_close_suspend(). On machines with multiple ixgbe cards this lock prevents scaling if device_shutdown() function is multi-threaded. It is not necessary to