Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-18 Thread David Miller
From: Jesper Dangaard Brouer Date: Fri, 16 Sep 2016 22:36:12 +0200 > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS. >

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-17 Thread Jesper Dangaard Brouer
On Fri, 16 Sep 2016 13:43:50 -0700 Brenden Blanco wrote: > On Fri, Sep 16, 2016 at 10:36:12PM +0200, Jesper Dangaard Brouer wrote: > > The XDP_TX action can fail transmitting the frame in case the TX ring > > is full or port is down. In case of TX failure it should drop

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Brenden Blanco
On Fri, Sep 16, 2016 at 10:36:12PM +0200, Jesper Dangaard Brouer wrote: > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS. > > Fixes:

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
On Fri, 16 Sep 2016 22:36:12 +0200 Jesper Dangaard Brouer wrote: > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS.

[net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
The XDP_TX action can fail transmitting the frame in case the TX ring is full or port is down. In case of TX failure it should drop the frame, and not as now call 'break' which is the same as XDP_PASS. Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support") Signed-off-by:

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
On Fri, 16 Sep 2016 13:00:50 -0700 Eric Dumazet wrote: > > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c > > b/drivers/net/ethernet/mellanox/mlx4/en_rx.c > > index 2040dad8611d..d414c67dfd12 100644 > > --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c > > +++

Re: [net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Eric Dumazet
On Fri, 2016-09-16 at 21:47 +0200, Jesper Dangaard Brouer wrote: > The XDP_TX action can fail transmitting the frame in case the TX ring > is full or port is down. In case of TX failure it should drop the > frame, and not as now call 'break' which is the same as XDP_PASS. > > Fixes: 9ecc2d86171a

[net PATCH] mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full

2016-09-16 Thread Jesper Dangaard Brouer
The XDP_TX action can fail transmitting the frame in case the TX ring is full or port is down. In case of TX failure it should drop the frame, and not as now call 'break' which is the same as XDP_PASS. Fixes: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and data write support") Signed-off-by: